feat: Update dependencies and enhance job run details template

- Add new dependencies: `github.com/joho/godotenv`, `github.com/stretchr/testify`, and `gopkg.in/natefinch/lumberjack.v2`
- Remove indirect dependency on `github.com/joho/godotenv`
- Refactor JobRunDetails template to separate content rendering for improved testing
- Enhance error message display in JobRunDetails template
- Introduce new test files for JWT and password functionalities
- Add comprehensive tests for database operations and error handling
This commit is contained in:
StarFleetCPTN
2025-03-13 18:40:40 -07:00
parent a8b4588ecb
commit 3193bf5111
33 changed files with 9185 additions and 232 deletions
+129
View File
@@ -0,0 +1,129 @@
package email
import (
"os"
"path/filepath"
"strings"
"testing"
"github.com/starfleetcptn/gomft/internal/config"
)
// Setup test configuration without using testutils (to avoid import cycles)
func setupTestConfig(t *testing.T) *config.Config {
tempDir, err := os.MkdirTemp("", "gomft-test-*")
if err != nil {
t.Fatalf("Failed to create temp directory: %v", err)
}
t.Cleanup(func() {
os.RemoveAll(tempDir)
})
return &config.Config{
ServerAddress: ":9090",
DataDir: filepath.Join(tempDir, "data"),
BackupDir: filepath.Join(tempDir, "backups"),
JWTSecret: "test-jwt-secret",
BaseURL: "http://test.example.com",
Email: config.EmailConfig{
Enabled: false,
Host: "smtp.test.com",
Port: 587,
Username: "test@example.com",
Password: "test-password",
FromEmail: "test@example.com",
FromName: "Test",
EnableTLS: true,
RequireAuth: true,
},
}
}
func TestEmailServiceDisabled(t *testing.T) {
// Set up test config with email disabled
cfg := setupTestConfig(t)
cfg.Email.Enabled = false
// Create the email service
service := NewService(cfg)
// Send a password reset email
err := service.SendPasswordResetEmail("test@example.com", "Test User", "token123")
// Expect an error indicating the service is disabled
if err == nil {
t.Error("Expected error when email service is disabled, but got none")
}
// Check that the error message contains the reset link
expectedMsg := cfg.BaseURL + "/reset-password?token=token123"
if !strings.Contains(err.Error(), expectedMsg) {
t.Errorf("Expected error message to contain the reset link %s, got: %s", expectedMsg, err.Error())
}
}
func TestGeneratePasswordResetEmailHTML(t *testing.T) {
// Set up test config
cfg := setupTestConfig(t)
service := NewService(cfg)
// Test cases
tests := []struct {
name string
data map[string]interface{}
expected []string // Strings that should be included in the HTML
}{
{
name: "Complete user data",
data: map[string]interface{}{
"Username": "John Doe",
"ResetLink": "http://example.com/reset?token=abc123",
"AppName": "GoMFT",
"Year": 2023,
"ExpiresHours": 0.25,
},
expected: []string{
"Hello John Doe",
"http://example.com/reset?token=abc123",
"GoMFT",
"2023",
"15 minutes",
},
},
{
name: "No username",
data: map[string]interface{}{
"ResetLink": "http://example.com/reset?token=abc123",
"AppName": "GoMFT",
"Year": 2023,
"ExpiresHours": 0.25,
},
expected: []string{
"Hello",
"http://example.com/reset?token=abc123",
"GoMFT",
"2023",
"15 minutes",
},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
// Generate HTML
html, err := service.generatePasswordResetEmailHTML(tc.data)
// Check for errors
if err != nil {
t.Fatalf("Error generating HTML: %v", err)
}
// Check that all expected strings are included
for _, expected := range tc.expected {
if !strings.Contains(html, expected) {
t.Errorf("Expected HTML to contain %q, but it doesn't", expected)
}
}
})
}
}
+35
View File
@@ -0,0 +1,35 @@
package email
import (
"fmt"
"github.com/starfleetcptn/gomft/internal/config"
)
// MockService implements the email Service for testing purposes
type MockService struct {
SendEmailCalls int
SendPasswordResetEmailCalls int
ReturnError error
}
// NewMockService creates a new mock email service
func NewMockService() *Service {
// Create minimal config
cfg := &config.Config{
Email: config.EmailConfig{
Enabled: false,
},
BaseURL: "http://localhost:8080",
}
return &Service{
Config: cfg,
}
}
// SendPasswordResetEmail mocks sending a password reset email
func (s *MockService) SendPasswordResetEmail(toEmail, username, resetToken string) error {
return fmt.Errorf("email service is disabled, reset link would be: %s/reset-password?token=%s",
"http://localhost:8080", resetToken)
}