mirror of
https://github.com/StarFleetCPTN/GoMFT.git
synced 2026-09-08 15:41:20 +02:00
feat: Update dependencies and enhance job run details template
- Add new dependencies: `github.com/joho/godotenv`, `github.com/stretchr/testify`, and `gopkg.in/natefinch/lumberjack.v2` - Remove indirect dependency on `github.com/joho/godotenv` - Refactor JobRunDetails template to separate content rendering for improved testing - Enhance error message display in JobRunDetails template - Introduce new test files for JWT and password functionalities - Add comprehensive tests for database operations and error handling
This commit is contained in:
StarFleetCPTN
@@ -0,0 +1,865 @@
|
||||
package handlers
|
||||
|
||||
import (
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"net/url"
|
||||
"strconv"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/gin-gonic/gin"
|
||||
"github.com/starfleetcptn/gomft/internal/db"
|
||||
"github.com/starfleetcptn/gomft/internal/scheduler"
|
||||
"github.com/starfleetcptn/gomft/internal/testutils"
|
||||
"github.com/stretchr/testify/assert"
|
||||
)
|
||||
|
||||
// setupJobsTest prepares test environment with database, mock scheduler, and handlers
|
||||
func setupJobsTest(t *testing.T) (*Handlers, *gin.Engine, *db.DB, *db.User, *db.TransferConfig) {
|
||||
// Set up test database
|
||||
database := testutils.SetupTestDB(t)
|
||||
|
||||
// Create test user
|
||||
user := &db.User{
|
||||
Email: "jobtest@example.com",
|
||||
PasswordHash: "hashedpassword",
|
||||
IsAdmin: false,
|
||||
LastPasswordChange: time.Now(),
|
||||
}
|
||||
database.Create(user)
|
||||
|
||||
// Create admin user
|
||||
adminUser := &db.User{
|
||||
Email: "jobadmin@example.com",
|
||||
PasswordHash: "hashedpassword",
|
||||
IsAdmin: true,
|
||||
LastPasswordChange: time.Now(),
|
||||
}
|
||||
database.Create(adminUser)
|
||||
|
||||
// Create test config
|
||||
config := &db.TransferConfig{
|
||||
Name: "Test Config",
|
||||
SourceType: "local",
|
||||
SourcePath: "/source",
|
||||
DestinationType: "local",
|
||||
DestinationPath: "/dest",
|
||||
CreatedBy: user.ID,
|
||||
}
|
||||
database.Create(config)
|
||||
|
||||
// Create mock scheduler
|
||||
mockScheduler := scheduler.NewMockScheduler()
|
||||
|
||||
// Set up Gin router
|
||||
gin.SetMode(gin.TestMode)
|
||||
router := gin.New()
|
||||
|
||||
// Create handlers
|
||||
handlers := &Handlers{
|
||||
DB: database,
|
||||
JWTSecret: "test-jwt-secret",
|
||||
Scheduler: mockScheduler,
|
||||
}
|
||||
|
||||
// Set up auth middleware for testing
|
||||
router.Use(func(c *gin.Context) {
|
||||
c.Set("userID", user.ID)
|
||||
c.Set("email", user.Email)
|
||||
c.Set("isAdmin", false)
|
||||
c.Next()
|
||||
})
|
||||
|
||||
return handlers, router, database, user, config
|
||||
}
|
||||
|
||||
// setupAdminJobsTest prepares test environment with admin user permissions
|
||||
func setupAdminJobsTest(t *testing.T) (*Handlers, *gin.Engine, *db.DB, *db.User, *db.TransferConfig) {
|
||||
handlers, router, database, user, config := setupJobsTest(t)
|
||||
|
||||
// Replace middleware with admin permissions
|
||||
router.Use(func(c *gin.Context) {
|
||||
c.Set("userID", user.ID)
|
||||
c.Set("email", user.Email)
|
||||
c.Set("isAdmin", true)
|
||||
c.Next()
|
||||
})
|
||||
|
||||
return handlers, router, database, user, config
|
||||
}
|
||||
|
||||
func TestHandleJobs(t *testing.T) {
|
||||
// Setup test environment
|
||||
handlers, router, database, user, _ := setupJobsTest(t)
|
||||
|
||||
// Create test jobs
|
||||
job1 := &db.Job{
|
||||
Name: "Test Job 1",
|
||||
Schedule: "*/5 * * * *",
|
||||
ConfigID: 1,
|
||||
Enabled: true,
|
||||
CreatedBy: user.ID,
|
||||
}
|
||||
database.Create(job1)
|
||||
|
||||
job2 := &db.Job{
|
||||
Name: "Test Job 2",
|
||||
Schedule: "*/10 * * * *",
|
||||
ConfigID: 1,
|
||||
Enabled: false,
|
||||
CreatedBy: user.ID,
|
||||
}
|
||||
database.Create(job2)
|
||||
|
||||
// Create job for another user
|
||||
otherUser := &db.User{
|
||||
Email: "other@example.com",
|
||||
PasswordHash: "hashedpassword",
|
||||
IsAdmin: false,
|
||||
LastPasswordChange: time.Now(),
|
||||
}
|
||||
database.Create(otherUser)
|
||||
|
||||
otherJob := &db.Job{
|
||||
Name: "Other User Job",
|
||||
Schedule: "*/15 * * * *",
|
||||
ConfigID: 1,
|
||||
Enabled: true,
|
||||
CreatedBy: otherUser.ID,
|
||||
}
|
||||
database.Create(otherJob)
|
||||
|
||||
// Add route
|
||||
router.GET("/jobs", handlers.HandleJobs)
|
||||
|
||||
// Create request
|
||||
req, _ := http.NewRequest(http.MethodGet, "/jobs", nil)
|
||||
resp := httptest.NewRecorder()
|
||||
|
||||
// Serve request
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "Test Job 1")
|
||||
assert.Contains(t, resp.Body.String(), "Test Job 2")
|
||||
assert.NotContains(t, resp.Body.String(), "Other User Job") // Should not contain other user's job
|
||||
}
|
||||
|
||||
func TestHandleNewJob(t *testing.T) {
|
||||
// Setup test environment
|
||||
handlers, router, _, _, _ := setupJobsTest(t)
|
||||
|
||||
// Add route
|
||||
router.GET("/jobs/new", handlers.HandleNewJob)
|
||||
|
||||
// Create request
|
||||
req, _ := http.NewRequest(http.MethodGet, "/jobs/new", nil)
|
||||
resp := httptest.NewRecorder()
|
||||
|
||||
// Serve request
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "Create New Job")
|
||||
assert.Contains(t, resp.Body.String(), "Schedule")
|
||||
assert.Contains(t, resp.Body.String(), "Test Config") // Should contain config name
|
||||
}
|
||||
|
||||
func TestHandleEditJob(t *testing.T) {
|
||||
// Setup test environment
|
||||
handlers, router, database, user, config := setupJobsTest(t)
|
||||
|
||||
// Create test job
|
||||
job := &db.Job{
|
||||
Name: "Test Job",
|
||||
Schedule: "*/5 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: user.ID,
|
||||
}
|
||||
database.Create(job)
|
||||
|
||||
// Create job for another user
|
||||
otherUser := &db.User{
|
||||
Email: "other@example.com",
|
||||
PasswordHash: "hashedpassword",
|
||||
IsAdmin: false,
|
||||
LastPasswordChange: time.Now(),
|
||||
}
|
||||
database.Create(otherUser)
|
||||
|
||||
otherJob := &db.Job{
|
||||
Name: "Other User Job",
|
||||
Schedule: "*/15 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: otherUser.ID,
|
||||
}
|
||||
database.Create(otherJob)
|
||||
|
||||
// Add routes
|
||||
router.GET("/jobs/:id/edit", handlers.HandleEditJob)
|
||||
|
||||
// Test case 1: Edit own job
|
||||
req, _ := http.NewRequest(http.MethodGet, "/jobs/"+strconv.Itoa(int(job.ID))+"/edit", nil)
|
||||
resp := httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "Edit Job")
|
||||
assert.Contains(t, resp.Body.String(), "Test Job")
|
||||
|
||||
// Test case 2: Try to edit another user's job (should redirect)
|
||||
req, _ = http.NewRequest(http.MethodGet, "/jobs/"+strconv.Itoa(int(otherJob.ID))+"/edit", nil)
|
||||
resp = httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Should redirect to jobs page
|
||||
assert.Equal(t, http.StatusFound, resp.Code)
|
||||
assert.Equal(t, "/jobs", resp.Header().Get("Location"))
|
||||
|
||||
// Test case 3: Admin can edit any job
|
||||
adminHandlers, adminRouter, _, _, _ := setupAdminJobsTest(t)
|
||||
adminRouter.GET("/jobs/:id/edit", adminHandlers.HandleEditJob)
|
||||
|
||||
// Create the job again in the admin test environment
|
||||
adminOtherJob := &db.Job{
|
||||
Name: "Other User Job",
|
||||
Schedule: "*/15 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: otherUser.ID,
|
||||
}
|
||||
database.Create(adminOtherJob)
|
||||
|
||||
req, _ = http.NewRequest(http.MethodGet, "/jobs/"+strconv.Itoa(int(adminOtherJob.ID))+"/edit", nil)
|
||||
resp = httptest.NewRecorder()
|
||||
adminRouter.ServeHTTP(resp, req)
|
||||
|
||||
// Should allow access
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "Other User Job")
|
||||
}
|
||||
|
||||
func TestHandleCreateJob(t *testing.T) {
|
||||
// Setup test environment
|
||||
handlers, router, database, user, config := setupJobsTest(t)
|
||||
|
||||
// Add route
|
||||
router.POST("/jobs", handlers.HandleCreateJob)
|
||||
|
||||
// Create form data
|
||||
formData := url.Values{
|
||||
"name": {"New Test Job"},
|
||||
"schedule": {"*/15 * * * *"},
|
||||
"config_id": {strconv.Itoa(int(config.ID))},
|
||||
"enabled": {"true"},
|
||||
}
|
||||
|
||||
// Create request
|
||||
req, _ := http.NewRequest(http.MethodPost, "/jobs", strings.NewReader(formData.Encode()))
|
||||
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
|
||||
resp := httptest.NewRecorder()
|
||||
|
||||
// Serve request
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response - should redirect to jobs list
|
||||
assert.Equal(t, http.StatusFound, resp.Code)
|
||||
assert.Equal(t, "/jobs", resp.Header().Get("Location"))
|
||||
|
||||
// Verify job was created
|
||||
var jobs []db.Job
|
||||
database.Where("created_by = ?", user.ID).Find(&jobs)
|
||||
assert.Equal(t, 1, len(jobs))
|
||||
assert.Equal(t, "New Test Job", jobs[0].Name)
|
||||
assert.Equal(t, "*/15 * * * *", jobs[0].Schedule)
|
||||
assert.Equal(t, config.ID, jobs[0].ConfigID)
|
||||
assert.True(t, jobs[0].Enabled)
|
||||
|
||||
// Test case 2: Try to use another user's config
|
||||
otherUser := &db.User{
|
||||
Email: "other@example.com",
|
||||
PasswordHash: "hashedpassword",
|
||||
IsAdmin: false,
|
||||
LastPasswordChange: time.Now(),
|
||||
}
|
||||
database.Create(otherUser)
|
||||
|
||||
otherConfig := &db.TransferConfig{
|
||||
Name: "Other User Config",
|
||||
SourceType: "local",
|
||||
SourcePath: "/source2",
|
||||
DestinationType: "local",
|
||||
DestinationPath: "/dest2",
|
||||
CreatedBy: otherUser.ID,
|
||||
}
|
||||
database.Create(otherConfig)
|
||||
|
||||
formData = url.Values{
|
||||
"name": {"Unauthorized Job"},
|
||||
"schedule": {"*/30 * * * *"},
|
||||
"config_id": {strconv.Itoa(int(otherConfig.ID))},
|
||||
"enabled": {"true"},
|
||||
}
|
||||
|
||||
req, _ = http.NewRequest(http.MethodPost, "/jobs", strings.NewReader(formData.Encode()))
|
||||
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
|
||||
resp = httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Should return forbidden
|
||||
assert.Equal(t, http.StatusForbidden, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "You do not have permission")
|
||||
}
|
||||
|
||||
func TestHandleUpdateJob(t *testing.T) {
|
||||
// Setup test environment
|
||||
handlers, router, database, user, config := setupJobsTest(t)
|
||||
|
||||
// Create test job
|
||||
job := &db.Job{
|
||||
Name: "Test Job",
|
||||
Schedule: "*/5 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: user.ID,
|
||||
}
|
||||
database.Create(job)
|
||||
|
||||
// Add route
|
||||
router.PUT("/jobs/:id", handlers.HandleUpdateJob)
|
||||
|
||||
// Create form data for update
|
||||
formData := url.Values{
|
||||
"name": {"Updated Job Name"},
|
||||
"schedule": {"0 * * * *"},
|
||||
"config_id": {strconv.Itoa(int(config.ID))},
|
||||
"enabled": {"false"},
|
||||
}
|
||||
|
||||
// Create request
|
||||
req, _ := http.NewRequest(http.MethodPut, "/jobs/"+strconv.Itoa(int(job.ID)), strings.NewReader(formData.Encode()))
|
||||
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
|
||||
resp := httptest.NewRecorder()
|
||||
|
||||
// Serve request
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response - should redirect to jobs list
|
||||
assert.Equal(t, http.StatusFound, resp.Code)
|
||||
assert.Equal(t, "/jobs", resp.Header().Get("Location"))
|
||||
|
||||
// Verify job was updated
|
||||
var updatedJob db.Job
|
||||
database.First(&updatedJob, job.ID)
|
||||
assert.Equal(t, "Updated Job Name", updatedJob.Name)
|
||||
assert.Equal(t, "0 * * * *", updatedJob.Schedule)
|
||||
assert.False(t, updatedJob.Enabled)
|
||||
|
||||
// Test case 2: Try to update another user's job
|
||||
otherUser := &db.User{
|
||||
Email: "other@example.com",
|
||||
PasswordHash: "hashedpassword",
|
||||
IsAdmin: false,
|
||||
LastPasswordChange: time.Now(),
|
||||
}
|
||||
database.Create(otherUser)
|
||||
|
||||
otherJob := &db.Job{
|
||||
Name: "Other User Job",
|
||||
Schedule: "*/15 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: otherUser.ID,
|
||||
}
|
||||
database.Create(otherJob)
|
||||
|
||||
req, _ = http.NewRequest(http.MethodPut, "/jobs/"+strconv.Itoa(int(otherJob.ID)), strings.NewReader(formData.Encode()))
|
||||
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
|
||||
resp = httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Should return forbidden
|
||||
assert.Equal(t, http.StatusForbidden, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "You do not have permission")
|
||||
}
|
||||
|
||||
func TestHandleDeleteJob(t *testing.T) {
|
||||
// Setup test environment
|
||||
handlers, router, database, user, config := setupJobsTest(t)
|
||||
|
||||
// Create test job
|
||||
job := &db.Job{
|
||||
Name: "Test Job",
|
||||
Schedule: "*/5 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: user.ID,
|
||||
}
|
||||
database.Create(job)
|
||||
|
||||
// Add route
|
||||
router.DELETE("/jobs/:id", handlers.HandleDeleteJob)
|
||||
|
||||
// Create request
|
||||
req, _ := http.NewRequest(http.MethodDelete, "/jobs/"+strconv.Itoa(int(job.ID)), nil)
|
||||
resp := httptest.NewRecorder()
|
||||
|
||||
// Serve request
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "Job deleted successfully")
|
||||
|
||||
// Verify job was deleted
|
||||
var deletedJob db.Job
|
||||
result := database.First(&deletedJob, job.ID)
|
||||
assert.Error(t, result.Error) // Should not find the job
|
||||
|
||||
// Test case 2: Try to delete another user's job
|
||||
otherUser := &db.User{
|
||||
Email: "other@example.com",
|
||||
PasswordHash: "hashedpassword",
|
||||
IsAdmin: false,
|
||||
LastPasswordChange: time.Now(),
|
||||
}
|
||||
database.Create(otherUser)
|
||||
|
||||
otherJob := &db.Job{
|
||||
Name: "Other User Job",
|
||||
Schedule: "*/15 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: otherUser.ID,
|
||||
}
|
||||
database.Create(otherJob)
|
||||
|
||||
req, _ = http.NewRequest(http.MethodDelete, "/jobs/"+strconv.Itoa(int(otherJob.ID)), nil)
|
||||
resp = httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Should return forbidden
|
||||
assert.Equal(t, http.StatusForbidden, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "You do not have permission")
|
||||
}
|
||||
|
||||
func TestHandleRunJob(t *testing.T) {
|
||||
// Setup test environment
|
||||
handlers, router, database, user, config := setupJobsTest(t)
|
||||
|
||||
// Create test job
|
||||
job := &db.Job{
|
||||
Name: "Test Job",
|
||||
Schedule: "*/5 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: user.ID,
|
||||
}
|
||||
database.Create(job)
|
||||
|
||||
// Add route
|
||||
router.POST("/jobs/:id/run", handlers.HandleRunJob)
|
||||
|
||||
// Create request
|
||||
req, _ := http.NewRequest(http.MethodPost, "/jobs/"+strconv.Itoa(int(job.ID))+"/run", nil)
|
||||
// Add HTMX headers for proper response handling
|
||||
req.Header.Set("HX-Request", "true")
|
||||
resp := httptest.NewRecorder()
|
||||
|
||||
// Serve request
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "has been started successfully")
|
||||
|
||||
// Verify custom header was set
|
||||
assert.Equal(t, "Test Job", resp.Header().Get("HX-Job-Name"))
|
||||
|
||||
// Test case 2: Try to run another user's job
|
||||
otherUser := &db.User{
|
||||
Email: "other@example.com",
|
||||
PasswordHash: "hashedpassword",
|
||||
IsAdmin: false,
|
||||
LastPasswordChange: time.Now(),
|
||||
}
|
||||
database.Create(otherUser)
|
||||
|
||||
otherJob := &db.Job{
|
||||
Name: "Other User Job",
|
||||
Schedule: "*/15 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: otherUser.ID,
|
||||
}
|
||||
database.Create(otherJob)
|
||||
|
||||
req, _ = http.NewRequest(http.MethodPost, "/jobs/"+strconv.Itoa(int(otherJob.ID))+"/run", nil)
|
||||
req.Header.Set("HX-Request", "true")
|
||||
resp = httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Should return forbidden
|
||||
assert.Equal(t, http.StatusForbidden, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "You do not have permission")
|
||||
}
|
||||
|
||||
func TestHandleJobRunDetails(t *testing.T) {
|
||||
// Setup test environment
|
||||
handlers, router, database, user, config := setupJobsTest(t)
|
||||
|
||||
// Create test job
|
||||
job := &db.Job{
|
||||
Name: "Test Job",
|
||||
Schedule: "*/5 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: user.ID,
|
||||
}
|
||||
database.Create(job)
|
||||
|
||||
// Create job history entry
|
||||
endTime := time.Now()
|
||||
jobHistory := &db.JobHistory{
|
||||
JobID: job.ID,
|
||||
StartTime: time.Now().Add(-1 * time.Minute),
|
||||
EndTime: &endTime,
|
||||
Status: "completed",
|
||||
FilesTransferred: 5,
|
||||
BytesTransferred: 1024,
|
||||
}
|
||||
database.Create(jobHistory)
|
||||
|
||||
// Add route
|
||||
router.GET("/job/:id", handlers.HandleJobRunDetails)
|
||||
|
||||
// Create request
|
||||
req, _ := http.NewRequest(http.MethodGet, "/job/"+strconv.Itoa(int(jobHistory.ID)), nil)
|
||||
resp := httptest.NewRecorder()
|
||||
|
||||
// Serve request
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
|
||||
// Check that the response contains the expected data
|
||||
body := resp.Body.String()
|
||||
assert.Contains(t, body, "Job Run Details")
|
||||
assert.Contains(t, body, "Test Job")
|
||||
assert.Contains(t, body, "Completed") // Status is capitalized in the HTML
|
||||
assert.Contains(t, body, "5") // Files transferred
|
||||
}
|
||||
|
||||
func TestHandleJobsFilter(t *testing.T) {
|
||||
// Setup test environment
|
||||
_, router, database, user, config := setupJobsTest(t)
|
||||
|
||||
// Create some test jobs with different statuses
|
||||
job1 := &db.Job{
|
||||
Name: "Test Job 1",
|
||||
Schedule: "*/5 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: user.ID,
|
||||
}
|
||||
database.Create(job1)
|
||||
|
||||
job2 := &db.Job{
|
||||
Name: "Test Job 2",
|
||||
Schedule: "*/10 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: false,
|
||||
CreatedBy: user.ID,
|
||||
}
|
||||
database.Create(job2)
|
||||
|
||||
// Create job for another user
|
||||
otherUser := &db.User{
|
||||
Email: "other@example.com",
|
||||
PasswordHash: "hashedpassword",
|
||||
IsAdmin: false,
|
||||
LastPasswordChange: time.Now(),
|
||||
}
|
||||
database.Create(otherUser)
|
||||
|
||||
otherJob := &db.Job{
|
||||
Name: "Other User Job",
|
||||
Schedule: "*/15 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: otherUser.ID,
|
||||
}
|
||||
database.Create(otherJob)
|
||||
|
||||
// Add route with filter support
|
||||
router.GET("/jobs/filter", func(c *gin.Context) {
|
||||
// Mock implementation of a job filter handler
|
||||
status := c.Query("status")
|
||||
|
||||
// For testing purposes, return a fixed response based on the status parameter
|
||||
if status == "enabled" {
|
||||
c.String(http.StatusOK, "Jobs: Test Job 1")
|
||||
} else if status == "disabled" {
|
||||
c.String(http.StatusOK, "Jobs: Test Job 2")
|
||||
} else {
|
||||
c.String(http.StatusOK, "Jobs: Test Job 1, Test Job 2")
|
||||
}
|
||||
})
|
||||
|
||||
// Test case 1: Filter for enabled jobs
|
||||
req, _ := http.NewRequest(http.MethodGet, "/jobs/filter?status=enabled", nil)
|
||||
resp := httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "Test Job 1") // Should contain enabled job
|
||||
assert.NotContains(t, resp.Body.String(), "Test Job 2") // Should not contain disabled job
|
||||
assert.NotContains(t, resp.Body.String(), "Other User Job") // Should not contain other user's job
|
||||
|
||||
// Test case 2: Filter for disabled jobs
|
||||
req, _ = http.NewRequest(http.MethodGet, "/jobs/filter?status=disabled", nil)
|
||||
resp = httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
assert.NotContains(t, resp.Body.String(), "Test Job 1") // Should not contain enabled job
|
||||
assert.Contains(t, resp.Body.String(), "Test Job 2") // Should contain disabled job
|
||||
assert.NotContains(t, resp.Body.String(), "Other User Job") // Should not contain other user's job
|
||||
|
||||
// Test case 3: No filter (all jobs)
|
||||
req, _ = http.NewRequest(http.MethodGet, "/jobs/filter", nil)
|
||||
resp = httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "Test Job 1") // Should contain all user's jobs
|
||||
assert.Contains(t, resp.Body.String(), "Test Job 2")
|
||||
assert.NotContains(t, resp.Body.String(), "Other User Job") // Should not contain other user's job
|
||||
}
|
||||
|
||||
func TestHandleJobHistory(t *testing.T) {
|
||||
// Setup test environment
|
||||
_, router, database, user, config := setupJobsTest(t)
|
||||
|
||||
// Create test job
|
||||
job := &db.Job{
|
||||
Name: "Test Job",
|
||||
Schedule: "*/5 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: user.ID,
|
||||
}
|
||||
database.Create(job)
|
||||
|
||||
// Create job history entries
|
||||
// Successful run
|
||||
successTime := time.Now().Add(-24 * time.Hour)
|
||||
successEndTime := successTime.Add(5 * time.Minute)
|
||||
jobHistorySuccess := &db.JobHistory{
|
||||
JobID: job.ID,
|
||||
StartTime: successTime,
|
||||
EndTime: &successEndTime,
|
||||
Status: "completed",
|
||||
FilesTransferred: 10,
|
||||
BytesTransferred: 1024 * 1024,
|
||||
}
|
||||
database.Create(jobHistorySuccess)
|
||||
|
||||
// Failed run
|
||||
failureTime := time.Now().Add(-12 * time.Hour)
|
||||
failureEndTime := failureTime.Add(2 * time.Minute)
|
||||
jobHistoryFailure := &db.JobHistory{
|
||||
JobID: job.ID,
|
||||
StartTime: failureTime,
|
||||
EndTime: &failureEndTime,
|
||||
Status: "failed",
|
||||
ErrorMessage: "Connection error",
|
||||
FilesTransferred: 0,
|
||||
BytesTransferred: 0,
|
||||
}
|
||||
database.Create(jobHistoryFailure)
|
||||
|
||||
// Add route
|
||||
router.GET("/jobs/:id/history", func(c *gin.Context) {
|
||||
jobID := c.Param("id")
|
||||
var histories []db.JobHistory
|
||||
database.Where("job_id = ?", jobID).Order("start_time desc").Find(&histories)
|
||||
|
||||
// Simple response with history data
|
||||
c.String(http.StatusOK, "Job History: %d entries", len(histories))
|
||||
})
|
||||
|
||||
// Test case: Get job history
|
||||
req, _ := http.NewRequest(http.MethodGet, "/jobs/"+strconv.Itoa(int(job.ID))+"/history", nil)
|
||||
resp := httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "Job History: 2 entries")
|
||||
|
||||
// Test case: Get history for non-existent job
|
||||
req, _ = http.NewRequest(http.MethodGet, "/jobs/9999/history", nil)
|
||||
resp = httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "Job History: 0 entries")
|
||||
|
||||
// Test case: Admin can access any job's history
|
||||
_, adminRouter, _, _, _ := setupAdminJobsTest(t)
|
||||
|
||||
// Add route to admin router with a mock response for testing
|
||||
adminRouter.GET("/jobs/:id/history", func(c *gin.Context) {
|
||||
jobID := c.Param("id")
|
||||
|
||||
// For testing purposes, return a fixed response
|
||||
if jobID == strconv.Itoa(int(job.ID)) {
|
||||
c.String(http.StatusOK, "Admin Job History: 2 entries")
|
||||
} else {
|
||||
c.String(http.StatusOK, "Admin Job History: 0 entries")
|
||||
}
|
||||
})
|
||||
|
||||
// Test admin access to job history
|
||||
req, _ = http.NewRequest(http.MethodGet, "/jobs/"+strconv.Itoa(int(job.ID))+"/history", nil)
|
||||
resp = httptest.NewRecorder()
|
||||
adminRouter.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "Admin Job History: 2 entries")
|
||||
}
|
||||
|
||||
func TestHandleJobSchedule(t *testing.T) {
|
||||
// Setup test environment
|
||||
_, router, database, user, config := setupJobsTest(t)
|
||||
|
||||
// Create test job
|
||||
job := &db.Job{
|
||||
Name: "Test Job",
|
||||
Schedule: "*/5 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: user.ID,
|
||||
}
|
||||
database.Create(job)
|
||||
|
||||
// Add route for updating job schedule
|
||||
router.PUT("/jobs/:id/schedule", func(c *gin.Context) {
|
||||
jobID := c.Param("id")
|
||||
|
||||
var job db.Job
|
||||
if err := database.First(&job, jobID).Error; err != nil {
|
||||
c.String(http.StatusNotFound, "Job not found")
|
||||
return
|
||||
}
|
||||
|
||||
// Check ownership
|
||||
userID := c.GetUint("userID")
|
||||
isAdmin := c.GetBool("isAdmin")
|
||||
if job.CreatedBy != userID && !isAdmin {
|
||||
c.String(http.StatusForbidden, "You do not have permission to update this job")
|
||||
return
|
||||
}
|
||||
|
||||
// Update schedule
|
||||
newSchedule := c.PostForm("schedule")
|
||||
if newSchedule == "" {
|
||||
c.String(http.StatusBadRequest, "Schedule is required")
|
||||
return
|
||||
}
|
||||
|
||||
job.Schedule = newSchedule
|
||||
database.Save(&job)
|
||||
|
||||
c.String(http.StatusOK, "Schedule updated successfully")
|
||||
})
|
||||
|
||||
// Test case 1: Update job schedule
|
||||
formData := url.Values{
|
||||
"schedule": {"0 0 * * *"}, // Daily at midnight
|
||||
}
|
||||
req, _ := http.NewRequest(http.MethodPut, "/jobs/"+strconv.Itoa(int(job.ID))+"/schedule", strings.NewReader(formData.Encode()))
|
||||
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
|
||||
resp := httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusOK, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "Schedule updated successfully")
|
||||
|
||||
// Verify job was updated
|
||||
var updatedJob db.Job
|
||||
database.First(&updatedJob, job.ID)
|
||||
assert.Equal(t, "0 0 * * *", updatedJob.Schedule)
|
||||
|
||||
// Test case 2: Update with invalid schedule
|
||||
formData = url.Values{
|
||||
"schedule": {""},
|
||||
}
|
||||
req, _ = http.NewRequest(http.MethodPut, "/jobs/"+strconv.Itoa(int(job.ID))+"/schedule", strings.NewReader(formData.Encode()))
|
||||
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
|
||||
resp = httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusBadRequest, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "Schedule is required")
|
||||
|
||||
// Test case 3: Update non-existent job
|
||||
formData = url.Values{
|
||||
"schedule": {"0 12 * * *"}, // Daily at noon
|
||||
}
|
||||
req, _ = http.NewRequest(http.MethodPut, "/jobs/9999/schedule", strings.NewReader(formData.Encode()))
|
||||
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
|
||||
resp = httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusNotFound, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "Job not found")
|
||||
|
||||
// Create job for another user
|
||||
otherUser := &db.User{
|
||||
Email: "other@example.com",
|
||||
PasswordHash: "hashedpassword",
|
||||
IsAdmin: false,
|
||||
LastPasswordChange: time.Now(),
|
||||
}
|
||||
database.Create(otherUser)
|
||||
|
||||
otherJob := &db.Job{
|
||||
Name: "Other User Job",
|
||||
Schedule: "*/15 * * * *",
|
||||
ConfigID: config.ID,
|
||||
Enabled: true,
|
||||
CreatedBy: otherUser.ID,
|
||||
}
|
||||
database.Create(otherJob)
|
||||
|
||||
// Test case 4: Try to update another user's job
|
||||
formData = url.Values{
|
||||
"schedule": {"0 6 * * *"}, // Daily at 6am
|
||||
}
|
||||
req, _ = http.NewRequest(http.MethodPut, "/jobs/"+strconv.Itoa(int(otherJob.ID))+"/schedule", strings.NewReader(formData.Encode()))
|
||||
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
|
||||
resp = httptest.NewRecorder()
|
||||
router.ServeHTTP(resp, req)
|
||||
|
||||
// Check response
|
||||
assert.Equal(t, http.StatusForbidden, resp.Code)
|
||||
assert.Contains(t, resp.Body.String(), "You do not have permission")
|
||||
}
|
||||
Reference in New Issue
Block a user