feat: Add recovery migrations for notification_services and auth_providers tables

- Introduced two new migrations (011b_recover_notification_services_rename and 011c_recover_auth_providers_rename) to check and recover the notification_services and auth_providers tables if they were incorrectly renamed during a previous migration.
- Implemented logic to handle various states of the tables, including logging warnings for potential issues and ensuring safe recovery actions.
- Updated the migration sequence to include these new recovery steps, enhancing the robustness of the database migration process.
This commit is contained in:
StarFleetCPTN
2025-04-07 09:06:22 -07:00
parent b9af8fc051
commit d691fc837e
4 changed files with 106 additions and 412 deletions
@@ -0,0 +1,45 @@
package migrations
import (
"fmt"
"github.com/go-gormigrate/gormigrate/v2"
"gorm.io/gorm"
)
// RecoverNotificationServicesRename checks for and corrects a specific inconsistent state
// left by a potentially failed run of migration 012, where the notification_services
// table might have been left renamed as _notification_services_old.
func RecoverNotificationServicesRename() *gormigrate.Migration {
return &gormigrate.Migration{
ID: "011b_recover_notification_services_rename",
Migrate: func(tx *gorm.DB) error {
fmt.Println("Running migration 011b: Checking for notification_services rename recovery...")
var oldTableExists int
tx.Raw("SELECT count(*) FROM sqlite_master WHERE type='table' AND name='_notification_services_old'").Scan(&oldTableExists)
var newTableExists int
tx.Raw("SELECT count(*) FROM sqlite_master WHERE type='table' AND name='notification_services'").Scan(&newTableExists)
if oldTableExists > 0 && newTableExists == 0 {
fmt.Println("Found _notification_services_old table but not notification_services. Attempting recovery rename...")
if err := tx.Exec("ALTER TABLE _notification_services_old RENAME TO notification_services").Error; err != nil {
return fmt.Errorf("failed to rename _notification_services_old back to notification_services: %w", err)
}
fmt.Println("Successfully renamed _notification_services_old to notification_services.")
} else if oldTableExists > 0 && newTableExists > 0 {
fmt.Println("Warning: Both notification_services and _notification_services_old tables exist. Manual inspection might be needed.")
} else {
fmt.Println("No recovery needed for notification_services rename.")
}
return nil
},
Rollback: func(tx *gorm.DB) error {
// Rollback doesn't make sense for a recovery step.
fmt.Println("Rollback for migration 011b_recover_notification_services_rename is not applicable.")
return nil
},
}
}
@@ -0,0 +1,45 @@
package migrations
import (
"fmt"
"github.com/go-gormigrate/gormigrate/v2"
"gorm.io/gorm"
)
// RecoverAuthProvidersRename checks for and corrects a specific inconsistent state
// left by a potentially failed run of migration 012, where the auth_providers
// table might have been left renamed as _auth_providers_old.
func RecoverAuthProvidersRename() *gormigrate.Migration {
return &gormigrate.Migration{
ID: "011c_recover_auth_providers_rename",
Migrate: func(tx *gorm.DB) error {
fmt.Println("Running migration 011c: Checking for auth_providers rename recovery...")
var oldTableExists int
tx.Raw("SELECT count(*) FROM sqlite_master WHERE type='table' AND name='_auth_providers_old'").Scan(&oldTableExists)
var newTableExists int
tx.Raw("SELECT count(*) FROM sqlite_master WHERE type='table' AND name='auth_providers'").Scan(&newTableExists)
if oldTableExists > 0 && newTableExists == 0 {
fmt.Println("Found _auth_providers_old table but not auth_providers. Attempting recovery rename...")
if err := tx.Exec("ALTER TABLE _auth_providers_old RENAME TO auth_providers").Error; err != nil {
return fmt.Errorf("failed to rename _auth_providers_old back to auth_providers: %w", err)
}
fmt.Println("Successfully renamed _auth_providers_old to auth_providers.")
} else if oldTableExists > 0 && newTableExists > 0 {
fmt.Println("Warning: Both auth_providers and _auth_providers_old tables exist. Manual inspection might be needed.")
} else {
fmt.Println("No recovery needed for auth_providers rename.")
}
return nil
},
Rollback: func(tx *gorm.DB) error {
// Rollback doesn't make sense for a recovery step.
fmt.Println("Rollback for migration 011c_recover_auth_providers_rename is not applicable.")
return nil
},
}
}
+16 -14
View File
@@ -11,20 +11,22 @@ var migrations []*gormigrate.Migration
func GetMigrations(db *gorm.DB) *gormigrate.Gormigrate {
// Add all migrations in order
migrations = append(migrations,
InitialSchema(), // 001
UpdateGDriveType(), // 002
Add2FA(), // 003
AddAuditLogs(), // 004
AddDefaultRoles(), // 005
AddTimestampsToJobHistories(), // 006
AddNotificationServices(), // 007
AddUserNotifications(), // 008
AddRcloneTables(), // 009
AddRcloneCommandToConfig(), // 010
AddAuthProviders(), // 011
RecoverTransferConfigsRename(), // 011a
AlterBooleanDefaults(), // 012
CleanupInvalidBooleans(), // 013
InitialSchema(), // 001
UpdateGDriveType(), // 002
Add2FA(), // 003
AddAuditLogs(), // 004
AddDefaultRoles(), // 005
AddTimestampsToJobHistories(), // 006
AddNotificationServices(), // 007
AddUserNotifications(), // 008
AddRcloneTables(), // 009
AddRcloneCommandToConfig(), // 010
AddAuthProviders(), // 011
RecoverTransferConfigsRename(), // 011a
RecoverNotificationServicesRename(), // 011b
RecoverAuthProvidersRename(), // 011c
AlterBooleanDefaults(), // 012
CleanupInvalidBooleans(), // 013
)
return gormigrate.New(db, gormigrate.DefaultOptions, migrations)