mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-11-19 19:03:54 +01:00
s3: route metadata-only self-copy off the distributed lock (#9638)
A non-versioned metadata-only self-copy (CopyObject with source == destination and the REPLACE directive) is a read-modify-write of one entry, which is why it held the distributed lock. It now routes to the owner as a serialized PATCH_EXTENDED: the owner merges the new managed metadata (set the replacements, delete the dropped keys) onto a fresh read of the entry under its per-path lock, so a concurrent change to non-managed keys (legal hold, retention, version id) is preserved instead of clobbered, and bumps mtime. PATCH_EXTENDED gains touch_mtime for the mtime bump. Versioned and suspended self-copies create a new version (already routed via the copy finalize) and the no-owner bootstrap keep the lock.
This commit is contained in:
1 parent
fa7056dc6f
commit
1f0c366583
7 files changed
+122
-16
No files matched your search
@@ -215,3 +215,41 @@ func (s3a *S3ApiServer) routedDelete(owner pb.ServerAddress, bucket, object stri
|
||||
}},
|
||||
})
|
||||
}
|
||||
|
||||
// routedMetadataReplace applies a metadata-only self-copy (REPLACE directive) to
|
||||
// an existing object in place via a routed PATCH_EXTENDED. The owner merges the
|
||||
// new managed metadata onto a fresh read of the entry under its per-path lock —
|
||||
// so a concurrent change to non-managed keys (legal hold, retention, version id)
|
||||
// is preserved rather than clobbered by a whole-entry rewrite — and bumps mtime.
|
||||
// updatedMetadata is the full managed-metadata set (processMetadataBytes); the
|
||||
// delete list is the managed keys the replace dropped.
|
||||
func (s3a *S3ApiServer) routedMetadataReplace(owner pb.ServerAddress, bucket, object string, current *filer_pb.Entry, updatedMetadata map[string][]byte) error {
|
||||
fullpath := util.NewFullPath(s3a.bucketDir(bucket), object)
|
||||
dir, name := fullpath.DirAndName()
|
||||
var del []string
|
||||
for k := range current.Extended {
|
||||
if isManagedCopyMetadataKey(k) {
|
||||
if _, keep := updatedMetadata[k]; !keep {
|
||||
del = append(del, k)
|
||||
}
|
||||
}
|
||||
}
|
||||
resp, err := s3a.objectTxnOnFiler(owner, &filer_pb.ObjectTransactionRequest{
|
||||
LockKey: string(fullpath),
|
||||
Mutations: []*filer_pb.ObjectMutation{{
|
||||
Type: filer_pb.ObjectMutation_PATCH_EXTENDED,
|
||||
Directory: dir,
|
||||
Name: name,
|
||||
SetExtended: updatedMetadata,
|
||||
DeleteExtended: del,
|
||||
TouchMtime: true,
|
||||
}},
|
||||
})
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
if resp.Error != "" {
|
||||
return fmt.Errorf("routed metadata replace %s/%s: %s", bucket, object, resp.Error)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
Reference in new issue
Block a user