From 384523761bf80616827c6a8fc92de195d2041167 Mon Sep 17 00:00:00 2001
From: Chris Lu <chrislusf@users.noreply.github.com>
Date: Fri, 23 Oct 2026 06:19:56 -0700
Subject: [PATCH] ci: skip actions/cache on self-hosted runners (#11986)

cargo registry/target and docker-image caches are already local on a
persistent self-hosted runner; the save/restore pass is pure overhead
(the setup-go cache-save stall on awscli-tests was the same pattern).
Gate every actions/cache step on runner.environment == 'github-hosted'.

Generated with [Devin](https://devin.ai)

Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
---
 .github/workflows/container_dev.yml             | 1 +
 .github/workflows/container_latest.yml          | 1 +
 .github/workflows/container_release_unified.yml | 1 +
 .github/workflows/e2e.yml                       | 1 +
 .github/workflows/performance.yml               | 4 ++--
 .github/workflows/postgres-tests.yml            | 1 +
 .github/workflows/rust-volume-server-tests.yml  | 3 +++
 .github/workflows/rust-worker-tests.yml         | 1 +
 .github/workflows/rust_binaries_dev.yml         | 2 ++
 .github/workflows/rust_binaries_release.yml     | 4 ++++
 .github/workflows/s3-tables-tests.yml           | 1 +
 11 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/container_dev.yml b/.github/workflows/container_dev.yml
index dd8c5843fc..2c30f861a2 100644
--- a/.github/workflows/container_dev.yml
+++ b/.github/workflows/container_dev.yml
@@ -55,6 +55,7 @@ jobs:
           echo "CFLAGS_aarch64_unknown_linux_musl=-U_FORTIFY_SOURCE" >> "$GITHUB_ENV"
 
       - name: Cache cargo registry and target
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
diff --git a/.github/workflows/container_latest.yml b/.github/workflows/container_latest.yml
index 3d99baaf24..0dc49db29c 100644
--- a/.github/workflows/container_latest.yml
+++ b/.github/workflows/container_latest.yml
@@ -99,6 +99,7 @@ jobs:
           echo "CFLAGS_aarch64_unknown_linux_musl=-U_FORTIFY_SOURCE" >> "$GITHUB_ENV"
 
       - name: Cache cargo registry and target
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
diff --git a/.github/workflows/container_release_unified.yml b/.github/workflows/container_release_unified.yml
index 095524ce34..6ac4ce06db 100644
--- a/.github/workflows/container_release_unified.yml
+++ b/.github/workflows/container_release_unified.yml
@@ -78,6 +78,7 @@ jobs:
           echo "CFLAGS_aarch64_unknown_linux_musl=-U_FORTIFY_SOURCE" >> "$GITHUB_ENV"
 
       - name: Cache cargo registry and target
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
index 8ca45f0067..363627df27 100644
--- a/.github/workflows/e2e.yml
+++ b/.github/workflows/e2e.yml
@@ -53,6 +53,7 @@ jobs:
       uses: docker/setup-buildx-action@v4
       
     - name: Cache Docker layers
+      if: runner.environment == 'github-hosted'
       uses: actions/cache@v6
       with:
         path: /tmp/.buildx-cache
diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml
index 599c01770c..0d22915b22 100644
--- a/.github/workflows/performance.yml
+++ b/.github/workflows/performance.yml
@@ -183,7 +183,7 @@ jobs:
         uses: dtolnay/rust-toolchain@stable
 
       - name: Cache cargo registry and target
-        if: matrix.impl == 'rust'
+        if: matrix.impl == 'rust' && runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
@@ -336,7 +336,7 @@ jobs:
         uses: dtolnay/rust-toolchain@stable
 
       - name: Cache cargo registry and target
-        if: matrix.impl == 'rust'
+        if: matrix.impl == 'rust' && runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
diff --git a/.github/workflows/postgres-tests.yml b/.github/workflows/postgres-tests.yml
index ed26b591b9..bbcef063bf 100644
--- a/.github/workflows/postgres-tests.yml
+++ b/.github/workflows/postgres-tests.yml
@@ -57,6 +57,7 @@ jobs:
       uses: docker/setup-buildx-action@v4
 
     - name: Cache Docker layers
+      if: runner.environment == 'github-hosted'
       uses: actions/cache@v6
       with:
         path: /tmp/.buildx-cache
diff --git a/.github/workflows/rust-volume-server-tests.yml b/.github/workflows/rust-volume-server-tests.yml
index eb5db5c739..84b80de66d 100644
--- a/.github/workflows/rust-volume-server-tests.yml
+++ b/.github/workflows/rust-volume-server-tests.yml
@@ -76,6 +76,7 @@ jobs:
         run: echo "fingerprint=$(getconf GNU_LIBC_VERSION | tr ' ' '-')-rustc-$(rustc -V | awk '{print $2}')" >> "$GITHUB_OUTPUT"
 
       - name: Cache cargo registry and target
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
@@ -128,6 +129,7 @@ jobs:
         run: echo "fingerprint=$(getconf GNU_LIBC_VERSION | tr ' ' '-')-rustc-$(rustc -V | awk '{print $2}')" >> "$GITHUB_OUTPUT"
 
       - name: Cache cargo registry and target
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
@@ -191,6 +193,7 @@ jobs:
         run: echo "fingerprint=windows-rustc-$(rustc -V | awk '{print $2}')" >> "$GITHUB_OUTPUT"
 
       - name: Cache cargo registry and target
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
diff --git a/.github/workflows/rust-worker-tests.yml b/.github/workflows/rust-worker-tests.yml
index 66510cf101..7bfaecb695 100644
--- a/.github/workflows/rust-worker-tests.yml
+++ b/.github/workflows/rust-worker-tests.yml
@@ -45,6 +45,7 @@ jobs:
         run: echo "fingerprint=$(getconf GNU_LIBC_VERSION | tr ' ' '-')-rustc-$(rustc -V | awk '{print $2}')" >> "$GITHUB_OUTPUT"
 
       - name: Cache cargo registry and target
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
diff --git a/.github/workflows/rust_binaries_dev.yml b/.github/workflows/rust_binaries_dev.yml
index 563022d028..e49abdbbd8 100644
--- a/.github/workflows/rust_binaries_dev.yml
+++ b/.github/workflows/rust_binaries_dev.yml
@@ -46,6 +46,7 @@ jobs:
         uses: dtolnay/rust-toolchain@stable
 
       - name: Cache cargo registry and target
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
@@ -114,6 +115,7 @@ jobs:
           targets: ${{ matrix.target }}
 
       - name: Cache cargo registry and target
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
diff --git a/.github/workflows/rust_binaries_release.yml b/.github/workflows/rust_binaries_release.yml
index a5a8b61455..f9446a917a 100644
--- a/.github/workflows/rust_binaries_release.yml
+++ b/.github/workflows/rust_binaries_release.yml
@@ -48,6 +48,7 @@ jobs:
           echo "OPENSSL_LIB_DIR=/usr/lib/aarch64-linux-gnu" >> "$GITHUB_ENV"
 
       - name: Cache cargo registry and target
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
@@ -153,6 +154,7 @@ jobs:
           echo "CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER=aarch64-linux-gnu-gcc" >> "$GITHUB_ENV"
 
       - name: Cache cargo registry and target
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
@@ -230,6 +232,7 @@ jobs:
           targets: ${{ matrix.target }}
 
       - name: Cache cargo registry and target
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
@@ -305,6 +308,7 @@ jobs:
         uses: dtolnay/rust-toolchain@stable
 
       - name: Cache cargo registry and target
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: |
diff --git a/.github/workflows/s3-tables-tests.yml b/.github/workflows/s3-tables-tests.yml
index 64aa3d7fbc..baa50a4cb9 100644
--- a/.github/workflows/s3-tables-tests.yml
+++ b/.github/workflows/s3-tables-tests.yml
@@ -800,6 +800,7 @@ jobs:
 
       - name: Restore python:3 image cache
         id: python-image
+        if: runner.environment == 'github-hosted'
         uses: actions/cache@v6
         with:
           path: /tmp/python3-image.tar