Github-Mirror/seaweedfs
1
0 Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-10-10 00:07:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent deadlock when stream error occurs - make cmds send non-blocking

Browse Source 
If managerLoop is blocked (e.g., waiting on regWait), a blocking send to cmds
will deadlock handleIncoming. Make the send non-blocking to prevent this.
This commit is contained in:
Chris Lu committed 2025-12-22 00:16:03 -08:00
1 parent 85369414f9
commit 3ebbd25a4b
1 file changed
+6 -2
Download Patch File Download Diff File Expand all files Collapse all files
weed/worker/client.go
+6 -2
View File
@@ -446,8 +446,12 @@ func handleIncoming(
default: default:
} }
// Report the failure as a command to the managerLoop (blocking) // Report the failure as a command to the managerLoop (non-blocking to prevent deadlock)
cmds <- grpcCommand{action: ActionStreamError, data: err} select {
case cmds <- grpcCommand{action: ActionStreamError, data: err}:
default:
glog.V(2).Infof("Manager busy, stream error not queued: %v", err)
}
// Exit the main handler loop // Exit the main handler loop
glog.V(1).Infof("INCOMING HANDLER STOPPED: Worker %s stopping incoming handler due to stream error", workerID) glog.V(1).Infof("INCOMING HANDLER STOPPED: Worker %s stopping incoming handler due to stream error", workerID)