mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-11-17 01:05:29 +01:00
fix: Phase 20 T3 — production wiring + fail-closed on partial evidence
Wire V2 promotion into production binary: - Add --block.v2Promotion CLI flag on weed master (default false) - MasterOption.BlockV2Promotion → NewMasterServer wires flag + querier - defaultBlockVSQueryEvidence placeholder (returns explicit error until proto regen on M01 enables gRPC evidence RPC) Fix three fail-closed violations found by tester: 1. blockV2Promotion=true + nil querier now fails closed with explicit log instead of silently falling back to V1 2. Partial evidence (any candidate query failed) now fails closed — unreachable candidate may be the most durable, promoting from incomplete evidence violates durability-first ordering 3. Clear EngineProjectionMode in applyPromotionLocked (already in previous commit, verified in tests here) 2 new tests: NilQuerier_FailsClosed, PartialEvidenceFailure_FailsClosed. Total T3 tests: 7, all pass. Existing V1 failover tests unaffected. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
59b2e2d8f9
commit
43016e6645
5 files changed
+104
-1
No files matched your search
@@ -74,6 +74,7 @@ type MasterOptions struct {
|
||||
debug *bool
|
||||
debugPort *int
|
||||
blockPromotionLSNTolerance *int
|
||||
blockV2Promotion *bool
|
||||
}
|
||||
|
||||
func init() {
|
||||
@@ -106,6 +107,7 @@ func init() {
|
||||
m.debug = cmdMaster.Flag.Bool("debug", false, "serves runtime profiling data via pprof on the port specified by -debug.port")
|
||||
m.debugPort = cmdMaster.Flag.Int("debug.port", 6060, "http port for debugging")
|
||||
m.blockPromotionLSNTolerance = cmdMaster.Flag.Int("block.promotion.lsnTolerance", 100, "max WAL LSN lag for block volume replica promotion eligibility")
|
||||
m.blockV2Promotion = cmdMaster.Flag.Bool("block.v2Promotion", false, "enable V2 durability-first promotion (requires proto regen for evidence RPC)")
|
||||
}
|
||||
|
||||
var cmdMaster = &Command{
|
||||
@@ -415,5 +417,6 @@ func (m *MasterOptions) toMasterOption(whiteList []string) *weed_server.MasterOp
|
||||
TelemetryUrl: *m.telemetryUrl,
|
||||
TelemetryEnabled: *m.telemetryEnabled,
|
||||
BlockPromotionLSNTolerance: *m.blockPromotionLSNTolerance,
|
||||
BlockV2Promotion: *m.blockV2Promotion,
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user