From 617599859ba0579befdc74b23ed3f707e65515ee Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Fri, 23 Oct 2026 18:50:27 -0700 Subject: [PATCH] docker: build RocksDB v11.1.2 for grocksdb v1.11.1 (#12002) The rocksdb release image fails to compile: grocksdb v1.11.1 calls C.rocksdb_block_based_options_set_block_align, C.rocksdb_block_based_options_set_index_block_search_type, and C.rocksdb_block_based_options_set_separate_key_value_in_data_block, all of which only exist in RocksDB v11.x headers. grocksdb v1.11.1's own build script pins 11.1.2, so move every default from v10.10.1 to v11.1.2 to match. Generated with [Devin](https://devin.ai) Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- .github/workflows/container_release_unified.yml | 4 ++-- .github/workflows/container_rocksdb_version.yml | 4 ++-- docker/Dockerfile.rocksdb_dev_env | 2 +- docker/Dockerfile.rocksdb_large | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/container_release_unified.yml b/.github/workflows/container_release_unified.yml index 6ac4ce06db..3080595eb4 100644 --- a/.github/workflows/container_release_unified.yml +++ b/.github/workflows/container_release_unified.yml @@ -25,7 +25,7 @@ on: rocksdb_version: description: 'RocksDB git tag to use when variant=rocksdb' required: false - default: 'v10.10.1' + default: 'v11.1.2' permissions: contents: read @@ -282,7 +282,7 @@ jobs: ${{ matrix.build_args }} BUILDKIT_INLINE_CACHE=1 BRANCH=${{ github.sha }} - ${{ matrix.variant == 'rocksdb' && format('ROCKSDB_VERSION={0}', github.event.inputs.rocksdb_version || 'v10.10.1') || '' }} + ${{ matrix.variant == 'rocksdb' && format('ROCKSDB_VERSION={0}', github.event.inputs.rocksdb_version || 'v11.1.2') || '' }} - name: Export digest if: github.event_name != 'workflow_dispatch' || github.event.inputs.variant == 'all' || github.event.inputs.variant == matrix.variant diff --git a/.github/workflows/container_rocksdb_version.yml b/.github/workflows/container_rocksdb_version.yml index f06eb500f4..0d3b5f2b8f 100644 --- a/.github/workflows/container_rocksdb_version.yml +++ b/.github/workflows/container_rocksdb_version.yml @@ -4,9 +4,9 @@ on: workflow_dispatch: inputs: rocksdb_version: - description: 'RocksDB git tag or branch to build (e.g. v10.10.1)' + description: 'RocksDB git tag or branch to build (e.g. v11.1.2)' required: true - default: 'v10.10.1' + default: 'v11.1.2' seaweedfs_ref: description: 'SeaweedFS git tag, branch, or commit to build' required: true diff --git a/docker/Dockerfile.rocksdb_dev_env b/docker/Dockerfile.rocksdb_dev_env index 95154c3737..2b6b0431b1 100644 --- a/docker/Dockerfile.rocksdb_dev_env +++ b/docker/Dockerfile.rocksdb_dev_env @@ -3,7 +3,7 @@ FROM golang:1.26 AS builder RUN apt-get update RUN apt-get install -y build-essential libsnappy-dev zlib1g-dev libbz2-dev libgflags-dev liblz4-dev libzstd-dev -ARG ROCKSDB_VERSION=v10.10.1 +ARG ROCKSDB_VERSION=v11.1.2 ENV ROCKSDB_VERSION=${ROCKSDB_VERSION} # build RocksDB diff --git a/docker/Dockerfile.rocksdb_large b/docker/Dockerfile.rocksdb_large index d902c544e9..757af7e64d 100644 --- a/docker/Dockerfile.rocksdb_large +++ b/docker/Dockerfile.rocksdb_large @@ -3,7 +3,7 @@ FROM golang:1.26 AS builder RUN apt-get update RUN apt-get install -y build-essential libsnappy-dev zlib1g-dev libbz2-dev libgflags-dev liblz4-dev libzstd-dev -ARG ROCKSDB_VERSION=v10.10.1 +ARG ROCKSDB_VERSION=v11.1.2 ENV ROCKSDB_VERSION=${ROCKSDB_VERSION} # build RocksDB