address comments

This commit is contained in:
chrislu committed 2025-07-12 12:10:37 -07:00
1 parent b9b480e605
commit 638715e590
2 files changed
+30 -587

No files matched your search

+4 -3
View File
@@ -158,9 +158,10 @@ func validateObjectLockConfiguration(config *ObjectLockConfiguration) error {
// Validate Rule if present
if config.Rule != nil {
if config.Rule.DefaultRetention != nil {
return validateDefaultRetention(config.Rule.DefaultRetention)
if config.Rule.DefaultRetention == nil {
return fmt.Errorf("rule configuration must specify DefaultRetention")
}
return validateDefaultRetention(config.Rule.DefaultRetention)
}
return nil
@@ -242,7 +243,7 @@ func (s3a *S3ApiServer) getObjectRetention(bucket, object, versionId string) (*O
}
}
if retention.Mode == "" && retention.RetainUntilDate == nil {
if retention.Mode == "" || retention.RetainUntilDate == nil {
return nil, fmt.Errorf("no retention configuration found")
}