From 69218c88fe98c51fc31665272a31caf301906c12 Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Mon, 6 Apr 2026 12:48:48 -0700 Subject: [PATCH] fix(stats): fix build on openbsd, solaris, and windows (#8951) fix(stats): replace undefined calculateDiskRemaining with inline calculation disk_openbsd.go, disk_solaris.go, and disk_windows.go all call calculateDiskRemaining() which is never defined, causing build failures on those platforms. Replace with the same inline calculation used in disk_supported.go. --- weed/stats/disk_openbsd.go | 4 +++- weed/stats/disk_solaris.go | 4 +++- weed/stats/disk_windows.go | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/weed/stats/disk_openbsd.go b/weed/stats/disk_openbsd.go index a8511de449..ae71180e32 100644 --- a/weed/stats/disk_openbsd.go +++ b/weed/stats/disk_openbsd.go @@ -17,7 +17,9 @@ func fillInDiskStatus(disk *volume_server_pb.DiskStatus) { disk.All = fs.F_blocks * uint64(fs.F_bsize) disk.Free = fs.F_bfree * uint64(fs.F_bsize) - calculateDiskRemaining(disk) + disk.Used = disk.All - disk.Free + disk.PercentFree = float32((float64(disk.Free) / float64(disk.All)) * 100) + disk.PercentUsed = float32((float64(disk.Used) / float64(disk.All)) * 100) return } diff --git a/weed/stats/disk_solaris.go b/weed/stats/disk_solaris.go index dccf87d74e..b3a3e75acb 100644 --- a/weed/stats/disk_solaris.go +++ b/weed/stats/disk_solaris.go @@ -17,7 +17,9 @@ func fillInDiskStatus(disk *volume_server_pb.DiskStatus) { disk.All = stat.Blocks * uint64(stat.Bsize) disk.Free = stat.Bfree * uint64(stat.Bsize) - calculateDiskRemaining(disk) + disk.Used = disk.All - disk.Free + disk.PercentFree = float32((float64(disk.Free) / float64(disk.All)) * 100) + disk.PercentUsed = float32((float64(disk.Used) / float64(disk.All)) * 100) return } diff --git a/weed/stats/disk_windows.go b/weed/stats/disk_windows.go index c3bf04eab9..694347c32f 100644 --- a/weed/stats/disk_windows.go +++ b/weed/stats/disk_windows.go @@ -40,7 +40,9 @@ func fillInDiskStatus(disk *volume_server_pb.DiskStatus) { return } - calculateDiskRemaining(disk) + disk.Used = disk.All - disk.Free + disk.PercentFree = float32((float64(disk.Free) / float64(disk.All)) * 100) + disk.PercentUsed = float32((float64(disk.Used) / float64(disk.All)) * 100) return }