From c7b5bcfc7ee27ab1e5b3da7d3ae100b161cc90c5 Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Thu, 22 Oct 2026 03:43:08 -0700 Subject: [PATCH] fuse integration: honor SkipCleanup in the mini-based framework too Same gap as the fuse-package framework: Cleanup read a fresh DefaultTestConfig, so a test's SkipCleanup setting was ignored. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- test/fuse_integration/framework_test.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/fuse_integration/framework_test.go b/test/fuse_integration/framework_test.go index ec0fc19b5a..cfb47a5375 100644 --- a/test/fuse_integration/framework_test.go +++ b/test/fuse_integration/framework_test.go @@ -30,6 +30,7 @@ type FuseTestFramework struct { filerPort int weedBinary string isSetup bool + config *TestConfig } // TestConfig holds configuration for FUSE tests @@ -83,6 +84,7 @@ func NewFuseTestFramework(t *testing.T, config *TestConfig) *FuseTestFramework { filerAddr: fmt.Sprintf("127.0.0.1:%d", filerPort), weedBinary: findWeedBinary(), isSetup: false, + config: config, } } @@ -132,6 +134,9 @@ func (f *FuseTestFramework) Setup(config *TestConfig) error { if f.isSetup { return fmt.Errorf("framework already setup") } + if config != nil { + f.config = config + } dirs := []string{f.mountPoint, f.logDir, f.dataDir} for _, dir := range dirs { @@ -182,7 +187,7 @@ func (f *FuseTestFramework) Cleanup() { f.copyLogsForCI() - if !DefaultTestConfig().SkipCleanup { + if !f.config.SkipCleanup { os.RemoveAll(f.tempDir) } }