mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-27 07:20:44 +01:00
Address code review nitpicks
- Remove unused extractObjectTags placeholder function (engine.go) - Add clarifying comment about s3:ExistingObjectTag/<key> evaluation - Consolidate duplicate tag-based examples in README - Factor out tagsToEntry helper to package level in tests
This commit is contained in:
1 parent
b198a0e8d1
commit
d93c90fdb3
3 files changed
+42
-94
No files matched your search
@@ -209,10 +209,8 @@ func ExtractConditionValuesFromRequest(r *http.Request) map[string][]string {
|
||||
values["aws:Referer"] = []string{referer}
|
||||
}
|
||||
|
||||
// S3 object-level conditions
|
||||
if r.Method == "GET" || r.Method == "HEAD" {
|
||||
values["s3:ExistingObjectTag"] = extractObjectTags(r)
|
||||
}
|
||||
// Note: s3:ExistingObjectTag/<key> conditions are evaluated using objectEntry
|
||||
// passed to EvaluatePolicy, not extracted from the request.
|
||||
|
||||
// S3 bucket-level conditions
|
||||
if delimiter := r.URL.Query().Get("delimiter"); delimiter != "" {
|
||||
@@ -251,13 +249,6 @@ func ExtractConditionValuesFromRequest(r *http.Request) map[string][]string {
|
||||
return values
|
||||
}
|
||||
|
||||
// extractObjectTags extracts object tags from request (placeholder implementation)
|
||||
func extractObjectTags(r *http.Request) []string {
|
||||
// This would need to be implemented based on how object tags are stored
|
||||
// For now, return empty slice
|
||||
return []string{}
|
||||
}
|
||||
|
||||
// BuildResourceArn builds an ARN for the given bucket and object
|
||||
func BuildResourceArn(bucketName, objectName string) string {
|
||||
if objectName == "" {
|
||||
|
||||
Reference in new issue
Block a user