From dc609f4f6f3fec22c560b85023c1a09f3b70a8e5 Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Thu, 16 Apr 2026 03:34:41 -0700 Subject: [PATCH] fix(test): use safe slice concatenation in manifest test Avoid append(manifest1, manifest2...) which can mutate manifest1's backing array. Use the copy-then-append pattern for consistency. Addresses CodeRabbit review nitpick. --- weed/filer/filechunk_manifest_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/weed/filer/filechunk_manifest_test.go b/weed/filer/filechunk_manifest_test.go index 0cf3ef298..9d81211fe 100644 --- a/weed/filer/filechunk_manifest_test.go +++ b/weed/filer/filechunk_manifest_test.go @@ -280,7 +280,7 @@ func TestCompactResolvedOverlappingManifests(t *testing.T) { } // Resolve all manifests into sub-chunks - allChunks := append(manifest1, manifest2...) + allChunks := append(append([]*filer_pb.FileChunk{}, manifest1...), manifest2...) dataChunks, _, err := store.resolveAll(allChunks) if err != nil { t.Fatal(err)