diff --git a/.github/workflows/s3-go-tests.yml b/.github/workflows/s3-go-tests.yml index 1260e5af41..e4aec8a212 100644 --- a/.github/workflows/s3-go-tests.yml +++ b/.github/workflows/s3-go-tests.yml @@ -4,6 +4,7 @@ on: pull_request: paths: - 'weed/s3api/**' + - 'weed/remote_storage/**' - 'weed/filer/**' - 'weed/server/**' - 'test/s3/**' diff --git a/weed/remote_storage/s3/s3_storage_client_test.go b/weed/remote_storage/s3/s3_storage_client_test.go index 60ca983631..14fead3c19 100644 --- a/weed/remote_storage/s3/s3_storage_client_test.go +++ b/weed/remote_storage/s3/s3_storage_client_test.go @@ -423,7 +423,8 @@ func TestS3WriteFileSendsOnlyTagAttributes(t *testing.T) { }, } - _, _ = client.WriteFile(loc, entry, bytes.NewReader([]byte("data"))) + _, err := client.WriteFile(loc, entry, bytes.NewReader([]byte("data"))) + require.NoError(t, err) require.NotNil(t, rt.uploadReq, "uploader should have issued a PUT") require.Equal(t, "a%20b=x%3Dy", rt.uploadReq.Header.Get("X-Amz-Tagging")) @@ -441,7 +442,8 @@ func TestS3WriteFileOmitsTaggingWhenNoTagAttributes(t *testing.T) { Extended: map[string][]byte{"Seaweed-X-Amz-Acl": []byte(`[{"Permission":"FULL_CONTROL"}]`)}, } - _, _ = client.WriteFile(loc, entry, bytes.NewReader([]byte("data"))) + _, err := client.WriteFile(loc, entry, bytes.NewReader([]byte("data"))) + require.NoError(t, err) require.NotNil(t, rt.uploadReq, "uploader should have issued a PUT") require.Empty(t, rt.uploadReq.Header.Get("X-Amz-Tagging"))