From fac021544e370375565b2ae031174a581b4417d1 Mon Sep 17 00:00:00 2001 From: yi111 <153097222+Yi-111-a@users.noreply.github.com> Date: Sat, 10 Oct 2026 23:44:09 +0800 Subject: [PATCH] s3api: register the azurekms KMS provider under its build tag (#11691) * s3api: register the azurekms KMS provider under its build tag weed/kms/azure registers itself with weed/kms from an init(), but the blank import that triggers it was commented out in auth_credentials.go (TODO: Fix Azure SDK compatibility issues). Nothing else imports the package, so building with -tags azurekms still ends with "KMS provider 'azure' not registered" at startup for any config using "type": "azure". Move the import into weed/s3api/kms_azure.go behind //go:build azurekms so default builds stay free of the Azure SDK, and drop the dead comment. Closes #11686 * ci: compile and test azurekms-gated code weed/kms/azure is excluded from every default build, so nothing in CI compiled it; that is how the provider shipped unregistered. Build the tree and run the kms tests with -tags azurekms on every Go change. --------- Co-authored-by: Yi-111-a <> Co-authored-by: Chris Lu --- weed/s3api/auth_credentials.go | 1 - weed/s3api/kms_azure.go | 8 ++++++++ 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 weed/s3api/kms_azure.go diff --git a/weed/s3api/auth_credentials.go b/weed/s3api/auth_credentials.go index 6c47005ba..11c4a105e 100644 --- a/weed/s3api/auth_credentials.go +++ b/weed/s3api/auth_credentials.go @@ -32,7 +32,6 @@ import ( // Import KMS providers to register them _ "github.com/seaweedfs/seaweedfs/weed/kms/aws" - // _ "github.com/seaweedfs/seaweedfs/weed/kms/azure" // TODO: Fix Azure SDK compatibility issues _ "github.com/seaweedfs/seaweedfs/weed/kms/gcp" _ "github.com/seaweedfs/seaweedfs/weed/kms/local" _ "github.com/seaweedfs/seaweedfs/weed/kms/openbao" diff --git a/weed/s3api/kms_azure.go b/weed/s3api/kms_azure.go new file mode 100644 index 000000000..ab5f731ea --- /dev/null +++ b/weed/s3api/kms_azure.go @@ -0,0 +1,8 @@ +//go:build azurekms + +package s3api + +// Import the Azure KMS provider so its init() registers it with +// weed/kms. The provider is gated behind the `azurekms` build tag so that +// default builds do not pull in the Azure SDK. +import _ "github.com/seaweedfs/seaweedfs/weed/kms/azure"