1 Commits

Include renames

Author	SHA1	Message	Date
Chris Lu	c11ff6657b	fix(ec): mirror EC sidecars onto every shard-bearing disk at startup (#9525) ... * fix(ec): mirror EC sidecars onto every shard-bearing disk at startup In a multi-disk volume server, ec.balance and ec.rebuild can land shards on a disk that does not also hold the matching .ecx / .ecj / .vif index files. The orphan-shard reconciler in reconcileEcShardsAcrossDisks already loads those shards by pointing the EcVolume at the sibling disk's index files; reads work, but any failure on the index-owning disk silently disables every shard on the other disk, even though those shards are physically fine. This change adds mirrorEcMetadataToShardDisks, a startup pass that physically replicates .ecx / .ecj / .vif onto each disk that holds shards but is missing them. Each copy is atomic (tmp + fsync + rename) and idempotent (a destination that already has the sidecar is preserved). After mirroring, the cross-disk reconciler prefers the local IdxDirectory so the EcVolume mounts self-contained; the cross-disk virtual mount remains as a fallback for volumes whose mirror failed (read-only target, out of space, partial copy on a previous boot). The same-disk invariant the EC lifecycle (encode / decode / balance / vacuum / repair) was already documented as promising is now actually restored at boot, so a future failure of one disk in a split-shards layout no longer takes the other disk's shards with it. Tests cover the orphan-layout mirror (dir0 receives the .ecx / .ecj / .vif from dir1) and idempotency (an existing destination .ecx is not overwritten with the owner's copy). * fix(ec): handle legacy pre-dir.idx sidecar layout in mirror skip-check hasAllEcSidecarsLocally checked only the modern destination path (IdxDirectory for .ecx/.ecj, Directory for .vif). A destination disk that still had a legacy .ecx in its data dir (written before -dir.idx was set) would report "not present" and the mirror would write a second copy to IdxDirectory, leaving two .ecx files on disk. Matches HasEcxFileOnDisk's open-with-fallback contract: check the modern path first, then the opposite directory. Factored the exists-and-not-a-dir check into a small statRegular helper so the fallback ladder stays readable. * rust(seaweed-volume): mirror EC sidecars onto shard-bearing disks at startup Port of the Go fix (commit 088e26ea6) to the Rust volume server. Adds Store::mirror_ec_metadata_to_shard_disks, called from add_location / load_new_volumes before the cross-disk orphan reconciler. Physically copies .ecx / .ecj / .vif from the disk that owns the index files onto every disk holding shards but missing sidecars, so each shard-bearing disk ends up self-contained. The reconciler now prefers the local idx_directory when the mirror has installed a .ecx there; the cross-disk virtual mount remains as the fallback for volumes whose mirror failed (read-only target, out of space, partial copy on a previous boot). Adds ec_local_ecx_path helper shared between reconcile and mirror to detect the post-mirror fast path. Mirrors the Go-side fallback in hasAllEcSidecarsLocally: when -dir.idx is configured and the destination still has a legacy .ecx in its data dir, that's recognized so the mirror does not write a duplicate copy into idx_directory. Tests cover the two key cases: orphan layout (dir0 receives the sidecars from dir1) and idempotency (a pre-existing destination .ecx is not overwritten). * trim verbose comments on EC mirror code Comments now lead with the WHY (non-obvious constraints, the post-mirror fast path, why local copies are authoritative) and drop restate-the-code blocks, headers, and section dividers. Behavior is unchanged; all existing tests still pass on both the Go volume server and the seaweed-volume Rust port. * drop github issue refs from added comments Two stray "#9212" references slipped into comments I added on the cross-disk reconciler call site. The git log carries the issue history; comments stand on their own. * test(ec): accept rebuild on either disk after sidecar mirror TestEcLifecycleAcrossMultipleDisks asserted the rebuilt shard 9 must land at the disk-0 path. With the boot-time sidecar mirror, every shard-bearing disk owns its own .ecx, so VolumeEcShardsRebuild now picks whichever disk hosts the most shards — disk 1 in this layout after the deletion. The shard can legitimately rebuild on either disk; the test now accepts both and uses the chosen path for the subsequent mount + read verification.	2026-05-17 19:55:15 -07:00