Commit Graph
25 Commits
Author SHA1 Message Date
chrislu fd51091abd fix: add persistent volume data directory for volume server
- Add -dir=/data flag to volume server command
- Mount Docker volume seaweedfs-volume-data to /data
- Ensures volume server has persistent storage for volume files
- Fixes issue where volume server couldn't create writable volumes
- Volume data persists across container restarts during tests
2025-11-22 21:32:37 -08:00
chrislu e48bf9a791 security: upgrade Jetty from 9.4.53 to 12.0.16
- Upgrade from 9.4.53.v20231009 to 12.0.16 (meets requirement >12.0.9)
- Addresses security vulnerabilities in older Jetty versions
- Externalized version to jetty.version property for easier maintenance
- Added jetty-util, jetty-io, jetty-security to dependencyManagement
- Ensures all Jetty transitive dependencies use secure version
2025-11-22 20:49:37 -08:00
chrislu a1a14259c3 fix: add -max=0 to volume server for unlimited volumes
- Add -max=0 flag to volume server command
- Allows volume server to create unlimited 50MB volumes
- Fixes 'No writable volumes' error during Spark tests
- Volume server will create new volumes as needed for writes
- Consistent with other integration test configurations
2025-11-22 20:42:03 -08:00
chrislu c49abc0c2f security: upgrade Apache ZooKeeper to 3.9.4
- Upgrade from 3.9.3 to 3.9.4 (latest stable)
- Ensures all known security vulnerabilities are patched
- Fixes GHSA-g93m-8x6h-g5gv, GHSA-r978-9m6m-6gm6, GHSA-2hmj-97jw-28jh
2025-11-22 17:55:17 -08:00
chrislu a051452fe6 security: upgrade Apache ZooKeeper to 3.9.3
- Upgrade from 3.9.1 to 3.9.3
- Fixes GHSA-g93m-8x6h-g5gv: Authentication bypass in Admin Server
- Fixes GHSA-r978-9m6m-6gm6: Information disclosure in persistent watchers
- Fixes GHSA-2hmj-97jw-28jh: Insufficient permission check in snapshot/restore
- Addresses high and moderate severity vulnerabilities
2025-11-22 17:55:03 -08:00
chrislu 150deefdc0 fix: aggressively suppress Parquet DEBUG logging
- Set Parquet I/O loggers to OFF (completely disabled)
- Add log4j.configuration system property to ensure config is used
- Override Spark's default log4j configuration
- Prevents thousands of record-level DEBUG messages in CI logs
2025-11-22 17:52:02 -08:00
chrislu b018588c14 security: upgrade Netty to 4.1.124.Final (patched version)
- Upgrade from 4.1.118.Final to 4.1.124.Final
- Fixes GHSA-prj3-ccx8-p6x4: MadeYouReset HTTP/2 DDoS vulnerability
- 4.1.124.Final is the confirmed patched version per GitHub advisory
- All versions <= 4.1.123.Final are vulnerable
2025-11-22 14:22:57 -08:00
chrislu 4dd55783da security: upgrade Netty to 4.1.118.Final
- Upgrade from 4.1.115.Final to 4.1.118.Final
- Fixes CVE-2025-24970: improper validation in SslHandler
- Fixes CVE-2024-47535: unsafe environment file reading on Windows
- Fixes CVE-2024-29025: HttpPostRequestDecoder resource exhaustion
- Addresses GHSA-prj3-ccx8-p6x4 and related vulnerabilities
2025-11-22 14:22:41 -08:00
chrislu fab383dc10 fix: use 127.0.0.1 for volume server IP registration
- Change volume -ip from seaweedfs-volume to 127.0.0.1
- Change -publicUrl from localhost:8080 to 127.0.0.1:8080
- Volume server now registers with master using 127.0.0.1
- Filer will return 127.0.0.1:8080 URL that's resolvable from host
- Fixes UnknownHostException for seaweedfs-volume hostname
2025-11-22 14:21:02 -08:00
chrislu 707e7732a7 fix: suppress verbose Parquet DEBUG logging
- Set org.apache.parquet to WARN level
- Set org.apache.parquet.io to ERROR level
- Suppress RecordConsumerLoggingWrapper and MessageColumnIO DEBUG logs
- Reduces CI log noise from thousands of record-level messages
- Keeps important error messages visible
2025-11-22 14:20:11 -08:00
chrislu 8c13794a49 security: upgrade Netty to 4.1.115.Final to fix CVE
- Upgrade netty.version from 4.1.100.Final to 4.1.115.Final
- Fixes GHSA-prj3-ccx8-p6x4: MadeYouReset HTTP/2 DDoS vulnerability
- Netty 4.1.115.Final includes patches for high severity DoS attack
- Addresses GitHub dependency review security alert
2025-11-22 14:09:54 -08:00
chrislu abaf933971 fix: add publicUrl to volume server for host network access
- Add -publicUrl=localhost:8080 to volume server command
- Ensures filer returns localhost URL instead of Docker service name
- Fixes UnknownHostException when tests run on host network
- Volume server is accessible via localhost from CI runner
2025-11-22 14:08:20 -08:00
chrislu 01e20a350c refactor: extract surefire JVM args to property
- Move multi-line argLine to surefire.jvm.args property
- Reference property in argLine for cleaner configuration
- Improves maintainability and readability
- Follows Maven best practices for JVM argument management
- Avoids potential whitespace parsing issues
2025-11-22 14:07:01 -08:00
chrislu 3074b1ee2f refactor: externalize seaweedfs-hadoop3-client version to property
- Add seaweedfs.hadoop3.client.version property set to 3.80
- Replace hardcoded version with ${seaweedfs.hadoop3.client.version}
- Enables easier version management from single location
- Follows Maven best practices for dependency versioning
2025-11-22 14:06:21 -08:00
chrislu 7b548be48e security: add dependencyManagement to fix vulnerable transitives
- Pin Jackson to 2.15.3 (fixes multiple CVEs in older versions)
- Pin Netty to 4.1.100.Final (fixes CVEs in transport/codec)
- Pin Apache Avro to 1.11.4 (fixes deserialization CVEs)
- Pin Apache ZooKeeper to 3.9.1 (fixes authentication bypass)
- Pin commons-compress to 1.26.0 (fixes zip slip vulnerabilities)
- Pin commons-io to 2.15.1 (fixes path traversal)
- Pin Guava to 32.1.3-jre (fixes temp directory vulnerabilities)
- Pin SnakeYAML to 2.2 (fixes arbitrary code execution)
- Pin Jetty to 9.4.53 (fixes multiple HTTP vulnerabilities)
- Overrides vulnerable versions from Spark/Hadoop transitives
2025-11-22 14:05:24 -08:00
chrislu ec08fadf85 fix: align maven-compiler-plugin with compiler properties
- Change compiler plugin source/target from hardcoded 1.8 to use properties
- Ensures consistency with maven.compiler.source/target set to 11
- Prevents version mismatch between properties and plugin configuration
- Aligns with surefire Java 9+ module arguments
2025-11-22 13:39:22 -08:00
chrislu e8e9df2680 test: improve docker-compose config for Spark tests
- Add -volumeSizeLimitMB=50 to master (consistent with other integration tests)
- Add -defaultReplication=000 to master for explicit single-copy storage
- Add explicit -port and -port.grpc flags to all services
- Add -preStopSeconds=1 to volume for faster shutdown
- Add healthchecks to master and volume services
- Use service_healthy conditions for proper startup ordering
- Improve healthcheck intervals and timeouts for faster startup
- Use -ip flag instead of -ip.bind for service identity
2025-11-22 13:35:52 -08:00
chrislu dd9c1c6190 fix: add -peers=none to master command for standalone mode
- Ensures master runs in standalone single-node mode
- Prevents master from trying to form a cluster
- Required for proper initialization in test environment
2025-11-22 13:34:01 -08:00
chrislu e63feb48fc ci: fix Maven artifact restoration in workflow
- Add step to restore Maven artifacts from download to ~/.m2/repository
- Restructure artifact upload to use consistent directory layout
- Remove obsolete 'version' field from docker-compose.yml to eliminate warnings
- Ensures SeaweedFS Java dependencies are available during test execution
2025-11-22 13:14:52 -08:00
chrislu 786f5de7bb ci: refactor Spark workflow for DRY and robustness
1. Add explicit permissions (least privilege):
   - contents: read
   - checks: write (for test reports)
   - pull-requests: write (for PR comments)

2. Extract duplicate build steps into shared 'build-deps' job:
   - Eliminates duplication between spark-tests and spark-example
   - Build artifacts are uploaded and reused by dependent jobs
   - Reduces CI time and ensures consistency

3. Fix spark-example service startup verification:
   - Match robust approach from spark-tests job
   - Add explicit timeout and failure handling
   - Verify all services (master, volume, filer)
   - Include diagnostic logging on failure
   - Prevents silent failures and obscure errors

These changes improve maintainability, security, and reliability
of the Spark integration test workflow.
2025-11-22 13:06:14 -08:00
chrislu b35463c8b4 spark: fix flaky test by sorting DataFrame before first()
- In testLargeDataset(), add orderBy("value") before calling first()
- Parquet files don't guarantee row order, so first() on unordered
  DataFrame can return any row, making assertions flaky
- Sorting by 'value' ensures the first row is always the one with
  value=0, making the test deterministic and reliable
2025-11-22 13:04:44 -08:00
chrislu 6f905acfd2 spark: update compiler source/target from Java 8 to Java 11
- Fix inconsistency between maven.compiler.source/target (1.8) and
  surefire JVM args (Java 9+ module flags like --add-opens)
- Update to Java 11 to match CI environment (GitHub Actions uses Java 11)
- Docker environment uses Java 17 which is also compatible
- Java 11+ is required for the --add-opens/--add-exports flags used
  in the surefire configuration
2025-11-22 13:03:55 -08:00
chrislu fba36f8d1c java: fix NPE in SeaweedWrite and Makefile env var scope
- Add null check for HttpEntity in SeaweedWrite.multipartUpload()
  to prevent NPE when response.getEntity() returns null
- Fix Makefile test target to properly export SEAWEEDFS_TEST_ENABLED
  by setting it on the same command line as mvn test
- Update docker-compose commands to use V2 syntax (docker compose)
  for consistency with GitHub Actions workflow
2025-11-22 13:00:41 -08:00
chrislu e15e2e23c4 fix building 2025-11-22 12:56:43 -08:00
chrislu 89a6d42cee Complete Spark integration test suite 2025-11-22 12:23:48 -08:00