package dash import ( "errors" "fmt" "net/http" "strings" "testing" "time" "github.com/seaweedfs/seaweedfs/weed/pb/filer_pb" "github.com/seaweedfs/seaweedfs/weed/s3api/s3lifecycle" "github.com/seaweedfs/seaweedfs/weed/s3api/s3lifecycle/scheduler" ) func minimalLifecycleRule() BucketLifecycleRule { return BucketLifecycleRule{ ID: "rule-1", Status: s3lifecycle.StatusEnabled, ExpirationDays: 30, } } func TestValidateBucketLifecycleRules_Valid(t *testing.T) { if err := validateBucketLifecycleRules([]BucketLifecycleRule{minimalLifecycleRule()}); err != nil { t.Fatalf("expected valid rule set to pass, got: %v", err) } } func TestValidateBucketLifecycleRules_Empty(t *testing.T) { if err := validateBucketLifecycleRules(nil); err != nil { t.Fatalf("expected empty rule set to pass, got: %v", err) } } func TestValidateBucketLifecycleRules_TooManyRules(t *testing.T) { rules := make([]BucketLifecycleRule, MaxBucketLifecycleRules+1) for i := range rules { rules[i] = BucketLifecycleRule{Status: s3lifecycle.StatusEnabled, ExpirationDays: 30} } if err := validateBucketLifecycleRules(rules); err == nil { t.Fatal("expected error for exceeding the rule count cap") } } func TestValidateBucketLifecycleRules_DuplicateIDs(t *testing.T) { rule := minimalLifecycleRule() if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule, rule}); err == nil { t.Fatal("expected error for duplicate rule IDs") } } func TestValidateBucketLifecycleRules_IDTooLong(t *testing.T) { rule := minimalLifecycleRule() longID := "" for i := 0; i < MaxBucketLifecycleRuleIDLength+1; i++ { longID += "a" } rule.ID = longID if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err == nil { t.Fatal("expected error for an ID longer than the cap") } } func TestValidateBucketLifecycleRules_InvalidStatus(t *testing.T) { rule := minimalLifecycleRule() rule.Status = "sort-of-enabled" if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err == nil { t.Fatal("expected error for an invalid status") } } func TestValidateBucketLifecycleRules_ExpirationDaysAndDateMutuallyExclusive(t *testing.T) { rule := minimalLifecycleRule() rule.ExpirationDate = "2030-01-01" if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err == nil { t.Fatal("expected error when both expiration_days and expiration_date are set") } } func TestValidateBucketLifecycleRules_DeleteMarkerWithExpirationDaysRejected(t *testing.T) { // AWS forbids combining ExpiredObjectDeleteMarker with Days/Date in the // same Expiration element; ruleFromCanonical would otherwise emit both // on the same . rule := minimalLifecycleRule() rule.ExpiredObjectDeleteMarker = true if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err == nil { t.Fatal("expected error when expired_object_delete_marker is combined with expiration_days") } } func TestValidateBucketLifecycleRules_DeleteMarkerWithExpirationDateRejected(t *testing.T) { rule := BucketLifecycleRule{ Status: s3lifecycle.StatusEnabled, ExpirationDate: "2030-01-01", ExpiredObjectDeleteMarker: true, } if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err == nil { t.Fatal("expected error when expired_object_delete_marker is combined with expiration_date") } } func TestValidateBucketLifecycleRules_DeleteMarkerAlone(t *testing.T) { rule := BucketLifecycleRule{ Status: s3lifecycle.StatusEnabled, ExpiredObjectDeleteMarker: true, } if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err != nil { t.Fatalf("expected standalone expired_object_delete_marker to be accepted, got: %v", err) } } func TestValidateBucketLifecycleRules_InvalidExpirationDate(t *testing.T) { rule := BucketLifecycleRule{Status: s3lifecycle.StatusEnabled, ExpirationDate: "01/01/2030"} if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err == nil { t.Fatal("expected error for a malformed expiration_date") } } func TestValidateBucketLifecycleRules_NegativeExpirationDays(t *testing.T) { rule := minimalLifecycleRule() rule.ExpirationDays = -1 if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err == nil { t.Fatal("expected error for negative expiration_days") } } // TestValidateBucketLifecycleRules_StandaloneNewerNoncurrentVersions guards // against re-adding a NoncurrentVersionExpirationDays requirement: // s3lifecycle.RuleActionKinds recognizes a standalone NewerNoncurrentVersions // (no days) as ActionKindNewerNoncurrent, a valid count-only retention rule // the S3 API already accepts and stores. func TestValidateBucketLifecycleRules_StandaloneNewerNoncurrentVersions(t *testing.T) { rule := BucketLifecycleRule{ Status: s3lifecycle.StatusEnabled, NewerNoncurrentVersions: 2, } if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err != nil { t.Fatalf("expected standalone newer_noncurrent_versions to be accepted, got: %v", err) } } func TestValidateBucketLifecycleRules_NegativeAbortMultipartDays(t *testing.T) { rule := minimalLifecycleRule() rule.AbortMultipartDays = -5 if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err == nil { t.Fatal("expected error for negative abort_multipart_days") } } func TestValidateBucketLifecycleRules_SizeGreaterThanNotLessThanSizeLessThan(t *testing.T) { rule := minimalLifecycleRule() rule.SizeGreaterThan = 2048 rule.SizeLessThan = 1024 if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err == nil { t.Fatal("expected error when size_greater_than >= size_less_than") } } func TestValidateBucketLifecycleRules_NegativeSizeBounds(t *testing.T) { rule := minimalLifecycleRule() rule.SizeGreaterThan = -1 if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err == nil { t.Fatal("expected error for a negative size_greater_than") } } func TestValidateBucketLifecycleRules_EmptyTagKey(t *testing.T) { rule := minimalLifecycleRule() rule.Tags = map[string]string{"": "value"} if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err == nil { t.Fatal("expected error for an empty tag key") } } func TestValidateBucketLifecycleRules_EmptyTagValue(t *testing.T) { rule := minimalLifecycleRule() rule.Tags = map[string]string{"env": " "} if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err == nil { t.Fatal("expected error for a blank tag value") } } func TestValidateBucketLifecycleRules_NoAction(t *testing.T) { rule := BucketLifecycleRule{Status: s3lifecycle.StatusEnabled, Prefix: "logs/"} if err := validateBucketLifecycleRules([]BucketLifecycleRule{rule}); err == nil { t.Fatal("expected error for a rule with no action") } } func TestFromBucketLifecycleRule_MapsAllFields(t *testing.T) { rule := BucketLifecycleRule{ ID: "rule-1", Status: s3lifecycle.StatusEnabled, Prefix: "logs/", Tags: map[string]string{"env": "dev"}, SizeGreaterThan: 1024, SizeLessThan: 2048, ExpirationDate: "2030-01-15", ExpiredObjectDeleteMarker: true, NoncurrentVersionExpirationDays: 30, NewerNoncurrentVersions: 2, AbortMultipartDays: 7, } out, err := fromBucketLifecycleRule(rule) if err != nil { t.Fatalf("unexpected error: %v", err) } if out.ID != rule.ID { t.Errorf("ID = %q, want %q", out.ID, rule.ID) } if out.Status != rule.Status { t.Errorf("Status = %q, want %q", out.Status, rule.Status) } if out.Prefix != rule.Prefix { t.Errorf("Prefix = %q, want %q", out.Prefix, rule.Prefix) } if len(out.FilterTags) != 1 || out.FilterTags["env"] != "dev" { t.Errorf("FilterTags = %v, want {env: dev}", out.FilterTags) } if out.FilterSizeGreaterThan != rule.SizeGreaterThan { t.Errorf("FilterSizeGreaterThan = %d, want %d", out.FilterSizeGreaterThan, rule.SizeGreaterThan) } if out.FilterSizeLessThan != rule.SizeLessThan { t.Errorf("FilterSizeLessThan = %d, want %d", out.FilterSizeLessThan, rule.SizeLessThan) } wantDate, _ := time.Parse(time.DateOnly, rule.ExpirationDate) if !out.ExpirationDate.Equal(wantDate) { t.Errorf("ExpirationDate = %v, want %v", out.ExpirationDate, wantDate) } if !out.ExpiredObjectDeleteMarker { t.Error("expected ExpiredObjectDeleteMarker=true") } if out.NoncurrentVersionExpirationDays != rule.NoncurrentVersionExpirationDays { t.Errorf("NoncurrentVersionExpirationDays = %d, want %d", out.NoncurrentVersionExpirationDays, rule.NoncurrentVersionExpirationDays) } if out.NewerNoncurrentVersions != rule.NewerNoncurrentVersions { t.Errorf("NewerNoncurrentVersions = %d, want %d", out.NewerNoncurrentVersions, rule.NewerNoncurrentVersions) } if out.AbortMPUDaysAfterInitiation != rule.AbortMultipartDays { t.Errorf("AbortMPUDaysAfterInitiation = %d, want %d", out.AbortMPUDaysAfterInitiation, rule.AbortMultipartDays) } } func TestFromBucketLifecycleRule_EmptyExpirationDate(t *testing.T) { rule := minimalLifecycleRule() rule.ExpirationDate = "" out, err := fromBucketLifecycleRule(rule) if err != nil { t.Fatalf("unexpected error: %v", err) } if !out.ExpirationDate.IsZero() { t.Errorf("expected zero ExpirationDate, got %v", out.ExpirationDate) } } func TestFromBucketLifecycleRule_InvalidExpirationDate(t *testing.T) { rule := minimalLifecycleRule() rule.ExpirationDate = "not-a-date" if _, err := fromBucketLifecycleRule(rule); err == nil { t.Fatal("expected error for a malformed expiration date") } } func TestBucketLifecycleMutation_SetsXML(t *testing.T) { m := bucketLifecycleMutation("/buckets", "mybucket", []byte("")) if m.Type != filer_pb.ObjectMutation_PATCH_EXTENDED { t.Fatalf("expected a PATCH_EXTENDED mutation, got %v", m.Type) } if m.Directory != "/buckets" || m.Name != "mybucket" { t.Fatalf("expected the mutation to target /buckets/mybucket, got %s/%s", m.Directory, m.Name) } if got := string(m.SetExtended[scheduler.BucketLifecycleConfigurationXMLKey]); got != "" { t.Fatalf("expected the XML key to carry the marshaled config, got %q", got) } if len(m.DeleteExtended) != 0 { t.Fatalf("expected no key deletions when saving rules, got %v", m.DeleteExtended) } } func TestBucketLifecycleMutation_ClearsBothKeys(t *testing.T) { m := bucketLifecycleMutation("/buckets", "mybucket", nil) if len(m.SetExtended) != 0 { t.Fatalf("expected no key writes when clearing, got %v", m.SetExtended) } want := map[string]bool{ scheduler.BucketLifecycleConfigurationXMLKey: true, scheduler.BucketLifecycleTransitionMinimumObjectSizeKey: true, } if len(m.DeleteExtended) != len(want) { t.Fatalf("expected both lifecycle keys to be cleared, got %v", m.DeleteExtended) } for _, k := range m.DeleteExtended { if !want[k] { t.Fatalf("unexpected key cleared: %s", k) } } } // A whole-entry write would have carried the rest of the bucket entry with it; // the patch must name only the keys it owns, so a concurrent owner or quota // change survives. func TestBucketLifecycleMutation_TouchesOnlyLifecycleKeys(t *testing.T) { for _, m := range []*filer_pb.ObjectMutation{ bucketLifecycleMutation("/buckets", "mybucket", []byte("")), bucketLifecycleMutation("/buckets", "mybucket", nil), } { if m.Entry != nil { t.Fatal("expected the mutation to carry no entry snapshot") } if m.SetContent { t.Fatal("expected the mutation to leave entry content alone") } for k := range m.SetExtended { if k != scheduler.BucketLifecycleConfigurationXMLKey { t.Fatalf("unexpected key written: %s", k) } } } } func TestSetBucketLifecycle_RejectsOversizedConfiguration(t *testing.T) { // A single rule ID long enough to blow the cap: this must fail before any // filer call, which is what makes it testable without one. rule := minimalLifecycleRule() rule.ID = strings.Repeat("x", scheduler.MaxBucketLifecycleConfigurationSize+1) err := (&AdminServer{}).SetBucketLifecycle("mybucket", []BucketLifecycleRule{rule}) if err == nil { t.Fatal("expected an oversized lifecycle configuration to be rejected") } if !strings.Contains(err.Error(), "exceeds") { t.Fatalf("expected a size-limit error, got: %v", err) } } func TestBucketLifecycleErrorStatus(t *testing.T) { if got := bucketLifecycleErrorStatus(fmt.Errorf("%w: mybucket", ErrBucketNotFound)); got != http.StatusNotFound { t.Fatalf("expected a missing bucket to map to 404, got %d", got) } if got := bucketLifecycleErrorStatus(errors.New("filer unreachable")); got != http.StatusInternalServerError { t.Fatalf("expected an unrelated failure to stay 500, got %d", got) } }