mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-08 15:41:15 +02:00
Chris Lu
c47eab1a5d
* admin: attach admin-signed Bearer token on filer IAM gRPC calls PR #9442 added Bearer-JWT enforcement on the filer's IAM gRPC service but didn't update its only production client, IamGrpcStore. The admin UI Users/Groups pages went through that client and started failing in 4.24 with either Unimplemented (filer refuses to register the service when jwt.filer_signing.key is empty) or Unauthenticated (the client sent no token). Issues #9495 and #9496 both trace to this gap. Plumb jwt.filer_signing.key into IamGrpcStore via a new SetAdminSigning hook called from the admin server, and append a freshly minted Bearer token to outgoing metadata on every call. The mint helper security.GenJwtForFilerAdmin existed since #9442 but had no production caller; this wires it up. Add an integration test alongside grpc_store.go that runs a real IamGrpcServer over a real grpc.Server listener and exercises the store end-to-end: matching key succeeds, wrong key returns Unauthenticated, no key returns Unauthenticated. Without the client-side token attach the success path fails, so the regression cannot land again. * address review: include adminSigningExpiresAfterSec in mu comment
102 lines
3.3 KiB
Go
102 lines
3.3 KiB
Go
package grpc
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/iam_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/policy_engine"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/status"
|
|
)
|
|
|
|
func (store *IamGrpcStore) GetPolicies(ctx context.Context) (map[string]policy_engine.PolicyDocument, error) {
|
|
policies := make(map[string]policy_engine.PolicyDocument)
|
|
err := store.withIamClient(ctx, func(ctx context.Context, client iam_pb.SeaweedIdentityAccessManagementClient) error {
|
|
resp, err := client.ListPolicies(ctx, &iam_pb.ListPoliciesRequest{})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for _, p := range resp.Policies {
|
|
var doc policy_engine.PolicyDocument
|
|
if err := json.Unmarshal([]byte(p.Content), &doc); err != nil {
|
|
return fmt.Errorf("failed to unmarshal policy %s: %v", p.Name, err)
|
|
}
|
|
policies[p.Name] = doc
|
|
}
|
|
return nil
|
|
})
|
|
return policies, err
|
|
}
|
|
|
|
func (store *IamGrpcStore) PutPolicy(ctx context.Context, name string, document policy_engine.PolicyDocument) error {
|
|
content, err := json.Marshal(document)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return store.withIamClient(ctx, func(ctx context.Context, client iam_pb.SeaweedIdentityAccessManagementClient) error {
|
|
_, err := client.PutPolicy(ctx, &iam_pb.PutPolicyRequest{
|
|
Name: name,
|
|
Content: string(content),
|
|
})
|
|
return err
|
|
})
|
|
}
|
|
|
|
func (store *IamGrpcStore) DeletePolicy(ctx context.Context, name string) error {
|
|
return store.withIamClient(ctx, func(ctx context.Context, client iam_pb.SeaweedIdentityAccessManagementClient) error {
|
|
_, err := client.DeletePolicy(ctx, &iam_pb.DeletePolicyRequest{
|
|
Name: name,
|
|
})
|
|
return err
|
|
})
|
|
}
|
|
|
|
func (store *IamGrpcStore) GetPolicy(ctx context.Context, name string) (*policy_engine.PolicyDocument, error) {
|
|
var doc policy_engine.PolicyDocument
|
|
err := store.withIamClient(ctx, func(ctx context.Context, client iam_pb.SeaweedIdentityAccessManagementClient) error {
|
|
resp, err := client.GetPolicy(ctx, &iam_pb.GetPolicyRequest{
|
|
Name: name,
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return json.Unmarshal([]byte(resp.Content), &doc)
|
|
})
|
|
if err != nil {
|
|
// If policy not found, return nil instead of error (consistent with other stores)
|
|
if st, ok := status.FromError(err); ok && st.Code() == codes.NotFound {
|
|
return nil, nil
|
|
}
|
|
return nil, err
|
|
}
|
|
return &doc, nil
|
|
}
|
|
|
|
// CreatePolicy creates a new policy (delegates to PutPolicy)
|
|
func (store *IamGrpcStore) CreatePolicy(ctx context.Context, name string, document policy_engine.PolicyDocument) error {
|
|
return store.PutPolicy(ctx, name, document)
|
|
}
|
|
|
|
// ListPolicyNames retrieves names of all IAM policies via gRPC.
|
|
func (store *IamGrpcStore) ListPolicyNames(ctx context.Context) ([]string, error) {
|
|
var names []string
|
|
err := store.withIamClient(ctx, func(ctx context.Context, client iam_pb.SeaweedIdentityAccessManagementClient) error {
|
|
resp, err := client.ListPolicies(ctx, &iam_pb.ListPoliciesRequest{})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for _, policy := range resp.Policies {
|
|
names = append(names, policy.Name)
|
|
}
|
|
return nil
|
|
})
|
|
return names, err
|
|
}
|
|
|
|
// UpdatePolicy updates an existing policy (delegates to PutPolicy)
|
|
func (store *IamGrpcStore) UpdatePolicy(ctx context.Context, name string, document policy_engine.PolicyDocument) error {
|
|
return store.PutPolicy(ctx, name, document)
|
|
}
|