mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-08 15:41:15 +02:00
Chris Lu
1996c6aec6
* volume server: open volume files with O_NOATIME Nothing reads the atime of .dat, .idx, .sdx, or EC files, but every needle read still dirtied the inode: even relatime writes atime on the first read after each write, so an actively written volume paid a metadata write per read/write cycle, and strictatime mounts paid one per read. Open the serving handles with O_NOATIME, falling back to a plain open when the file belongs to another owner (EPERM). Claude-Session: https://claude.ai/code/session_015uVY4diBgEn3VYQoc2eMuD * seaweed-volume: mirror the O_NOATIME volume file opens Same change as the Go volume server: serving handles for .dat, .idx, .sdx, .ecx, .ecj, and shard files open with O_NOATIME on Linux, with a plain-open fallback on EPERM. Claude-Session: https://claude.ai/code/session_015uVY4diBgEn3VYQoc2eMuD * route the tier-down and recreate .dat opens through the no-atime helper Review caught the Rust tier-down swap opening the local .dat directly. The Go swapToLocalDatBackend and the zero-length read-only .dat recreate in maybeWriteSuperBlock had the same gap: all three install long-lived serving handles. Claude-Session: https://claude.ai/code/session_015uVY4diBgEn3VYQoc2eMuD
54 lines
1.6 KiB
Go
54 lines
1.6 KiB
Go
package storage
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/backend"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/needle"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/super_block"
|
|
)
|
|
|
|
func (v *Volume) maybeWriteSuperBlock(ver needle.Version) error {
|
|
|
|
datSize, _, e := v.DataBackend.GetStat()
|
|
if e != nil {
|
|
glog.V(0).Infof("failed to stat datafile %s: %v", v.DataBackend.Name(), e)
|
|
return e
|
|
}
|
|
if datSize == 0 {
|
|
if !needle.IsSupportedVersion(ver) {
|
|
return fmt.Errorf("volume super block version %d is not supported", ver)
|
|
}
|
|
v.SuperBlock.Version = ver
|
|
_, e = v.DataBackend.WriteAt(v.SuperBlock.Bytes(), 0)
|
|
if e != nil && os.IsPermission(e) {
|
|
//read-only, but zero length - recreate it!
|
|
var dataFile *os.File
|
|
if dataFile, e = backend.OpenVolumeFile(v.DataBackend.Name(), os.O_RDWR|os.O_CREATE|os.O_TRUNC); e == nil {
|
|
v.DataBackend = backend.NewDiskFile(dataFile)
|
|
if _, e = v.DataBackend.WriteAt(v.SuperBlock.Bytes(), 0); e == nil {
|
|
v.noWriteLock.Lock()
|
|
v.noWriteOrDelete = false
|
|
v.noWriteCanDelete = false
|
|
v.noWriteLock.Unlock()
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return e
|
|
}
|
|
|
|
func (v *Volume) readSuperBlock() (err error) {
|
|
v.SuperBlock, err = super_block.ReadSuperBlock(v.DataBackend)
|
|
if v.volumeInfo != nil && v.volumeInfo.Replication != "" {
|
|
if replication, err := super_block.NewReplicaPlacementFromString(v.volumeInfo.Replication); err != nil {
|
|
return fmt.Errorf("Error parse volume %d replication %s : %v", v.Id, v.volumeInfo.Replication, err)
|
|
} else {
|
|
v.SuperBlock.ReplicaPlacement = replication
|
|
}
|
|
}
|
|
return err
|
|
}
|