mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-11-18 01:37:10 +01:00
On renewal failure the renew goroutine stored isLocked=false before its deferred renewGoroutineRunning.Store(false) ran. A concurrent RequestLock interleaving there reacquires the lease (sees isLocked=false), sets isLocked=true, then its CompareAndSwap on renewGoroutineRunning fails because the old goroutine's flag is still set — so no replacement renewer starts. The lock is then held locally with nothing renewing it, and silently expires on the master after the lease TTL, admitting a second holder. Clear renewGoroutineRunning before isLocked on the failure path so the reacquire path always starts a fresh renewer. Builds and vets clean; no behavior change on the success path. Claude-Session: https://claude.ai/code/session_01Ks16jnt4S7gdDk8cheQ3xu
172 lines
4.9 KiB
Go
172 lines
4.9 KiB
Go
package exclusive_locks
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
"sync/atomic"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/master_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/wdclient"
|
|
)
|
|
|
|
const (
|
|
RenewInterval = 4 * time.Second
|
|
SafeRenewInterval = 3 * time.Second
|
|
InitLockInterval = 1 * time.Second
|
|
// bounds each lease and renew RPC attempt so an unresponsive master
|
|
// cannot hold l.mu (and block ReleaseLock) indefinitely
|
|
rpcTimeout = 3 * time.Second
|
|
)
|
|
|
|
type ExclusiveLocker struct {
|
|
token int64
|
|
lockTsNs int64
|
|
isLocked atomic.Bool
|
|
masterClient *wdclient.MasterClient
|
|
lockName string
|
|
message string
|
|
clientName string
|
|
// serializes renew and release RPCs: a renewal in flight during a release
|
|
// would re-create the lock on the master and leave it held until expiry
|
|
mu sync.Mutex
|
|
// Each lock has and only has one goroutine
|
|
renewGoroutineRunning atomic.Bool
|
|
}
|
|
|
|
func NewExclusiveLocker(masterClient *wdclient.MasterClient, lockName string) *ExclusiveLocker {
|
|
return &ExclusiveLocker{
|
|
masterClient: masterClient,
|
|
lockName: lockName,
|
|
}
|
|
}
|
|
|
|
func (l *ExclusiveLocker) IsLocked() bool {
|
|
return l.isLocked.Load()
|
|
}
|
|
|
|
func (l *ExclusiveLocker) GetToken() (token int64, lockTsNs int64) {
|
|
for time.Unix(0, atomic.LoadInt64(&l.lockTsNs)).Add(SafeRenewInterval).Before(time.Now()) {
|
|
// wait until now is within the safe lock period, no immediate renewal to change the token
|
|
time.Sleep(100 * time.Millisecond)
|
|
}
|
|
return atomic.LoadInt64(&l.token), atomic.LoadInt64(&l.lockTsNs)
|
|
}
|
|
|
|
func (l *ExclusiveLocker) RequestLock(clientName string) {
|
|
if l.isLocked.Load() {
|
|
return
|
|
}
|
|
|
|
// retry to get the lease
|
|
for {
|
|
if err := l.masterClient.WithClient(false, func(client master_pb.SeaweedClient) error {
|
|
attemptCtx, cancel := context.WithTimeout(context.Background(), rpcTimeout)
|
|
defer cancel()
|
|
resp, err := client.LeaseAdminToken(attemptCtx, &master_pb.LeaseAdminTokenRequest{
|
|
PreviousToken: atomic.LoadInt64(&l.token),
|
|
PreviousLockTime: atomic.LoadInt64(&l.lockTsNs),
|
|
LockName: l.lockName,
|
|
ClientName: clientName,
|
|
})
|
|
if err == nil {
|
|
atomic.StoreInt64(&l.token, resp.Token)
|
|
atomic.StoreInt64(&l.lockTsNs, resp.LockTsNs)
|
|
}
|
|
return err
|
|
}); err != nil {
|
|
glog.V(2).Infof("Failed to acquire lock %s: %v", l.lockName, err)
|
|
time.Sleep(InitLockInterval)
|
|
} else {
|
|
break
|
|
}
|
|
}
|
|
|
|
l.mu.Lock()
|
|
l.clientName = clientName
|
|
l.isLocked.Store(true)
|
|
l.mu.Unlock()
|
|
glog.V(1).Infof("Acquired lock %s", l.lockName)
|
|
|
|
// Each lock has and only has one goroutine
|
|
if l.renewGoroutineRunning.CompareAndSwap(false, true) {
|
|
// start a goroutine to renew the lease
|
|
go func() {
|
|
ctx2, cancel2 := context.WithCancel(context.Background())
|
|
defer cancel2()
|
|
|
|
for {
|
|
if err := l.renewLease(ctx2); err != nil {
|
|
glog.Warningf("Failed to renew lock %s: %v", l.lockName, err)
|
|
// clear the running flag before isLocked, so a RequestLock that
|
|
// reacquires (once isLocked is false) starts a replacement renewer
|
|
l.renewGoroutineRunning.Store(false)
|
|
l.isLocked.Store(false)
|
|
return
|
|
}
|
|
time.Sleep(RenewInterval)
|
|
}
|
|
}()
|
|
}
|
|
|
|
}
|
|
|
|
func (l *ExclusiveLocker) renewLease(ctx context.Context) error {
|
|
l.mu.Lock()
|
|
defer l.mu.Unlock()
|
|
if !l.isLocked.Load() {
|
|
return nil
|
|
}
|
|
return l.masterClient.WithClient(false, func(client master_pb.SeaweedClient) error {
|
|
attemptCtx, cancel := context.WithTimeout(ctx, rpcTimeout)
|
|
defer cancel()
|
|
resp, err := client.LeaseAdminToken(attemptCtx, &master_pb.LeaseAdminTokenRequest{
|
|
PreviousToken: atomic.LoadInt64(&l.token),
|
|
PreviousLockTime: atomic.LoadInt64(&l.lockTsNs),
|
|
LockName: l.lockName,
|
|
ClientName: l.clientName,
|
|
Message: l.message,
|
|
})
|
|
if err == nil {
|
|
atomic.StoreInt64(&l.token, resp.Token)
|
|
atomic.StoreInt64(&l.lockTsNs, resp.LockTsNs)
|
|
glog.V(2).Infof("Renewed lock %s: ts %d token %d", l.lockName, l.lockTsNs, l.token)
|
|
}
|
|
return err
|
|
})
|
|
}
|
|
|
|
func (l *ExclusiveLocker) ReleaseLock() {
|
|
l.mu.Lock()
|
|
defer l.mu.Unlock()
|
|
|
|
l.isLocked.Store(false)
|
|
l.clientName = ""
|
|
|
|
prevToken := atomic.LoadInt64(&l.token)
|
|
prevLockTsNs := atomic.LoadInt64(&l.lockTsNs)
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
// single unbounded attempt: a release cut short by a deadline leaves the
|
|
// lock held until it expires, turning a slow unlock into a ghost lock
|
|
l.masterClient.WithClient(false, func(client master_pb.SeaweedClient) error {
|
|
client.ReleaseAdminToken(ctx, &master_pb.ReleaseAdminTokenRequest{
|
|
PreviousToken: prevToken,
|
|
PreviousLockTime: prevLockTsNs,
|
|
LockName: l.lockName,
|
|
})
|
|
return nil
|
|
})
|
|
// compare on clear: a RequestLock racing a slow release must not have its
|
|
// fresh token zeroed
|
|
atomic.CompareAndSwapInt64(&l.token, prevToken, 0)
|
|
atomic.CompareAndSwapInt64(&l.lockTsNs, prevLockTsNs, 0)
|
|
}
|
|
|
|
func (l *ExclusiveLocker) SetMessage(message string) {
|
|
l.message = message
|
|
}
|