3 people ca4ce2c581 volume: a read plan waits for a vacuum commit instead of answering 404 (#12375) ...

* volume: a read plan waits for a vacuum commit instead of answering 404

A vacuum commit closes the needle map, swaps the compacted files in and
reloads the map. It holds the data-file write lease for that and takes no
store lock. needle_read_plan, which the HTTP GET path uses, read the needle
map without the data-file read lease, so a GET planned in that window found
no map and answered 404 for a live needle.

needle_read_plan now takes the read lease first, as read_needle_with_option
does, so the plan waits for the commit and then reads the reloaded map.
Go's readNeedle does the same under dataFileAccessLock.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* volume: plan a read with the store guard released

A plan that waits on a vacuum commit's data-file lease under the store
read guard parks store writers (allocate, mount, EC ops) on that commit,
and every store reader queued behind them. Look the volume up under the
guard and plan after releasing it, as Go's readNeedle does, and look the
volume up again if its handle was closed while the plan waited.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* volume: retry a read plan while its handle keeps closing

A plan that waited out an unmount looked the volume up only once more,
so a replacement handle that also closed before its plan took the lease
answered NotFound for a needle a later mount holds. Repeat the lookup
while the planned handle is closed, at most three times, so a closed
handle that stays in the map still ends the loop.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* volume: start the swap-window check once the plan holds the volume

The swap-window test gave the plan 300 ms to answer early, so a reader
thread that started late passed the check without waiting on the
commit. Share the writer test's wait for the plan's volume handle and
start both timed checks after it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* volume: run the swap-window read-plan test on a redb map too

A commit reloads the index through load_index_redb for the redb kinds,
a path the in-memory run never took during the swap window.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* volume: say a needle read plan is resolved under the data-file lease

The plan no longer resolves under the store guard, and resolving it
takes the data-file read lease.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* volume: read the needle through the plan in the read-plan tests

The tests checked only that the plan resolved and then read the needle
through Store::read_volume_needle, so a plan with a wrong offset or size
after the commit still passed. Read through the plan, as GET does, and
compare the data.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* volume: test the read plan's lookup after an unmount closed the handle

No test reached the closed-handle retry, so dropping it left every test
green. Take the lookup as a closure so a test can hand the plan the
handle an unmount closed and then the remounted volume, and check that
the plan reads the needle from the remount.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>

2026-11-03 14:50:30 -08:00

..

remote_storage

volume: don't let an unreachable tier backend hold up volume server startup (#12312)

2026-11-01 18:35:37 -08:00

security

security: fail closed on gRPC TLS errors, verify dialed server identity (#12263)

2026-10-30 20:04:45 -07:00

server

volume: a read plan waits for a vacuum commit instead of answering 404 (#12375)

2026-11-03 14:50:30 -08:00

storage

volume: a read plan waits for a vacuum commit instead of answering 404 (#12375)

2026-11-03 14:50:30 -08:00

config.rs

weed-worker: find jwt.filer_signing.key where the Go worker does, and let the chart deliver it (#12373)

2026-11-03 14:49:39 -08:00

images.rs

volume: replicas keep the primary's compression and metadata (#12350)

2026-11-02 11:24:51 -08:00

lib.rs

rust volume: stop glibc retaining freed EC buffers as unreturnable heap (#11255)

2026-09-10 09:29:31 -07:00

main.rs

rust volume: run each gRPC TLS handshake on its own task (#12372)

2026-11-03 11:23:07 -08:00

malloc_tuning.rs

rust volume: stop glibc retaining freed EC buffers as unreturnable heap (#11255)

2026-09-10 09:29:31 -07:00

metrics.rs

s3api: don't delete chunks when CreateEntry outcome is ambiguous (#11376)

2026-09-17 19:58:49 -07:00

security.rs

rust: cargo fmt both crates, with a commented-out fmt --check CI step (#11329)

2026-09-15 09:29:22 -07:00

version.rs

rust: clippy-clean both crates and adopt the std APIs the 1.91 MSRV allows (#11312)

2026-09-14 11:29:29 -07:00