mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-31 17:30:42 +01:00
* s3tables: refuse a create that a namespace delete can lose DeleteNamespace checks the namespace for children and then deletes its directory recursively in a second filer call. The filer locks each path on its own, so a table created under the namespace between the two is not seen by the check and is removed by the delete, while both requests answer 200. The mirror case loses the table too: a create that passed its namespace check before the delete finished re-created the namespace directory through the filer's parent creation and recorded a table in a namespace that no longer exists. Each side now writes before it reads. DeleteNamespace claims the namespace record with a fresh token before it scans, deletes only while the record still holds that claim, and lifts its own claim when it stops. CreateTable, RegisterTable and CreateView re-read the namespace after writing their record and back out when it is claimed or gone: they remove what they wrote and answer 409 or 404 instead of reporting an entry that does not survive, or 500 when the record could not be removed and may remain. An entry the scan missed was written after the claim, so its create sees the claim; a create and a delete can both fail, but no longer both succeed. A create is also refused up front while a claim is held, but only after its authorization check, so a caller that may not create there does not learn of the delete. A create writes its record marked "create" and lifts the mark once the namespace is confirmed open. Until then GetTable, GetView, UpdateTable and a second create treat the record as absent, so no request is told about a table or view that the first create may still back out. * s3tables: keep a create's unfinished record out of reads and listings * s3tables: refuse catalog writes on a record an operation claimed * s3tables: answer 404 when a create's write path loses the namespace * s3tables: confirm the rename destination's namespace like a create * s3tables: cover unfinished-record reads, claimed-record writes, rename claim * s3tables: lift a leftover claim when a no-token delete clears the record * s3tables: answer 409 when a claimed record turns away a write UpdateView, TagResource, and UntagResource surfaced ErrConcurrentUpdate as a 500, so an expected conflict looked like a server fault to the caller. Map it to Conflict the way UpdateTable and the policy handlers already do. * s3tables: name the lost source when a rename finds it deleted * s3tables: report an entry deleted before its update as not found The filer answers an UpdateEntry on an entry removed since the lookup with codes.NotFound. mutateEntryExtended returned that error unchanged instead of filer_pb.ErrNotFound, so a rename whose source was deleted mid-claim answered 500 instead of NoSuchTable or NoSuchView. MemFiler now answers a missing entry the same way, so the rename tests for tables and views take the real filer's path. * s3tables: unpublish the destination when a rename's source clear fails * s3tables: refuse to delete a record another operation claimed * s3tables: release catalog claims on an uncanceled cleanup context * s3tables: answer 404 when a racing delete already removed the table * s3tables: keep the rename destination marked until the source clears * s3tables: guard the rename rollback against a recreated source and an unfinished destination * s3tables: drop the unfinished destination only once the source is restored * s3tables: re-resolve the purge target on the record a delete claims * s3tables: cover a delete that meets a moved metadata location * s3tables: answer 409 when a create's record changed under it * s3tables: adopt a record still marked by its unfinished create * s3tables: skip unfinished creates in the namespace empty check * s3tables: delete only the record the caller was authorized on DeleteView and DeleteTable check permissions on the record they read first, then read the name again to claim it. A record that took the name in between, such as a table or another owner's view created after a concurrent delete, was claimed and removed on the first record's authorization, and DeleteView never compared the caller's version token with it. The second read now repeats the first one's checks: a record of the other kind or an unfinished create answers 404, and a token that no longer matches answers 409. A delete without a token also compares the record's version token with the authorized one and answers 409 when they differ. * s3tables: re-check the parent after a create lifts its mark A create that passed checkParentOpen and paused before lifting its mark could still confirm while a namespace delete held the claim: the delete scans the still-marked record, skips it, and removes it under a create that already answered success. confirmParent now re-reads the same parent record after the mark clears and backs the confirmed record out when the namespace moved on. * s3tables: mark the rename destination with a claim of its own claimCatalogEntry adopted every create-marked record, including a rename's destination: a create landing after the source cleared could replace the destination before the rename published it, and with the source name reused the restore could leave the table on neither name. The destination now marks with the rename's own claim, which readers still treat as unpublished but a create must refuse, and the commit re-checks the destination namespace after the record goes live. The source keeps its rename claim until the commit lands so a namespace delete scanning the cleared record still refuses. * s3tables: compare the parent's createdAt, not its editable metadata A namespace update rewrites ExtendedKeyMetadata in place, so a create or rename whose second parent read landed across an UpdateNamespace saw a changed blob and reported the still-live namespace as gone: creates backed their record out and answered 404, renames undid their destination. createdAt survives the edit but changes on a delete+recreate, so it still identifies the record. * s3tables: retry lifting the rename's claim off the cleared source The release's only failure mode is a transient filer error — nothing else can write the cleared record — yet a single loss left the claim behind: the old name stayed refused to creates and the namespace counted the record as a child. Retry the release before warning. * s3tables: page the namespace scan before deleting it A page of skippable entries — bare directories or unfinished creates — ended the scan with hasChildren false, so a table on a later page was removed with the namespace. Keep listing with StartFromFileName until a child shows or the listing ends. --------- Co-authored-by: chrislusf <chrislusf@users.noreply.github.com>
281 lines
9.8 KiB
Go
281 lines
9.8 KiB
Go
// Package s3tablestest provides an in-memory filer for driving S3 Tables and
|
|
// Lance namespace operations end-to-end without a live cluster.
|
|
package s3tablestest
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"net"
|
|
"path"
|
|
"sort"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
|
|
"google.golang.org/grpc"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/credentials/insecure"
|
|
"google.golang.org/grpc/status"
|
|
)
|
|
|
|
// MemFiler is an in-memory filer used to drive Manager operations
|
|
// end-to-end without a live cluster.
|
|
type MemFiler struct {
|
|
filer_pb.UnimplementedSeaweedFilerServer
|
|
// mu guards entries. The real filer serves concurrent RPCs, and a test that
|
|
// races writers against each other - the point of an exclusive create - hits
|
|
// this map from several goroutines at once.
|
|
mu sync.RWMutex
|
|
entries map[string]map[string]*filer_pb.Entry // dir -> name -> entry
|
|
Client filer_pb.SeaweedFilerClient
|
|
// BeforeUpdate runs once, at the start of the next UpdateEntry, so a test
|
|
// can land a competing write in a handler's read-to-write window.
|
|
BeforeUpdate func()
|
|
// BeforeDelete runs once before the next DeleteEntry, so a test can land a
|
|
// competing write in a handler's check-to-delete window.
|
|
BeforeDelete func()
|
|
// OnLookup runs at the start of every LookupDirectoryEntry with the target
|
|
// path, so a test can land a competing write between two reads.
|
|
OnLookup func(dir, name string)
|
|
// OnUpdate runs at the start of every UpdateEntry with the target path, so
|
|
// a test can land a competing write at a chosen step of a multi-update
|
|
// operation.
|
|
OnUpdate func(dir, name string)
|
|
// RejectDelete returns the reason DeleteEntry refuses a path, answered the
|
|
// way the filer answers one: no transport error, the reason in the response.
|
|
RejectDelete func(dir, name string) string
|
|
}
|
|
|
|
func newMemFiler() *MemFiler {
|
|
return &MemFiler{entries: make(map[string]map[string]*filer_pb.Entry)}
|
|
}
|
|
|
|
func (f *MemFiler) Get(dir, name string) *filer_pb.Entry {
|
|
f.mu.RLock()
|
|
defer f.mu.RUnlock()
|
|
if d, ok := f.entries[dir]; ok {
|
|
return d[name]
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (f *MemFiler) Put(dir, name string, extended map[string][]byte) {
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
if _, ok := f.entries[dir]; !ok {
|
|
f.entries[dir] = make(map[string]*filer_pb.Entry)
|
|
}
|
|
f.entries[dir][name] = &filer_pb.Entry{Name: name, IsDirectory: true, Extended: extended}
|
|
}
|
|
|
|
// PutFile adds a file entry with an explicit modification time, which callers
|
|
// that age entries out (orphan cleanup, expiry) need in order to see them.
|
|
func (f *MemFiler) PutFile(dir, name string, mtime time.Time) {
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
if _, ok := f.entries[dir]; !ok {
|
|
f.entries[dir] = make(map[string]*filer_pb.Entry)
|
|
}
|
|
f.entries[dir][name] = &filer_pb.Entry{
|
|
Name: name,
|
|
Attributes: &filer_pb.FuseAttributes{Mtime: mtime.Unix(), Crtime: mtime.Unix()},
|
|
}
|
|
}
|
|
|
|
func (f *MemFiler) LookupDirectoryEntry(_ context.Context, req *filer_pb.LookupDirectoryEntryRequest) (*filer_pb.LookupDirectoryEntryResponse, error) {
|
|
if hook := f.OnLookup; hook != nil {
|
|
hook(req.Directory, req.Name)
|
|
}
|
|
if e := f.Get(req.Directory, req.Name); e != nil {
|
|
return &filer_pb.LookupDirectoryEntryResponse{Entry: e}, nil
|
|
}
|
|
// Carry the sentinel text so filer_pb.LookupEntry maps it to ErrNotFound.
|
|
return nil, status.Errorf(codes.NotFound, "%s: %s/%s", filer_pb.ErrNotFound.Error(), req.Directory, req.Name)
|
|
}
|
|
|
|
// ListEntries honours prefix, start-from and limit the way the real filer does.
|
|
// A harness that ignores them makes a paginating caller re-read the first page
|
|
// forever, which looks like duplicated entries rather than a broken listing.
|
|
func (f *MemFiler) ListEntries(req *filer_pb.ListEntriesRequest, stream grpc.ServerStreamingServer[filer_pb.ListEntriesResponse]) error {
|
|
f.mu.RLock()
|
|
d, ok := f.entries[req.Directory]
|
|
names := make([]string, 0, len(d))
|
|
snapshot := make(map[string]*filer_pb.Entry, len(d))
|
|
for name, entry := range d {
|
|
names = append(names, name)
|
|
snapshot[name] = entry
|
|
}
|
|
f.mu.RUnlock()
|
|
if !ok {
|
|
return nil
|
|
}
|
|
sort.Strings(names)
|
|
|
|
sent := uint32(0)
|
|
for _, name := range names {
|
|
if req.Prefix != "" && !strings.HasPrefix(name, req.Prefix) {
|
|
continue
|
|
}
|
|
if req.StartFromFileName != "" {
|
|
if name < req.StartFromFileName {
|
|
continue
|
|
}
|
|
if name == req.StartFromFileName && !req.InclusiveStartFrom {
|
|
continue
|
|
}
|
|
}
|
|
if err := stream.Send(&filer_pb.ListEntriesResponse{Entry: snapshot[name]}); err != nil {
|
|
return err
|
|
}
|
|
sent++
|
|
if req.Limit > 0 && sent >= req.Limit {
|
|
return nil
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (f *MemFiler) CreateEntry(_ context.Context, req *filer_pb.CreateEntryRequest) (*filer_pb.CreateEntryResponse, error) {
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
if _, ok := f.entries[req.Directory]; !ok {
|
|
f.entries[req.Directory] = make(map[string]*filer_pb.Entry)
|
|
}
|
|
// O_EXCL is the filer's put-if-not-exists. Ignoring it here would let a test
|
|
// that races two writers see both of them win.
|
|
if _, exists := f.entries[req.Directory][req.Entry.Name]; exists && req.OExcl {
|
|
return &filer_pb.CreateEntryResponse{ErrorCode: filer_pb.FilerError_ENTRY_ALREADY_EXISTS}, nil
|
|
}
|
|
f.entries[req.Directory][req.Entry.Name] = req.Entry
|
|
return &filer_pb.CreateEntryResponse{}, nil
|
|
}
|
|
|
|
func (f *MemFiler) UpdateEntry(_ context.Context, req *filer_pb.UpdateEntryRequest) (*filer_pb.UpdateEntryResponse, error) {
|
|
// The hooks run before the lock is taken: their whole purpose is to land a
|
|
// competing write in the read-to-write window, and that write needs the lock.
|
|
if hook := f.OnUpdate; hook != nil {
|
|
hook(req.Directory, req.Entry.Name)
|
|
}
|
|
if hook := f.BeforeUpdate; hook != nil {
|
|
f.BeforeUpdate = nil
|
|
hook()
|
|
}
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
// The real filer looks the entry up before anything else and answers a
|
|
// missing one with codes.NotFound, not a failed precondition.
|
|
existing := f.entries[req.Directory][req.Entry.Name]
|
|
if existing == nil {
|
|
return nil, status.Errorf(codes.NotFound, "not found %s: %v", path.Join(req.Directory, req.Entry.Name), filer_pb.ErrNotFound)
|
|
}
|
|
// The real filer validates ExpectedExtended under the per-path lock; without
|
|
// it here a lost update would look like a success.
|
|
for key, expected := range req.ExpectedExtended {
|
|
actual := existing.Extended[key]
|
|
if !bytes.Equal(actual, expected) {
|
|
return nil, status.Errorf(codes.FailedPrecondition, "extended attribute %q changed", key)
|
|
}
|
|
}
|
|
if _, ok := f.entries[req.Directory]; !ok {
|
|
f.entries[req.Directory] = make(map[string]*filer_pb.Entry)
|
|
}
|
|
f.entries[req.Directory][req.Entry.Name] = req.Entry
|
|
return &filer_pb.UpdateEntryResponse{}, nil
|
|
}
|
|
|
|
func (f *MemFiler) DeleteEntry(_ context.Context, req *filer_pb.DeleteEntryRequest) (*filer_pb.DeleteEntryResponse, error) {
|
|
if hook := f.BeforeDelete; hook != nil {
|
|
f.BeforeDelete = nil
|
|
hook()
|
|
}
|
|
if reject := f.RejectDelete; reject != nil {
|
|
if reason := reject(req.Directory, req.Name); reason != "" {
|
|
return &filer_pb.DeleteEntryResponse{Error: reason}, nil
|
|
}
|
|
}
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
// The real filer refuses a non-recursive delete of a non-empty folder.
|
|
if child := path.Join(req.Directory, req.Name); !req.IsRecursive && len(f.entries[child]) > 0 {
|
|
return &filer_pb.DeleteEntryResponse{Error: "fail to delete non-empty folder: " + child}, nil
|
|
}
|
|
// The real filer evaluates ExpectedExtended under the path lock and refuses
|
|
// the delete when the entry no longer matches what the caller captured.
|
|
for key, expected := range req.ExpectedExtended {
|
|
var actual []byte
|
|
if d, ok := f.entries[req.Directory]; ok {
|
|
if existing := d[req.Name]; existing != nil {
|
|
actual = existing.Extended[key]
|
|
}
|
|
}
|
|
if !bytes.Equal(actual, expected) {
|
|
return nil, status.Errorf(codes.FailedPrecondition, "extended attribute %q changed", key)
|
|
}
|
|
}
|
|
if d, ok := f.entries[req.Directory]; ok {
|
|
delete(d, req.Name)
|
|
}
|
|
// Honor recursive data deletion so a regression that wipes the table directory
|
|
// also drops its metadata/ and data/ children (the data-loss this guards against).
|
|
if req.IsRecursive && req.IsDeleteData {
|
|
child := path.Join(req.Directory, req.Name)
|
|
for dir := range f.entries {
|
|
if dir == child || strings.HasPrefix(dir, child+"/") {
|
|
delete(f.entries, dir)
|
|
}
|
|
}
|
|
}
|
|
return &filer_pb.DeleteEntryResponse{}, nil
|
|
}
|
|
|
|
// GetFilerConfiguration answers with the defaults, so operations that resolve
|
|
// the buckets directory before touching an entry work against this filer.
|
|
func (f *MemFiler) GetFilerConfiguration(_ context.Context, _ *filer_pb.GetFilerConfigurationRequest) (*filer_pb.GetFilerConfigurationResponse, error) {
|
|
return &filer_pb.GetFilerConfigurationResponse{DirBuckets: s3_constants.DefaultBucketsPath}, nil
|
|
}
|
|
|
|
func (f *MemFiler) Ping(_ context.Context, _ *filer_pb.PingRequest) (*filer_pb.PingResponse, error) {
|
|
now := time.Now().UnixNano()
|
|
return &filer_pb.PingResponse{StartTimeNs: now, RemoteTimeNs: now, StopTimeNs: now}, nil
|
|
}
|
|
|
|
func Start(t *testing.T) *MemFiler {
|
|
t.Helper()
|
|
fs := newMemFiler()
|
|
|
|
listener, err := net.Listen("tcp", "127.0.0.1:0")
|
|
if err != nil {
|
|
t.Fatalf("start filer: %v", err)
|
|
}
|
|
|
|
server := grpc.NewServer()
|
|
filer_pb.RegisterSeaweedFilerServer(server, fs)
|
|
go func() { _ = server.Serve(listener) }()
|
|
t.Cleanup(server.GracefulStop)
|
|
|
|
conn, err := grpc.NewClient(listener.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
if err != nil {
|
|
t.Fatalf("start filer: %v", err)
|
|
}
|
|
t.Cleanup(func() { _ = conn.Close() })
|
|
|
|
fs.Client = filer_pb.NewSeaweedFilerClient(conn)
|
|
deadline := time.Now().Add(5 * time.Second)
|
|
for {
|
|
pingCtx, cancel := context.WithTimeout(context.Background(), 50*time.Millisecond)
|
|
_, err := fs.Client.Ping(pingCtx, &filer_pb.PingRequest{})
|
|
cancel()
|
|
if err == nil {
|
|
break
|
|
}
|
|
if time.Now().After(deadline) {
|
|
t.Fatalf("filer not ready: %v", err)
|
|
}
|
|
time.Sleep(10 * time.Millisecond)
|
|
}
|
|
return fs
|
|
}
|