mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-08 23:37:43 +02:00
* fix(volume): keep the TTL clock across a vacuum commit instead of rescanning CommitCompact reloads the swapped files while holding dataFileAccessLock, and for a vacuumed TTL volume that reload re-derived lastModifiedTsSeconds by reading every live needle's append timestamp from the .dat: two random reads per needle, with every read of the volume blocked behind them. The in-memory clock is already current at that point. Every write since the volume loaded moved it, and makeupDiff only replays writes that went through that path. Carry it across the reload instead. This also stops an over-budget scan from falling back to the new .dat's mtime and restarting an expiring volume's TTL at the commit. * volume: carry the append watermark as the TTL clock across a vacuum commit The running append watermark is the clock the reload's recovery scan recomputes, so the commit can keep it directly. Client-supplied needle modified times can run ahead of or behind the append time; keeping lastModifiedTsSeconds itself would let a forged or stale timestamp move expiry through a vacuum, where the scan it replaces used server-side append timestamps. * storage: test that a vacuum commit keeps the append clock A write's client supplied modified time can lie ahead of or behind its append time; the commit must land the TTL clock on the append watermark, the same value the recovery scan would have recomputed. * volume: carry the append watermark as the TTL clock across a vacuum commit Mirrors the Go volume server: the running append watermark is the clock the reload's recovery scan recomputes, so the commit keeps it instead of rescanning live needles under the write lock. * volume: commit carries the last-write append time, not the latest append lastAppendAtNs counts tombstone appends and is reseeded from the .dat tail at every load, so it can sit ahead of the last write -- a delete freshens the commit clock -- or behind it: a restarted vacuumed volume's tail needle is not its newest write, and the commit would move the TTL clock backward into premature expiry. Track lastWriteAppendAtNs instead, bumped only on needle appends and seeded by the recovery scan, so the commit lands the clock on the same live-write maximum the rescan would have recomputed. * volume: rescan at commit when the newest write was deleted lastWriteAppendAtNs can hold a write the index no longer holds, so carrying it extends the TTL clock past what recovery over the compacted index would compute. Remember the key behind the watermark so its tombstone or index rollback can send the reload back through recoverLastModifiedTs, landing on the newest surviving write. * volume: a tombstone retires the write rows beneath it in the last-write scan A needle deleted after the compaction copy leaves its write row followed by a tombstone in the committed index. The reverse scan skipped the tombstone row but then counted the dead write, reseeding the watermark and flag as if it were alive. Track keys whose latest row is a tombstone so their earlier write rows stop counting, and exercise the delete-inside-the-commit-window ordering in the tests. --------- Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com> Co-authored-by: Chris Lu <chris.lu@gmail.com>
627 lines
21 KiB
Go
627 lines
21 KiB
Go
package storage
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"path"
|
|
"strconv"
|
|
"strings"
|
|
"sync"
|
|
"sync/atomic"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/master_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/volume_server_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/stats"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/backend"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/needle"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/super_block"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/types"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/volume_info"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
)
|
|
|
|
type Volume struct {
|
|
Id needle.VolumeId
|
|
dir string
|
|
dirIdx string
|
|
Collection string
|
|
DataBackend backend.BackendStorageFile
|
|
nm NeedleMapper
|
|
tmpNm TempNeedleMapper
|
|
needleMapKind NeedleMapKind
|
|
noWriteOrDelete bool // if readonly, either noWriteOrDelete or noWriteCanDelete
|
|
noWriteCanDelete bool // if readonly, either noWriteOrDelete or noWriteCanDelete
|
|
ioUnavailable bool
|
|
ioUnavailableError string
|
|
noWriteLock sync.RWMutex
|
|
hasRemoteFile atomic.Bool // if the volume is tiered: data lives in a remote backend
|
|
MemoryMapMaxSizeMb uint32
|
|
|
|
super_block.SuperBlock
|
|
|
|
dataFileAccessLock sync.RWMutex
|
|
superBlockAccessLock sync.Mutex
|
|
|
|
// The batch worker exists only once the volume takes a durable write. Most
|
|
// never do -- read-only, remote-tiered, or written without fsync -- and a
|
|
// parked worker costs its goroutine stack plus a 128-slot channel, which a
|
|
// server holding millions of volumes cannot pay for all of them.
|
|
asyncWorkerLock sync.Mutex
|
|
asyncRequestsChan chan *needle.AsyncRequest
|
|
asyncWorkerClosed bool
|
|
|
|
lastModifiedTsSeconds uint64 // unix time in seconds
|
|
lastAppendAtNs uint64 // unix time in nanoseconds
|
|
lastWriteAppendAtNs uint64 // AppendAtNs of the newest write; tombstones don't move it
|
|
lastWriteNeedleKey types.NeedleId // the write behind the watermark
|
|
lastWriteDeleted bool // that write was deleted, so recovery has to rescan
|
|
keepLastModifiedTsOnLoad bool
|
|
|
|
lastCompactIndexOffset uint64
|
|
lastCompactRevision uint16
|
|
ldbTimeout int64
|
|
|
|
isCompactionInProgress atomic.Bool
|
|
lastDiskCheckNs atomic.Int64 // unix time in nanoseconds for phantom volume detection
|
|
|
|
volumeInfoRWLock sync.RWMutex
|
|
volumeInfo *volume_server_pb.VolumeInfo
|
|
location *DiskLocation
|
|
diskId uint32 // ID of this volume's disk in Store.Locations array
|
|
|
|
IoErrorTracker
|
|
}
|
|
|
|
func NewVolume(dirname string, dirIdx string, collection string, id needle.VolumeId, needleMapKind NeedleMapKind, replicaPlacement *super_block.ReplicaPlacement, ttl *needle.TTL, preallocate int64, ver needle.Version, memoryMapMaxSizeMb uint32, ldbTimeout int64) (v *Volume, e error) {
|
|
// if replicaPlacement is nil, the superblock will be loaded from disk
|
|
v = &Volume{dir: dirname, dirIdx: dirIdx, Collection: collection, Id: id, MemoryMapMaxSizeMb: memoryMapMaxSizeMb}
|
|
v.SuperBlock = super_block.SuperBlock{ReplicaPlacement: replicaPlacement, Ttl: ttl}
|
|
v.needleMapKind = needleMapKind
|
|
v.ldbTimeout = ldbTimeout
|
|
e = v.load(true, true, needleMapKind, preallocate, ver)
|
|
return
|
|
}
|
|
|
|
func (v *Volume) String() string {
|
|
v.noWriteLock.RLock()
|
|
defer v.noWriteLock.RUnlock()
|
|
return fmt.Sprintf("Id:%v dir:%s dirIdx:%s Collection:%s dataFile:%v nm:%v noWrite:%v canDelete:%v", v.Id, v.dir, v.dirIdx, v.Collection, v.DataBackend, v.nm, v.noWriteOrDelete || v.noWriteCanDelete, v.noWriteCanDelete)
|
|
}
|
|
|
|
func VolumeFileName(dir string, collection string, id int) (fileName string) {
|
|
idString := strconv.Itoa(id)
|
|
if collection == "" {
|
|
fileName = path.Join(dir, idString)
|
|
} else {
|
|
fileName = path.Join(dir, collection+"_"+idString)
|
|
}
|
|
return
|
|
}
|
|
|
|
func (v *Volume) DataFileName() (fileName string) {
|
|
return VolumeFileName(v.dir, v.Collection, int(v.Id))
|
|
}
|
|
|
|
func (v *Volume) IndexFileName() (fileName string) {
|
|
return VolumeFileName(v.dirIdx, v.Collection, int(v.Id))
|
|
}
|
|
|
|
func (v *Volume) FileName(ext string) (fileName string) {
|
|
switch ext {
|
|
case ".idx", ".cpx", ".ldb", ".cpldb", ".rdb":
|
|
return VolumeFileName(v.dirIdx, v.Collection, int(v.Id)) + ext
|
|
}
|
|
// .dat, .cpd, .vif
|
|
return VolumeFileName(v.dir, v.Collection, int(v.Id)) + ext
|
|
}
|
|
|
|
// RelocateIndexTo moves the volume's index to newIdxDir and reopens the volume
|
|
// against it in place, without unmounting. It takes the data-file write lock —
|
|
// so a concurrent read blocks briefly instead of failing — closes the needle
|
|
// map and data backend, moves the .idx (and the derived .sdx best-effort), then
|
|
// retargets dirIdx and reloads, mirroring CommitCompact's close-swap-load. A
|
|
// decode co-locates the rebuilt index with the data so the on-demand mount can
|
|
// find the volume; this returns it to the -dir.idx tier once the EC shards are
|
|
// gone. A no-op when the index already lives in newIdxDir. A derived .ldb is
|
|
// not moved: the reload rebuilds it in newIdxDir from the .idx.
|
|
func (v *Volume) RelocateIndexTo(newIdxDir string) error {
|
|
v.dataFileAccessLock.Lock()
|
|
defer v.dataFileAccessLock.Unlock()
|
|
|
|
if v.dirIdx == newIdxDir {
|
|
return nil
|
|
}
|
|
oldBase := VolumeFileName(v.dirIdx, v.Collection, int(v.Id))
|
|
if _, err := os.Stat(oldBase + ".idx"); err != nil {
|
|
return nil // nothing co-located to move
|
|
}
|
|
newBase := VolumeFileName(newIdxDir, v.Collection, int(v.Id))
|
|
|
|
if v.nm != nil {
|
|
_ = v.nm.Sync()
|
|
v.nm.Close()
|
|
v.nm = nil
|
|
}
|
|
if v.DataBackend != nil {
|
|
_ = v.DataBackend.Sync()
|
|
_ = v.DataBackend.Close()
|
|
v.DataBackend = nil
|
|
}
|
|
|
|
if err := RenameOrCopyFile(oldBase+".idx", newBase+".idx"); err != nil {
|
|
// Reopen against the old dir so the volume is not left down; surface a
|
|
// failed reopen since it leaves the volume unusable until the next load.
|
|
if reopenErr := v.load(true, false, v.needleMapKind, 0, v.Version()); reopenErr != nil {
|
|
glog.Errorf("relocate volume %d: reopen after failed .idx move: %v", v.Id, reopenErr)
|
|
}
|
|
return fmt.Errorf("relocate index for volume %d: move .idx: %w", v.Id, err)
|
|
}
|
|
// The .sdx is a derived sorted index; move it when present, but a failure is
|
|
// not fatal — drop the stale copy so the reload rebuilds it in the new dir.
|
|
if _, err := os.Stat(oldBase + ".sdx"); err == nil {
|
|
if err := RenameOrCopyFile(oldBase+".sdx", newBase+".sdx"); err != nil {
|
|
glog.Warningf("relocate volume %d: move .sdx: %v (will rebuild)", v.Id, err)
|
|
_ = os.Remove(oldBase + ".sdx")
|
|
}
|
|
}
|
|
v.dirIdx = newIdxDir
|
|
return v.load(true, false, v.needleMapKind, 0, v.Version())
|
|
}
|
|
|
|
func (v *Volume) Version() needle.Version {
|
|
v.superBlockAccessLock.Lock()
|
|
defer v.superBlockAccessLock.Unlock()
|
|
if v.volumeInfo.Version != 0 {
|
|
v.SuperBlock.Version = needle.Version(v.volumeInfo.Version)
|
|
}
|
|
return v.SuperBlock.Version
|
|
}
|
|
|
|
func (v *Volume) FileStat() (datSize uint64, idxSize uint64, modTime time.Time) {
|
|
v.dataFileAccessLock.RLock()
|
|
defer v.dataFileAccessLock.RUnlock()
|
|
|
|
if v.DataBackend == nil {
|
|
return
|
|
}
|
|
|
|
datFileSize, modTime, e := v.DataBackend.GetStat()
|
|
if e == nil {
|
|
return uint64(datFileSize), v.nm.IndexFileSize(), modTime
|
|
}
|
|
glog.V(0).Infof("Failed to read file size %s %v", v.DataBackend.Name(), e)
|
|
return // -1 causes integer overflow and the volume to become unwritable.
|
|
}
|
|
|
|
func (v *Volume) ContentSize() uint64 {
|
|
v.dataFileAccessLock.RLock()
|
|
defer v.dataFileAccessLock.RUnlock()
|
|
if v.nm == nil {
|
|
return 0
|
|
}
|
|
return v.nm.ContentSize()
|
|
}
|
|
|
|
func (v *Volume) doIsEmpty() (bool, error) {
|
|
// check v.DataBackend.GetStat()
|
|
if v.DataBackend == nil {
|
|
return false, fmt.Errorf("v.DataBackend is nil")
|
|
} else {
|
|
datFileSize, _, e := v.DataBackend.GetStat()
|
|
if e != nil {
|
|
glog.V(0).Infof("Failed to read file size %s %v", v.DataBackend.Name(), e)
|
|
return false, fmt.Errorf("v.DataBackend.GetStat(): %v", e)
|
|
}
|
|
if datFileSize > super_block.SuperBlockSize {
|
|
return false, nil
|
|
}
|
|
}
|
|
// check v.nm.ContentSize()
|
|
if v.nm != nil {
|
|
if v.nm.ContentSize() > 0 {
|
|
return false, nil
|
|
}
|
|
}
|
|
return true, nil
|
|
}
|
|
|
|
// doIsGarbage reports whether every byte ever written is already deleted —
|
|
// the same all-garbage state vacuum measures, checked against the byte
|
|
// counters because the count counters drift on reload.
|
|
func (v *Volume) doIsGarbage() bool {
|
|
if v.nm == nil {
|
|
return false
|
|
}
|
|
contentSize := v.nm.ContentSize()
|
|
return contentSize > 0 && v.nm.DeletedSize() >= contentSize
|
|
}
|
|
|
|
func (v *Volume) DeletedSize() uint64 {
|
|
v.dataFileAccessLock.RLock()
|
|
defer v.dataFileAccessLock.RUnlock()
|
|
if v.nm == nil {
|
|
return 0
|
|
}
|
|
return v.nm.DeletedSize()
|
|
}
|
|
|
|
func (v *Volume) FileCount() uint64 {
|
|
v.dataFileAccessLock.RLock()
|
|
defer v.dataFileAccessLock.RUnlock()
|
|
if v.nm == nil {
|
|
return 0
|
|
}
|
|
return uint64(v.nm.FileCount())
|
|
}
|
|
|
|
func (v *Volume) DeletedCount() uint64 {
|
|
v.dataFileAccessLock.RLock()
|
|
defer v.dataFileAccessLock.RUnlock()
|
|
if v.nm == nil {
|
|
return 0
|
|
}
|
|
return uint64(v.nm.DeletedCount())
|
|
}
|
|
|
|
func (v *Volume) MaxFileKey() types.NeedleId {
|
|
v.dataFileAccessLock.RLock()
|
|
defer v.dataFileAccessLock.RUnlock()
|
|
if v.nm == nil {
|
|
return 0
|
|
}
|
|
return v.nm.MaxFileKey()
|
|
}
|
|
|
|
func (v *Volume) IndexFileSize() uint64 {
|
|
v.dataFileAccessLock.RLock()
|
|
defer v.dataFileAccessLock.RUnlock()
|
|
if v.nm == nil {
|
|
return 0
|
|
}
|
|
return v.nm.IndexFileSize()
|
|
}
|
|
|
|
func (v *Volume) DiskType() types.DiskType {
|
|
return v.location.DiskType
|
|
}
|
|
|
|
func (v *Volume) SyncToDisk() {
|
|
v.dataFileAccessLock.Lock()
|
|
defer v.dataFileAccessLock.Unlock()
|
|
if v.nm != nil {
|
|
if err := v.nm.Sync(); err != nil {
|
|
glog.Warningf("Volume Close fail to sync volume idx %d", v.Id)
|
|
}
|
|
}
|
|
if v.DataBackend != nil {
|
|
if err := v.DataBackend.Sync(); err != nil {
|
|
glog.Warningf("Volume Close fail to sync volume %d", v.Id)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Close cleanly shuts down this volume
|
|
func (v *Volume) Close() {
|
|
// Wait for any in-progress compaction to finish and claim the flag so no
|
|
// new compaction can start. This must happen BEFORE acquiring
|
|
// dataFileAccessLock to avoid deadlocking with CommitCompact which holds
|
|
// the flag while waiting for the lock.
|
|
for !v.isCompactionInProgress.CompareAndSwap(false, true) {
|
|
time.Sleep(521 * time.Millisecond)
|
|
glog.Warningf("Volume Close wait for compaction %d", v.Id)
|
|
}
|
|
defer v.isCompactionInProgress.Store(false)
|
|
|
|
v.dataFileAccessLock.Lock()
|
|
defer v.dataFileAccessLock.Unlock()
|
|
|
|
v.doClose()
|
|
}
|
|
|
|
// SwapDataBackend atomically replaces the data backend and updates the
|
|
// remote-tier flag under dataFileAccessLock, closing the old backend. Both tier
|
|
// directions go through here so hasRemoteFile always matches the live backend:
|
|
// tier-down passes hasRemoteFile=false (now serving a local .dat), tier-up
|
|
// passes true. Keeping the swap and the flag under one lock means the heartbeat
|
|
// never observes a half-swapped backend or a flag that disagrees with it — a
|
|
// stale-false flag would make doDeleteRequest skip the new .dat's tombstones and
|
|
// disable the phantom-.dat guard.
|
|
func (v *Volume) SwapDataBackend(newBackend backend.BackendStorageFile, hasRemoteFile bool) {
|
|
v.dataFileAccessLock.Lock()
|
|
defer v.dataFileAccessLock.Unlock()
|
|
v.swapDataBackendLocked(newBackend, hasRemoteFile)
|
|
}
|
|
|
|
// swapDataBackendLocked is the body of SwapDataBackend for callers that already
|
|
// hold dataFileAccessLock (e.g. load() reached while CommitCompact holds the
|
|
// lock). Reusing it from those under-lock paths avoids re-entering the
|
|
// non-reentrant lock, which would deadlock.
|
|
func (v *Volume) swapDataBackendLocked(newBackend backend.BackendStorageFile, hasRemoteFile bool) {
|
|
if v.DataBackend != nil {
|
|
v.DataBackend.Close()
|
|
}
|
|
v.DataBackend = newBackend
|
|
v.hasRemoteFile.Store(hasRemoteFile)
|
|
}
|
|
|
|
func (v *Volume) doClose() {
|
|
if v.nm != nil {
|
|
if err := v.nm.Sync(); err != nil {
|
|
glog.Warningf("Volume Close fail to sync volume idx %d", v.Id)
|
|
}
|
|
v.nm.Close()
|
|
v.nm = nil
|
|
}
|
|
if v.DataBackend != nil {
|
|
if err := v.DataBackend.Close(); err != nil {
|
|
glog.Warningf("Volume Close fail to sync volume %d", v.Id)
|
|
}
|
|
v.DataBackend = nil
|
|
stats.VolumeServerVolumeGauge.WithLabelValues(v.Collection, "volume").Dec()
|
|
}
|
|
}
|
|
|
|
func (v *Volume) NeedToReplicate() bool {
|
|
return v.ReplicaPlacement.GetCopyCount() > 1
|
|
}
|
|
|
|
// volume is expired if modified time + volume ttl < now
|
|
// except when volume is empty
|
|
// or when the volume does not have a ttl
|
|
// or when volumeSizeLimit is 0 when server just starts
|
|
func (v *Volume) expired(contentSize uint64, volumeSizeLimit uint64) bool {
|
|
if volumeSizeLimit == 0 {
|
|
// skip if we don't know size limit
|
|
return false
|
|
}
|
|
if contentSize <= super_block.SuperBlockSize {
|
|
return false
|
|
}
|
|
if v.Ttl == nil || v.Ttl.Minutes() == 0 {
|
|
return false
|
|
}
|
|
glog.V(2).Infof("volume %d now:%v lastModified:%v", v.Id, time.Now().Unix(), v.lastModifiedTsSeconds)
|
|
livedMinutes := (time.Now().Unix() - int64(v.lastModifiedTsSeconds)) / 60
|
|
glog.V(2).Infof("volume %d ttl:%v lived:%v", v.Id, v.Ttl, livedMinutes)
|
|
if int64(v.Ttl.Minutes()) < livedMinutes {
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
|
|
// ExpireAtSec is when this volume's data becomes garbage, counted from its last
|
|
// write. Counting from the current time instead let every .vif rewrite -- a
|
|
// read-only mark, a tier upload, an EC encode -- hand an already expiring volume
|
|
// another full TTL. Zero when the volume has no TTL.
|
|
func (v *Volume) ExpireAtSec() uint64 {
|
|
if v.Ttl == nil {
|
|
return 0
|
|
}
|
|
ttlSeconds := v.Ttl.ToSeconds()
|
|
if ttlSeconds == 0 {
|
|
return 0
|
|
}
|
|
lastWriteSec := v.lastModifiedTsSeconds
|
|
if lastWriteSec == 0 {
|
|
lastWriteSec = uint64(time.Now().Unix())
|
|
}
|
|
return lastWriteSec + ttlSeconds
|
|
}
|
|
|
|
// wait either maxDelayMinutes or 10% of ttl minutes
|
|
func (v *Volume) expiredLongEnough(maxDelayMinutes uint32) bool {
|
|
if v.Ttl == nil || v.Ttl.Minutes() == 0 {
|
|
return false
|
|
}
|
|
removalDelay := v.Ttl.Minutes() / 10
|
|
if removalDelay > maxDelayMinutes {
|
|
removalDelay = maxDelayMinutes
|
|
}
|
|
|
|
if uint64(v.Ttl.Minutes()+removalDelay)*60+v.lastModifiedTsSeconds < uint64(time.Now().Unix()) {
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
|
|
func (v *Volume) collectStatus() (maxFileKey types.NeedleId, datFileSize int64, modTime time.Time, fileCount, deletedCount, deletedSize uint64, ok bool) {
|
|
v.dataFileAccessLock.RLock()
|
|
defer v.dataFileAccessLock.RUnlock()
|
|
|
|
if v.nm == nil || v.DataBackend == nil {
|
|
return
|
|
}
|
|
|
|
ok = true
|
|
|
|
maxFileKey = v.nm.MaxFileKey()
|
|
datFileSize, modTime, _ = v.DataBackend.GetStat()
|
|
fileCount = uint64(v.nm.FileCount())
|
|
deletedCount = uint64(v.nm.DeletedCount())
|
|
deletedSize = v.nm.DeletedSize()
|
|
|
|
return
|
|
}
|
|
|
|
// ToVolumeInformationMessage fills into with what the master is told about this
|
|
// volume, allocating a message when into is nil. A heartbeat that keeps only
|
|
// the volumes it reports fills the same message for all the rest.
|
|
func (v *Volume) ToVolumeInformationMessage(into *master_pb.VolumeInformationMessage) (types.NeedleId, *master_pb.VolumeInformationMessage) {
|
|
|
|
maxFileKey, volumeSize, modTime, fileCount, deletedCount, deletedSize, ok := v.collectStatus()
|
|
|
|
if !ok {
|
|
return 0, nil
|
|
}
|
|
|
|
// Detect phantom volumes: the .dat was unlinked from disk but is still held
|
|
// open as a deleted FD, so the volume keeps serving and heartbeating while no
|
|
// disk-path operation can ever succeed. Skip remote-tiered volumes, whose .dat
|
|
// legitimately lives in cloud storage. Only a present .dat is cached for 30s; a
|
|
// missing one is re-checked every heartbeat so the volume stays suppressed until
|
|
// the file returns.
|
|
if fileCount > 0 && !v.HasRemoteFile() {
|
|
const diskCheckIntervalNs = 30 * int64(time.Second)
|
|
now := time.Now().UnixNano()
|
|
if now-v.lastDiskCheckNs.Load() > diskCheckIntervalNs {
|
|
if _, err := os.Stat(v.FileName(".dat")); os.IsNotExist(err) {
|
|
glog.Warningf("Volume %d: data file %s missing (held open as deleted FD) - not reporting to master", v.Id, v.FileName(".dat"))
|
|
return 0, nil
|
|
}
|
|
v.lastDiskCheckNs.Store(now)
|
|
}
|
|
}
|
|
|
|
volumeInfo := into
|
|
if volumeInfo == nil {
|
|
volumeInfo = &master_pb.VolumeInformationMessage{}
|
|
}
|
|
volumeInfo.Id = uint32(v.Id)
|
|
volumeInfo.Size = uint64(volumeSize)
|
|
volumeInfo.Collection = v.Collection
|
|
volumeInfo.FileCount = fileCount
|
|
volumeInfo.DeleteCount = deletedCount
|
|
volumeInfo.DeletedByteCount = deletedSize
|
|
volumeInfo.ReadOnly, _, volumeInfo.ReadOnlyCanDelete, _ = v.ReadOnlyReasons()
|
|
volumeInfo.ReplicaPlacement = uint32(v.ReplicaPlacement.Byte())
|
|
volumeInfo.Version = uint32(v.Version())
|
|
volumeInfo.Ttl = v.Ttl.ToUint32()
|
|
volumeInfo.CompactRevision = uint32(v.SuperBlock.CompactionRevision)
|
|
volumeInfo.ModifiedAtSecond = modTime.Unix()
|
|
volumeInfo.DiskType = string(v.location.DiskType)
|
|
volumeInfo.DiskId = v.diskId
|
|
volumeInfo.RemoteStorageName, volumeInfo.RemoteStorageKey = v.RemoteStorageNameKey()
|
|
|
|
return maxFileKey, volumeInfo
|
|
}
|
|
|
|
func (v *Volume) RemoteStorageNameKey() (storageName, storageKey string) {
|
|
if v.volumeInfo == nil {
|
|
return
|
|
}
|
|
if len(v.volumeInfo.GetFiles()) == 0 {
|
|
return
|
|
}
|
|
return v.volumeInfo.GetFiles()[0].BackendName(), v.volumeInfo.GetFiles()[0].GetKey()
|
|
}
|
|
|
|
func (v *Volume) IsReadOnly() bool {
|
|
readOnly, _, _, _ := v.ReadOnlyReasons()
|
|
return readOnly
|
|
}
|
|
|
|
// ReadOnlyReasons reports whether the volume refuses writes and why, reading the
|
|
// flags once so the reasons cannot disagree with the verdict.
|
|
func (v *Volume) ReadOnlyReasons() (readOnly, noWriteOrDelete, noWriteCanDelete, diskSpaceLow bool) {
|
|
v.noWriteLock.RLock()
|
|
noWriteOrDelete, noWriteCanDelete = v.noWriteOrDelete, v.noWriteCanDelete
|
|
if v.ioUnavailable {
|
|
noWriteOrDelete = true
|
|
}
|
|
v.noWriteLock.RUnlock()
|
|
// The location is attached when the volume joins a disk location, which is
|
|
// after NewVolume hands it back.
|
|
diskSpaceLow = v.location != nil && v.location.isDiskSpaceLow.Load()
|
|
return noWriteOrDelete || noWriteCanDelete || diskSpaceLow, noWriteOrDelete, noWriteCanDelete, diskSpaceLow
|
|
}
|
|
|
|
var errVolumeUnavailable = errors.New("volume unavailable")
|
|
|
|
func (v *Volume) UnavailableError() error {
|
|
v.noWriteLock.RLock()
|
|
unavailable := v.ioUnavailable
|
|
reason := v.ioUnavailableError
|
|
v.noWriteLock.RUnlock()
|
|
if !unavailable {
|
|
return nil
|
|
}
|
|
if reason == "" {
|
|
return fmt.Errorf("volume %d is unavailable: %w", v.Id, errVolumeUnavailable)
|
|
}
|
|
return fmt.Errorf("volume %d is unavailable: %s: %w", v.Id, reason, errVolumeUnavailable)
|
|
}
|
|
|
|
func (v *Volume) markIoUnavailable(err error) {
|
|
v.noWriteLock.Lock()
|
|
v.noWriteOrDelete = true
|
|
v.ioUnavailable = true
|
|
v.ioUnavailableError = err.Error()
|
|
v.noWriteLock.Unlock()
|
|
v.markIoQuarantined()
|
|
|
|
if persistErr := v.persistUnavailable(err.Error()); persistErr != nil {
|
|
glog.Warningf("volume %d: failed to persist unavailable marker: %v", v.Id, persistErr)
|
|
}
|
|
if v.volumeInfo != nil {
|
|
if persistErr := v.PersistReadOnly(true, false); persistErr != nil {
|
|
glog.Warningf("volume %d: failed to persist unavailable state: %v", v.Id, persistErr)
|
|
}
|
|
}
|
|
glog.Errorf("volume %d entered unavailable state after failed recovery: %v", v.Id, err)
|
|
}
|
|
|
|
// persistUnavailable records the failed-recovery state so a reload keeps the
|
|
// volume unavailable instead of serving an unverified .dat/index pair.
|
|
func (v *Volume) persistUnavailable(reason string) error {
|
|
marker := v.FileName(".unavailable")
|
|
f, err := os.OpenFile(marker, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if _, err := f.WriteString(reason); err != nil {
|
|
f.Close()
|
|
return err
|
|
}
|
|
if err := f.Sync(); err != nil {
|
|
f.Close()
|
|
return err
|
|
}
|
|
if err := f.Close(); err != nil {
|
|
return err
|
|
}
|
|
return util.FsyncDir(v.dir)
|
|
}
|
|
|
|
// restoreUnavailable re-arms the in-memory state the .unavailable marker
|
|
// recorded. The marker is deleted manually once the volume pair is verified.
|
|
func (v *Volume) restoreUnavailable() {
|
|
reason, err := os.ReadFile(v.FileName(".unavailable"))
|
|
if err != nil {
|
|
return
|
|
}
|
|
v.noWriteLock.Lock()
|
|
v.noWriteOrDelete = true
|
|
v.ioUnavailable = true
|
|
v.ioUnavailableError = strings.TrimSpace(string(reason))
|
|
v.noWriteLock.Unlock()
|
|
v.markIoQuarantined()
|
|
glog.Warningf("volume %d is unavailable: %s", v.Id, v.ioUnavailableError)
|
|
}
|
|
|
|
func (v *Volume) PersistReadOnly(readOnly bool, canDelete bool) error {
|
|
v.volumeInfoRWLock.Lock()
|
|
defer v.volumeInfoRWLock.Unlock()
|
|
prevReadOnly := v.volumeInfo.ReadOnly
|
|
prevReadOnlyCanDelete := v.volumeInfo.ReadOnlyCanDelete
|
|
v.volumeInfo.ReadOnly = readOnly
|
|
v.volumeInfo.ReadOnlyCanDelete = readOnly && canDelete
|
|
if err := v.SaveVolumeInfo(); err != nil {
|
|
// A pre-commit failure (write/sync/close/rename) leaves the old
|
|
// .vif intact, so roll back in-memory state to match it. A
|
|
// NotCrashDurableError means the rename already committed the
|
|
// new mode to disk; rolling back would split in-memory state
|
|
// from the durable file, so keep the new state and propagate.
|
|
var ndErr *volume_info.NotCrashDurableError
|
|
if !errors.As(err, &ndErr) {
|
|
v.volumeInfo.ReadOnly = prevReadOnly
|
|
v.volumeInfo.ReadOnlyCanDelete = prevReadOnlyCanDelete
|
|
}
|
|
return fmt.Errorf("persist volume read-only state: %w", err)
|
|
}
|
|
return nil
|
|
}
|