mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-15 11:00:51 +02:00
* fix(s3api/iam): fail config snapshot on empty or malformed IAM files A full IAM reload reads every identity/policy/service-account/group file from the filer. When an external secrets tool rewrites a file, a reload that reads it mid-rewrite sees empty or partially-written content. The identity, policy and service-account loaders silently skipped such files (``continue``), so the snapshot was missing entries that still existed on disk. The atomic swap then installed an incomplete identity set while ``isAuthEnabled`` stayed on, denying unrelated clients mid-reload (#11259). The group loader and the read-error paths already fail the snapshot in this situation (a skipped entry reads as deleted). Apply the same behavior to empty content and unmarshal failures across the identity, policy, service-account and group loaders, so a transient mid-rewrite fails the reload (preserving the last known-good state) instead of silently dropping entries. * fix(s3api/iam): coalesce burst IAM config reloads through the reload queue onIamConfigChange did a full synchronous reload for every identity/policy file change event. When several independently-refreshing credentials rewrite their files within the same second, that produced a burst of dozens of back-to-back full reloads, each reading the whole store and widening the window where a mid-rewrite file is observed (#11259). Route every IAM config change through the existing coalescing reload queue (scheduleReload/reloadRetryLoop) instead. A burst of N events now collapses into a single reload (plus one tail reload for events that arrived while one was in flight). scheduleReload gains a reason argument for the existing log line; the reloadRetryLoop already retries failed reloads, so the per-event failure handoff is no longer needed. Tests that asserted on the synchronous reload now wire up the queue (centralized in newTestS3ApiServerWithMemoryIAM) and poll via waitForIdentity/waitForIdentityGone. Adds TestOnIamConfigChangeCoalescesBurstReloads showing 50 events coalesce into <=3 reloads. * fix(s3api/iam): skip non-JSON auxiliary files before failing IAM snapshot Per review: the multi-file loaders unmarshal every entry in an IAM directory, so a non-JSON auxiliary file (README, .DS_Store, a migration backup such as identity.json.old) would hit the new empty/malformed errors and reject the whole snapshot, blocking all later IAM reloads. Only *.json files are IAM objects (SeaweedFS writes identities, policies, service accounts and groups as <name>.json, and other call sites already gate on the .json suffix). Skip non-.json entries at the top of each loader loop, before reading content, so auxiliary files are ignored while empty/malformed .json files still fail the snapshot. Adds TestLoadConfigurationIgnoresNonJsonAuxiliaryFiles. * fix(s3api/iam): reject IAM files with empty identifiers and skip aux in listing Per review: - ListPolicyNames listed every regular entry in the policies directory as a policy name, including non-JSON auxiliary files, but GetPolicy cannot retrieve them. Apply the same .json suffix filter used by the loader so the list only exposes retrievable policies. - json.Unmarshal accepts `{}` and unknown fields. The identity and group loaders merge by the decoded Name (not the file name), so a `{}` file could install an empty-key record and displace a real one; the service-account loader accepted an empty Id. Validate Identity.Name, Group.Name and ServiceAccount.Id (via validateServiceAccountId) after unmarshal and fail the snapshot on empty identifiers. Adds TestFilerEtcStoreListPolicyNamesSkipsNonJsonAuxiliary and empty-identifier regression tests for identity, group and service-account files.
474 lines
20 KiB
Go
474 lines
20 KiB
Go
package s3api
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/credential"
|
|
_ "github.com/seaweedfs/seaweedfs/weed/credential/memory"
|
|
"github.com/seaweedfs/seaweedfs/weed/filer"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/iam_pb"
|
|
)
|
|
|
|
// An advanced -iam.config file (STS/OIDC/roles) carries no inline identities, so the
|
|
// server must not enter static-config mode. Otherwise it freezes live reloads and
|
|
// filer-backed identities created at runtime (e.g. by the operator's IAM CRDs) never
|
|
// take effect.
|
|
func TestIamConfigWithoutIdentitiesIsNotStatic(t *testing.T) {
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
path := writeTempIamConfig(t, `{"sts":{"signingKey":"dGVzdC1zaWduaW5nLWtleQ=="}}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(path); err != nil {
|
|
t.Fatalf("failed to load advanced iam config: %v", err)
|
|
}
|
|
|
|
if s3a.iam.IsStaticConfig() {
|
|
t.Fatalf("advanced iam config without identities must not be treated as static")
|
|
}
|
|
|
|
// A filer change (operator creating a user) must still reload at runtime.
|
|
if err := s3a.iam.credentialManager.CreateUser(context.Background(), &iam_pb.Identity{Name: "alice"}); err != nil {
|
|
t.Fatalf("failed to create alice: %v", err)
|
|
}
|
|
if err := s3a.onIamConfigChange(filer.IamConfigDirectory+"/identities", nil, &filer_pb.Entry{Name: "alice.json"}); err != nil {
|
|
t.Fatalf("onIamConfigChange returned error: %v", err)
|
|
}
|
|
waitForIdentity(t, s3a.iam, "alice")
|
|
}
|
|
|
|
// A -config identity file protects its identities but must not block live
|
|
// delivery of filer-managed identities to a running gateway.
|
|
func TestConfigWithIdentitiesStillLiveReloadsDynamic(t *testing.T) {
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
path := writeTempIamConfig(t, `{"identities":[{"name":"static-admin","credentials":[{"accessKey":"AKIAITEST","secretKey":"c2VjcmV0"}],"actions":["Admin"]}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(path); err != nil {
|
|
t.Fatalf("failed to load identity config: %v", err)
|
|
}
|
|
|
|
if !s3a.iam.IsStaticConfig() {
|
|
t.Fatalf("config file with inline identities must be treated as static")
|
|
}
|
|
|
|
s3a.iam.m.RLock()
|
|
id := s3a.iam.nameToIdentity["static-admin"]
|
|
s3a.iam.m.RUnlock()
|
|
if id == nil || !id.IsStatic {
|
|
t.Fatalf("expected static-admin to be marked static")
|
|
}
|
|
|
|
if err := s3a.iam.credentialManager.CreateUser(context.Background(), &iam_pb.Identity{Name: "alice"}); err != nil {
|
|
t.Fatalf("failed to create alice: %v", err)
|
|
}
|
|
if err := s3a.onIamConfigChange(filer.IamConfigDirectory+"/identities", nil, &filer_pb.Entry{Name: "alice.json"}); err != nil {
|
|
t.Fatalf("onIamConfigChange returned error: %v", err)
|
|
}
|
|
waitForIdentity(t, s3a.iam, "alice")
|
|
if !hasIdentity(s3a.iam, "static-admin") {
|
|
t.Fatalf("static-admin must survive the dynamic reload")
|
|
}
|
|
|
|
// deletion on the filer must revoke on the running gateway too
|
|
if err := s3a.iam.credentialManager.DeleteUser(context.Background(), "alice"); err != nil {
|
|
t.Fatalf("failed to delete alice: %v", err)
|
|
}
|
|
if err := s3a.onIamConfigChange(filer.IamConfigDirectory+"/identities", &filer_pb.Entry{Name: "alice.json"}, nil); err != nil {
|
|
t.Fatalf("onIamConfigChange returned error: %v", err)
|
|
}
|
|
waitForIdentityGone(t, s3a.iam, "alice")
|
|
if !hasIdentity(s3a.iam, "static-admin") {
|
|
t.Fatalf("static-admin must survive the deletion reload")
|
|
}
|
|
}
|
|
|
|
// A single pushed identity (PutIdentity) is a partial merge and must not wipe
|
|
// other dynamic identities or a dynamic anonymous identity.
|
|
func TestUpsertIdentityKeepsOtherDynamicIdentities(t *testing.T) {
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
path := writeTempIamConfig(t, `{"identities":[{"name":"static-admin","credentials":[{"accessKey":"AKIAITEST","secretKey":"c2VjcmV0"}],"actions":["Admin"]}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(path); err != nil {
|
|
t.Fatalf("failed to load identity config: %v", err)
|
|
}
|
|
|
|
for _, name := range []string{"alice", "anonymous"} {
|
|
if err := s3a.iam.credentialManager.CreateUser(context.Background(), &iam_pb.Identity{Name: name}); err != nil {
|
|
t.Fatalf("failed to create %s: %v", name, err)
|
|
}
|
|
}
|
|
if err := s3a.iam.LoadS3ApiConfigurationFromCredentialManager(); err != nil {
|
|
t.Fatalf("failed to load from credential manager: %v", err)
|
|
}
|
|
|
|
if err := s3a.iam.UpsertIdentity(&iam_pb.Identity{Name: "bob", Actions: []string{"Read"}}); err != nil {
|
|
t.Fatalf("failed to upsert bob: %v", err)
|
|
}
|
|
for _, name := range []string{"static-admin", "alice", "anonymous", "bob"} {
|
|
if !hasIdentity(s3a.iam, name) {
|
|
t.Fatalf("expected %s to survive a partial upsert", name)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Reloading the static config file (grace.OnReload) must mark newly added
|
|
// identities as static so dynamic filer updates can't overwrite them, while
|
|
// leaving already-loaded dynamic (filer-managed) identities untouched.
|
|
func TestReloadStaticConfigMarksNewIdentitiesWithoutFreezingDynamic(t *testing.T) {
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
p1 := writeTempIamConfig(t, `{"identities":[{"name":"static-admin","credentials":[{"accessKey":"AKADMIN0","secretKey":"c2VjcmV0"}],"actions":["Admin"]}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(p1); err != nil {
|
|
t.Fatalf("failed to load initial config: %v", err)
|
|
}
|
|
|
|
// A dynamic identity arrives from the filer; merge mode keeps it dynamic.
|
|
if err := s3a.iam.credentialManager.CreateUser(context.Background(), &iam_pb.Identity{Name: "alice"}); err != nil {
|
|
t.Fatalf("failed to create alice: %v", err)
|
|
}
|
|
if err := s3a.iam.LoadS3ApiConfigurationFromCredentialManager(); err != nil {
|
|
t.Fatalf("failed to load from credential manager: %v", err)
|
|
}
|
|
if !hasIdentity(s3a.iam, "alice") {
|
|
t.Fatalf("expected alice to load dynamically")
|
|
}
|
|
|
|
// Reload the static file with a new identity bob.
|
|
p2 := writeTempIamConfig(t, `{"identities":[{"name":"static-admin","credentials":[{"accessKey":"AKADMIN0","secretKey":"c2VjcmV0"}],"actions":["Admin"]},{"name":"bob","credentials":[{"accessKey":"AKBOB000","secretKey":"c2VjcmV0"}],"actions":["Read"]}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(p2); err != nil {
|
|
t.Fatalf("failed to reload config: %v", err)
|
|
}
|
|
|
|
if !isStaticName(s3a.iam, "bob") {
|
|
t.Fatalf("expected reloaded identity bob to be marked static")
|
|
}
|
|
if isStaticName(s3a.iam, "alice") {
|
|
t.Fatalf("dynamic identity alice must not be frozen as static by a config reload")
|
|
}
|
|
}
|
|
|
|
// A config-file reload must apply an edited secretKey to its static identity.
|
|
func TestReloadStaticConfigUpdatesExistingSecretKey(t *testing.T) {
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
p1 := writeTempIamConfig(t, `{"identities":[{"name":"static-admin","credentials":[{"accessKey":"AKADMIN0","secretKey":"b2xkc2VjcmV0"}],"actions":["Admin"]}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(p1); err != nil {
|
|
t.Fatalf("failed to load initial config: %v", err)
|
|
}
|
|
|
|
_, cred, found := s3a.iam.lookupByAccessKey("AKADMIN0")
|
|
if !found || cred.SecretKey != "b2xkc2VjcmV0" {
|
|
t.Fatalf("expected initial secretKey to load, got found=%v cred=%+v", found, cred)
|
|
}
|
|
|
|
// Rotate the secretKey in the file and reload.
|
|
p2 := writeTempIamConfig(t, `{"identities":[{"name":"static-admin","credentials":[{"accessKey":"AKADMIN0","secretKey":"bmV3c2VjcmV0"}],"actions":["Admin"]}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(p2); err != nil {
|
|
t.Fatalf("failed to reload config: %v", err)
|
|
}
|
|
|
|
_, cred, found = s3a.iam.lookupByAccessKey("AKADMIN0")
|
|
if !found {
|
|
t.Fatalf("static-admin access key disappeared after reload")
|
|
}
|
|
if cred.SecretKey != "bmV3c2VjcmV0" {
|
|
t.Fatalf("expected reloaded secretKey bmV3c2VjcmV0, got %q", cred.SecretKey)
|
|
}
|
|
if !isStaticName(s3a.iam, "static-admin") {
|
|
t.Fatalf("static-admin must stay marked static after reload")
|
|
}
|
|
}
|
|
|
|
// A reload must also reapply a service-account credential under a static parent.
|
|
func TestReloadStaticConfigUpdatesServiceAccountSecret(t *testing.T) {
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
p1 := writeTempIamConfig(t, `{"identities":[{"name":"static-admin","credentials":[{"accessKey":"AKADMIN0","secretKey":"YWRtaW4="}],"actions":["Admin"]}],"serviceAccounts":[{"id":"sa-1","parentUser":"static-admin","credential":{"accessKey":"AKSA0001","secretKey":"b2xkc2E="}}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(p1); err != nil {
|
|
t.Fatalf("failed to load initial config: %v", err)
|
|
}
|
|
if _, cred, found := s3a.iam.lookupByAccessKey("AKSA0001"); !found || cred.SecretKey != "b2xkc2E=" {
|
|
t.Fatalf("expected service account secret to load, got found=%v cred=%+v", found, cred)
|
|
}
|
|
|
|
// Rotate the service account secret in the file and reload.
|
|
p2 := writeTempIamConfig(t, `{"identities":[{"name":"static-admin","credentials":[{"accessKey":"AKADMIN0","secretKey":"YWRtaW4="}],"actions":["Admin"]}],"serviceAccounts":[{"id":"sa-1","parentUser":"static-admin","credential":{"accessKey":"AKSA0001","secretKey":"bmV3c2E="}}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(p2); err != nil {
|
|
t.Fatalf("failed to reload config: %v", err)
|
|
}
|
|
_, cred, found := s3a.iam.lookupByAccessKey("AKSA0001")
|
|
if !found {
|
|
t.Fatalf("service account access key disappeared after reload")
|
|
}
|
|
if cred.SecretKey != "bmV3c2E=" {
|
|
t.Fatalf("expected reloaded service account secret bmV3c2E=, got %q", cred.SecretKey)
|
|
}
|
|
}
|
|
|
|
// A full snapshot reconciles policy and group deletions, static-file policies
|
|
// survive, and groups in a static config file are ignored: the dynamic store
|
|
// is the only source of groups.
|
|
func TestFullStateMergeReconcilesPoliciesAndGroups(t *testing.T) {
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
path := writeTempIamConfig(t, `{"identities":[{"name":"static-admin","credentials":[{"accessKey":"AKIAITEST","secretKey":"c2VjcmV0"}],"actions":["Admin"]}],"policies":[{"name":"file-policy","content":"{}"}],"groups":[{"name":"file-group","members":["static-admin"]}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(path); err != nil {
|
|
t.Fatalf("failed to load identity config: %v", err)
|
|
}
|
|
if hasGroup(s3a.iam, "file-group") {
|
|
t.Fatalf("groups in a static config file must be ignored")
|
|
}
|
|
|
|
full := &iam_pb.S3ApiConfiguration{
|
|
Policies: []*iam_pb.Policy{{Name: "dynamic-policy", Content: "{}"}},
|
|
Groups: []*iam_pb.Group{{Name: "g1"}},
|
|
}
|
|
if err := s3a.iam.MergeS3ApiConfiguration(full, false, true); err != nil {
|
|
t.Fatalf("full merge failed: %v", err)
|
|
}
|
|
if !hasPolicy(s3a.iam, "file-policy") || !hasPolicy(s3a.iam, "dynamic-policy") || !hasGroup(s3a.iam, "g1") {
|
|
t.Fatalf("expected file-policy, dynamic-policy and g1 after full merge")
|
|
}
|
|
|
|
// partial merge preserves groups and policies
|
|
if err := s3a.iam.UpsertIdentity(&iam_pb.Identity{Name: "bob"}); err != nil {
|
|
t.Fatalf("upsert failed: %v", err)
|
|
}
|
|
if !hasPolicy(s3a.iam, "dynamic-policy") || !hasGroup(s3a.iam, "g1") {
|
|
t.Fatalf("partial merge must not drop dynamic-policy or g1")
|
|
}
|
|
|
|
// a static-file reload leaves dynamic groups alone
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(path); err != nil {
|
|
t.Fatalf("failed to reload config: %v", err)
|
|
}
|
|
if !hasGroup(s3a.iam, "g1") {
|
|
t.Fatalf("dynamic g1 must survive a static-file reload")
|
|
}
|
|
|
|
// empty full snapshot: dynamic policy and last group deleted, file policy stays
|
|
if err := s3a.iam.MergeS3ApiConfiguration(&iam_pb.S3ApiConfiguration{}, false, true); err != nil {
|
|
t.Fatalf("empty full merge failed: %v", err)
|
|
}
|
|
if hasPolicy(s3a.iam, "dynamic-policy") {
|
|
t.Fatalf("expected dynamic-policy to be removed by empty full snapshot")
|
|
}
|
|
if hasGroup(s3a.iam, "g1") {
|
|
t.Fatalf("expected g1 to be removed by empty full snapshot")
|
|
}
|
|
if !hasPolicy(s3a.iam, "file-policy") {
|
|
t.Fatalf("file-policy must survive full-state reconciliation")
|
|
}
|
|
}
|
|
|
|
// flakyStore fails LoadConfiguration a fixed number of times.
|
|
type flakyStore struct {
|
|
credential.CredentialStore
|
|
failures int
|
|
}
|
|
|
|
func (f *flakyStore) LoadConfiguration(ctx context.Context) (*iam_pb.S3ApiConfiguration, error) {
|
|
if f.failures > 0 {
|
|
f.failures--
|
|
return nil, fmt.Errorf("transient store failure")
|
|
}
|
|
return f.CredentialStore.LoadConfiguration(ctx)
|
|
}
|
|
|
|
// A failed reload queued from an IAM config change must keep retrying until
|
|
// the store recovers.
|
|
func TestFailedReloadRetriesUntilSuccess(t *testing.T) {
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
prev := iamReloadRetryInterval
|
|
iamReloadRetryInterval = 10 * time.Millisecond
|
|
t.Cleanup(func() { iamReloadRetryInterval = prev })
|
|
|
|
if err := s3a.iam.credentialManager.CreateUser(context.Background(), &iam_pb.Identity{Name: "alice"}); err != nil {
|
|
t.Fatalf("failed to create alice: %v", err)
|
|
}
|
|
s3a.iam.credentialManager.Store = &flakyStore{CredentialStore: s3a.iam.credentialManager.Store, failures: 2}
|
|
|
|
// onIamConfigChange only queues a coalesced reload; the retry loop does the
|
|
// work and retries through the transient store failures.
|
|
if err := s3a.onIamConfigChange(filer.IamConfigDirectory+"/identities", nil, &filer_pb.Entry{Name: "alice.json"}); err != nil {
|
|
t.Fatalf("onIamConfigChange returned error: %v", err)
|
|
}
|
|
waitForIdentity(t, s3a.iam, "alice")
|
|
}
|
|
|
|
func hasPolicy(iam *IdentityAccessManagement, name string) bool {
|
|
iam.m.RLock()
|
|
defer iam.m.RUnlock()
|
|
_, ok := iam.policies[name]
|
|
return ok
|
|
}
|
|
|
|
func hasGroup(iam *IdentityAccessManagement, name string) bool {
|
|
iam.m.RLock()
|
|
defer iam.m.RUnlock()
|
|
_, ok := iam.groups[name]
|
|
return ok
|
|
}
|
|
|
|
func isStaticName(iam *IdentityAccessManagement, name string) bool {
|
|
iam.m.RLock()
|
|
defer iam.m.RUnlock()
|
|
return iam.staticIdentityNames[name]
|
|
}
|
|
|
|
func writeTempIamConfig(t *testing.T, content string) string {
|
|
t.Helper()
|
|
path := filepath.Join(t.TempDir(), "iam.json")
|
|
if err := os.WriteFile(path, []byte(content), 0o600); err != nil {
|
|
t.Fatalf("failed to write temp config: %v", err)
|
|
}
|
|
return path
|
|
}
|
|
|
|
// A static config file may hold ${VAR} in place of a key, so a deployment can
|
|
// keep the keys in its own secret store and pass them in as environment
|
|
// variables rather than baking them into the file.
|
|
func TestStaticConfigExpandsEnvCredentialRefs(t *testing.T) {
|
|
t.Setenv("SEAWEEDFS_S3_ADMIN_ACCESS_KEY_ID", "AKIAFROMENV")
|
|
t.Setenv("SEAWEEDFS_S3_ADMIN_SECRET_ACCESS_KEY", "secretfromenv")
|
|
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
path := writeTempIamConfig(t, `{"identities":[{"name":"anvAdmin","credentials":[{"accessKey":"${SEAWEEDFS_S3_ADMIN_ACCESS_KEY_ID}","secretKey":"${SEAWEEDFS_S3_ADMIN_SECRET_ACCESS_KEY}"}],"actions":["Admin"]}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(path); err != nil {
|
|
t.Fatalf("failed to load identity config: %v", err)
|
|
}
|
|
|
|
_, cred, found := s3a.iam.lookupByAccessKey("AKIAFROMENV")
|
|
if !found {
|
|
t.Fatalf("expected the access key from the environment to be loaded")
|
|
}
|
|
if cred.SecretKey != "secretfromenv" {
|
|
t.Fatalf("expected the secret key from the environment, got %q", cred.SecretKey)
|
|
}
|
|
if _, _, found := s3a.iam.lookupByAccessKey("${SEAWEEDFS_S3_ADMIN_ACCESS_KEY_ID}"); found {
|
|
t.Fatalf("the unexpanded reference must not remain usable as an access key")
|
|
}
|
|
}
|
|
|
|
// An unset variable must not leave the reference behind as a literal key.
|
|
func TestStaticConfigDropsUnresolvedEnvCredentialRefs(t *testing.T) {
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
path := writeTempIamConfig(t, `{"identities":[{"name":"anvAdmin","credentials":[{"accessKey":"${SEAWEEDFS_S3_MISSING_ACCESS_KEY_ID}","secretKey":"${SEAWEEDFS_S3_MISSING_SECRET_ACCESS_KEY}"}],"actions":["Admin"]}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(path); err != nil {
|
|
t.Fatalf("failed to load identity config: %v", err)
|
|
}
|
|
|
|
if _, _, found := s3a.iam.lookupByAccessKey("${SEAWEEDFS_S3_MISSING_ACCESS_KEY_ID}"); found {
|
|
t.Fatalf("a credential referencing an unset variable must be dropped")
|
|
}
|
|
if !hasIdentity(s3a.iam, "anvAdmin") {
|
|
t.Fatalf("expected the identity itself to still load")
|
|
}
|
|
}
|
|
|
|
// Keys that merely contain a dollar sign are literal, and identities coming
|
|
// from the filer are never expanded.
|
|
func TestEnvCredentialRefsOnlyApplyToStaticConfig(t *testing.T) {
|
|
t.Setenv("SEAWEEDFS_S3_DYNAMIC_SECRET_ACCESS_KEY", "secretfromenv")
|
|
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
if err := s3a.iam.LoadS3ApiConfigurationFromBytes([]byte(`{"identities":[{"name":"dynamic","credentials":[{"accessKey":"AKIALITERAL","secretKey":"${SEAWEEDFS_S3_DYNAMIC_SECRET_ACCESS_KEY}"}],"actions":["Admin"]}]}`)); err != nil {
|
|
t.Fatalf("failed to load dynamic config: %v", err)
|
|
}
|
|
|
|
_, cred, found := s3a.iam.lookupByAccessKey("AKIALITERAL")
|
|
if !found {
|
|
t.Fatalf("expected the dynamic identity to load")
|
|
}
|
|
if cred.SecretKey != "${SEAWEEDFS_S3_DYNAMIC_SECRET_ACCESS_KEY}" {
|
|
t.Fatalf("a dynamic identity must keep its secret key verbatim, got %q", cred.SecretKey)
|
|
}
|
|
}
|
|
|
|
// A key holding a dollar sign that is not a reference stays untouched.
|
|
func TestStaticConfigKeepsLiteralDollarSigns(t *testing.T) {
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
path := writeTempIamConfig(t, `{"identities":[{"name":"anvAdmin","credentials":[{"accessKey":"AKIALITERAL","secretKey":"pa$$word"}],"actions":["Admin"]}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(path); err != nil {
|
|
t.Fatalf("failed to load identity config: %v", err)
|
|
}
|
|
|
|
_, cred, found := s3a.iam.lookupByAccessKey("AKIALITERAL")
|
|
if !found {
|
|
t.Fatalf("expected the identity to load")
|
|
}
|
|
if cred.SecretKey != "pa$$word" {
|
|
t.Fatalf("expected the literal secret key, got %q", cred.SecretKey)
|
|
}
|
|
}
|
|
|
|
// A secret store handing over a blank value must not leave an access key that
|
|
// any signature matches.
|
|
func TestStaticConfigDropsEmptyEnvCredentialRefs(t *testing.T) {
|
|
t.Setenv("SEAWEEDFS_S3_ADMIN_ACCESS_KEY_ID", "AKIAFROMENV")
|
|
t.Setenv("SEAWEEDFS_S3_ADMIN_SECRET_ACCESS_KEY", "")
|
|
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
path := writeTempIamConfig(t, `{"identities":[{"name":"anvAdmin","credentials":[{"accessKey":"${SEAWEEDFS_S3_ADMIN_ACCESS_KEY_ID}","secretKey":"${SEAWEEDFS_S3_ADMIN_SECRET_ACCESS_KEY}"}],"actions":["Admin"]}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(path); err != nil {
|
|
t.Fatalf("failed to load identity config: %v", err)
|
|
}
|
|
|
|
if _, _, found := s3a.iam.lookupByAccessKey("AKIAFROMENV"); found {
|
|
t.Fatalf("a credential whose secret key resolves to empty must be dropped")
|
|
}
|
|
}
|
|
|
|
// A reference the substitution cannot match, such as a typo in the variable
|
|
// name, must not survive as a literal key.
|
|
func TestStaticConfigDropsMalformedEnvCredentialRefs(t *testing.T) {
|
|
for _, malformed := range []string{"${MY-VAR}", "${1VAR}", "${}", "${UNTERMINATED", "${A}${B"} {
|
|
t.Run(malformed, func(t *testing.T) {
|
|
t.Setenv("SEAWEEDFS_S3_ADMIN_SECRET_ACCESS_KEY", "secretfromenv")
|
|
t.Setenv("A", "a")
|
|
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
path := writeTempIamConfig(t, fmt.Sprintf(`{"identities":[{"name":"anvAdmin","credentials":[{"accessKey":%q,"secretKey":"${SEAWEEDFS_S3_ADMIN_SECRET_ACCESS_KEY}"}],"actions":["Admin"]}]}`, malformed))
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(path); err != nil {
|
|
t.Fatalf("failed to load identity config: %v", err)
|
|
}
|
|
|
|
if _, _, found := s3a.iam.lookupByAccessKey(malformed); found {
|
|
t.Fatalf("%s must not become a usable access key", malformed)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// A resolved value that happens to contain ${ is still the key the operator set.
|
|
func TestStaticConfigKeepsBracesComingFromTheEnvironment(t *testing.T) {
|
|
t.Setenv("SEAWEEDFS_S3_ADMIN_ACCESS_KEY_ID", "AKIAFROMENV")
|
|
t.Setenv("SEAWEEDFS_S3_ADMIN_SECRET_ACCESS_KEY", "pa${ss}word")
|
|
|
|
s3a := newTestS3ApiServerWithMemoryIAM(t, []*iam_pb.Identity{})
|
|
|
|
path := writeTempIamConfig(t, `{"identities":[{"name":"anvAdmin","credentials":[{"accessKey":"${SEAWEEDFS_S3_ADMIN_ACCESS_KEY_ID}","secretKey":"${SEAWEEDFS_S3_ADMIN_SECRET_ACCESS_KEY}"}],"actions":["Admin"]}]}`)
|
|
if err := s3a.iam.loadS3ApiConfigurationFromFile(path); err != nil {
|
|
t.Fatalf("failed to load identity config: %v", err)
|
|
}
|
|
|
|
_, cred, found := s3a.iam.lookupByAccessKey("AKIAFROMENV")
|
|
if !found {
|
|
t.Fatalf("expected the identity to load")
|
|
}
|
|
if cred.SecretKey != "pa${ss}word" {
|
|
t.Fatalf("expected the secret key from the environment verbatim, got %q", cred.SecretKey)
|
|
}
|
|
}
|