mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-20 13:30:46 +02:00
Chris LuandCopilot
3bd990d2ea
- Remove versioningConfigured guard: object lock protections must apply to all buckets - Combine identical switch cases for clarity - Change default case to fail-closed (true) for safety - Add test case for suspended versioning with specific versionId - Update test expectations to reflect fail-closed default Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
70 lines
2.0 KiB
Go
70 lines
2.0 KiB
Go
package s3api
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestObjectLockVersionToCheckForDelete(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
versioningState string
|
|
requestedVersionID string
|
|
expectedVersionID string
|
|
expectedShouldCheck bool
|
|
}{
|
|
{
|
|
name: "enabled versioning without version id checks latest version",
|
|
versioningState: s3_constants.VersioningEnabled,
|
|
requestedVersionID: "",
|
|
expectedVersionID: "",
|
|
expectedShouldCheck: true,
|
|
},
|
|
{
|
|
name: "suspended versioning without version id checks null version",
|
|
versioningState: s3_constants.VersioningSuspended,
|
|
requestedVersionID: "",
|
|
expectedVersionID: "null",
|
|
expectedShouldCheck: true,
|
|
},
|
|
{
|
|
name: "specific version id is always checked",
|
|
versioningState: s3_constants.VersioningEnabled,
|
|
requestedVersionID: "3LgYQ7f7VxQ3",
|
|
expectedVersionID: "3LgYQ7f7VxQ3",
|
|
expectedShouldCheck: true,
|
|
},
|
|
{
|
|
name: "non-versioned buckets still check current object",
|
|
versioningState: "",
|
|
requestedVersionID: "",
|
|
expectedVersionID: "",
|
|
expectedShouldCheck: true,
|
|
},
|
|
{
|
|
name: "unknown versioning state without version id is checked (fail-closed for safety)",
|
|
versioningState: "UnexpectedState",
|
|
requestedVersionID: "",
|
|
expectedVersionID: "",
|
|
expectedShouldCheck: true,
|
|
},
|
|
{
|
|
name: "suspended versioning with specific version id checks that version",
|
|
versioningState: s3_constants.VersioningSuspended,
|
|
requestedVersionID: "abc123",
|
|
expectedVersionID: "abc123",
|
|
expectedShouldCheck: true,
|
|
},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
versionID, shouldCheck := objectLockVersionToCheckForDelete(tc.versioningState, tc.requestedVersionID)
|
|
assert.Equal(t, tc.expectedVersionID, versionID)
|
|
assert.Equal(t, tc.expectedShouldCheck, shouldCheck)
|
|
})
|
|
}
|
|
}
|