Files
seaweedfs/weed/shell/command_volume_mark.go
T
Chris Lu b0ab4c4e1e shell: make every -collection flag parse the same way (#11794)
* shell: make every -collection flag parse the same way

The filter vocabulary (comma-separated names, wildcards, regexes,
"_default" for the empty-named collection) already existed in
wildcard.CompileCollectionMatcher, but several commands still did their
own exact-match comparison or sent the raw flag value to servers.

fs.mergeVolumes used a literal string compare, so -collection=_default
silently produced an empty merge plan; it now uses the shared matcher
while keeping "*" as the match-all default. volume.fsck and volume.mark
filter through the matcher too, and volume.vacuum resolves the filter
client-side into per-collection and per-volume requests, since no
Collection value scopes the VacuumVolume RPC to the unnamed collection
alone.

Commands that put one concrete collection name on the wire normalize
"_default" to "" (volume.grow, fs.configure, mq.topic.compact,
collection.delete, ec.rebuild, ec.balance), and the tier -volumeId
commands resolve the volume's actual collection from topology first so
patterns and named-collection requests pass the volume server's
collection check.

* shell: spell the default-collection keyword via CollectionDefault

* shell: address review findings on collection filter handling

volume.fsck keeps a set of every volume the master knows before any
filtering, so a filer entry whose volume was excluded by -collection or
-volumeId is skipped instead of reported "volume not found" and deleted
by -reallyDeleteFilerEntries. The collection filter also no longer
scopes the filer walk to /buckets/<collection>: fs.configure can bind a
collection to any path prefix, and a narrower walk could mark live
chunks as orphans under -reallyDeleteFromVolume.

ec.rebuild and ec.balance resolve -collection through the new
wildcard.ExpandCollectionFilter, which passes literal names through even
when the master does not list them — ec.rebuild must be able to recover
a collection whose shards all lost their index and never registered.

fs.configure and mq.topic.compact now reject _default outright: an empty
Collection means "unset" in both the path-rule merge and the filer's
storage-option fallback chain, so the keyword would have been silently
ignored.

The unnamed-collection vacuum sweep keeps the master's low-disk-space
exception: a volume whose every replica is read-only is probed with
VacuumVolumeCheck and stays eligible when a replica reports
DiskSpaceLow, instead of being dropped outright.
2026-10-16 21:07:51 -07:00

168 lines
5.3 KiB
Go

package shell
import (
"context"
"errors"
"flag"
"fmt"
"io"
"github.com/seaweedfs/seaweedfs/weed/pb"
"github.com/seaweedfs/seaweedfs/weed/pb/master_pb"
"github.com/seaweedfs/seaweedfs/weed/util/wildcard"
"github.com/seaweedfs/seaweedfs/weed/storage/needle"
)
func init() {
Commands = append(Commands, &commandVolumeMark{})
}
type commandVolumeMark struct {
}
func (c *commandVolumeMark) Name() string {
return "volume.mark"
}
func (c *commandVolumeMark) Help() string {
return `Mark volume writable or readonly from one volume server, or all volume replicas in one collection
volume.mark -node <volume server host:port> -volumeId <volume id> -writable, -readonly or -readonlyCanDelete
volume.mark -collection <collection> -writable, -readonly or -readonlyCanDelete
Use -collection ` + CollectionDefault + ` to target volumes that belong to no named collection.
-readonlyCanDelete rejects new writes but keeps accepting deletes, so a
volume holding expiring data drains over time until it can be vacuumed
away or merged into other volumes with fs.mergeVolumes.
`
}
func (c *commandVolumeMark) HasTag(CommandTag) bool {
return false
}
func (c *commandVolumeMark) Do(args []string, commandEnv *CommandEnv, writer io.Writer) (err error) {
volMarkCommand := flag.NewFlagSet(c.Name(), flag.ContinueOnError)
volumeIdInt := volMarkCommand.Int("volumeId", 0, "the volume id")
nodeStr := volMarkCommand.String("node", "", "the volume server <host>:<port>")
collection := volMarkCommand.String("collection", "", "comma-separated collection names, wildcards, or regex patterns; \""+CollectionDefault+"\" for the collection with no name")
writable := volMarkCommand.Bool("writable", false, "volume mark writable")
readonly := volMarkCommand.Bool("readonly", false, "volume mark readonly")
readonlyCanDelete := volMarkCommand.Bool("readonlyCanDelete", false, "volume mark readonly but still accepting deletes")
if err = volMarkCommand.Parse(args); err != nil {
return nil
}
collectionSet, nodeSet, volumeIdSet := false, false, false
volMarkCommand.Visit(func(f *flag.Flag) {
switch f.Name {
case "collection":
collectionSet = true
case "node":
nodeSet = true
case "volumeId":
volumeIdSet = true
}
})
modeCount := 0
for _, set := range []bool{*writable, *readonly, *readonlyCanDelete} {
if set {
modeCount++
}
}
if modeCount != 1 {
return fmt.Errorf("use exactly one of -writable, -readonly or -readonlyCanDelete")
}
markWritable := *writable
if collectionSet {
if *collection == "" {
return fmt.Errorf("collection is required")
}
if nodeSet || volumeIdSet {
return fmt.Errorf("cannot use -collection with -node or -volumeId")
}
} else if !nodeSet || !volumeIdSet || *nodeStr == "" || *volumeIdInt == 0 {
return fmt.Errorf("use -node and -volumeId, or -collection")
}
if err = commandEnv.confirmIsLocked(args); err != nil {
return
}
if collectionSet {
topologyInfo, _, err := collectTopologyInfo(commandEnv, 0)
if err != nil {
return err
}
targets, err := collectVolumeMarkTargetsByCollection(topologyInfo, *collection)
if err != nil {
return err
}
state := "readonly"
if markWritable {
state = "writable"
} else if *readonlyCanDelete {
state = "readonly (can delete)"
}
var failures []error
for _, target := range targets {
if err := markVolumeState(context.Background(), commandEnv.option.GrpcDialOption, target.volumeId, target.sourceVolumeServer, markWritable, *readonlyCanDelete, true); err != nil {
failures = append(failures, fmt.Errorf("mark volume %d on %s: %w", target.volumeId, target.sourceVolumeServer, err))
fmt.Fprintf(writer, "volume %d on %s: %v\n", target.volumeId, target.sourceVolumeServer, err)
continue
}
fmt.Fprintf(writer, "volume %d on %s marked %s\n", target.volumeId, target.sourceVolumeServer, state)
}
if len(failures) > 0 {
return fmt.Errorf("marked %d of %d volumes %s, %d failed: %w", len(targets)-len(failures), len(targets), state, len(failures), errors.Join(failures...))
}
return nil
}
sourceVolumeServer := pb.ServerAddress(*nodeStr)
volumeId := needle.VolumeId(*volumeIdInt)
return markVolumeState(context.Background(), commandEnv.option.GrpcDialOption, volumeId, sourceVolumeServer, markWritable, *readonlyCanDelete, true)
}
type volumeMarkTarget struct {
volumeId needle.VolumeId
sourceVolumeServer pb.ServerAddress
}
func collectVolumeMarkTargetsByCollection(topoInfo *master_pb.TopologyInfo, collection string) ([]volumeMarkTarget, error) {
if collection == "" {
return nil, fmt.Errorf("collection is required")
}
collectionMatcher, err := wildcard.CompileCollectionMatcher(collection)
if err != nil {
return nil, fmt.Errorf("invalid collection pattern %q: %w", collection, err)
}
var targets []volumeMarkTarget
eachDataNode(topoInfo, func(dc DataCenterId, rack RackId, dn *master_pb.DataNodeInfo) {
if dn == nil {
return
}
sourceVolumeServer := pb.NewServerAddressFromDataNode(dn)
for _, diskInfo := range dn.GetDiskInfos() {
for _, v := range diskInfo.GetVolumeInfos() {
if collectionMatcher.Matches(v.GetCollection()) {
targets = append(targets, volumeMarkTarget{
volumeId: needle.VolumeId(v.GetId()),
sourceVolumeServer: sourceVolumeServer,
})
}
}
}
})
if len(targets) == 0 {
return nil, fmt.Errorf("no volumes match collection %s", collection)
}
return targets, nil
}