mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-14 18:40:48 +02:00
* filer: scope TUS HEAD/PATCH/DELETE against the session target path checkTusJwtAuthorization only populated the scoped-path list for POST, so a prefix-restricted token was scope-checked at session creation but not on HEAD/PATCH/DELETE, which act on an existing session addressed by id. A low-privilege tenant holding a valid write token who learns another upload's session id could PATCH attacker bytes into that session, or DELETE/HEAD it, landing content at a target path its own AllowedPrefixes forbids. The session id is unguessable to an unauthenticated attacker but is not an authorization boundary against a legitimate tenant. Resolve the effective target for HEAD/PATCH/DELETE from the session's stored TargetPath and scope the prefix check against it, the same way POST scopes the create target. The scoped paths are resolved lazily so the session read runs only for a prefix-restricted token; unrestricted tokens and deployments without a signing key touch no extra state. An unknown session stays unscoped so the handler still answers 404. * filer: fail closed when a TUS session target cannot be resolved The lazy scope resolver swallowed every readTusSessionInfo error and left the request unscoped, so a filer read error or a corrupt session .info would authorize a prefix-restricted token against a target the server never resolved. Only a genuinely missing session should stay unscoped (so the handler answers 404); any other failure now propagates and denies the request. checkJwtAuthorizationScoped's resolver returns an error and a failed resolution is treated as not-authorized. * filer: fold the scoped-path resolver into checkJwtAuthorization checkJwtAuthorization now takes the lazy resolver directly instead of a separate checkJwtAuthorizationScoped wrapper, and the surrounding comments are trimmed to the load-bearing why.
478 lines
15 KiB
Go
478 lines
15 KiB
Go
package weed_server
|
|
|
|
import (
|
|
"context"
|
|
"encoding/base64"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"sort"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/filer"
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
"github.com/seaweedfs/seaweedfs/weed/util/constants"
|
|
)
|
|
|
|
const (
|
|
TusVersion = "1.0.0"
|
|
TusMaxSize = int64(5 * 1024 * 1024 * 1024) // 5GB default max size
|
|
TusUploadsFolder = ".uploads.tus"
|
|
TusInfoFileName = ".info"
|
|
TusChunkExt = ".chunk"
|
|
TusExtensions = "creation,creation-with-upload,termination"
|
|
)
|
|
|
|
// ErrWormEnforced marks a TUS completion rejected because the target entry is
|
|
// WORM-protected. It shares the message the normal write path uses so it maps to
|
|
// the same client-facing status.
|
|
var ErrWormEnforced = errors.New(constants.ErrMsgOperationNotPermitted)
|
|
|
|
// TusSession represents an in-progress TUS upload session
|
|
type TusSession struct {
|
|
ID string `json:"id"`
|
|
TargetPath string `json:"target_path"`
|
|
Size int64 `json:"size"`
|
|
Offset int64 `json:"offset"`
|
|
Metadata map[string]string `json:"metadata,omitempty"`
|
|
CreatedAt time.Time `json:"created_at"`
|
|
ExpiresAt time.Time `json:"expires_at,omitempty"`
|
|
Chunks []*TusChunkInfo `json:"chunks,omitempty"`
|
|
}
|
|
|
|
// TusChunkInfo tracks individual chunk uploads within a session
|
|
type TusChunkInfo struct {
|
|
Offset int64 `json:"offset"`
|
|
Size int64 `json:"size"`
|
|
FileId string `json:"file_id"`
|
|
UploadAt int64 `json:"upload_at"`
|
|
}
|
|
|
|
// tusSessionDir returns the directory path for storing TUS upload sessions
|
|
func (fs *FilerServer) tusSessionDir() string {
|
|
return "/" + TusUploadsFolder
|
|
}
|
|
|
|
// tusSessionPath returns the path to a specific upload session directory
|
|
func (fs *FilerServer) tusSessionPath(uploadID string) string {
|
|
return fmt.Sprintf("/%s/%s", TusUploadsFolder, uploadID)
|
|
}
|
|
|
|
// tusSessionInfoPath returns the path to the session info file
|
|
func (fs *FilerServer) tusSessionInfoPath(uploadID string) string {
|
|
return fmt.Sprintf("/%s/%s/%s", TusUploadsFolder, uploadID, TusInfoFileName)
|
|
}
|
|
|
|
// tusChunkPath returns the path to store a chunk info file
|
|
// Format: /{TusUploadsFolder}/{uploadID}/chunk_{offset}_{size}_{encodedFileId}
|
|
func (fs *FilerServer) tusChunkPath(uploadID string, offset, size int64, fileId string) string {
|
|
// Use URL-safe base64 encoding to safely encode fileId (handles both / and _ in fileId)
|
|
encodedFileId := base64.RawURLEncoding.EncodeToString([]byte(fileId))
|
|
return fmt.Sprintf("/%s/%s/chunk_%016d_%016d_%s", TusUploadsFolder, uploadID, offset, size, encodedFileId)
|
|
}
|
|
|
|
// parseTusChunkPath parses chunk info from a chunk entry
|
|
// The entry's Crtime is used for the UploadAt timestamp to preserve the actual upload time
|
|
func parseTusChunkPath(entry *filer.Entry) (*TusChunkInfo, error) {
|
|
name := entry.Name()
|
|
if !strings.HasPrefix(name, "chunk_") {
|
|
return nil, fmt.Errorf("not a chunk file: %s", name)
|
|
}
|
|
// Use strings.Cut to correctly handle base64-encoded fileId which may contain underscores
|
|
s := name[6:] // Skip "chunk_" prefix
|
|
offsetStr, rest, found := strings.Cut(s, "_")
|
|
if !found {
|
|
return nil, fmt.Errorf("invalid chunk file name format (missing offset): %s", name)
|
|
}
|
|
sizeStr, encodedFileId, found := strings.Cut(rest, "_")
|
|
if !found {
|
|
return nil, fmt.Errorf("invalid chunk file name format (missing size): %s", name)
|
|
}
|
|
|
|
offset, err := strconv.ParseInt(offsetStr, 10, 64)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("invalid offset in chunk file %q: %w", name, err)
|
|
}
|
|
size, err := strconv.ParseInt(sizeStr, 10, 64)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("invalid size in chunk file %q: %w", name, err)
|
|
}
|
|
// Decode fileId from URL-safe base64
|
|
fileIdBytes, err := base64.RawURLEncoding.DecodeString(encodedFileId)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("invalid fileId encoding in chunk file %q: %w", name, err)
|
|
}
|
|
return &TusChunkInfo{
|
|
Offset: offset,
|
|
Size: size,
|
|
FileId: string(fileIdBytes),
|
|
UploadAt: entry.Crtime.UnixNano(),
|
|
}, nil
|
|
}
|
|
|
|
// createTusSession creates a new TUS upload session
|
|
func (fs *FilerServer) createTusSession(ctx context.Context, uploadID, targetPath string, size int64, metadata map[string]string) (*TusSession, error) {
|
|
session := &TusSession{
|
|
ID: uploadID,
|
|
TargetPath: targetPath,
|
|
Size: size,
|
|
Offset: 0,
|
|
Metadata: metadata,
|
|
CreatedAt: time.Now(),
|
|
ExpiresAt: time.Now().Add(7 * 24 * time.Hour), // 7 days default expiration
|
|
Chunks: []*TusChunkInfo{},
|
|
}
|
|
|
|
// Create session directory
|
|
sessionDirPath := util.FullPath(fs.tusSessionPath(uploadID))
|
|
if err := fs.filer.CreateEntry(ctx, &filer.Entry{
|
|
FullPath: sessionDirPath,
|
|
Attr: filer.Attr{
|
|
Mode: os.ModeDir | 0755,
|
|
Crtime: time.Now(),
|
|
Mtime: time.Now(),
|
|
Uid: OS_UID,
|
|
Gid: OS_GID,
|
|
},
|
|
}, nil, false, false, nil, false, fs.filer.MaxFilenameLength); err != nil {
|
|
return nil, fmt.Errorf("create session directory: %w", err)
|
|
}
|
|
|
|
// Save session info
|
|
if err := fs.saveTusSession(ctx, session); err != nil {
|
|
// Cleanup the directory on failure
|
|
fs.filer.DeleteEntryMetaAndData(ctx, sessionDirPath, true, true, false, false, nil, 0)
|
|
return nil, fmt.Errorf("save session info: %w", err)
|
|
}
|
|
|
|
glog.V(2).Infof("Created TUS session %s for %s, size=%d", uploadID, targetPath, size)
|
|
return session, nil
|
|
}
|
|
|
|
// saveTusSession saves the session info to the filer
|
|
func (fs *FilerServer) saveTusSession(ctx context.Context, session *TusSession) error {
|
|
sessionData, err := json.Marshal(session)
|
|
if err != nil {
|
|
return fmt.Errorf("marshal session: %w", err)
|
|
}
|
|
|
|
infoPath := util.FullPath(fs.tusSessionInfoPath(session.ID))
|
|
entry := &filer.Entry{
|
|
FullPath: infoPath,
|
|
Attr: filer.Attr{
|
|
Mode: 0644,
|
|
Crtime: session.CreatedAt,
|
|
Mtime: time.Now(),
|
|
Uid: OS_UID,
|
|
Gid: OS_GID,
|
|
},
|
|
Content: sessionData,
|
|
}
|
|
|
|
if err := fs.filer.CreateEntry(ctx, entry, nil, false, false, nil, false, fs.filer.MaxFilenameLength); err != nil {
|
|
return fmt.Errorf("save session info entry: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// readTusSessionInfo reads and decodes a session's .info file without listing its
|
|
// chunks, the cheap lookup the authorization check needs for the stored TargetPath.
|
|
func (fs *FilerServer) readTusSessionInfo(ctx context.Context, uploadID string) (*TusSession, error) {
|
|
infoPath := util.FullPath(fs.tusSessionInfoPath(uploadID))
|
|
entry, err := fs.filer.FindEntry(ctx, infoPath)
|
|
if err != nil {
|
|
if err == filer_pb.ErrNotFound {
|
|
return nil, fmt.Errorf("TUS upload session not found: %s: %w", uploadID, filer_pb.ErrNotFound)
|
|
}
|
|
return nil, fmt.Errorf("find session: %w", err)
|
|
}
|
|
|
|
var session TusSession
|
|
if err := json.Unmarshal(entry.Content, &session); err != nil {
|
|
return nil, fmt.Errorf("unmarshal session: %w", err)
|
|
}
|
|
return &session, nil
|
|
}
|
|
|
|
// getTusSession retrieves a TUS session by upload ID, including chunks from directory listing
|
|
func (fs *FilerServer) getTusSession(ctx context.Context, uploadID string) (*TusSession, error) {
|
|
session, err := fs.readTusSessionInfo(ctx, uploadID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Load chunks from directory listing with pagination (atomic read, no race condition)
|
|
sessionDirPath := util.FullPath(fs.tusSessionPath(uploadID))
|
|
session.Chunks = nil
|
|
session.Offset = 0
|
|
|
|
lastFileName := ""
|
|
pageSize := 1000
|
|
for {
|
|
entries, hasMore, err := fs.filer.ListDirectoryEntries(ctx, sessionDirPath, lastFileName, false, int64(pageSize), "", "", "")
|
|
if err != nil {
|
|
return nil, fmt.Errorf("list session directory: %w", err)
|
|
}
|
|
|
|
for _, e := range entries {
|
|
if strings.HasPrefix(e.Name(), "chunk_") {
|
|
chunk, parseErr := parseTusChunkPath(e)
|
|
if parseErr != nil {
|
|
glog.V(1).Infof("Skipping invalid chunk file %s: %v", e.Name(), parseErr)
|
|
continue
|
|
}
|
|
session.Chunks = append(session.Chunks, chunk)
|
|
}
|
|
lastFileName = e.Name()
|
|
}
|
|
|
|
if !hasMore || len(entries) < pageSize {
|
|
break
|
|
}
|
|
}
|
|
|
|
// Sort chunks by offset and compute current offset as maximum contiguous range from 0
|
|
if len(session.Chunks) > 0 {
|
|
sort.Slice(session.Chunks, func(i, j int) bool {
|
|
return session.Chunks[i].Offset < session.Chunks[j].Offset
|
|
})
|
|
// Compute the maximum contiguous offset from 0
|
|
// This correctly handles gaps in the upload sequence
|
|
contiguousEnd := int64(0)
|
|
for _, chunk := range session.Chunks {
|
|
if chunk.Offset > contiguousEnd {
|
|
// Gap detected, stop at the first gap
|
|
break
|
|
}
|
|
chunkEnd := chunk.Offset + chunk.Size
|
|
if chunkEnd > contiguousEnd {
|
|
contiguousEnd = chunkEnd
|
|
}
|
|
}
|
|
session.Offset = contiguousEnd
|
|
}
|
|
|
|
return session, nil
|
|
}
|
|
|
|
// saveTusChunk stores the chunk info as a separate file entry
|
|
// This avoids read-modify-write race conditions across multiple filer instances
|
|
// The chunk metadata is encoded in the filename; the entry's Crtime preserves upload time
|
|
func (fs *FilerServer) saveTusChunk(ctx context.Context, uploadID string, chunk *TusChunkInfo) error {
|
|
if chunk == nil {
|
|
return nil
|
|
}
|
|
|
|
// Store chunk info as a separate file entry (atomic operation)
|
|
// Chunk metadata is encoded in the filename; Crtime is used for UploadAt when reading back
|
|
chunkPath := util.FullPath(fs.tusChunkPath(uploadID, chunk.Offset, chunk.Size, chunk.FileId))
|
|
|
|
if err := fs.filer.CreateEntry(ctx, &filer.Entry{
|
|
FullPath: chunkPath,
|
|
Attr: filer.Attr{
|
|
Mode: 0644,
|
|
Crtime: time.Now(),
|
|
Mtime: time.Now(),
|
|
Uid: OS_UID,
|
|
Gid: OS_GID,
|
|
},
|
|
}, nil, false, false, nil, false, fs.filer.MaxFilenameLength); err != nil {
|
|
return fmt.Errorf("save chunk info: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// deleteTusSession removes a TUS upload session and all its data
|
|
func (fs *FilerServer) deleteTusSession(ctx context.Context, uploadID string) error {
|
|
|
|
session, err := fs.getTusSession(ctx, uploadID)
|
|
if err != nil {
|
|
// Session might already be deleted or never existed
|
|
glog.V(1).Infof("TUS session %s not found for deletion: %v", uploadID, err)
|
|
return nil
|
|
}
|
|
|
|
// Batch delete all uploaded chunks from volume servers
|
|
if len(session.Chunks) > 0 {
|
|
var chunksToDelete []*filer_pb.FileChunk
|
|
for _, chunk := range session.Chunks {
|
|
if chunk.FileId != "" {
|
|
chunksToDelete = append(chunksToDelete, &filer_pb.FileChunk{FileId: chunk.FileId})
|
|
}
|
|
}
|
|
if len(chunksToDelete) > 0 {
|
|
fs.filer.DeleteChunks(ctx, util.FullPath(session.TargetPath), chunksToDelete)
|
|
}
|
|
}
|
|
|
|
// Delete the session directory
|
|
sessionDirPath := util.FullPath(fs.tusSessionPath(uploadID))
|
|
if err := fs.filer.DeleteEntryMetaAndData(ctx, sessionDirPath, true, true, false, false, nil, 0); err != nil {
|
|
return fmt.Errorf("delete session directory: %w", err)
|
|
}
|
|
|
|
glog.V(2).Infof("Deleted TUS session %s", uploadID)
|
|
return nil
|
|
}
|
|
|
|
// completeTusUpload assembles all chunks and creates the final file
|
|
func (fs *FilerServer) completeTusUpload(ctx context.Context, session *TusSession) error {
|
|
if session.Offset != session.Size {
|
|
return fmt.Errorf("upload incomplete: offset=%d, expected=%d", session.Offset, session.Size)
|
|
}
|
|
|
|
// Sort chunks by offset to ensure correct order
|
|
sort.Slice(session.Chunks, func(i, j int) bool {
|
|
return session.Chunks[i].Offset < session.Chunks[j].Offset
|
|
})
|
|
|
|
// Validate chunks are contiguous with no gaps or overlaps
|
|
expectedOffset := int64(0)
|
|
for _, chunk := range session.Chunks {
|
|
if chunk.Offset != expectedOffset {
|
|
return fmt.Errorf("chunk gap or overlap detected: expected offset %d, got %d", expectedOffset, chunk.Offset)
|
|
}
|
|
expectedOffset = chunk.Offset + chunk.Size
|
|
}
|
|
if expectedOffset != session.Size {
|
|
return fmt.Errorf("chunks do not cover full file: chunks end at %d, expected %d", expectedOffset, session.Size)
|
|
}
|
|
|
|
// Assemble file chunks in order
|
|
var fileChunks []*filer_pb.FileChunk
|
|
|
|
for _, chunk := range session.Chunks {
|
|
fid, fidErr := filer_pb.ToFileIdObject(chunk.FileId)
|
|
if fidErr != nil {
|
|
return fmt.Errorf("invalid file ID %s at offset %d: %w", chunk.FileId, chunk.Offset, fidErr)
|
|
}
|
|
|
|
fileChunk := &filer_pb.FileChunk{
|
|
FileId: chunk.FileId,
|
|
Offset: chunk.Offset,
|
|
Size: uint64(chunk.Size),
|
|
ModifiedTsNs: chunk.UploadAt,
|
|
Fid: fid,
|
|
}
|
|
fileChunks = append(fileChunks, fileChunk)
|
|
}
|
|
|
|
// Determine content type from metadata
|
|
contentType := ""
|
|
if session.Metadata != nil {
|
|
if ct, ok := session.Metadata["content-type"]; ok {
|
|
contentType = ct
|
|
}
|
|
}
|
|
|
|
// Create the final file entry
|
|
targetPath := util.FullPath(session.TargetPath)
|
|
|
|
// Apply the same read-only / WORM protections the normal write path enforces
|
|
// before landing the entry at the client-chosen target path.
|
|
if fs.filer.FilerConf.MatchStorageRule(string(targetPath)).ReadOnly {
|
|
return fmt.Errorf("%w: %s", ErrReadOnly, targetPath)
|
|
}
|
|
if wormEnforced, err := fs.wormEnforcedForEntry(ctx, string(targetPath)); err != nil {
|
|
return fmt.Errorf("check worm: %w", err)
|
|
} else if wormEnforced {
|
|
return ErrWormEnforced
|
|
}
|
|
|
|
entry := &filer.Entry{
|
|
FullPath: targetPath,
|
|
Attr: filer.Attr{
|
|
Mode: 0644,
|
|
Crtime: session.CreatedAt,
|
|
Mtime: time.Now(),
|
|
Uid: OS_UID,
|
|
Gid: OS_GID,
|
|
Mime: contentType,
|
|
},
|
|
Chunks: fileChunks,
|
|
}
|
|
|
|
// Ensure parent directory exists
|
|
if err := fs.filer.CreateEntry(ctx, entry, nil, false, false, nil, false, fs.filer.MaxFilenameLength); err != nil {
|
|
return fmt.Errorf("create final file entry: %w", err)
|
|
}
|
|
|
|
// Delete the session (but keep the chunks since they're now part of the final file)
|
|
sessionDirPath := util.FullPath(fs.tusSessionPath(session.ID))
|
|
if err := fs.filer.DeleteEntryMetaAndData(ctx, sessionDirPath, true, false, false, false, nil, 0); err != nil {
|
|
glog.V(1).Infof("Failed to cleanup TUS session directory %s: %v", session.ID, err)
|
|
}
|
|
|
|
glog.V(2).Infof("Completed TUS upload %s -> %s, size=%d, chunks=%d",
|
|
session.ID, session.TargetPath, session.Size, len(fileChunks))
|
|
|
|
return nil
|
|
}
|
|
|
|
// StartTusSessionCleanup starts a background goroutine that periodically cleans up expired TUS sessions
|
|
func (fs *FilerServer) StartTusSessionCleanup(interval time.Duration) {
|
|
go func() {
|
|
ticker := time.NewTicker(interval)
|
|
defer ticker.Stop()
|
|
|
|
for range ticker.C {
|
|
fs.cleanupExpiredTusSessions()
|
|
}
|
|
}()
|
|
glog.V(0).Infof("TUS session cleanup started with interval %v", interval)
|
|
}
|
|
|
|
// cleanupExpiredTusSessions scans for and removes expired TUS upload sessions
|
|
func (fs *FilerServer) cleanupExpiredTusSessions() {
|
|
ctx := context.Background()
|
|
uploadsDir := util.FullPath(fs.tusSessionDir())
|
|
|
|
// List all session directories under the TUS uploads folder
|
|
var lastFileName string
|
|
const pageSize = 100
|
|
|
|
for {
|
|
entries, hasMore, err := fs.filer.ListDirectoryEntries(ctx, uploadsDir, lastFileName, false, int64(pageSize), "", "", "")
|
|
if err != nil {
|
|
glog.V(1).Infof("TUS cleanup: failed to list sessions: %v", err)
|
|
return
|
|
}
|
|
|
|
now := time.Now()
|
|
for _, entry := range entries {
|
|
if !entry.IsDirectory() {
|
|
lastFileName = entry.Name()
|
|
continue
|
|
}
|
|
|
|
uploadID := entry.Name()
|
|
session, err := fs.getTusSession(ctx, uploadID)
|
|
if err != nil {
|
|
glog.V(2).Infof("TUS cleanup: skipping session %s: %v", uploadID, err)
|
|
lastFileName = uploadID
|
|
continue
|
|
}
|
|
|
|
if !session.ExpiresAt.IsZero() && now.After(session.ExpiresAt) {
|
|
glog.V(1).Infof("TUS cleanup: removing expired session %s (expired at %v)", uploadID, session.ExpiresAt)
|
|
if err := fs.deleteTusSession(ctx, uploadID); err != nil {
|
|
glog.V(1).Infof("TUS cleanup: failed to delete session %s: %v", uploadID, err)
|
|
}
|
|
}
|
|
|
|
lastFileName = uploadID
|
|
}
|
|
|
|
if !hasMore || len(entries) < pageSize {
|
|
break
|
|
}
|
|
}
|
|
}
|