mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-17 19:48:35 +02:00
Chris Lu
a5ccefb661
* filer: escape LIKE wildcards in SQL list prefixes ListDirectoryPrefixedEntries bound prefix+"%" straight into a LIKE clause, so '_' and '%' in object names (e.g. Langfuse keys like call_03_...) acted as wildcards: wrong results and a ~40x slower range scan because (dirhash, name) can no longer be narrowed. Escape '!'/'%'/'_' in the prefix and declare ESCAPE '!' in the generated list SQL so every abstract_sql backend (mysql, mysql2, postgres, postgres2, sqlite) matches literally with identical semantics. '!' is used instead of '\' because SQLite shares SqlGenMysql but would reject the MySQL-style '\\' literal, and '\' would still need escaping itself. * filer: escape LIKE wildcards in YDB list prefixes Same wildcard-in-prefix bug as the abstract_sql backends: YQL LIKE treated '_' and '%' in the prefix as wildcards. Apply the shared LikePattern helper and declare ESCAPE '!' (YQL allows any escape char except '%', '_' and '\'). * test: cover literal '_'/'%'/'!' prefixes in sqlite filer listing End-to-end regression test through SqliteStore against a real database; runs in CI under the sqlite build tag.
91 lines
3.0 KiB
Go
91 lines
3.0 KiB
Go
package mysql
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestDefaultUpsertQueryUsesOnDuplicateKey(t *testing.T) {
|
|
gen := &SqlGenMysql{UpsertQueryTemplate: DefaultUpsertQuery}
|
|
got := gen.GetSqlInsert("filemeta")
|
|
if !strings.Contains(got, "ON DUPLICATE KEY UPDATE") {
|
|
t.Fatalf("expected ON DUPLICATE KEY UPDATE in default upsert, got: %s", got)
|
|
}
|
|
if strings.Contains(got, "AS `new`") {
|
|
t.Fatalf("default should avoid MySQL 8.0.19 row-alias syntax for MariaDB compat, got: %s", got)
|
|
}
|
|
if !strings.Contains(got, "`filemeta`") {
|
|
t.Fatalf("expected backticked table name, got: %s", got)
|
|
}
|
|
}
|
|
|
|
func TestDefaultCreateTableQueryRendersValidSql(t *testing.T) {
|
|
gen := &SqlGenMysql{CreateTableSqlTemplate: DefaultCreateTableQuery}
|
|
got := gen.GetSqlCreateTable("filemeta")
|
|
if strings.Contains(got, "%!") {
|
|
t.Fatalf("template rendered to malformed SQL, got: %s", got)
|
|
}
|
|
if !strings.Contains(got, "`filemeta`") {
|
|
t.Fatalf("expected backticked table name, got: %s", got)
|
|
}
|
|
}
|
|
|
|
func TestEmptyUpsertTemplateFallsBackToPlainInsert(t *testing.T) {
|
|
gen := &SqlGenMysql{}
|
|
got := gen.GetSqlInsert("filemeta")
|
|
if strings.Contains(got, "ON DUPLICATE KEY UPDATE") {
|
|
t.Fatalf("plain INSERT path should not contain ON DUPLICATE KEY UPDATE, got: %s", got)
|
|
}
|
|
}
|
|
|
|
func TestListSqlDefaultOrderingFollowsColumn(t *testing.T) {
|
|
gen := &SqlGenMysql{}
|
|
for _, got := range []string{gen.GetSqlListExclusive("filemeta"), gen.GetSqlListInclusive("filemeta")} {
|
|
if strings.Contains(got, "BINARY") {
|
|
t.Fatalf("default list query should not force BINARY, got: %s", got)
|
|
}
|
|
if !strings.Contains(got, "ORDER BY `name` ASC") {
|
|
t.Fatalf("expected plain name ordering, got: %s", got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestListSqlBinaryOrderingOnNonBinaryColumn(t *testing.T) {
|
|
gen := &SqlGenMysql{ForceBinaryCollation: true}
|
|
for _, got := range []string{gen.GetSqlListExclusive("filemeta"), gen.GetSqlListInclusive("filemeta")} {
|
|
if !strings.Contains(got, "ORDER BY BINARY `name` ASC") {
|
|
t.Fatalf("expected BINARY ordering, got: %s", got)
|
|
}
|
|
if !strings.Contains(got, "BINARY `name` LIKE ?") {
|
|
t.Fatalf("expected BINARY prefix filter, got: %s", got)
|
|
}
|
|
if strings.Contains(got, "AND `name` > ?") || strings.Contains(got, "AND `name` >= ?") {
|
|
t.Fatalf("pagination comparison must also be BINARY, got: %s", got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestListSqlEscapesLikeWildcards(t *testing.T) {
|
|
gen := &SqlGenMysql{}
|
|
for _, got := range []string{gen.GetSqlListExclusive("filemeta"), gen.GetSqlListInclusive("filemeta")} {
|
|
if !strings.Contains(got, "LIKE ? ESCAPE '!'") {
|
|
t.Fatalf("list query must declare the escape char matching LikePattern, got: %s", got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestIsBinaryCollation(t *testing.T) {
|
|
binary := []string{"", "binary", "utf8mb4_bin", "utf8mb3_bin", "latin1_bin", "UTF8MB4_BIN"}
|
|
for _, c := range binary {
|
|
if !isBinaryCollation(c) {
|
|
t.Fatalf("expected %q to be treated as binary", c)
|
|
}
|
|
}
|
|
ci := []string{"utf8mb4_general_ci", "utf8mb3_general_ci", "utf8mb4_0900_ai_ci", "latin1_swedish_ci"}
|
|
for _, c := range ci {
|
|
if isBinaryCollation(c) {
|
|
t.Fatalf("expected %q to be treated as non-binary", c)
|
|
}
|
|
}
|
|
}
|