mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-08 15:41:15 +02:00
* Add GitHub Actions workflow for codespell on master * Add rudimentary codespell config * Tune codespell config: skip generated code, ignore camelCase, whitelist domain terms Add camelCase/PascalCase regex to ignore common Go/Rust/JS identifiers like allLocations, publishErr, ReadInside, FlushInterval. Also skip templ-generated *_templ.go files, and whitelist a handful of short/domain-specific words (visibles, fo, te, ser, bject, unparseable, keep-alives, tread, anc, ue) that show up as false positives across the tree. Co-Authored-By: Claude Code 2.1.217 / Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Fix ambiguous typos and protect false positives Fixes typos that codespell reports with multiple candidate suggestions (so `codespell -w` cannot auto-apply them), plus one inline pragma and one config entry to protect legitimate identifiers. Manual fixes (single correct answer chosen from context): - pattens -> patterns (5x) in filer/upload/shell flag help strings - finded -> found (2x) in tarantool storage.lua comment - spacify -> specify (2x) in helm chart values.yaml comment - wether -> whether in skiplist.go docstring - simpe -> simple in mq schema test case name False-positive protection: - Add `//codespell:ignore` next to `source GET's` (possessive of HTTP verb) in s3api_object_handlers_copy_stream.go - Whitelist `auther` in .codespellrc — it's a local variable meaning "authenticator" in weed/security/tls.go, not a typo of "author". Co-Authored-By: Claude Code 2.1.217 / Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Extend codespell ignore list: .git-meta path and thirdparty groupId Also skip `.git-meta` (scratch dir for commit messages that may contain typo words verbatim) and whitelist `thirdparty` — it appears as the literal Maven groupId `org.apache.hadoop.thirdparty` in hdfs3 poms and cannot be renamed. Co-Authored-By: Claude Code 2.1.217 / Claude Opus 4.7 (1M context) <noreply@anthropic.com> * [DATALAD RUNCMD] Fix non-ambiguous typos with codespell -w Auto-applied fixes to the 44 remaining single-suggestion typos across docs, comments, log messages, tests, config, and one Java pom. === Do not change lines below === { "chain": [], "cmd": "uvx codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^ * Revert breaking codespell fixes; whitelist unknwon and atleast Two of the auto-applied `codespell -w` fixes were false positives that would break the build/tests: - go.mod: `github.com/unknwon/goconfig` is a real Go module path — the upstream author's GitHub handle is literally `unknwon`. Renaming to `unknown` would fail dependency resolution. - test/benchmark/fuse_db/bin/{sqlite_verify.py,run_mysql.sh,run_sqlite.sh}: `atleast` is a literal CLI mode value (a string constant compared and passed as a positional argument). Rewriting to `at least` splits it into two arguments and breaks the mode check. Reverted those files and whitelisted both words in .codespellrc so future runs won't re-suggest the same broken fixes. Co-Authored-By: Claude Code 2.1.217 / Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Code 2.1.217 / Claude Opus 4.7 (1M context) <noreply@anthropic.com>
141 lines
4.1 KiB
Go
141 lines
4.1 KiB
Go
package filer
|
|
|
|
import (
|
|
"bytes"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
)
|
|
|
|
// onMetadataChangeEvent is triggered after filer processed change events from local or remote filers
|
|
func (f *Filer) onMetadataChangeEvent(event *filer_pb.SubscribeMetadataResponse) {
|
|
f.maybeReloadFilerConfiguration(event)
|
|
f.maybeReloadRemoteStorageConfigurationAndMapping(event)
|
|
f.onBucketEvents(event)
|
|
f.onEmptyFolderCleanupEvents(event)
|
|
}
|
|
|
|
func (f *Filer) onBucketEvents(event *filer_pb.SubscribeMetadataResponse) {
|
|
message := event.EventNotification
|
|
oldDir := event.Directory
|
|
newDir := filer_pb.MetadataEventTargetDirectory(event)
|
|
|
|
if filer_pb.IsCreate(event) {
|
|
if newDir == f.DirBucketsPath && message.NewEntry.IsDirectory {
|
|
f.Store.OnBucketCreation(message.NewEntry.Name)
|
|
}
|
|
}
|
|
if filer_pb.IsDelete(event) {
|
|
if oldDir == f.DirBucketsPath && message.OldEntry.IsDirectory {
|
|
f.Store.OnBucketDeletion(message.OldEntry.Name)
|
|
}
|
|
}
|
|
if filer_pb.IsRename(event) {
|
|
if oldDir == f.DirBucketsPath && message.OldEntry.IsDirectory {
|
|
f.Store.OnBucketDeletion(message.OldEntry.Name)
|
|
}
|
|
if newDir == f.DirBucketsPath && message.NewEntry.IsDirectory {
|
|
f.Store.OnBucketCreation(message.NewEntry.Name)
|
|
}
|
|
}
|
|
}
|
|
|
|
// onEmptyFolderCleanupEvents handles create/delete events for empty folder cleanup
|
|
func (f *Filer) onEmptyFolderCleanupEvents(event *filer_pb.SubscribeMetadataResponse) {
|
|
if f.EmptyFolderCleaner == nil || !f.EmptyFolderCleaner.IsEnabled() {
|
|
return
|
|
}
|
|
|
|
message := event.EventNotification
|
|
directory := event.Directory
|
|
eventTime := time.Unix(0, event.TsNs)
|
|
|
|
// Handle delete events - trigger folder cleanup check
|
|
if filer_pb.IsDelete(event) && message.OldEntry != nil {
|
|
f.EmptyFolderCleaner.OnDeleteEvent(directory, message.OldEntry.Name, message.OldEntry.IsDirectory, eventTime)
|
|
}
|
|
|
|
// Handle create events - cancel pending cleanup for the folder
|
|
if filer_pb.IsCreate(event) && message.NewEntry != nil {
|
|
f.EmptyFolderCleaner.OnCreateEvent(directory, message.NewEntry.Name, message.NewEntry.IsDirectory)
|
|
}
|
|
|
|
// Handle rename/move events
|
|
if filer_pb.IsRename(event) {
|
|
// Treat the old location as a delete
|
|
if message.OldEntry != nil {
|
|
f.EmptyFolderCleaner.OnDeleteEvent(directory, message.OldEntry.Name, message.OldEntry.IsDirectory, eventTime)
|
|
}
|
|
// Treat the new location as a create
|
|
if message.NewEntry != nil {
|
|
newDir := message.NewParentPath
|
|
if newDir == "" {
|
|
newDir = directory
|
|
}
|
|
f.EmptyFolderCleaner.OnCreateEvent(newDir, message.NewEntry.Name, message.NewEntry.IsDirectory)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (f *Filer) maybeReloadFilerConfiguration(event *filer_pb.SubscribeMetadataResponse) {
|
|
if !filer_pb.MetadataEventTouchesDirectory(event, DirectoryEtcSeaweedFS) {
|
|
return
|
|
}
|
|
|
|
entry := event.EventNotification.NewEntry
|
|
if entry == nil {
|
|
return
|
|
}
|
|
|
|
glog.V(0).Infof("processing %v", event)
|
|
if entry.Name == FilerConfName {
|
|
f.reloadFilerConfiguration(entry)
|
|
}
|
|
}
|
|
|
|
func (f *Filer) readEntry(chunks []*filer_pb.FileChunk, size uint64) ([]byte, error) {
|
|
var buf bytes.Buffer
|
|
err := StreamContent(f.MasterClient, &buf, chunks, 0, int64(size))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return buf.Bytes(), nil
|
|
}
|
|
|
|
func (f *Filer) reloadFilerConfiguration(entry *filer_pb.Entry) {
|
|
fc := NewFilerConf()
|
|
err := fc.loadFromChunks(f, entry.Content, entry.GetChunks(), FileSize(entry))
|
|
if err != nil {
|
|
glog.Errorf("read filer conf chunks: %v", err)
|
|
return
|
|
}
|
|
f.FilerConf = fc
|
|
}
|
|
|
|
func (f *Filer) LoadFilerConf() {
|
|
fc := NewFilerConf()
|
|
err := util.Retry("loadFilerConf", func() error {
|
|
return fc.loadFromFiler(f)
|
|
})
|
|
if err != nil {
|
|
glog.Errorf("read filer conf: %v", err)
|
|
return
|
|
}
|
|
f.FilerConf = fc
|
|
}
|
|
|
|
// //////////////////////////////////
|
|
// load and maintain remote storages
|
|
// //////////////////////////////////
|
|
func (f *Filer) LoadRemoteStorageConfAndMapping() {
|
|
if err := f.RemoteStorage.LoadRemoteStorageConfigurationsAndMapping(f); err != nil {
|
|
glog.Errorf("read remote conf and mapping: %v", err)
|
|
return
|
|
}
|
|
}
|
|
func (f *Filer) maybeReloadRemoteStorageConfigurationAndMapping(event *filer_pb.SubscribeMetadataResponse) {
|
|
// FIXME add reloading
|
|
}
|