mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-14 18:40:48 +02:00
Chris Lu
49a7d4ff6a
Three from review. The client's dependencies were unpinned, so an unrelated upstream release could change what an old commit reproduces. Pinned to the versions this suite was verified against; the client is as much the thing under test as the server. The search was called ANN and was not: without an index LanceDB scans. The test now builds an IVF_PQ index over 1024 rows first, which is worth more than the wording fix - an index writes into a directory of the table that the S3 door has to admit, and that guard has refused a Lance directory before. It builds, covers all 1024 rows, and searches. The assertion moved with it. Demanding the exact nearest neighbour was right for a brute-force scan and wrong for a quantized index, which answered 0 as readily as 1; both are correct, so the check is now the neighbourhood. And the pushdown check accepted any failure. It now requires the refusal to be the catalog's Unsupported and requires that nothing was left behind, or, when the client falls back, that the table is complete. Claude-Session: https://claude.ai/code/session_01Rkp1Mw5E89Jp6dzJFYiMrm