Files
seaweedfs/weed/storage/needle_map_metric.go
T
Chris Lu ab559bca76 storage: hash index-metric bloom filter with xxhash
The reverse index walk dedupes seen NeedleIds with a BoomFilters bloom
filter. Its default kernel is FNV-1, whose final step only XORs the last
input byte into the hash's low bits, so keys sharing the high 7 bytes of
a big-endian NeedleId land on correlated probe positions and false
positives arrive in bursts of hundreds instead of the ~0.001 target
rate. Each false positive hides a live-latest key and inflates the
rebuilt deletion counters, which is what made
TestFastLoadingNeedleMapMetrics flake past its +256 bound in CI
(observed DeletedCount drift of 267).

Swap the kernel for xxhash, which fully diffuses the key bytes; the
observed false-positive count in 300 local runs of the test drops to
max 2 (avg 0.23).
2026-10-19 01:47:25 -07:00

241 lines
7.1 KiB
Go

package storage
import (
"fmt"
"io"
"os"
"sync/atomic"
"github.com/cespare/xxhash/v2"
"github.com/seaweedfs/seaweedfs/weed/storage/idx"
"github.com/seaweedfs/seaweedfs/weed/storage/needle"
. "github.com/seaweedfs/seaweedfs/weed/storage/types"
boom "github.com/tylertreat/BoomFilters"
)
type mapMetric struct {
DeletionCounter uint32 `json:"DeletionCounter"`
FileCounter uint32 `json:"FileCounter"`
DeletionByteCounter uint64 `json:"DeletionByteCounter"`
FileByteCounter uint64 `json:"FileByteCounter"`
MaximumFileKey uint64 `json:"MaxFileKey"`
// MaximumNeedleEnd is the largest (offset.ToActualOffset() +
// GetActualSize(size, version)) seen during the index walk. It is used
// at volume load to verify that no .idx entry references bytes past
// the end of the .dat — the deeper-than-tail corruption shape from
// issue #8928 — without paying for a second linear scan of the index.
MaximumNeedleEnd int64 `json:"MaxNeedleEnd"`
}
type batchMapMetricSnapshot struct {
deletionCounter uint32
fileCounter uint32
deletionByteCounter uint64
fileByteCounter uint64
maximumFileKey uint64
maximumNeedleEnd int64
}
func (mm *mapMetric) snapshotBatchMetrics() batchMapMetricSnapshot {
return batchMapMetricSnapshot{
deletionCounter: atomic.LoadUint32(&mm.DeletionCounter),
fileCounter: atomic.LoadUint32(&mm.FileCounter),
deletionByteCounter: atomic.LoadUint64(&mm.DeletionByteCounter),
fileByteCounter: atomic.LoadUint64(&mm.FileByteCounter),
maximumFileKey: atomic.LoadUint64(&mm.MaximumFileKey),
maximumNeedleEnd: atomic.LoadInt64(&mm.MaximumNeedleEnd),
}
}
func (mm *mapMetric) restoreBatchMetrics(snapshot batchMapMetricSnapshot) {
atomic.StoreUint32(&mm.DeletionCounter, snapshot.deletionCounter)
atomic.StoreUint32(&mm.FileCounter, snapshot.fileCounter)
atomic.StoreUint64(&mm.DeletionByteCounter, snapshot.deletionByteCounter)
atomic.StoreUint64(&mm.FileByteCounter, snapshot.fileByteCounter)
atomic.StoreUint64(&mm.MaximumFileKey, snapshot.maximumFileKey)
atomic.StoreInt64(&mm.MaximumNeedleEnd, snapshot.maximumNeedleEnd)
}
func (mm *mapMetric) logDelete(deletedByteCount Size) {
if mm == nil {
return
}
mm.LogDeletionCounter(deletedByteCount)
}
func (mm *mapMetric) logPut(key NeedleId, oldSize Size, newSize Size) {
if mm == nil {
return
}
mm.MaybeSetMaxFileKey(key)
mm.LogFileCounter(newSize)
if oldSize > 0 && oldSize.IsValid() {
mm.LogDeletionCounter(oldSize)
}
}
func (mm *mapMetric) LogFileCounter(newSize Size) {
if mm == nil {
return
}
atomic.AddUint32(&mm.FileCounter, 1)
atomic.AddUint64(&mm.FileByteCounter, uint64(newSize))
}
func (mm *mapMetric) LogDeletionCounter(oldSize Size) {
if mm == nil {
return
}
if oldSize > 0 {
atomic.AddUint32(&mm.DeletionCounter, 1)
atomic.AddUint64(&mm.DeletionByteCounter, uint64(oldSize))
}
}
func (mm *mapMetric) ContentSize() uint64 {
if mm == nil {
return 0
}
return atomic.LoadUint64(&mm.FileByteCounter)
}
func (mm *mapMetric) DeletedSize() uint64 {
if mm == nil {
return 0
}
return atomic.LoadUint64(&mm.DeletionByteCounter)
}
func (mm *mapMetric) FileCount() int {
if mm == nil {
return 0
}
return int(atomic.LoadUint32(&mm.FileCounter))
}
func (mm *mapMetric) DeletedCount() int {
if mm == nil {
return 0
}
return int(atomic.LoadUint32(&mm.DeletionCounter))
}
func (mm *mapMetric) MaxFileKey() NeedleId {
if mm == nil {
return 0
}
t := uint64(mm.MaximumFileKey)
return Uint64ToNeedleId(t)
}
func (mm *mapMetric) MaybeSetMaxFileKey(key NeedleId) {
if mm == nil {
return
}
if key > mm.MaxFileKey() {
atomic.StoreUint64(&mm.MaximumFileKey, uint64(key))
}
}
// MaybeSetMaxNeedleEnd updates MaximumNeedleEnd if the supplied entry's
// (offset + actual size) is larger than what we have seen so far. Skips
// deleted/zero-offset entries because they don't reserve space in .dat.
func (mm *mapMetric) MaybeSetMaxNeedleEnd(offset Offset, size Size, version needle.Version) {
if mm == nil || offset.IsZero() || !size.IsValid() {
return
}
end := offset.ToActualOffset() + needle.GetActualSize(size, version)
if end > atomic.LoadInt64(&mm.MaximumNeedleEnd) {
atomic.StoreInt64(&mm.MaximumNeedleEnd, end)
}
}
func (mm *mapMetric) MaxNeedleEnd() int64 {
if mm == nil {
return 0
}
return atomic.LoadInt64(&mm.MaximumNeedleEnd)
}
func needleMapMetricFromIndexFile(r *os.File, mm *mapMetric, version needle.Version) error {
var bf *boom.BloomFilter
buf := make([]byte, NeedleIdSize)
var liveKeyCount uint32
var liveKeyBytes uint64
err := reverseWalkIndexFile(r, func(entryCount int64) {
bf = boom.NewBloomFilter(uint(entryCount), 0.001)
// The default FNV-1 kernel leaves the last byte of a big-endian
// NeedleId as the final XOR, so keys in the same 256-block get
// correlated probe positions and false positives arrive in bursts
// of hundreds. xxhash diffuses the input fully and keeps the
// observed rate near the 0.001 target.
bf.SetHash(xxhash.New())
}, func(key NeedleId, offset Offset, size Size) error {
mm.MaybeSetMaxFileKey(key)
mm.MaybeSetMaxNeedleEnd(offset, size, version)
NeedleIdToBytes(buf, key)
seen := bf.TestAndAdd(buf)
if offset.IsZero() || size.IsDeleted() {
return nil
}
mm.FileCounter++
mm.FileByteCounter += uint64(size)
if !seen {
liveKeyCount++
liveKeyBytes += uint64(size)
}
return nil
})
if err != nil {
return err
}
// Runtime counters tally each live-key removal: an overwrite deletes the
// superseded row and a tombstone deletes the live row. Replaying forward,
// that is (file rows) - (keys whose latest row is live).
mm.DeletionCounter = mm.FileCounter - liveKeyCount
mm.DeletionByteCounter = mm.FileByteCounter - liveKeyBytes
return nil
}
func newNeedleMapMetricFromIndexFile(r *os.File, version needle.Version) (mm *mapMetric, err error) {
mm = &mapMetric{}
err = needleMapMetricFromIndexFile(r, mm, version)
return
}
func reverseWalkIndexFile(r *os.File, initFn func(entryCount int64), fn func(key NeedleId, offset Offset, size Size) error) error {
fi, err := r.Stat()
if err != nil {
return fmt.Errorf("file %s stat error: %v", r.Name(), err)
}
fileSize := fi.Size()
if fileSize%NeedleMapEntrySize != 0 {
return fmt.Errorf("unexpected file %s size: %d", r.Name(), fileSize)
}
entryCount := fileSize / NeedleMapEntrySize
initFn(entryCount)
batchSize := int64(1024 * 4)
bytes := make([]byte, NeedleMapEntrySize*batchSize)
nextBatchSize := entryCount % batchSize
if nextBatchSize == 0 {
nextBatchSize = batchSize
}
remainingCount := entryCount - nextBatchSize
for remainingCount >= 0 {
n, e := r.ReadAt(bytes[:NeedleMapEntrySize*nextBatchSize], NeedleMapEntrySize*remainingCount)
// glog.V(0).Infoln("file", r.Name(), "readerOffset", NeedleMapEntrySize*remainingCount, "count", count, "e", e)
if e == io.EOF && n == int(NeedleMapEntrySize*nextBatchSize) {
e = nil
}
if e != nil {
return e
}
for i := int(nextBatchSize) - 1; i >= 0; i-- {
key, offset, size := idx.IdxFileEntry(bytes[i*NeedleMapEntrySize : i*NeedleMapEntrySize+NeedleMapEntrySize])
if e = fn(key, offset, size); e != nil {
return e
}
}
nextBatchSize = batchSize
remainingCount -= nextBatchSize
}
return nil
}