mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-10 08:30:47 +02:00
chrislu
fe41380d51
Implements comprehensive DDL support for MQ topic management: New Components: - Real MQ broker connectivity via BrokerClient - CREATE TABLE → ConfigureTopic gRPC calls - DROP TABLE → DeleteTopic operations - DESCRIBE table → Schema introspection - SQL type mapping (SQL ↔ MQ schema types) Enhanced Features: - Live topic discovery from MQ broker - Fallback to cached/sample data when broker unavailable - MySQL-compatible DESCRIBE output - Schema validation and error handling - CREATE TABLE with column definitions Key Infrastructure: - broker_client.go: gRPC communication with MQ broker - sql_types.go: Bidirectional SQL/MQ type conversion - describe.go: Table schema introspection - Enhanced engine.go: Full DDL routing and execution Supported SQL Operations: ✅ SHOW DATABASES, SHOW TABLES (live + fallback) ✅ CREATE TABLE table_name (col1 INT, col2 VARCHAR(50), ...) ✅ DROP TABLE table_name ✅ DESCRIBE table_name / SHOW COLUMNS FROM table_name Known Limitations: - SQL parser issues with reserved keywords (e.g., 'timestamp') - Requires running MQ broker for full functionality - ALTER TABLE not yet implemented - DeleteTopic method needs broker-side implementation Architecture Decisions: - Broker discovery via filer lock mechanism (same as shell commands) - Graceful fallback when broker unavailable - ConfigureTopic for CREATE TABLE with 6 default partitions - Schema versioning ready for ALTER TABLE support Testing: - Unit tests updated with filer address parameter - Integration tests for DDL operations - Error handling for connection failures Next Phase: SELECT query execution with Parquet scanning
96 lines
2.3 KiB
Go
96 lines
2.3 KiB
Go
package engine
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
)
|
|
|
|
func TestSQLEngine_ShowDatabases(t *testing.T) {
|
|
engine := NewSQLEngine("localhost:8888")
|
|
|
|
result, err := engine.ExecuteSQL(context.Background(), "SHOW DATABASES")
|
|
if err != nil {
|
|
t.Fatalf("Expected no error, got %v", err)
|
|
}
|
|
|
|
if result.Error != nil {
|
|
t.Fatalf("Expected no query error, got %v", result.Error)
|
|
}
|
|
|
|
if len(result.Columns) != 1 || result.Columns[0] != "Database" {
|
|
t.Errorf("Expected column 'Database', got %v", result.Columns)
|
|
}
|
|
|
|
if len(result.Rows) == 0 {
|
|
t.Error("Expected at least one database, got none")
|
|
}
|
|
|
|
// Should have sample databases: default, analytics, logs
|
|
expectedDatabases := map[string]bool{
|
|
"default": false, "analytics": false, "logs": false,
|
|
}
|
|
|
|
for _, row := range result.Rows {
|
|
if len(row) > 0 {
|
|
dbName := row[0].ToString()
|
|
if _, exists := expectedDatabases[dbName]; exists {
|
|
expectedDatabases[dbName] = true
|
|
}
|
|
}
|
|
}
|
|
|
|
for db, found := range expectedDatabases {
|
|
if !found {
|
|
t.Errorf("Expected to find database '%s'", db)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSQLEngine_ShowTables(t *testing.T) {
|
|
engine := NewSQLEngine("localhost:8888")
|
|
|
|
result, err := engine.ExecuteSQL(context.Background(), "SHOW TABLES")
|
|
if err != nil {
|
|
t.Fatalf("Expected no error, got %v", err)
|
|
}
|
|
|
|
if result.Error != nil {
|
|
t.Fatalf("Expected no query error, got %v", result.Error)
|
|
}
|
|
|
|
if len(result.Columns) != 1 || result.Columns[0] != "Tables_in_default" {
|
|
t.Errorf("Expected column 'Tables_in_default', got %v", result.Columns)
|
|
}
|
|
|
|
if len(result.Rows) == 0 {
|
|
t.Error("Expected at least one table, got none")
|
|
}
|
|
}
|
|
|
|
func TestSQLEngine_ParseError(t *testing.T) {
|
|
engine := NewSQLEngine("localhost:8888")
|
|
|
|
result, err := engine.ExecuteSQL(context.Background(), "INVALID SQL")
|
|
if err == nil {
|
|
t.Error("Expected parse error for invalid SQL")
|
|
}
|
|
|
|
if result.Error == nil {
|
|
t.Error("Expected result error for invalid SQL")
|
|
}
|
|
}
|
|
|
|
func TestSQLEngine_UnsupportedStatement(t *testing.T) {
|
|
engine := NewSQLEngine("localhost:8888")
|
|
|
|
// INSERT is not yet implemented
|
|
result, err := engine.ExecuteSQL(context.Background(), "INSERT INTO test VALUES (1)")
|
|
if err == nil {
|
|
t.Error("Expected error for unsupported statement")
|
|
}
|
|
|
|
if result.Error == nil {
|
|
t.Error("Expected result error for unsupported statement")
|
|
}
|
|
}
|