mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-08 23:50:43 +02:00
Implements comprehensive DDL support for MQ topic management: New Components: - Real MQ broker connectivity via BrokerClient - CREATE TABLE → ConfigureTopic gRPC calls - DROP TABLE → DeleteTopic operations - DESCRIBE table → Schema introspection - SQL type mapping (SQL ↔ MQ schema types) Enhanced Features: - Live topic discovery from MQ broker - Fallback to cached/sample data when broker unavailable - MySQL-compatible DESCRIBE output - Schema validation and error handling - CREATE TABLE with column definitions Key Infrastructure: - broker_client.go: gRPC communication with MQ broker - sql_types.go: Bidirectional SQL/MQ type conversion - describe.go: Table schema introspection - Enhanced engine.go: Full DDL routing and execution Supported SQL Operations: ✅ SHOW DATABASES, SHOW TABLES (live + fallback) ✅ CREATE TABLE table_name (col1 INT, col2 VARCHAR(50), ...) ✅ DROP TABLE table_name ✅ DESCRIBE table_name / SHOW COLUMNS FROM table_name Known Limitations: - SQL parser issues with reserved keywords (e.g., 'timestamp') - Requires running MQ broker for full functionality - ALTER TABLE not yet implemented - DeleteTopic method needs broker-side implementation Architecture Decisions: - Broker discovery via filer lock mechanism (same as shell commands) - Graceful fallback when broker unavailable - ConfigureTopic for CREATE TABLE with 6 default partitions - Schema versioning ready for ALTER TABLE support Testing: - Unit tests updated with filer address parameter - Integration tests for DDL operations - Error handling for connection failures Next Phase: SELECT query execution with Parquet scanning
124 lines
3.2 KiB
Go
124 lines
3.2 KiB
Go
package engine
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestSQLEngine_SelectBasic(t *testing.T) {
|
|
engine := NewSQLEngine("localhost:8888")
|
|
|
|
// Test SELECT * FROM table
|
|
result, err := engine.ExecuteSQL(context.Background(), "SELECT * FROM user_events")
|
|
if err != nil {
|
|
t.Fatalf("Expected no error, got %v", err)
|
|
}
|
|
|
|
if result.Error != nil {
|
|
t.Fatalf("Expected no query error, got %v", result.Error)
|
|
}
|
|
|
|
if len(result.Columns) == 0 {
|
|
t.Error("Expected columns in result")
|
|
}
|
|
|
|
if len(result.Rows) == 0 {
|
|
t.Error("Expected rows in result")
|
|
}
|
|
|
|
// Should have sample data with 3 columns
|
|
expectedColumns := []string{"user_id", "event_type", "data"}
|
|
if len(result.Columns) != len(expectedColumns) {
|
|
t.Errorf("Expected %d columns, got %d", len(expectedColumns), len(result.Columns))
|
|
}
|
|
|
|
// Should have 3 sample rows
|
|
if len(result.Rows) != 3 {
|
|
t.Errorf("Expected 3 rows, got %d", len(result.Rows))
|
|
}
|
|
}
|
|
|
|
func TestSQLEngine_SelectWithLimit(t *testing.T) {
|
|
engine := NewSQLEngine("localhost:8888")
|
|
|
|
// Test SELECT with LIMIT
|
|
result, err := engine.ExecuteSQL(context.Background(), "SELECT * FROM user_events LIMIT 2")
|
|
if err != nil {
|
|
t.Fatalf("Expected no error, got %v", err)
|
|
}
|
|
|
|
if result.Error != nil {
|
|
t.Fatalf("Expected no query error, got %v", result.Error)
|
|
}
|
|
|
|
// Should have exactly 2 rows due to LIMIT
|
|
if len(result.Rows) != 2 {
|
|
t.Errorf("Expected 2 rows with LIMIT 2, got %d", len(result.Rows))
|
|
}
|
|
}
|
|
|
|
func TestSQLEngine_SelectSpecificColumns(t *testing.T) {
|
|
engine := NewSQLEngine("localhost:8888")
|
|
|
|
// Test SELECT specific columns (this will fall back to sample data)
|
|
result, err := engine.ExecuteSQL(context.Background(), "SELECT user_id, event_type FROM user_events")
|
|
if err != nil {
|
|
t.Fatalf("Expected no error, got %v", err)
|
|
}
|
|
|
|
if result.Error != nil {
|
|
t.Fatalf("Expected no query error, got %v", result.Error)
|
|
}
|
|
|
|
// Should have all columns for now (sample data doesn't implement projection yet)
|
|
if len(result.Columns) == 0 {
|
|
t.Error("Expected columns in result")
|
|
}
|
|
}
|
|
|
|
func TestSQLEngine_SelectFromNonExistentTable(t *testing.T) {
|
|
engine := NewSQLEngine("localhost:8888")
|
|
|
|
// Test SELECT from non-existent table
|
|
result, _ := engine.ExecuteSQL(context.Background(), "SELECT * FROM nonexistent_table")
|
|
if result.Error == nil {
|
|
t.Error("Expected error for non-existent table")
|
|
}
|
|
|
|
if !strings.Contains(result.Error.Error(), "not found") {
|
|
t.Errorf("Expected 'not found' error, got: %v", result.Error)
|
|
}
|
|
}
|
|
|
|
func TestSQLEngine_SelectDifferentTables(t *testing.T) {
|
|
engine := NewSQLEngine("localhost:8888")
|
|
|
|
// Test different sample tables
|
|
tables := []string{"user_events", "system_logs"}
|
|
|
|
for _, tableName := range tables {
|
|
result, err := engine.ExecuteSQL(context.Background(), fmt.Sprintf("SELECT * FROM %s", tableName))
|
|
if err != nil {
|
|
t.Errorf("Error querying table %s: %v", tableName, err)
|
|
continue
|
|
}
|
|
|
|
if result.Error != nil {
|
|
t.Errorf("Query error for table %s: %v", tableName, result.Error)
|
|
continue
|
|
}
|
|
|
|
if len(result.Columns) == 0 {
|
|
t.Errorf("No columns returned for table %s", tableName)
|
|
}
|
|
|
|
if len(result.Rows) == 0 {
|
|
t.Errorf("No rows returned for table %s", tableName)
|
|
}
|
|
|
|
t.Logf("Table %s: %d columns, %d rows", tableName, len(result.Columns), len(result.Rows))
|
|
}
|
|
}
|