mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-11-15 08:18:42 +01:00
* s3 sink: forward user metadata to the destination object filer.backup and filer.sync to an S3 sink copied the object body and tags but dropped the X-Amz-Meta- attributes the S3 gateway stores with each object, so the destination object came back without its user metadata. Send them as the upload's metadata, keyed by the lowercased suffix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 sink: send mtime as metadata without writing it into the entry The sink stored X-Amz-Meta-Mtime into the replicated entry's Extended map, modifying the caller's entry, and since tags were limited to X-Amz-Tagging- keys it was never sent anywhere. Add it to the upload metadata instead, keeping an mtime the source object already carries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 sink: RFC 2047 encode metadata values that are not printable ASCII The S3 gateway keeps user metadata values as raw bytes. Forwarded as is, a UTF-8 value fails SigV4 on AWS and a control character makes the HTTP client reject the request, and filer.backup retries such an object forever. Encode those values as RFC 2047 encoded words, which S3 decodes on write. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 sink: upload without user metadata past the S3 2 KB limit The S3 gateway does not cap user metadata, but S3 rejects more than 2 KB of it, and filer.backup would retry that object forever. Upload such an object without its metadata and log a warning, as the sink did before metadata was forwarded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 sink: skip metadata keys that are not valid header names Filer gRPC clients can store any Extended key. An X-Amz-Meta- key with a space or control character makes the HTTP client reject the whole upload, which filer.backup retries forever. Leave such keys out with a warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 sink: pick the same value for metadata keys that differ only in case An entry holding both X-Amz-Meta-Project and the legacy x-amz-meta-project maps both to project, and map order decided which value was uploaded. Keep the lowest key, so the canonical form wins over the legacy lowercase one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 sink: use a test value codespell accepts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
298 lines
10 KiB
Go
298 lines
10 KiB
Go
package S3Sink
|
|
|
|
import (
|
|
"encoding/base64"
|
|
"fmt"
|
|
"mime"
|
|
"net/url"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/aws/aws-sdk-go/aws"
|
|
"github.com/aws/aws-sdk-go/aws/credentials"
|
|
"github.com/aws/aws-sdk-go/aws/session"
|
|
"github.com/aws/aws-sdk-go/service/s3"
|
|
"github.com/aws/aws-sdk-go/service/s3/s3iface"
|
|
"github.com/aws/aws-sdk-go/service/s3/s3manager"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/filer"
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/replication/repl_util"
|
|
"github.com/seaweedfs/seaweedfs/weed/replication/sink"
|
|
"github.com/seaweedfs/seaweedfs/weed/replication/source"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
"golang.org/x/net/http/httpguts"
|
|
)
|
|
|
|
// maxMetadataSize is the S3 limit on user metadata, counted over keys and values.
|
|
const maxMetadataSize = 2 * 1024
|
|
|
|
type S3Sink struct {
|
|
conn s3iface.S3API
|
|
filerSource *source.FilerSource
|
|
isIncremental bool
|
|
keepPartSize bool
|
|
s3DisableContentMD5Validation bool
|
|
s3ForcePathStyle bool
|
|
uploaderConcurrency int
|
|
uploaderMaxUploadParts int
|
|
uploaderPartSizeMb int
|
|
region string
|
|
bucket string
|
|
dir string
|
|
endpoint string
|
|
acl string
|
|
}
|
|
|
|
func init() {
|
|
sink.Sinks = append(sink.Sinks, &S3Sink{})
|
|
}
|
|
|
|
func (s3sink *S3Sink) GetName() string {
|
|
return "s3"
|
|
}
|
|
|
|
func (s3sink *S3Sink) GetSinkToDirectory() string {
|
|
return s3sink.dir
|
|
}
|
|
|
|
func (s3sink *S3Sink) GetDestinationIdentity() string {
|
|
return s3sink.endpoint + "\x00" + s3sink.bucket + "\x00" + s3sink.dir
|
|
}
|
|
|
|
func (s3sink *S3Sink) IsIncremental() bool {
|
|
return s3sink.isIncremental
|
|
}
|
|
|
|
func (s3sink *S3Sink) Initialize(configuration util.Configuration, prefix string) error {
|
|
configuration.SetDefault(prefix+"region", "us-east-2")
|
|
configuration.SetDefault(prefix+"directory", "/")
|
|
configuration.SetDefault(prefix+"keep_part_size", true)
|
|
configuration.SetDefault(prefix+"uploader_max_upload_parts", 1000)
|
|
configuration.SetDefault(prefix+"uploader_part_size_mb", 8)
|
|
configuration.SetDefault(prefix+"uploader_concurrency", 8)
|
|
configuration.SetDefault(prefix+"s3_disable_content_md5_validation", true)
|
|
configuration.SetDefault(prefix+"s3_force_path_style", true)
|
|
s3sink.region = configuration.GetString(prefix + "region")
|
|
s3sink.bucket = configuration.GetString(prefix + "bucket")
|
|
s3sink.dir = configuration.GetString(prefix + "directory")
|
|
s3sink.endpoint = configuration.GetString(prefix + "endpoint")
|
|
s3sink.acl = configuration.GetString(prefix + "acl")
|
|
s3sink.isIncremental = configuration.GetBool(prefix + "is_incremental")
|
|
s3sink.keepPartSize = configuration.GetBool(prefix + "keep_part_size")
|
|
s3sink.s3DisableContentMD5Validation = configuration.GetBool(prefix + "s3_disable_content_md5_validation")
|
|
s3sink.s3ForcePathStyle = configuration.GetBool(prefix + "s3_force_path_style")
|
|
s3sink.uploaderMaxUploadParts = configuration.GetInt(prefix + "uploader_max_upload_parts")
|
|
s3sink.uploaderPartSizeMb = configuration.GetInt(prefix + "uploader_part_size")
|
|
s3sink.uploaderConcurrency = configuration.GetInt(prefix + "uploader_concurrency")
|
|
|
|
glog.V(0).Infof("sink.s3.region: %v", s3sink.region)
|
|
glog.V(0).Infof("sink.s3.bucket: %v", s3sink.bucket)
|
|
glog.V(0).Infof("sink.s3.directory: %v", s3sink.dir)
|
|
glog.V(0).Infof("sink.s3.endpoint: %v", s3sink.endpoint)
|
|
glog.V(0).Infof("sink.s3.acl: %v", s3sink.acl)
|
|
glog.V(0).Infof("sink.s3.is_incremental: %v", s3sink.isIncremental)
|
|
glog.V(0).Infof("sink.s3.s3_disable_content_md5_validation: %v", s3sink.s3DisableContentMD5Validation)
|
|
glog.V(0).Infof("sink.s3.s3_force_path_style: %v", s3sink.s3ForcePathStyle)
|
|
glog.V(0).Infof("sink.s3.keep_part_size: %v", s3sink.keepPartSize)
|
|
if s3sink.uploaderMaxUploadParts > s3manager.MaxUploadParts {
|
|
s3sink.uploaderMaxUploadParts = s3manager.MaxUploadParts
|
|
glog.Warningf("uploader_max_upload_parts is greater than the maximum number of parts allowed when uploading multiple parts to Amazon S3")
|
|
glog.V(0).Infof("sink.s3.uploader_max_upload_parts: %v => %v", s3sink.uploaderMaxUploadParts, s3manager.MaxUploadParts)
|
|
} else {
|
|
glog.V(0).Infof("sink.s3.uploader_max_upload_parts: %v", s3sink.uploaderMaxUploadParts)
|
|
}
|
|
glog.V(0).Infof("sink.s3.uploader_part_size_mb: %v", s3sink.uploaderPartSizeMb)
|
|
glog.V(0).Infof("sink.s3.uploader_concurrency: %v", s3sink.uploaderConcurrency)
|
|
|
|
return s3sink.initialize(
|
|
configuration.GetString(prefix+"aws_access_key_id"),
|
|
configuration.GetString(prefix+"aws_secret_access_key"),
|
|
)
|
|
}
|
|
|
|
func (s3sink *S3Sink) SetSourceFiler(s *source.FilerSource) {
|
|
s3sink.filerSource = s
|
|
}
|
|
|
|
func (s3sink *S3Sink) initialize(awsAccessKeyId, awsSecretAccessKey string) error {
|
|
config := &aws.Config{
|
|
Region: aws.String(s3sink.region),
|
|
Endpoint: aws.String(s3sink.endpoint),
|
|
S3DisableContentMD5Validation: aws.Bool(s3sink.s3DisableContentMD5Validation),
|
|
S3ForcePathStyle: aws.Bool(s3sink.s3ForcePathStyle),
|
|
}
|
|
if awsAccessKeyId != "" && awsSecretAccessKey != "" {
|
|
config.Credentials = credentials.NewStaticCredentials(awsAccessKeyId, awsSecretAccessKey, "")
|
|
}
|
|
|
|
sess, err := session.NewSession(config)
|
|
if err != nil {
|
|
return fmt.Errorf("create aws session: %w", err)
|
|
}
|
|
s3sink.conn = s3.New(sess)
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s3sink *S3Sink) DeleteEntry(key string, isDirectory, deleteIncludeChunks bool, signatures []int32) error {
|
|
|
|
key = cleanKey(key)
|
|
|
|
if isDirectory {
|
|
return nil
|
|
}
|
|
|
|
input := &s3.DeleteObjectInput{
|
|
Bucket: aws.String(s3sink.bucket),
|
|
Key: aws.String(key),
|
|
}
|
|
|
|
result, err := s3sink.conn.DeleteObject(input)
|
|
|
|
if err == nil {
|
|
glog.V(2).Infof("[%s] delete %s: %v", s3sink.bucket, key, result)
|
|
} else {
|
|
glog.Errorf("[%s] delete %s: %v", s3sink.bucket, key, err)
|
|
}
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
func (s3sink *S3Sink) CreateEntry(key string, entry *filer_pb.Entry, signatures []int32) (err error) {
|
|
key = cleanKey(key)
|
|
|
|
if entry.IsDirectory {
|
|
return nil
|
|
}
|
|
|
|
reader := filer.NewFileReader(s3sink.filerSource, entry)
|
|
|
|
// Decrypt SSE-encrypted objects so the destination receives plaintext
|
|
decryptedReader, err := repl_util.MaybeDecryptReader(reader, entry)
|
|
if err != nil {
|
|
repl_util.CloseReader(reader)
|
|
return fmt.Errorf("decrypt SSE object: %w", err)
|
|
}
|
|
defer repl_util.CloseMaybeDecryptedReader(reader, decryptedReader)
|
|
|
|
// Create an uploader with the session and custom options
|
|
uploader := s3manager.NewUploaderWithClient(s3sink.conn, func(u *s3manager.Uploader) {
|
|
u.PartSize = int64(s3sink.uploaderPartSizeMb * 1024 * 1024)
|
|
u.Concurrency = s3sink.uploaderConcurrency
|
|
u.MaxUploadParts = s3sink.uploaderMaxUploadParts
|
|
})
|
|
|
|
if s3sink.keepPartSize {
|
|
switch chunkCount := len(entry.Chunks); {
|
|
case chunkCount > 1:
|
|
if firstChunkSize := int64(entry.Chunks[0].Size); firstChunkSize > s3manager.MinUploadPartSize {
|
|
uploader.PartSize = firstChunkSize
|
|
}
|
|
default:
|
|
uploader.PartSize = 0
|
|
}
|
|
}
|
|
|
|
// process tagging
|
|
tags := buildTaggingString(entry.Extended)
|
|
|
|
// Upload the file to S3.
|
|
uploadInput := s3manager.UploadInput{
|
|
Bucket: aws.String(s3sink.bucket),
|
|
Key: aws.String(key),
|
|
Body: decryptedReader,
|
|
}
|
|
if tags != "" {
|
|
uploadInput.Tagging = aws.String(tags)
|
|
}
|
|
metadata := toMetadata(entry.Extended)
|
|
if _, found := metadata["mtime"]; !found {
|
|
metadata["mtime"] = aws.String(strconv.FormatInt(entry.Attributes.Mtime, 10))
|
|
}
|
|
if size := metadataSize(metadata); size <= maxMetadataSize {
|
|
uploadInput.Metadata = metadata
|
|
} else {
|
|
glog.Warningf("[%s] %s: %d bytes of user metadata exceed the S3 limit of %d, uploading without it", s3sink.bucket, key, size, maxMetadataSize)
|
|
}
|
|
if entry.Attributes.Mime != "" {
|
|
uploadInput.ContentType = aws.String(entry.Attributes.Mime)
|
|
}
|
|
if len(entry.Attributes.Md5) > 0 {
|
|
uploadInput.ContentMD5 = aws.String(base64.StdEncoding.EncodeToString([]byte(entry.Attributes.Md5)))
|
|
}
|
|
_, err = uploader.Upload(&uploadInput)
|
|
if err != nil {
|
|
if sourceErr := filer.ReaderSourceError(reader); sourceErr != nil {
|
|
return fmt.Errorf("read source %s: %w", key, sourceErr)
|
|
}
|
|
}
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
func (s3sink *S3Sink) UpdateEntry(key string, oldEntry *filer_pb.Entry, newParentPath string, newEntry *filer_pb.Entry, deleteIncludeChunks bool, signatures []int32) (foundExistingEntry bool, err error) {
|
|
key = cleanKey(key)
|
|
return true, s3sink.CreateEntry(key, newEntry, signatures)
|
|
}
|
|
|
|
func cleanKey(key string) string {
|
|
if strings.HasPrefix(key, "/") {
|
|
key = key[1:]
|
|
}
|
|
return key
|
|
}
|
|
|
|
// buildTaggingString builds the S3 Tagging header value from entry extended metadata.
|
|
// Only keys with the AmzObjectTaggingPrefix ("X-Amz-Tagging-") are included as object
|
|
// tags. The prefix is stripped and values are URL-encoded to produce a valid S3 tagging
|
|
// query string.
|
|
func buildTaggingString(extended map[string][]byte) string {
|
|
tagValues := url.Values{}
|
|
for k, v := range extended {
|
|
if strings.HasPrefix(k, s3_constants.AmzObjectTaggingPrefix) {
|
|
tagKey := k[len(s3_constants.AmzObjectTaggingPrefix):]
|
|
tagValues.Set(tagKey, string(v))
|
|
}
|
|
}
|
|
return tagValues.Encode()
|
|
}
|
|
|
|
// toMetadata maps the X-Amz-Meta- attributes, matched case-insensitively for
|
|
// entries written before the S3 gateway canonicalized them, to S3 user metadata.
|
|
// Of keys that differ only in case the lowest wins, so X-Amz-Meta-Foo beats the
|
|
// legacy x-amz-meta-foo. Values that are not printable ASCII are RFC 2047
|
|
// encoded, which S3 decodes.
|
|
func toMetadata(extended map[string][]byte) map[string]*string {
|
|
prefix := s3_constants.AmzUserMetaPrefix
|
|
metadata := make(map[string]*string)
|
|
sourceKeys := make(map[string]string)
|
|
for k, v := range extended {
|
|
if len(k) <= len(prefix) || !strings.EqualFold(k[:len(prefix)], prefix) {
|
|
continue
|
|
}
|
|
if !httpguts.ValidHeaderFieldName(k) {
|
|
glog.Warningf("skip metadata %q: not a valid header name", k)
|
|
continue
|
|
}
|
|
name := strings.ToLower(k[len(prefix):])
|
|
if seen, found := sourceKeys[name]; found && seen < k {
|
|
continue
|
|
}
|
|
sourceKeys[name] = k
|
|
metadata[name] = aws.String(mime.QEncoding.Encode("utf-8", string(v)))
|
|
}
|
|
return metadata
|
|
}
|
|
|
|
func metadataSize(metadata map[string]*string) (size int) {
|
|
for k, v := range metadata {
|
|
size += len(k) + len(*v)
|
|
}
|
|
return size
|
|
}
|