mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-28 16:00:37 +01:00
* filer: make the HTTP connection idle timeout configurable The filer applied a hardcoded 10s activity timeout to its HTTP listener. A buffering proxy in front of the filer can stall upstream reads longer than that when the end client drains slowly, so large downloads through it were truncated (#8062). Expose the value as -idleTimeout (default 10, unchanged), matching the existing -idleTimeout flags on the volume and s3 servers, and wire filer.idleTimeout through 'weed server' and 'weed mini' too. A nil option keeps the 10s default so embedders constructing FilerOptions directly keep working. * filer: apply the idle timeout to the readonly port too The -port.readonly listener ran without any connection timeout while the main API port timed out. Give it the same -idleTimeout so both ports behave identically. * webdav: make the HTTP connection idle timeout configurable The WebDAV server used the same hardcoded 10s activity timeout. Expose it as -idleTimeout (default 10, unchanged), including -webdav.idleTimeout when embedded via 'weed filer -webdav', 'weed server -webdav', and 'weed mini'. * iam: make the HTTP connection idle timeout configurable The IAM API server used the same hardcoded 10s activity timeout. Expose it as -idleTimeout (default 10, unchanged), including -iam.idleTimeout when embedded via 'weed filer -iam' and 'weed server -iam'. * sftp: make the connection idle timeout configurable The SFTP server used the same hardcoded 10s activity timeout. Expose it as -idleTimeout (default 10, unchanged), including -sftp.idleTimeout when embedded via 'weed filer -sftp' and 'weed server -sftp'. * command: clamp idle timeout seconds before converting to duration A seconds value past time.Duration's range would overflow on multiplication and silently disable the timeout. Bound it in one shared helper, which also deduplicates the nil-default handling at the four call sites. * command: return zero for non-positive idle timeout seconds A large negative seconds value could wrap on multiplication and come out positive. Guard before converting so non-positive input always disables the timeout. * command: apply idle timeout to local unix socket listeners The unix-socket listeners in filer, s3, and sftp served accepted connections with no activity deadline while the TCP listeners already wrapped conns in util.Listener. Wrap the socket listeners the same way so a positive idleTimeout also bounds idle socket connections. * command: clamp s3 idle timeout seconds before multiplying s3 still multiplied the flag inline, so an out-of-range value could overflow time.Duration. Route it through idleTimeoutSeconds like the other commands; non-positive keeps meaning disabled. * volume: clamp idle connection timeout seconds before converting * command: cover idleTimeoutSeconds conversion semantics * command: gate idleTimeoutSeconds clamp check on 64-bit int
160 lines
6.2 KiB
Go
160 lines
6.2 KiB
Go
package command
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/util/version"
|
|
|
|
"time"
|
|
|
|
"github.com/gorilla/mux"
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/iamapi"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/security"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
"github.com/seaweedfs/seaweedfs/weed/util/grace"
|
|
|
|
// Import credential stores to register them
|
|
_ "github.com/seaweedfs/seaweedfs/weed/credential/filer_etc"
|
|
_ "github.com/seaweedfs/seaweedfs/weed/credential/memory"
|
|
_ "github.com/seaweedfs/seaweedfs/weed/credential/postgres"
|
|
)
|
|
|
|
var (
|
|
iamStandaloneOptions IamOptions
|
|
)
|
|
|
|
type IamOptions struct {
|
|
filer *string
|
|
masters *string
|
|
ip *string
|
|
ipBind *string
|
|
listenOnLocalhost *bool
|
|
port *int
|
|
idleTimeout *int
|
|
selfServiceRequiresGrant *bool
|
|
}
|
|
|
|
func init() {
|
|
cmdIam.Run = runIam // break init cycle
|
|
iamStandaloneOptions.filer = cmdIam.Flag.String("filer", "localhost:8888", "comma-separated filer server addresses for high availability")
|
|
iamStandaloneOptions.masters = cmdIam.Flag.String("master", "localhost:9333", "comma-separated master servers")
|
|
iamStandaloneOptions.ip = cmdIam.Flag.String("ip", util.DetectedHostAddress(), "iam server http listen ip address")
|
|
iamStandaloneOptions.ipBind = cmdIam.Flag.String("ip.bind", "", "ip address to bind to. If empty, default to same as -ip option.")
|
|
iamStandaloneOptions.port = cmdIam.Flag.Int("port", 8111, "iam server http listen port")
|
|
iamStandaloneOptions.idleTimeout = cmdIam.Flag.Int("idleTimeout", 10, "connection idle seconds")
|
|
iamStandaloneOptions.selfServiceRequiresGrant = cmdIam.Flag.Bool("selfServiceRequiresGrant", false, iamSelfServiceRequiresGrantUsage)
|
|
}
|
|
|
|
var cmdIam = &Command{
|
|
UsageLine: "iam [-port=8111] [-filer=<ip:port>[,<ip:port>]...] [-master=<ip:port>,<ip:port>]",
|
|
Short: "[DEPRECATED] start a standalone iam API compatible server",
|
|
Long: `[DEPRECATED] start a standalone iam API compatible server.
|
|
|
|
DEPRECATION NOTICE:
|
|
The standalone 'weed iam' command is deprecated and will be removed in a future release.
|
|
|
|
The IAM API is now embedded in the S3 server by default. Simply use 'weed s3' instead,
|
|
which provides both S3 and IAM APIs on the same port (enabled by default with -iam=true).
|
|
|
|
This simplifies deployment by running a single server instead of two separate servers,
|
|
following the pattern used by MinIO and Ceph RGW.
|
|
|
|
To use the embedded IAM API:
|
|
weed s3 -port=8333 # IAM API is available on the same port
|
|
|
|
To disable the embedded IAM API (if you prefer the old behavior):
|
|
weed s3 -iam=false # Run S3 without IAM
|
|
weed iam -port=8111 # Run IAM separately (deprecated)
|
|
|
|
Multiple filer addresses can be specified for high availability, separated by commas.`,
|
|
}
|
|
|
|
func runIam(cmd *Command, args []string) bool {
|
|
glog.Warningf("================================================================================")
|
|
glog.Warningf("DEPRECATION WARNING: 'weed iam' is deprecated and will be removed in a future release.")
|
|
glog.Warningf("The IAM API is now embedded in 'weed s3' by default (use -iam=true, which is the default).")
|
|
glog.Warningf("Please migrate to using 'weed s3' which provides both S3 and IAM APIs on the same port.")
|
|
glog.Warningf("================================================================================")
|
|
return iamStandaloneOptions.startIamServer()
|
|
}
|
|
|
|
func (iamopt *IamOptions) startIamServer() bool {
|
|
filerAddresses := pb.ServerAddresses(*iamopt.filer).ToAddresses()
|
|
|
|
util.LoadSecurityConfiguration()
|
|
grpcDialOption := security.LoadClientTLS(util.GetViper(), "grpc.client")
|
|
for {
|
|
err := pb.WithOneOfGrpcFilerClients(false, filerAddresses, grpcDialOption, func(client filer_pb.SeaweedFilerClient) error {
|
|
resp, err := client.GetFilerConfiguration(context.Background(), &filer_pb.GetFilerConfigurationRequest{})
|
|
if err != nil {
|
|
return fmt.Errorf("get filer configuration: %v", err)
|
|
}
|
|
glog.V(0).Infof("IAM read filer configuration: %s", resp)
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
glog.V(0).Infof("wait to connect to filers %v", filerAddresses)
|
|
time.Sleep(time.Second)
|
|
} else {
|
|
glog.V(0).Infof("connected to filers %v", filerAddresses)
|
|
break
|
|
}
|
|
}
|
|
|
|
masters := pb.ServerAddresses(*iamopt.masters).ToAddressMap()
|
|
router := mux.NewRouter().SkipClean(true)
|
|
iamApiServer, iamApiServer_err := iamapi.NewIamApiServer(router, &iamapi.IamServerOption{
|
|
Masters: masters,
|
|
Filers: filerAddresses,
|
|
Port: *iamopt.port,
|
|
GrpcDialOption: grpcDialOption,
|
|
IamSelfServiceRequiresGrant: *iamopt.selfServiceRequiresGrant,
|
|
})
|
|
glog.V(0).Info("NewIamApiServer created")
|
|
if iamApiServer_err != nil {
|
|
glog.Fatalf("IAM API Server startup error: %v", iamApiServer_err)
|
|
}
|
|
|
|
// Register shutdown handler to prevent goroutine leak
|
|
grace.OnInterrupt(func() {
|
|
iamApiServer.Shutdown()
|
|
})
|
|
|
|
// The loopback companion listener is only kept while -ip.bind is unset and
|
|
// the bind address falls back to -ip. An explicit -ip.bind pins the port to
|
|
// exactly that address.
|
|
bindIp := *iamopt.ip
|
|
listenOnLocalhost := iamopt.ipBind == nil || *iamopt.ipBind == ""
|
|
if iamopt.ipBind != nil && *iamopt.ipBind != "" {
|
|
bindIp = *iamopt.ipBind
|
|
}
|
|
if iamopt.listenOnLocalhost != nil {
|
|
listenOnLocalhost = *iamopt.listenOnLocalhost
|
|
}
|
|
idleTimeout := idleTimeoutSeconds(iamopt.idleTimeout)
|
|
|
|
listenAddress := fmt.Sprintf(":%d", *iamopt.port)
|
|
iamApiListener, iamApiLocalListener, err := util.NewIpAndLocalListeners(bindIp, *iamopt.port, idleTimeout, listenOnLocalhost)
|
|
if err != nil {
|
|
glog.Fatalf("IAM API Server listener on %s error: %v", listenAddress, err)
|
|
}
|
|
|
|
glog.V(0).Infof("Start Seaweed IAM API Server %s at http port %d", version.Version(), *iamopt.port)
|
|
if iamApiLocalListener != nil {
|
|
go func() {
|
|
if err = newHttpServer(router, nil).Serve(iamApiLocalListener); err != nil {
|
|
glog.Errorf("IAM API Server Fail to serve: %v", err)
|
|
}
|
|
}()
|
|
}
|
|
if err = newHttpServer(router, nil).Serve(iamApiListener); err != nil {
|
|
glog.Fatalf("IAM API Server Fail to serve: %v", err)
|
|
}
|
|
|
|
return true
|
|
}
|