mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-16 11:08:39 +02:00
When no STS configuration is provided in the IAM config file, the STS service was not being initialized, causing temporary credentials from AssumeRole to be rejected with "InvalidAccessKeyId" errors. This commit adds a DefaultSTSConfig() function that provides sensible defaults (1h token duration, 12h max session, secure random signing key) and updates the IAM manager to use these defaults when no explicit STS configuration is provided. Changes: - Add DefaultSTSConfig() with secure random signing key generation - Update IAM manager to use default config when config.STS is nil - Add tests verifying initialization with and without explicit config Fixes #8312
704 lines
24 KiB
Go
704 lines
24 KiB
Go
package integration
|
|
|
|
import (
|
|
"context"
|
|
"encoding/base64"
|
|
"encoding/json"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/iam/policy"
|
|
"github.com/seaweedfs/seaweedfs/weed/iam/providers"
|
|
"github.com/seaweedfs/seaweedfs/weed/iam/sts"
|
|
"github.com/seaweedfs/seaweedfs/weed/iam/utils"
|
|
)
|
|
|
|
// maxPoliciesForEvaluation defines an upper bound on the number of policies that
|
|
// will be evaluated for a single request. This protects against pathological or
|
|
// malicious inputs that attempt to create extremely large policy lists.
|
|
const maxPoliciesForEvaluation = 1024
|
|
|
|
// IAMManager orchestrates all IAM components
|
|
type IAMManager struct {
|
|
stsService *sts.STSService
|
|
policyEngine *policy.PolicyEngine
|
|
roleStore RoleStore
|
|
filerAddressProvider func() string // Function to get current filer address
|
|
initialized bool
|
|
}
|
|
|
|
// IAMConfig holds configuration for all IAM components
|
|
type IAMConfig struct {
|
|
// STS service configuration
|
|
STS *sts.STSConfig `json:"sts"`
|
|
|
|
// Policy engine configuration
|
|
Policy *policy.PolicyEngineConfig `json:"policy"`
|
|
|
|
// Role store configuration
|
|
Roles *RoleStoreConfig `json:"roleStore"`
|
|
}
|
|
|
|
// RoleStoreConfig holds role store configuration
|
|
type RoleStoreConfig struct {
|
|
// StoreType specifies the role store backend (memory, filer, etc.)
|
|
StoreType string `json:"storeType"`
|
|
|
|
// StoreConfig contains store-specific configuration
|
|
StoreConfig map[string]interface{} `json:"storeConfig,omitempty"`
|
|
}
|
|
|
|
// RoleDefinition defines a role with its trust policy and attached policies
|
|
type RoleDefinition struct {
|
|
// RoleName is the name of the role
|
|
RoleName string `json:"roleName"`
|
|
|
|
// RoleArn is the full ARN of the role
|
|
RoleArn string `json:"roleArn"`
|
|
|
|
// TrustPolicy defines who can assume this role
|
|
TrustPolicy *policy.PolicyDocument `json:"trustPolicy"`
|
|
|
|
// AttachedPolicies lists the policy names attached to this role
|
|
AttachedPolicies []string `json:"attachedPolicies"`
|
|
|
|
// Description is an optional description of the role
|
|
Description string `json:"description,omitempty"`
|
|
}
|
|
|
|
// ActionRequest represents a request to perform an action
|
|
type ActionRequest struct {
|
|
// Principal is the entity performing the action
|
|
Principal string `json:"principal"`
|
|
|
|
// Action is the action being requested
|
|
Action string `json:"action"`
|
|
|
|
// Resource is the resource being accessed
|
|
Resource string `json:"resource"`
|
|
|
|
// SessionToken for temporary credential validation
|
|
SessionToken string `json:"sessionToken"`
|
|
|
|
// RequestContext contains additional request information
|
|
RequestContext map[string]interface{} `json:"requestContext,omitempty"`
|
|
|
|
// PolicyNames to evaluate (overrides role-based policies if present)
|
|
PolicyNames []string `json:"policyNames,omitempty"`
|
|
}
|
|
|
|
// NewIAMManager creates a new IAM manager
|
|
func NewIAMManager() *IAMManager {
|
|
return &IAMManager{}
|
|
}
|
|
|
|
// Initialize initializes the IAM manager with all components
|
|
func (m *IAMManager) Initialize(config *IAMConfig, filerAddressProvider func() string) error {
|
|
if config == nil {
|
|
return fmt.Errorf("config cannot be nil")
|
|
}
|
|
|
|
// Store the filer address provider function
|
|
m.filerAddressProvider = filerAddressProvider
|
|
|
|
// Initialize STS service
|
|
m.stsService = sts.NewSTSService()
|
|
|
|
// Use default config if none provided
|
|
stsConfig := config.STS
|
|
if stsConfig == nil {
|
|
glog.V(1).Infof("No STS configuration provided, using defaults")
|
|
stsConfig = sts.DefaultSTSConfig()
|
|
}
|
|
|
|
if err := m.stsService.Initialize(stsConfig); err != nil {
|
|
return fmt.Errorf("failed to initialize STS service: %w", err)
|
|
}
|
|
|
|
// CRITICAL SECURITY: Set trust policy validator to ensure proper role assumption validation
|
|
m.stsService.SetTrustPolicyValidator(m)
|
|
|
|
// Initialize policy engine
|
|
m.policyEngine = policy.NewPolicyEngine()
|
|
if err := m.policyEngine.InitializeWithProvider(config.Policy, m.filerAddressProvider); err != nil {
|
|
return fmt.Errorf("failed to initialize policy engine: %w", err)
|
|
}
|
|
|
|
// Initialize role store
|
|
roleStore, err := m.createRoleStoreWithProvider(config.Roles, m.filerAddressProvider)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to initialize role store: %w", err)
|
|
}
|
|
m.roleStore = roleStore
|
|
|
|
m.initialized = true
|
|
return nil
|
|
}
|
|
|
|
// getFilerAddress returns the current filer address using the provider function
|
|
func (m *IAMManager) getFilerAddress() string {
|
|
if m.filerAddressProvider != nil {
|
|
return m.filerAddressProvider()
|
|
}
|
|
return "" // Fallback to empty string if no provider is set
|
|
}
|
|
|
|
// createRoleStore creates a role store based on configuration
|
|
func (m *IAMManager) createRoleStore(config *RoleStoreConfig) (RoleStore, error) {
|
|
if config == nil {
|
|
// Default to generic cached filer role store when no config provided
|
|
return NewGenericCachedRoleStore(nil, nil)
|
|
}
|
|
|
|
switch config.StoreType {
|
|
case "", "filer":
|
|
// Check if caching is explicitly disabled
|
|
if config.StoreConfig != nil {
|
|
if noCache, ok := config.StoreConfig["noCache"].(bool); ok && noCache {
|
|
return NewFilerRoleStore(config.StoreConfig, nil)
|
|
}
|
|
}
|
|
// Default to generic cached filer store for better performance
|
|
return NewGenericCachedRoleStore(config.StoreConfig, nil)
|
|
case "cached-filer", "generic-cached":
|
|
return NewGenericCachedRoleStore(config.StoreConfig, nil)
|
|
case "memory":
|
|
return NewMemoryRoleStore(), nil
|
|
default:
|
|
return nil, fmt.Errorf("unsupported role store type: %s", config.StoreType)
|
|
}
|
|
}
|
|
|
|
// createRoleStoreWithProvider creates a role store with a filer address provider function
|
|
func (m *IAMManager) createRoleStoreWithProvider(config *RoleStoreConfig, filerAddressProvider func() string) (RoleStore, error) {
|
|
if config == nil {
|
|
// Default to generic cached filer role store when no config provided
|
|
return NewGenericCachedRoleStore(nil, filerAddressProvider)
|
|
}
|
|
|
|
switch config.StoreType {
|
|
case "", "filer":
|
|
// Check if caching is explicitly disabled
|
|
if config.StoreConfig != nil {
|
|
if noCache, ok := config.StoreConfig["noCache"].(bool); ok && noCache {
|
|
return NewFilerRoleStore(config.StoreConfig, filerAddressProvider)
|
|
}
|
|
}
|
|
// Default to generic cached filer store for better performance
|
|
return NewGenericCachedRoleStore(config.StoreConfig, filerAddressProvider)
|
|
case "cached-filer", "generic-cached":
|
|
return NewGenericCachedRoleStore(config.StoreConfig, filerAddressProvider)
|
|
case "memory":
|
|
return NewMemoryRoleStore(), nil
|
|
default:
|
|
return nil, fmt.Errorf("unsupported role store type: %s", config.StoreType)
|
|
}
|
|
}
|
|
|
|
// RegisterIdentityProvider registers an identity provider
|
|
func (m *IAMManager) RegisterIdentityProvider(provider providers.IdentityProvider) error {
|
|
if !m.initialized {
|
|
return fmt.Errorf("IAM manager not initialized")
|
|
}
|
|
|
|
return m.stsService.RegisterProvider(provider)
|
|
}
|
|
|
|
// CreatePolicy creates a new policy
|
|
func (m *IAMManager) CreatePolicy(ctx context.Context, filerAddress string, name string, policyDoc *policy.PolicyDocument) error {
|
|
if !m.initialized {
|
|
return fmt.Errorf("IAM manager not initialized")
|
|
}
|
|
|
|
return m.policyEngine.AddPolicy(filerAddress, name, policyDoc)
|
|
}
|
|
|
|
// CreateRole creates a new role with trust policy and attached policies
|
|
func (m *IAMManager) CreateRole(ctx context.Context, filerAddress string, roleName string, roleDef *RoleDefinition) error {
|
|
if !m.initialized {
|
|
return fmt.Errorf("IAM manager not initialized")
|
|
}
|
|
|
|
if roleName == "" {
|
|
return fmt.Errorf("role name cannot be empty")
|
|
}
|
|
|
|
if roleDef == nil {
|
|
return fmt.Errorf("role definition cannot be nil")
|
|
}
|
|
|
|
// Set role ARN if not provided
|
|
if roleDef.RoleArn == "" {
|
|
roleDef.RoleArn = fmt.Sprintf("arn:aws:iam::role/%s", roleName)
|
|
}
|
|
|
|
// Validate trust policy
|
|
if roleDef.TrustPolicy != nil {
|
|
if err := policy.ValidateTrustPolicyDocument(roleDef.TrustPolicy); err != nil {
|
|
return fmt.Errorf("invalid trust policy: %w", err)
|
|
}
|
|
}
|
|
|
|
// Store role definition
|
|
return m.roleStore.StoreRole(ctx, "", roleName, roleDef)
|
|
}
|
|
|
|
// UpdateBucketPolicy updates the policy for a bucket
|
|
func (m *IAMManager) UpdateBucketPolicy(ctx context.Context, bucketName string, policyJSON []byte) error {
|
|
if !m.initialized {
|
|
return fmt.Errorf("IAM manager not initialized")
|
|
}
|
|
|
|
if bucketName == "" {
|
|
return fmt.Errorf("bucket name cannot be empty")
|
|
}
|
|
|
|
// Parse the policy document handled by the IAM policy engine
|
|
var policyDoc policy.PolicyDocument
|
|
if err := json.Unmarshal(policyJSON, &policyDoc); err != nil {
|
|
return fmt.Errorf("invalid policy JSON: %w", err)
|
|
}
|
|
|
|
// Store the policy with a special prefix to distinguish from IAM policies
|
|
policyName := "bucket-policy:" + bucketName
|
|
return m.policyEngine.AddPolicy(m.getFilerAddress(), policyName, &policyDoc)
|
|
}
|
|
|
|
// AssumeRoleWithWebIdentity assumes a role using web identity (OIDC)
|
|
func (m *IAMManager) AssumeRoleWithWebIdentity(ctx context.Context, request *sts.AssumeRoleWithWebIdentityRequest) (*sts.AssumeRoleResponse, error) {
|
|
if !m.initialized {
|
|
return nil, fmt.Errorf("IAM manager not initialized")
|
|
}
|
|
|
|
// Extract role name from ARN
|
|
roleName := utils.ExtractRoleNameFromArn(request.RoleArn)
|
|
|
|
// Get role definition
|
|
roleDef, err := m.roleStore.GetRole(ctx, m.getFilerAddress(), roleName)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("role not found: %s", roleName)
|
|
}
|
|
|
|
// Validate trust policy before allowing STS to assume the role
|
|
if err := m.validateTrustPolicyForWebIdentity(ctx, roleDef, request.WebIdentityToken, request.DurationSeconds); err != nil {
|
|
return nil, fmt.Errorf("trust policy validation failed: %w", err)
|
|
}
|
|
|
|
// Use STS service to assume the role
|
|
return m.stsService.AssumeRoleWithWebIdentity(ctx, request)
|
|
}
|
|
|
|
// AssumeRoleWithCredentials assumes a role using credentials (LDAP)
|
|
func (m *IAMManager) AssumeRoleWithCredentials(ctx context.Context, request *sts.AssumeRoleWithCredentialsRequest) (*sts.AssumeRoleResponse, error) {
|
|
if !m.initialized {
|
|
return nil, fmt.Errorf("IAM manager not initialized")
|
|
}
|
|
|
|
// Extract role name from ARN
|
|
roleName := utils.ExtractRoleNameFromArn(request.RoleArn)
|
|
|
|
// Get role definition
|
|
roleDef, err := m.roleStore.GetRole(ctx, m.getFilerAddress(), roleName)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("role not found: %s", roleName)
|
|
}
|
|
|
|
// Validate trust policy
|
|
if err := m.validateTrustPolicyForCredentials(ctx, roleDef, request); err != nil {
|
|
return nil, fmt.Errorf("trust policy validation failed: %w", err)
|
|
}
|
|
|
|
// Use STS service to assume the role
|
|
return m.stsService.AssumeRoleWithCredentials(ctx, request)
|
|
}
|
|
|
|
// IsActionAllowed checks if a principal is allowed to perform an action on a resource
|
|
func (m *IAMManager) IsActionAllowed(ctx context.Context, request *ActionRequest) (bool, error) {
|
|
if !m.initialized {
|
|
return false, fmt.Errorf("IAM manager not initialized")
|
|
}
|
|
|
|
// Validate session token if present (skip for OIDC tokens which are already validated,
|
|
// and skip for empty tokens which represent static access keys)
|
|
if request.SessionToken != "" && !isOIDCToken(request.SessionToken) {
|
|
_, err := m.stsService.ValidateSessionToken(ctx, request.SessionToken)
|
|
if err != nil {
|
|
return false, fmt.Errorf("invalid session: %w", err)
|
|
}
|
|
}
|
|
|
|
// Create evaluation context
|
|
evalCtx := &policy.EvaluationContext{
|
|
Principal: request.Principal,
|
|
Action: request.Action,
|
|
Resource: request.Resource,
|
|
RequestContext: request.RequestContext,
|
|
}
|
|
|
|
// Ensure RequestContext exists and populate with principal info
|
|
if evalCtx.RequestContext == nil {
|
|
evalCtx.RequestContext = make(map[string]interface{})
|
|
}
|
|
// Add principal to context for policy matching
|
|
// The PolicyEngine checks RequestContext["principal"] or RequestContext["aws:PrincipalArn"]
|
|
evalCtx.RequestContext["principal"] = request.Principal
|
|
evalCtx.RequestContext["aws:PrincipalArn"] = request.Principal
|
|
|
|
// Parse principal ARN to extract details for context variables (e.g. ${aws:username})
|
|
arnInfo := utils.ParsePrincipalARN(request.Principal)
|
|
if arnInfo.RoleName != "" {
|
|
// For assumed roles, AWS docs say aws:username IS the role name.
|
|
// However, for user isolation in these tests, we typically map the session name (the user who assumed the role) to aws:username.
|
|
// arn:aws:sts::account:assumed-role/RoleName/SessionName
|
|
awsUsername := arnInfo.RoleName
|
|
if idx := strings.LastIndex(request.Principal, "/"); idx != -1 && idx < len(request.Principal)-1 {
|
|
awsUsername = request.Principal[idx+1:]
|
|
}
|
|
|
|
evalCtx.RequestContext["aws:username"] = awsUsername
|
|
evalCtx.RequestContext["aws:userid"] = arnInfo.RoleName
|
|
}
|
|
if arnInfo.AccountID != "" {
|
|
evalCtx.RequestContext["aws:PrincipalAccount"] = arnInfo.AccountID
|
|
}
|
|
|
|
// Determine if there is a bucket policy to evaluate
|
|
var bucketPolicyName string
|
|
if strings.HasPrefix(request.Resource, "arn:aws:s3:::") {
|
|
resourcePath := request.Resource[13:] // remove "arn:aws:s3:::"
|
|
parts := strings.SplitN(resourcePath, "/", 2)
|
|
if len(parts) > 0 && parts[0] != "" {
|
|
bucketPolicyName = "bucket-policy:" + parts[0]
|
|
}
|
|
}
|
|
|
|
// If explicit policy names are provided (e.g. from user identity), evaluate them directly
|
|
if len(request.PolicyNames) > 0 {
|
|
policies := request.PolicyNames
|
|
if bucketPolicyName != "" {
|
|
// Enforce an upper bound on the number of policies to avoid excessive allocations
|
|
if len(policies) >= maxPoliciesForEvaluation {
|
|
return false, fmt.Errorf("too many policies for evaluation: %d >= %d", len(policies), maxPoliciesForEvaluation)
|
|
}
|
|
// Create a new slice to avoid modifying the request and append the bucket policy
|
|
copied := make([]string, len(policies))
|
|
copy(copied, policies)
|
|
policies = append(copied, bucketPolicyName)
|
|
}
|
|
|
|
result, err := m.policyEngine.Evaluate(ctx, "", evalCtx, policies)
|
|
if err != nil {
|
|
return false, fmt.Errorf("policy evaluation failed: %w", err)
|
|
}
|
|
return result.Effect == policy.EffectAllow, nil
|
|
}
|
|
|
|
// Extract role name from principal ARN
|
|
roleName := utils.ExtractRoleNameFromPrincipal(request.Principal)
|
|
if roleName == "" {
|
|
return false, fmt.Errorf("could not extract role from principal: %s", request.Principal)
|
|
}
|
|
|
|
// Get role definition
|
|
roleDef, err := m.roleStore.GetRole(ctx, m.getFilerAddress(), roleName)
|
|
if err != nil {
|
|
return false, fmt.Errorf("role not found: %s", roleName)
|
|
}
|
|
|
|
// Evaluate policies attached to the role
|
|
policies := roleDef.AttachedPolicies
|
|
if bucketPolicyName != "" {
|
|
// Enforce an upper bound on the number of policies to avoid excessive allocations
|
|
if len(policies) >= maxPoliciesForEvaluation {
|
|
return false, fmt.Errorf("too many policies for evaluation: %d >= %d", len(policies), maxPoliciesForEvaluation)
|
|
}
|
|
// Create a new slice to avoid modifying the role definition and append the bucket policy
|
|
copied := make([]string, len(policies))
|
|
copy(copied, policies)
|
|
policies = append(copied, bucketPolicyName)
|
|
}
|
|
|
|
result, err := m.policyEngine.Evaluate(ctx, "", evalCtx, policies)
|
|
if err != nil {
|
|
return false, fmt.Errorf("policy evaluation failed: %w", err)
|
|
}
|
|
|
|
return result.Effect == policy.EffectAllow, nil
|
|
}
|
|
|
|
// ValidateTrustPolicy validates if a principal can assume a role (for testing)
|
|
func (m *IAMManager) ValidateTrustPolicy(ctx context.Context, roleArn, provider, userID string) bool {
|
|
roleName := utils.ExtractRoleNameFromArn(roleArn)
|
|
roleDef, err := m.roleStore.GetRole(ctx, m.getFilerAddress(), roleName)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
|
|
// Simple validation based on provider in trust policy
|
|
if roleDef.TrustPolicy != nil {
|
|
for _, statement := range roleDef.TrustPolicy.Statement {
|
|
if statement.Effect == "Allow" {
|
|
if principal, ok := statement.Principal.(map[string]interface{}); ok {
|
|
if federated, ok := principal["Federated"].(string); ok {
|
|
// For OIDC, check against issuer URL
|
|
if provider == "oidc" && federated == "test-oidc" {
|
|
return true
|
|
}
|
|
// For LDAP, check against test-ldap
|
|
if provider == "ldap" && federated == "test-ldap" {
|
|
return true
|
|
}
|
|
// Also check for wildcard
|
|
if federated == "*" {
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
// validateTrustPolicyForWebIdentity validates trust policy for OIDC assumption
|
|
func (m *IAMManager) validateTrustPolicyForWebIdentity(ctx context.Context, roleDef *RoleDefinition, webIdentityToken string, durationSeconds *int64) error {
|
|
if roleDef.TrustPolicy == nil {
|
|
return fmt.Errorf("role has no trust policy")
|
|
}
|
|
|
|
// Create evaluation context for trust policy validation
|
|
requestContext := make(map[string]interface{})
|
|
|
|
// Try to parse as JWT first, fallback to mock token handling
|
|
tokenClaims, err := parseJWTTokenForTrustPolicy(webIdentityToken)
|
|
if err != nil {
|
|
// If JWT parsing fails, this might be a mock token (like "valid-oidc-token")
|
|
// For mock tokens, we'll use default values that match the trust policy expectations
|
|
requestContext["aws:FederatedProvider"] = "test-oidc"
|
|
requestContext["oidc:iss"] = "test-oidc"
|
|
// This ensures aws:userid key is populated even for mock tokens if needed
|
|
requestContext["aws:userid"] = "mock-user"
|
|
requestContext["oidc:sub"] = "mock-user"
|
|
} else {
|
|
// Add standard context values from JWT claims that trust policies might check
|
|
// See: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_iam-condition-keys.html#condition-keys-web-identity-federation
|
|
|
|
// The issuer is the federated provider for OIDC
|
|
if iss, ok := tokenClaims["iss"].(string); ok {
|
|
// Default to issuer URL
|
|
requestContext["aws:FederatedProvider"] = iss
|
|
requestContext["oidc:iss"] = iss
|
|
|
|
// Try to resolve provider name from issuer for better policy matching
|
|
// This allows policies to reference the provider name (e.g. "keycloak") instead of the full issuer URL
|
|
if m.stsService != nil {
|
|
for name, provider := range m.stsService.GetProviders() {
|
|
if oidcProvider, ok := provider.(interface{ GetIssuer() string }); ok {
|
|
confIssuer := oidcProvider.GetIssuer()
|
|
|
|
if confIssuer == iss {
|
|
requestContext["aws:FederatedProvider"] = name
|
|
break
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if sub, ok := tokenClaims["sub"].(string); ok {
|
|
requestContext["oidc:sub"] = sub
|
|
// Map subject to aws:userid as well for compatibility
|
|
requestContext["aws:userid"] = sub
|
|
}
|
|
if aud, ok := tokenClaims["aud"].(string); ok {
|
|
requestContext["oidc:aud"] = aud
|
|
}
|
|
// Custom claims can be prefixed if needed, but for "be 100% compatible with AWS",
|
|
// we should rely on standard OIDC claims.
|
|
|
|
// Add all other claims with oidc: prefix to support custom claims in trust policies
|
|
// This enables checking claims like "oidc:roles", "oidc:groups", "oidc:email", etc.
|
|
for k, v := range tokenClaims {
|
|
// Skip claims we've already handled explicitly or shouldn't expose
|
|
if k == "iss" || k == "sub" || k == "aud" {
|
|
continue
|
|
}
|
|
|
|
// Add with oidc: prefix
|
|
requestContext["oidc:"+k] = v
|
|
}
|
|
}
|
|
|
|
// Add DurationSeconds to context if provided
|
|
if durationSeconds != nil {
|
|
requestContext["sts:DurationSeconds"] = *durationSeconds
|
|
}
|
|
|
|
// Create evaluation context for trust policy
|
|
evalCtx := &policy.EvaluationContext{
|
|
Principal: "web-identity-user", // Placeholder principal for trust policy evaluation
|
|
Action: "sts:AssumeRoleWithWebIdentity",
|
|
Resource: roleDef.RoleArn,
|
|
RequestContext: requestContext,
|
|
}
|
|
|
|
// Evaluate the trust policy directly
|
|
if !m.evaluateTrustPolicy(roleDef.TrustPolicy, evalCtx) {
|
|
return fmt.Errorf("trust policy denies web identity assumption")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// validateTrustPolicyForCredentials validates trust policy for credential assumption
|
|
func (m *IAMManager) validateTrustPolicyForCredentials(ctx context.Context, roleDef *RoleDefinition, request *sts.AssumeRoleWithCredentialsRequest) error {
|
|
if roleDef.TrustPolicy == nil {
|
|
return fmt.Errorf("role has no trust policy")
|
|
}
|
|
|
|
// Check if trust policy allows credential assumption for the specific provider
|
|
for _, statement := range roleDef.TrustPolicy.Statement {
|
|
if statement.Effect == "Allow" {
|
|
for _, action := range statement.Action {
|
|
if action == "sts:AssumeRoleWithCredentials" {
|
|
if principal, ok := statement.Principal.(map[string]interface{}); ok {
|
|
if federated, ok := principal["Federated"].(string); ok {
|
|
if federated == request.ProviderName {
|
|
return nil // Allow
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return fmt.Errorf("trust policy does not allow credential assumption for provider: %s", request.ProviderName)
|
|
}
|
|
|
|
// Helper functions
|
|
|
|
// ExpireSessionForTesting manually expires a session for testing purposes
|
|
func (m *IAMManager) ExpireSessionForTesting(ctx context.Context, sessionToken string) error {
|
|
if !m.initialized {
|
|
return fmt.Errorf("IAM manager not initialized")
|
|
}
|
|
|
|
return m.stsService.ExpireSessionForTesting(ctx, sessionToken)
|
|
}
|
|
|
|
// GetSTSService returns the STS service instance
|
|
func (m *IAMManager) GetSTSService() *sts.STSService {
|
|
return m.stsService
|
|
}
|
|
|
|
// parseJWTTokenForTrustPolicy parses a JWT token to extract claims for trust policy evaluation
|
|
func parseJWTTokenForTrustPolicy(tokenString string) (map[string]interface{}, error) {
|
|
// Simple JWT parsing without verification (for trust policy context only)
|
|
// In production, this should use proper JWT parsing with signature verification
|
|
parts := strings.Split(tokenString, ".")
|
|
if len(parts) != 3 {
|
|
return nil, fmt.Errorf("invalid JWT format")
|
|
}
|
|
|
|
// Decode the payload (second part)
|
|
payload := parts[1]
|
|
// Add padding if needed
|
|
for len(payload)%4 != 0 {
|
|
payload += "="
|
|
}
|
|
|
|
decoded, err := base64.URLEncoding.DecodeString(payload)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to decode JWT payload: %w", err)
|
|
}
|
|
|
|
var claims map[string]interface{}
|
|
if err := json.Unmarshal(decoded, &claims); err != nil {
|
|
return nil, fmt.Errorf("failed to unmarshal JWT claims: %w", err)
|
|
}
|
|
|
|
return claims, nil
|
|
}
|
|
|
|
// evaluateTrustPolicy evaluates a trust policy against the evaluation context
|
|
// Now delegates to PolicyEngine for unified policy evaluation
|
|
func (m *IAMManager) evaluateTrustPolicy(trustPolicy *policy.PolicyDocument, evalCtx *policy.EvaluationContext) bool {
|
|
if trustPolicy == nil {
|
|
return false
|
|
}
|
|
|
|
// Use the PolicyEngine to evaluate the trust policy
|
|
// The PolicyEngine now handles Principal, Action, Resource, and Condition matching
|
|
result, err := m.policyEngine.EvaluateTrustPolicy(context.Background(), trustPolicy, evalCtx)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
|
|
return result.Effect == policy.EffectAllow
|
|
}
|
|
|
|
// evaluateTrustPolicyConditions and evaluatePrincipalValue have been removed
|
|
// Trust policy evaluation is now handled entirely by PolicyEngine.EvaluateTrustPolicy()
|
|
|
|
// isOIDCToken checks if a token is an OIDC JWT token (vs STS session token)
|
|
func isOIDCToken(token string) bool {
|
|
// JWT tokens have three parts separated by dots and start with base64-encoded JSON
|
|
parts := strings.Split(token, ".")
|
|
if len(parts) != 3 {
|
|
return false
|
|
}
|
|
|
|
// JWT tokens typically start with "eyJ" (base64 encoded JSON starting with "{")
|
|
return strings.HasPrefix(token, "eyJ")
|
|
}
|
|
|
|
// TrustPolicyValidator interface implementation
|
|
// These methods allow the IAMManager to serve as the trust policy validator for the STS service
|
|
|
|
// ValidateTrustPolicyForWebIdentity implements the TrustPolicyValidator interface
|
|
func (m *IAMManager) ValidateTrustPolicyForWebIdentity(ctx context.Context, roleArn string, webIdentityToken string, durationSeconds *int64) error {
|
|
if !m.initialized {
|
|
return fmt.Errorf("IAM manager not initialized")
|
|
}
|
|
|
|
// Extract role name from ARN
|
|
roleName := utils.ExtractRoleNameFromArn(roleArn)
|
|
|
|
// Get role definition
|
|
roleDef, err := m.roleStore.GetRole(ctx, m.getFilerAddress(), roleName)
|
|
if err != nil {
|
|
return fmt.Errorf("role not found: %s", roleName)
|
|
}
|
|
|
|
// Use existing trust policy validation logic
|
|
return m.validateTrustPolicyForWebIdentity(ctx, roleDef, webIdentityToken, durationSeconds)
|
|
}
|
|
|
|
// ValidateTrustPolicyForCredentials implements the TrustPolicyValidator interface
|
|
func (m *IAMManager) ValidateTrustPolicyForCredentials(ctx context.Context, roleArn string, identity *providers.ExternalIdentity) error {
|
|
if !m.initialized {
|
|
return fmt.Errorf("IAM manager not initialized")
|
|
}
|
|
|
|
// Extract role name from ARN
|
|
roleName := utils.ExtractRoleNameFromArn(roleArn)
|
|
|
|
// Get role definition
|
|
roleDef, err := m.roleStore.GetRole(ctx, m.getFilerAddress(), roleName)
|
|
if err != nil {
|
|
return fmt.Errorf("role not found: %s", roleName)
|
|
}
|
|
|
|
// For credentials, we need to create a mock request to reuse existing validation
|
|
// This is a bit of a hack, but it allows us to reuse the existing logic
|
|
mockRequest := &sts.AssumeRoleWithCredentialsRequest{
|
|
ProviderName: identity.Provider, // Use the provider name from the identity
|
|
}
|
|
|
|
// Use existing trust policy validation logic
|
|
return m.validateTrustPolicyForCredentials(ctx, roleDef, mockRequest)
|
|
}
|