mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-27 07:20:44 +01:00
chrislu
7149b723ec
Consumer Group Protocol Metadata completed: ## Core Enhancements - **ClientHost extraction**: Real client IP/host instead of hardcoded 'unknown' - ExtractClientHost() extracts IP from connection context - Populates GroupMember.ClientHost with actual remote address - **Enhanced protocol metadata parsing**: Robust parsing with error handling - ParseConsumerProtocolMetadata() with validation and graceful fallbacks - Handles malformed metadata, oversized fields, and edge cases - **Improved assignment strategy selection**: Priority-based protocol selection - SelectBestProtocol() prefers sticky > roundrobin > range - Considers both client capabilities and existing group protocols ## Implementation Details - **Connection Context**: Added ConnectionContext to Handler for client info - **Metadata Analysis**: AnalyzeProtocolMetadata() for detailed debugging - **Enhanced Subscription Extraction**: ExtractTopicsFromMetadata() with fallbacks - **Validation**: SanitizeConsumerGroupID() prevents malformed group IDs - **Graceful Error Handling**: Invalid metadata handled without failures ## New Files - : Core metadata parsing and client context logic - : Comprehensive test suite (17 test cases) ## Integration - **JoinGroup enhancement**: Uses real client host and robust metadata parsing - **Backward compatibility**: Legacy methods maintained for compatibility - **Debug improvements**: Enhanced logging shows parsed protocol details ## Testing & Verification - **17 comprehensive tests**: Protocol parsing, client host extraction, strategy selection - **Edge case coverage**: Empty metadata, malformed data, oversized fields - **E2E compatibility**: Sarama tests pass, no regressions - **Performance validation**: Benchmark tests for parsing operations Ready for Phase 5: Multi-batch Fetch concatenation support