mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-08 15:41:15 +02:00
* storage: make DeleteVolume errors inspectable with errors.Is An absent volume wraps ErrVolumeNotFound and an only-empty refusal now wraps ErrVolumeNotEmpty with %w instead of %v, so callers no longer have to match on the message. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * volume server: return NotFound and FailedPrecondition from VolumeDelete An absent volume maps to codes.NotFound and a non-empty volume under only_empty to codes.FailedPrecondition, so a caller retiring a volume can treat NotFound as already done. The store message is kept in the status description because the EC empty-replica sweep still matches on it. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * wdclient: add LookupVolumeIdsAuthoritative Bypasses the vid map and asks the provider directly, for callers where a stale positive location is unsafe. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * filer: add LookupDirectoryEntries batch lookup RPC Up to 4096 exact-path lookups in one call, resolved concurrently with results in request order, plus one deduplicated location lookup for every volume the returned entries reference and per-fid read tokens when the filer signs reads. unavailable_volume_is_miss lets cache-style callers take an entry whose volume has no live location as a miss, resolved against the master rather than the filer's location cache. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * filer: test that an expired file entry is deleted on read Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * filer: test that AssignVolume and CreateEntry resolve the same TTL rule Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * master: refuse partial lookups while warming up LookupVolume returned Unavailable during warm-up only when every requested volume was missing. A batch mixing a reported volume with one whose server has not reconnected yet came back as a partial answer with a per-volume not-found, which a caller treating the master as authoritative reads as gone. Any not-found during warm-up is now Unavailable, which callers already retry. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * filer: build batch test requests instead of copying a proto message Copying a generated message copies its internal mutex, which go vet's copylocks check rejects. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * filer: match ErrNotFound with errors.Is and state the miss rule's contract A wrapped not-found from the store would otherwise be reported as an error rather than a miss. The comments now say why a nil location map is the only sign of an unanswered lookup: the provider returns nil when it got no answer and a populated map, with unserved volumes reported as errors, when the master did answer. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * volume server: map absent and non-empty VolumeDelete errors in the Rust server Matches the Go server: an absent volume is NotFound and an only_empty refusal is FailedPrecondition instead of Internal, with the messages the EC empty-replica sweep matches on. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * filer: test that a malformed entry keeps its error outside cache mode Same test file as the enterprise tree, so the next sync sees one version. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm
50 lines
1.4 KiB
Go
50 lines
1.4 KiB
Go
package wdclient
|
|
|
|
import (
|
|
"context"
|
|
"reflect"
|
|
"testing"
|
|
)
|
|
|
|
type authoritativeLookupProvider struct {
|
|
calls int
|
|
result map[string][]Location
|
|
err error
|
|
}
|
|
|
|
func (p *authoritativeLookupProvider) LookupVolumeIds(_ context.Context, volumeIDs []string) (map[string][]Location, error) {
|
|
p.calls++
|
|
return p.result, p.err
|
|
}
|
|
|
|
func TestAuthoritativeVolumeLookupDoesNotTrustCachedLocations(t *testing.T) {
|
|
provider := &authoritativeLookupProvider{result: map[string][]Location{}}
|
|
client := newVidMapClient(provider, "", DefaultVidMapCacheSize)
|
|
client.addLocation(17, Location{Url: "retired-volume:8080"})
|
|
|
|
locations, err := client.LookupVolumeIdsAuthoritative(context.Background(), []string{"17"})
|
|
if err != nil {
|
|
t.Fatalf("authoritative lookup: %v", err)
|
|
}
|
|
if provider.calls != 1 {
|
|
t.Fatalf("provider calls = %d, want 1", provider.calls)
|
|
}
|
|
if len(locations) != 0 {
|
|
t.Fatalf("authoritative lookup returned stale cache: %#v", locations)
|
|
}
|
|
}
|
|
|
|
func TestAuthoritativeVolumeLookupReturnsProviderResult(t *testing.T) {
|
|
want := map[string][]Location{"17": {{Url: "current-volume:8080"}}}
|
|
provider := &authoritativeLookupProvider{result: want}
|
|
client := newVidMapClient(provider, "", DefaultVidMapCacheSize)
|
|
|
|
got, err := client.LookupVolumeIdsAuthoritative(context.Background(), []string{"17"})
|
|
if err != nil {
|
|
t.Fatalf("authoritative lookup: %v", err)
|
|
}
|
|
if !reflect.DeepEqual(got, want) {
|
|
t.Fatalf("locations = %#v, want %#v", got, want)
|
|
}
|
|
}
|