mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-11-13 07:19:18 +01:00
Ping QiuandClaude Opus 4.6
5a9a52f2d0
CP6-2 wires the CSI driver to SeaweedFS master/volume-server control plane: - Proto: block volume messages in master.proto/volume_server.proto, codegen - Master registry: in-memory BlockVolumeRegistry with Pending->Active status, full/delta heartbeat, inflight lock, placement (fewest volumes) - VS gRPC: AllocateBlockVolume/DeleteBlockVolume handlers, shared naming - Master RPCs: CreateBlockVolume (retry up to 3 servers), Delete, Lookup - Heartbeat: block volume fields wired into bidirectional stream - CSI Controller: VolumeBackend interface (Local + Master), returns volume_context - CSI Node: reads volume_context for remote targets, staged map + IQN derivation - Mode flag: --mode=controller/node/all, --master for control-plane - K8s manifests: csi-driver.yaml, csi-controller.yaml, csi-node.yaml csi-sanity conformance (33 pass, 58 skip) found 6 bugs: - BUG-SANITY-1/2/3: missing VolumeCapabilities/VolumeCapability validation - BUG-SANITY-4: NodePublish used mount instead of bind mount - BUG-SANITY-5: NodeUnpublish didn't remove target path - BUG-SANITY-6: NodeUnpublish failed on unmounted path k3s Level 4 (PVC->Pod data persistence) found 1 bug: - BUG-K3S-1: IsLoggedIn didn't handle iscsiadm exit code 21 226 CSI tests + 54 server tests = 280 new tests, all passing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
111 lines
2.8 KiB
Go
111 lines
2.8 KiB
Go
package weed_server
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func newTestBlockServiceWithDir(t *testing.T) (*BlockService, string) {
|
|
t.Helper()
|
|
dir := t.TempDir()
|
|
blockDir := filepath.Join(dir, "blocks")
|
|
os.MkdirAll(blockDir, 0755)
|
|
bs := StartBlockService("127.0.0.1:0", blockDir, "iqn.2024.test:")
|
|
if bs == nil {
|
|
t.Fatal("StartBlockService returned nil")
|
|
}
|
|
t.Cleanup(func() { bs.Shutdown() })
|
|
return bs, blockDir
|
|
}
|
|
|
|
func TestVS_AllocateBlockVolume(t *testing.T) {
|
|
bs, blockDir := newTestBlockServiceWithDir(t)
|
|
|
|
path, iqn, iscsiAddr, err := bs.CreateBlockVol("test-vol", 4*1024*1024, "ssd")
|
|
if err != nil {
|
|
t.Fatalf("CreateBlockVol: %v", err)
|
|
}
|
|
if path == "" || iqn == "" || iscsiAddr == "" {
|
|
t.Fatalf("empty return values: path=%q iqn=%q addr=%q", path, iqn, iscsiAddr)
|
|
}
|
|
|
|
// Verify file exists.
|
|
expectedPath := filepath.Join(blockDir, "test-vol.blk")
|
|
if path != expectedPath {
|
|
t.Fatalf("path: got %q, want %q", path, expectedPath)
|
|
}
|
|
if _, err := os.Stat(path); os.IsNotExist(err) {
|
|
t.Fatalf(".blk file not created at %s", path)
|
|
}
|
|
|
|
// IQN should contain sanitized name.
|
|
if !strings.Contains(iqn, "test-vol") {
|
|
t.Fatalf("IQN %q should contain 'test-vol'", iqn)
|
|
}
|
|
}
|
|
|
|
func TestVS_AllocateIdempotent(t *testing.T) {
|
|
bs, _ := newTestBlockServiceWithDir(t)
|
|
|
|
path1, iqn1, _, err := bs.CreateBlockVol("vol1", 4*1024*1024, "")
|
|
if err != nil {
|
|
t.Fatalf("first create: %v", err)
|
|
}
|
|
|
|
// Same name+size should return same info.
|
|
path2, iqn2, _, err := bs.CreateBlockVol("vol1", 4*1024*1024, "")
|
|
if err != nil {
|
|
t.Fatalf("idempotent create: %v", err)
|
|
}
|
|
if path1 != path2 || iqn1 != iqn2 {
|
|
t.Fatalf("idempotent mismatch: (%q,%q) vs (%q,%q)", path1, iqn1, path2, iqn2)
|
|
}
|
|
}
|
|
|
|
func TestVS_AllocateSizeMismatch(t *testing.T) {
|
|
bs, _ := newTestBlockServiceWithDir(t)
|
|
|
|
_, _, _, err := bs.CreateBlockVol("vol1", 4*1024*1024, "")
|
|
if err != nil {
|
|
t.Fatalf("first create: %v", err)
|
|
}
|
|
|
|
// Requesting a LARGER size than existing should fail.
|
|
_, _, _, err = bs.CreateBlockVol("vol1", 8*1024*1024, "")
|
|
if err == nil {
|
|
t.Fatal("size mismatch should return error")
|
|
}
|
|
}
|
|
|
|
func TestVS_DeleteBlockVolume(t *testing.T) {
|
|
bs, blockDir := newTestBlockServiceWithDir(t)
|
|
|
|
bs.CreateBlockVol("vol1", 4*1024*1024, "")
|
|
path := filepath.Join(blockDir, "vol1.blk")
|
|
|
|
// File should exist.
|
|
if _, err := os.Stat(path); err != nil {
|
|
t.Fatalf("file should exist: %v", err)
|
|
}
|
|
|
|
if err := bs.DeleteBlockVol("vol1"); err != nil {
|
|
t.Fatalf("DeleteBlockVol: %v", err)
|
|
}
|
|
|
|
// File should be gone.
|
|
if _, err := os.Stat(path); !os.IsNotExist(err) {
|
|
t.Fatal("file should be removed after delete")
|
|
}
|
|
}
|
|
|
|
func TestVS_DeleteNotFound(t *testing.T) {
|
|
bs, _ := newTestBlockServiceWithDir(t)
|
|
|
|
// Deleting non-existent volume should be idempotent.
|
|
if err := bs.DeleteBlockVol("no-such-vol"); err != nil {
|
|
t.Fatalf("delete non-existent should not error: %v", err)
|
|
}
|
|
}
|