Files
seaweedfs/weed/filer/filer_inode_test.go
T
Chris Lu dfd05d14cb refactor(filer): remove the inode->path index and the NFS gateway (#9724)
* fix(filer): derive inodes by hash instead of a snowflake sequencer

Compute the same inode the FUSE mount would: non-hard-linked entries hash path + crtime, hard links hash their shared HardLinkId so every link resolves to one inode. Removes the snowflake inodeSequencer and the SEAWEEDFS_FILER_SNOWFLAKE_ID knob; inodes are now deterministic across filers.

* chore: remove the experimental NFS gateway

The NFS frontend ('weed nfs') was the only consumer of the inode->path index. Remove the weed/server/nfs package, the command and its registration, the integration test harness, and the CI workflow; go mod tidy drops the willscott/go-nfs and go-nfs-client dependencies.

* refactor(filer): drop the inode->path index

With the NFS gateway gone, nothing reads it. A regular file's inode is a pure hash of its path and a hard link's is a hash of its shared HardLinkId -- both derivable on demand -- so the secondary KV index and its write/remove hooks are dead. Removes filer_inode_index.go and the recordInodeIndex hooks from the store wrapper.
2026-05-28 15:00:18 -07:00

167 lines
4.3 KiB
Go

package filer
import (
"context"
"os"
"testing"
"time"
"github.com/seaweedfs/seaweedfs/weed/pb"
"github.com/seaweedfs/seaweedfs/weed/util"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestEnsureEntryInodeMatchesFuseDerivation(t *testing.T) {
f := &Filer{}
crtime := time.Unix(1700000000, 0)
entry := &Entry{
FullPath: util.FullPath("/dir/file.txt"),
Attr: Attr{Crtime: crtime},
}
f.ensureEntryInode(entry)
// The filer stores exactly what the FUSE mount would compute for a
// non-hard-linked entry, and it is deterministic across calls.
assert.Equal(t, entry.FullPath.AsInode(crtime.Unix()), entry.Attr.Inode)
again := &Entry{FullPath: entry.FullPath, Attr: Attr{Crtime: crtime}}
f.ensureEntryInode(again)
assert.Equal(t, entry.Attr.Inode, again.Attr.Inode)
}
func TestEnsureEntryInodeSharesAcrossHardLinks(t *testing.T) {
f := &Filer{}
hardLinkId := NewHardLinkId()
a := &Entry{
FullPath: util.FullPath("/links/a.txt"),
Attr: Attr{Crtime: time.Unix(1700000000, 0)},
HardLinkId: hardLinkId,
}
b := &Entry{
FullPath: util.FullPath("/links/b.txt"),
Attr: Attr{Crtime: time.Unix(1800000000, 0)},
HardLinkId: hardLinkId,
}
f.ensureEntryInode(a)
f.ensureEntryInode(b)
// Every link to the same target resolves to one inode, independent of path
// or creation time.
assert.Equal(t, uint64(util.HashStringToLong(string(hardLinkId))), a.Attr.Inode)
assert.Equal(t, a.Attr.Inode, b.Attr.Inode)
}
func newTestFilerWithStubStore() (*Filer, *stubFilerStore) {
store := newStubFilerStore()
f := NewFiler(pb.ServerDiscovery{}, nil, "", "", "", "", "", 255, nil)
f.Store = NewFilerStoreWrapper(store)
return f, store
}
func TestCreateEntryAssignsInodeWhenMissing(t *testing.T) {
f, store := newTestFilerWithStubStore()
entry := &Entry{
FullPath: util.FullPath("/dir/file.txt"),
Attr: Attr{
Mode: 0o644,
},
}
err := f.CreateEntry(context.Background(), entry, nil, false, false, nil, false, f.MaxFilenameLength)
require.NoError(t, err)
stored, findErr := store.FindEntry(context.Background(), entry.FullPath)
require.NoError(t, findErr)
require.NotNil(t, stored)
assert.NotZero(t, stored.Attr.Inode)
assert.NotEqual(t, uint64(1), stored.Attr.Inode)
}
func TestCreateEntryAssignsInodesToAutoCreatedParents(t *testing.T) {
f, store := newTestFilerWithStubStore()
entry := &Entry{
FullPath: util.FullPath("/a/b/c.txt"),
Attr: Attr{
Mode: 0o644,
},
}
err := f.CreateEntry(context.Background(), entry, nil, false, false, nil, false, f.MaxFilenameLength)
require.NoError(t, err)
for _, path := range []string{"/a", "/a/b", "/a/b/c.txt"} {
stored, findErr := store.FindEntry(context.Background(), util.FullPath(path))
require.NoError(t, findErr, path)
require.NotNil(t, stored, path)
assert.NotZero(t, stored.Attr.Inode, path)
}
}
func TestUpdateEntryPreservesExistingInode(t *testing.T) {
f, store := newTestFilerWithStubStore()
original := &Entry{
FullPath: util.FullPath("/doc.txt"),
Attr: Attr{
Mode: 0o644,
Inode: 12345,
},
}
require.NoError(t, store.InsertEntry(context.Background(), original))
updated := &Entry{
FullPath: util.FullPath("/doc.txt"),
Attr: Attr{
Mode: os.ModeDir | 0o755,
},
}
err := f.UpdateEntry(context.Background(), original, updated)
require.Error(t, err)
updated = &Entry{
FullPath: util.FullPath("/doc.txt"),
Attr: Attr{
Mode: 0o600,
},
}
err = f.UpdateEntry(context.Background(), original, updated)
require.NoError(t, err)
stored, findErr := store.FindEntry(context.Background(), original.FullPath)
require.NoError(t, findErr)
require.NotNil(t, stored)
assert.Equal(t, uint64(12345), stored.Attr.Inode)
}
func TestUpdateEntryBackfillsMissingLegacyInode(t *testing.T) {
f, store := newTestFilerWithStubStore()
original := &Entry{
FullPath: util.FullPath("/legacy.txt"),
Attr: Attr{
Mode: 0o644,
},
}
require.NoError(t, store.InsertEntry(context.Background(), original))
updated := &Entry{
FullPath: util.FullPath("/legacy.txt"),
Attr: Attr{
Mode: 0o640,
},
}
err := f.UpdateEntry(context.Background(), original, updated)
require.NoError(t, err)
stored, findErr := store.FindEntry(context.Background(), original.FullPath)
require.NoError(t, findErr)
require.NotNil(t, stored)
assert.NotZero(t, stored.Attr.Inode)
assert.NotEqual(t, uint64(1), stored.Attr.Inode)
}