mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-11-16 08:45:22 +01:00
* s3 lifecycle: walk checkpoints take each entry's resume position Versions of one object share a Path, so a checkpoint set from Path after the first version made a resume skip the rest. The ListFunc now gives each entry the start value that continues after it, and leaves it empty on all but an object's last version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: resume a bucket listing where the walk stopped The filer listing skipped entries with key <= start, but its order is not key order: each directory emits its .versions groups before its files, and a directory's children come before a sibling like dir.txt. Positions are now one (pass, name) frame per directory level, so a resume seeds each listing and skips exactly what was finished. A version group is one unit, and a skipped group still keeps its bare null version out of the second pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: content hash of a walk view Hashes every non-disabled action of a view and the versioning of their buckets, so a saved walk position can be tied to the walk it came from: another rule set, another walk mode, or a bucket that turned versioned gives another hash. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: persist daily walk progress and resume it A walk that failed or was cut short started over on the next pass, listing again every bucket it had already finished. WalkBuckets now keeps the finished buckets and each unfinished bucket's position in a checkpoint file next to the shard cursors, one per shard set, and the next walk of the same view and shards resumes from it. The record is saved every 30s and when the walk stops, and cleared when a walk completes, so the next walk is full again and sees keys added behind the position; a clear that fails fails the walk rather than leave a record that would skip buckets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: a stuck resumed walk starts over A bucket that fails at the same place on every pass kept the walk from completing, so the buckets it had finished were never walked again and their due objects waited forever. A resumed walk that fails again without finishing anything clears its checkpoint, and the next walk is full. A canceled walk keeps it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: do not resume a walk checkpoint left for a week A checkpoint is cleared only by a later walk of the same shard set, so a set that stopped walking, such as a one-off per-shard walk, left its record behind, and a walk of that set much later would skip buckets finished long before. Records now carry their save time and are not resumed after seven days; a walk that keeps retrying saves on every attempt and stays fresh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: a failed walk without progress leaves its checkpoint alone A pass canceled while it read the checkpoint failed the read, then saved its own empty progress over the record it never loaded, so the next pass started every bucket again. A failed walk that finished nothing has nothing new to record and no longer writes; the stuck resume reset still clears. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: space out walk checkpoint saves after a failed one The save time advanced only on success, so once the filer refused a periodic save every following entry tried again and logged another warning. The interval now counts from the last attempt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: a walk checkpoint save that errors may still be on disk A save whose reply was lost left onDisk false, so a walk that then completed skipped the clear and the next walk resumed from the stale record instead of walking everything. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: keep a stalled walk checkpoint for a day A resumed walk that failed again without progress dropped its record right away, so an outage spanning two attempts restarted the whole walk. Treat the walk as stuck only once its record has not advanced for a day. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: a resumed walk counts its earlier buckets as walked Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: replay a resumed recovery walk from the walk that began it A recovery or cold-start pass rewinds replay to runNow - maxTTL. When the walk resumed a checkpoint, its finished buckets were listed in an earlier attempt, so an object there that was not yet due then and whose write is now older than maxTTL was neither expired by the walk nor replayed. The checkpoint now keeps the start of the walk that began it, WalkBuckets returns that time (its own start for a fresh walk), and runShard floors the recovery rewind and the cold-start replay at it. A record without a start is not resumed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: a cold start that resumed a walk replays on the next pass The pass's shared subscription starts at runNow - maxTTL for a shard without a cursor, before its walk reports an earlier start, so flooring the cold-start drain at the walk start could not deliver the older events. Such a shard now saves its cursor at the walk start minus maxTTL and returns, like the recovery branch, and the next pass replays the window from that cursor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: test that a cursor below the floor opens the next subscription Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * s3 lifecycle: test the cold-start replay across two Run passes A cold start whose walk resumed an earlier attempt sees an older event only on the next pass. The test runs Run twice against a filer that serves events past the requested floor, with a later in-window event that would otherwise move the cursor past the older one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
212 lines
7.2 KiB
Go
212 lines
7.2 KiB
Go
// Package bootstrap is the bucket-level lifecycle walker. The walker
|
|
// iterates every entry under a bucket, evaluates every active ActionKey
|
|
// against it, and dispatches inline-delete RPCs for currently-due actions;
|
|
// not-yet-due entries are left for the meta-log reader to pick up later.
|
|
//
|
|
// Callback-driven so the listing source and the LifecycleDelete dispatcher
|
|
// can be supplied separately (real client or test fake).
|
|
package bootstrap
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3lifecycle"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3lifecycle/engine"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3lifecycle/router"
|
|
"github.com/seaweedfs/seaweedfs/weed/stats"
|
|
)
|
|
|
|
// Entry is the routing-relevant slice of a filer entry. SuccessorModTime
|
|
// and NoncurrentIndex are populated only on versioned-bucket walks; the
|
|
// retention path bails out conservatively when they're zero / nil.
|
|
//
|
|
// MPU init directories at .uploads/<id> populate DestKey with the
|
|
// destination object key (from entry.Extended[ExtMultipartObjectKey]) so
|
|
// rule-prefix matching works on the user's intended path while Path
|
|
// stays as the upload directory the dispatcher must rm.
|
|
type Entry struct {
|
|
Path string
|
|
DestKey string
|
|
ModTime time.Time
|
|
Size int64
|
|
IsDirectory bool
|
|
IsLatest bool
|
|
IsDeleteMarker bool
|
|
IsMPUInit bool
|
|
NumVersions int
|
|
Tags map[string]string
|
|
|
|
SuccessorModTime time.Time
|
|
NoncurrentIndex *int
|
|
|
|
// VersionID is the S3 version id of this entry, empty for
|
|
// non-versioned buckets. Populated by the ListFunc adapter when
|
|
// the entry came from a `.versions/` directory; the walker itself
|
|
// doesn't use it, but the Dispatcher needs it to address the
|
|
// right version on LifecycleDelete.
|
|
VersionID string
|
|
|
|
// Identity is the listed entry's fingerprint; the server refuses the
|
|
// delete when the live entry no longer matches it.
|
|
Identity *router.EntryIdentity
|
|
|
|
// Resume is the ListFunc start value that continues the walk after
|
|
// this entry. Empty keeps the previous position, as for every
|
|
// version of an object but its last.
|
|
Resume string
|
|
}
|
|
|
|
// ListFunc lists the bucket, starting after start: "" or the Resume of
|
|
// an entry an earlier walk finished.
|
|
type ListFunc func(ctx context.Context, bucket, start string, cb func(*Entry) error) error
|
|
|
|
// Dispatcher executes one (action, entry) verdict. An error halts the walk;
|
|
// the caller decides whether to retry from the recorded last_scanned_path.
|
|
type Dispatcher interface {
|
|
Delete(ctx context.Context, action *engine.CompiledAction, entry *Entry) error
|
|
}
|
|
|
|
// Checkpoint is the resume state: LastScannedPath is the Resume of the
|
|
// last finished entry, to pass back as WalkOptions.Resume.
|
|
type Checkpoint struct {
|
|
LastScannedPath string
|
|
Completed bool
|
|
}
|
|
|
|
type WalkOptions struct {
|
|
Resume string
|
|
Now time.Time
|
|
}
|
|
|
|
// Walk iterates entries via list, evaluates each active ActionKey via
|
|
// MatchPath + EvaluateAction, and calls Dispatcher.Delete for currently-due
|
|
// actions. SCAN_AT_DATE actions are skipped (their bootstrap is scheduled
|
|
// separately).
|
|
func Walk(ctx context.Context, snap *engine.Snapshot, bucket string, list ListFunc, dispatch Dispatcher, opts WalkOptions) (Checkpoint, error) {
|
|
now := opts.Now
|
|
if now.IsZero() {
|
|
now = time.Now().UTC()
|
|
}
|
|
cp := Checkpoint{LastScannedPath: opts.Resume}
|
|
|
|
// Reuse one ObjectInfo across the walk; EvaluateAction reads it
|
|
// synchronously without retaining.
|
|
var info s3lifecycle.ObjectInfo
|
|
|
|
err := list(ctx, bucket, opts.Resume, func(entry *Entry) error {
|
|
if entry == nil || entry.Path == "" {
|
|
return nil
|
|
}
|
|
// MPU init directories at .uploads/<id> are the one directory
|
|
// shape lifecycle cares about; everything else stays out.
|
|
if !entry.IsDirectory || entry.IsMPUInit {
|
|
if err := walkEntry(ctx, snap, bucket, entry, dispatch, now, &info); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
if entry.Resume != "" {
|
|
cp.LastScannedPath = entry.Resume
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return cp, err
|
|
}
|
|
cp.Completed = true
|
|
return cp, nil
|
|
}
|
|
|
|
func walkEntry(ctx context.Context, snap *engine.Snapshot, bucket string, entry *Entry, dispatch Dispatcher, now time.Time, info *s3lifecycle.ObjectInfo) error {
|
|
// MPU init: rule-prefix matching uses the destination key, not the
|
|
// .uploads/<id> directory path. A bare directory with no DestKey is
|
|
// either a stray dir or an init mid-write before metadata landed —
|
|
// skip rather than guess.
|
|
matchKey := entry.Path
|
|
if entry.IsMPUInit {
|
|
if entry.DestKey == "" {
|
|
return nil
|
|
}
|
|
matchKey = entry.DestKey
|
|
}
|
|
keys := snap.MatchPath(bucket, matchKey, nil)
|
|
if len(keys) == 0 {
|
|
return nil
|
|
}
|
|
*info = s3lifecycle.ObjectInfo{
|
|
Key: matchKey,
|
|
ModTime: entry.ModTime,
|
|
Size: entry.Size,
|
|
IsLatest: entry.IsLatest,
|
|
IsDeleteMarker: entry.IsDeleteMarker,
|
|
IsMPUInit: entry.IsMPUInit,
|
|
NumVersions: entry.NumVersions,
|
|
SuccessorModTime: entry.SuccessorModTime,
|
|
NoncurrentIndex: entry.NoncurrentIndex,
|
|
Tags: entry.Tags,
|
|
}
|
|
for _, key := range keys {
|
|
action := snap.Action(key)
|
|
if action == nil {
|
|
continue
|
|
}
|
|
// DISABLED can be flipped at runtime independent of XML Status,
|
|
// so skip it even though EvaluateAction would also reject.
|
|
// SCAN_AT_DATE actions are processed here too — the date check
|
|
// in EvaluateAction (now.Before(rule.ExpirationDate)) gates the
|
|
// dispatch, so pre-date walks are no-ops and post-date walks
|
|
// expire eligible objects. The earlier "scan-at-date runs its
|
|
// own bootstrap" plan was never wired; until that lands, the
|
|
// regular bootstrap walk is the only path that fires
|
|
// ExpirationDate rules.
|
|
if action.Mode == engine.ModeDisabled {
|
|
continue
|
|
}
|
|
// (kind, info) shape gate: ABORT_MPU only on MPU init records,
|
|
// every other kind only on regular objects/versions. Mismatched
|
|
// pairs would either dispatch a noncurrent action with empty
|
|
// version_id (server BLOCKs, cursor freezes) or dispatch
|
|
// ABORT_MPU against a regular object path.
|
|
if entry.IsMPUInit && key.ActionKind != s3lifecycle.ActionKindAbortMPU {
|
|
continue
|
|
}
|
|
if !entry.IsMPUInit && key.ActionKind == s3lifecycle.ActionKindAbortMPU {
|
|
continue
|
|
}
|
|
res := s3lifecycle.EvaluateAction(action.Rule, key.ActionKind, info, now)
|
|
if res.Action == s3lifecycle.ActionNone {
|
|
continue
|
|
}
|
|
if err := dispatch.Delete(ctx, action, entry); err != nil {
|
|
glog.Warningf("lifecycle bootstrap: dispatch %s/%s kind=%s: %v",
|
|
bucket, entry.Path, key.ActionKind, err)
|
|
return err
|
|
}
|
|
stats.S3LifecycleBootstrapDispatchCounter.WithLabelValues(bucket, key.ActionKind.String()).Inc()
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// EntryCallback wraps an in-memory slice as a ListFunc that resumes by
|
|
// Path; useful for tests.
|
|
func EntryCallback(entries []*Entry) ListFunc {
|
|
return func(ctx context.Context, bucket, start string, cb func(*Entry) error) error {
|
|
for _, e := range entries {
|
|
if start != "" && e.Path <= start {
|
|
continue
|
|
}
|
|
if e != nil && e.Resume == "" {
|
|
e.Resume = e.Path
|
|
}
|
|
if err := cb(e); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func HasPrefix(path, prefix string) bool { return strings.HasPrefix(path, prefix) }
|