mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-20 13:04:25 +02:00
* fix(s3/lifecycle): reader handles bare /buckets parent and pre-normalizes prefix extractBucketKey accepted /buckets/ but rejected /buckets (no trailing slash); some delete events emit the bare form, so bucket-root events were silently dropped. Pre-normalize BucketsPath once on Run instead of recomputing per event. * perf(s3/lifecycle): pool sha256 hashers in ShardID ShardID runs on every meta-log event before the shard filter; a fresh sha256.New per call produces measurable allocator pressure under load. sync.Pool reuses hashers across calls. * fix(s3/lifecycle): router skips hard deletes and missing-attribute events A hard delete carries no schedule-relevant state — Expiration would hit NOOP_RESOLVED at dispatch and ExpiredObjectDeleteMarker fires from a Create on the latest version. Skip rather than burn a schedule slot. Missing Attributes leaves ModTime at year 0001, which makes ExpirationDays fire immediately at dispatch. Skip the event instead. Drop the unused 'versioned' parameter from buildObjectInfo; the dispatcher's identity-CAS handles version drift in Phase 5. * fix(s3/lifecycle): EntryIdentity.MtimeNs holds true nanoseconds Both computeEntryIdentity (server) and buildIdentity (router) wrote entry.Attributes.Mtime (seconds) into a field named MtimeNs. The CAS worked because both sides agreed, but the encoding contradicted the field name and would break if either side later started using true nanoseconds. Combine Mtime*1e9 + the FuseAttributes.MtimeNs nanosecond component on both sides; the test was updated to match. * fix(s3/lifecycle): dispatcher distinguishes ctx cancel from transport errors A canceled or deadline-exceeded RPC is shutdown, not a transport failure: re-queue the Match at its original DueTime with no retry-budget burn so a quick restart can't escalate it to BLOCKED. * fix(s3/lifecycle): reader fallback prefix normalization mirrors Run The fallback path that builds prefix from r.BucketsPath when bucketsPathSlash is empty (test-only entry into extractBucketKey) was appending an unconditional '/', producing '//' if BucketsPath already ended with one. Use the same normalization Run does. * fix(s3/lifecycle): ObjectInfo.ModTime carries the nanosecond component ModTime dropped FuseAttributes.MtimeNs, leaving ExpirationDays one nanosecond off relative to EntryIdentity.MtimeNs. Pass both to time.Unix so the precision matches the CAS witness.
171 lines
5.1 KiB
Go
171 lines
5.1 KiB
Go
package router
|
|
|
|
import (
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3lifecycle"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3lifecycle/engine"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3lifecycle/reader"
|
|
)
|
|
|
|
// Match is one (event, action) pair where EvaluateAction fired. The
|
|
// dispatcher runs `LifecycleDelete` at DueTime; identity-CAS in the RPC
|
|
// guards against drift between schedule time and dispatch time.
|
|
type Match struct {
|
|
Key s3lifecycle.ActionKey
|
|
Action *engine.CompiledAction
|
|
Result s3lifecycle.EvalResult
|
|
EventTs time.Time
|
|
DueTime time.Time
|
|
Bucket string
|
|
ObjectKey string
|
|
VersionID string
|
|
Identity *EntryIdentity
|
|
}
|
|
|
|
// EntryIdentity is the schedule-time CAS witness; the dispatcher serializes
|
|
// it into the LifecycleDelete request. The fields mirror
|
|
// s3_lifecycle_pb.EntryIdentity but stay in-package so the router doesn't
|
|
// pull a proto dependency.
|
|
type EntryIdentity struct {
|
|
MtimeNs int64
|
|
Size int64
|
|
HeadFid string
|
|
}
|
|
|
|
// Route returns the matches that fire for ev against snap. Only EVENT_DRIVEN
|
|
// actions on this bucket are considered; actions in SCAN_AT_DATE or DISABLED
|
|
// modes are out-of-band of the event stream. Inactive actions
|
|
// (BootstrapComplete=false) are also skipped.
|
|
func Route(snap *engine.Snapshot, ev *reader.Event, now time.Time) []Match {
|
|
if snap == nil || ev == nil {
|
|
return nil
|
|
}
|
|
// Hard deletes carry no schedule-relevant state: an Expiration would
|
|
// hit NOOP_RESOLVED at dispatch time anyway, ExpiredObjectDeleteMarker
|
|
// only fires on the latest-version delete-marker which is a Create
|
|
// from the server's perspective. Skip rather than burn a schedule slot.
|
|
if ev.NewEntry == nil {
|
|
return nil
|
|
}
|
|
keys := snap.BucketActionKeys(ev.Bucket)
|
|
if len(keys) == 0 {
|
|
return nil
|
|
}
|
|
info := buildObjectInfo(ev)
|
|
if info == nil {
|
|
return nil
|
|
}
|
|
eventTime := time.Unix(0, ev.TsNs)
|
|
|
|
var matches []Match
|
|
for _, key := range keys {
|
|
action := snap.Action(key)
|
|
if action == nil || !action.IsActive() {
|
|
continue
|
|
}
|
|
if action.Mode != engine.ModeEventDriven {
|
|
continue
|
|
}
|
|
// Evaluate at the scheduled dispatch time, not the event time:
|
|
// ExpirationDays gates on now >= modtime + N, which is exactly
|
|
// what holds when we actually dispatch. The dispatcher's
|
|
// identity-CAS catches drift if the object changes meanwhile.
|
|
dueTime := eventTime.Add(action.Delay)
|
|
res := s3lifecycle.EvaluateAction(action.Rule, key.ActionKind, info, dueTime)
|
|
if res.Action == s3lifecycle.ActionNone {
|
|
continue
|
|
}
|
|
matches = append(matches, Match{
|
|
Key: key,
|
|
Action: action,
|
|
Result: res,
|
|
EventTs: eventTime,
|
|
DueTime: dueTime,
|
|
Bucket: ev.Bucket,
|
|
ObjectKey: ev.Key,
|
|
Identity: buildIdentity(ev),
|
|
})
|
|
}
|
|
return matches
|
|
}
|
|
|
|
// buildObjectInfo derives a non-versioned ObjectInfo from a meta-log event.
|
|
// Versioned-bucket semantics (IsLatest, NumVersions, NoncurrentIndex,
|
|
// IsDeleteMarker for noncurrent versions) require listing siblings and land
|
|
// in Phase 5; for now any event is treated as IsLatest=true with the
|
|
// LifecycleDelete RPC's identity-CAS catching stale schedules.
|
|
//
|
|
// Returns nil when Attributes are missing — without ModTime, EvaluateAction
|
|
// would compute due against year-0001 and fire immediately.
|
|
func buildObjectInfo(ev *reader.Event) *s3lifecycle.ObjectInfo {
|
|
entry := ev.NewEntry
|
|
if entry == nil || entry.Attributes == nil {
|
|
return nil
|
|
}
|
|
info := &s3lifecycle.ObjectInfo{
|
|
Key: ev.Key,
|
|
ModTime: time.Unix(entry.Attributes.Mtime, int64(entry.Attributes.MtimeNs)),
|
|
Size: int64(entry.Attributes.FileSize),
|
|
IsLatest: true,
|
|
NumVersions: 1,
|
|
}
|
|
if tags := extractTags(entry.Extended); len(tags) > 0 {
|
|
info.Tags = tags
|
|
}
|
|
if isDeleteMarkerEntry(entry) {
|
|
info.IsDeleteMarker = true
|
|
}
|
|
return info
|
|
}
|
|
|
|
// buildIdentity captures the entry's schedule-time fingerprint for the CAS
|
|
// witness. Returns nil if the event has no entry to fingerprint (deletes).
|
|
func buildIdentity(ev *reader.Event) *EntryIdentity {
|
|
entry := ev.NewEntry
|
|
if entry == nil {
|
|
return nil
|
|
}
|
|
id := &EntryIdentity{}
|
|
if entry.Attributes != nil {
|
|
// Mirror the server-side computeEntryIdentity encoding: Mtime
|
|
// (seconds) and MtimeNs (nanosecond component) combine into
|
|
// EntryIdentity.MtimeNs as nanoseconds-since-epoch.
|
|
id.MtimeNs = entry.Attributes.Mtime*int64(1e9) + int64(entry.Attributes.MtimeNs)
|
|
id.Size = int64(entry.Attributes.FileSize)
|
|
}
|
|
if len(entry.GetChunks()) > 0 {
|
|
id.HeadFid = entry.GetChunks()[0].FileId
|
|
}
|
|
return id
|
|
}
|
|
|
|
func extractTags(ext map[string][]byte) map[string]string {
|
|
if len(ext) == 0 {
|
|
return nil
|
|
}
|
|
prefix := s3_constants.AmzObjectTagging + "-"
|
|
var out map[string]string
|
|
for k, v := range ext {
|
|
if !strings.HasPrefix(k, prefix) {
|
|
continue
|
|
}
|
|
if out == nil {
|
|
out = map[string]string{}
|
|
}
|
|
out[k[len(prefix):]] = string(v)
|
|
}
|
|
return out
|
|
}
|
|
|
|
func isDeleteMarkerEntry(entry *filer_pb.Entry) bool {
|
|
if entry == nil || len(entry.Extended) == 0 {
|
|
return false
|
|
}
|
|
v, ok := entry.Extended[s3_constants.ExtDeleteMarkerKey]
|
|
return ok && len(v) == 1 && v[0] == 1
|
|
}
|