mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-08 15:41:15 +02:00
* s3tables: report a delete the filer rejected deleteDirectory discarded DeleteEntryResponse and checked only the transport error, so DeleteTable, DeleteNamespace, DeleteView and DeleteTableBucket answered 200 for a delete the filer refused. Call filer_pb.DoRemove, which reads resp.Error and still treats a missing entry as success. Claude-Session: https://claude.ai/code/session_01BjDWtZsCoZY6x4pdDmGWxU * admin: report a delete the filer rejected The bucket delete, the file browser handlers and the topic retention purger all discarded DeleteEntryResponse, so a delete the filer refused came back as success. Call filer_pb.DoRemove, which reads resp.Error. Claude-Session: https://claude.ai/code/session_01BjDWtZsCoZY6x4pdDmGWxU * credential: report a delete the filer rejected DeleteUser, DeletePolicy and the full-sync cleanup loops discarded DeleteEntryResponse, so a rejected delete answered success and left the credential file in place. The service account path in the same store already read resp.Error; the rest now do too, via filer_pb.DoRemove where not-found is already tolerated. Claude-Session: https://claude.ai/code/session_01BjDWtZsCoZY6x4pdDmGWxU * shell: report a delete the filer rejected remote.configure -delete, remote.cache and the remote metadata sync discarded DeleteEntryResponse, so a rejected delete printed as removed. Call filer_pb.DoRemove, which reads resp.Error. Claude-Session: https://claude.ai/code/session_01BjDWtZsCoZY6x4pdDmGWxU * mq: report a delete the filer rejected The consumer offset group purge and the coordinator assignment delete discarded DeleteEntryResponse. Call filer_pb.DoRemove, which reads resp.Error. Claude-Session: https://claude.ai/code/session_01BjDWtZsCoZY6x4pdDmGWxU * iam: count only the revocation entries the filer actually deleted The expiry sweep discarded DeleteEntryResponse, so a rejected delete was counted as purged and the entry stayed. Call filer_pb.DoRemove, which reads resp.Error, matching the role and provider stores beside it. Claude-Session: https://claude.ai/code/session_01BjDWtZsCoZY6x4pdDmGWxU * mount: fail rmdir when the unary fallback delete was rejected The streaming branch turns DeleteEntryResponse.Error into an error, the unary fallback dropped it, so rmdir of a non-empty directory answered OK off the stream and ENOTEMPTY on it. Surface it in both. Claude-Session: https://claude.ai/code/session_01BjDWtZsCoZY6x4pdDmGWxU * s3tables: fail DeleteTableBucket when the directory delete is refused The handler only failed when both the leaf entry and the directory delete failed, so a refused bucket directory delete still answered 200 with the bucket in place. The directory is the bucket, so it decides; the leaf entry stays best-effort. Claude-Session: https://claude.ai/code/session_01BjDWtZsCoZY6x4pdDmGWxU
243 lines
8.1 KiB
Go
243 lines
8.1 KiB
Go
// Package s3tablestest provides an in-memory filer for driving S3 Tables and
|
|
// Lance namespace operations end-to-end without a live cluster.
|
|
package s3tablestest
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"net"
|
|
"path"
|
|
"sort"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
|
|
"google.golang.org/grpc"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/credentials/insecure"
|
|
"google.golang.org/grpc/status"
|
|
)
|
|
|
|
// MemFiler is an in-memory filer used to drive Manager operations
|
|
// end-to-end without a live cluster.
|
|
type MemFiler struct {
|
|
filer_pb.UnimplementedSeaweedFilerServer
|
|
// mu guards entries. The real filer serves concurrent RPCs, and a test that
|
|
// races writers against each other - the point of an exclusive create - hits
|
|
// this map from several goroutines at once.
|
|
mu sync.RWMutex
|
|
entries map[string]map[string]*filer_pb.Entry // dir -> name -> entry
|
|
Client filer_pb.SeaweedFilerClient
|
|
// BeforeUpdate runs once, at the start of the next UpdateEntry, so a test
|
|
// can land a competing write in a handler's read-to-write window.
|
|
BeforeUpdate func()
|
|
// RejectDelete returns the reason DeleteEntry refuses a path, answered the
|
|
// way the filer answers one: no transport error, the reason in the response.
|
|
RejectDelete func(dir, name string) string
|
|
}
|
|
|
|
func newMemFiler() *MemFiler {
|
|
return &MemFiler{entries: make(map[string]map[string]*filer_pb.Entry)}
|
|
}
|
|
|
|
func (f *MemFiler) Get(dir, name string) *filer_pb.Entry {
|
|
f.mu.RLock()
|
|
defer f.mu.RUnlock()
|
|
if d, ok := f.entries[dir]; ok {
|
|
return d[name]
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (f *MemFiler) Put(dir, name string, extended map[string][]byte) {
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
if _, ok := f.entries[dir]; !ok {
|
|
f.entries[dir] = make(map[string]*filer_pb.Entry)
|
|
}
|
|
f.entries[dir][name] = &filer_pb.Entry{Name: name, IsDirectory: true, Extended: extended}
|
|
}
|
|
|
|
// PutFile adds a file entry with an explicit modification time, which callers
|
|
// that age entries out (orphan cleanup, expiry) need in order to see them.
|
|
func (f *MemFiler) PutFile(dir, name string, mtime time.Time) {
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
if _, ok := f.entries[dir]; !ok {
|
|
f.entries[dir] = make(map[string]*filer_pb.Entry)
|
|
}
|
|
f.entries[dir][name] = &filer_pb.Entry{
|
|
Name: name,
|
|
Attributes: &filer_pb.FuseAttributes{Mtime: mtime.Unix(), Crtime: mtime.Unix()},
|
|
}
|
|
}
|
|
|
|
func (f *MemFiler) LookupDirectoryEntry(_ context.Context, req *filer_pb.LookupDirectoryEntryRequest) (*filer_pb.LookupDirectoryEntryResponse, error) {
|
|
if e := f.Get(req.Directory, req.Name); e != nil {
|
|
return &filer_pb.LookupDirectoryEntryResponse{Entry: e}, nil
|
|
}
|
|
// Carry the sentinel text so filer_pb.LookupEntry maps it to ErrNotFound.
|
|
return nil, status.Errorf(codes.NotFound, "%s: %s/%s", filer_pb.ErrNotFound.Error(), req.Directory, req.Name)
|
|
}
|
|
|
|
// ListEntries honours prefix, start-from and limit the way the real filer does.
|
|
// A harness that ignores them makes a paginating caller re-read the first page
|
|
// forever, which looks like duplicated entries rather than a broken listing.
|
|
func (f *MemFiler) ListEntries(req *filer_pb.ListEntriesRequest, stream grpc.ServerStreamingServer[filer_pb.ListEntriesResponse]) error {
|
|
f.mu.RLock()
|
|
d, ok := f.entries[req.Directory]
|
|
names := make([]string, 0, len(d))
|
|
snapshot := make(map[string]*filer_pb.Entry, len(d))
|
|
for name, entry := range d {
|
|
names = append(names, name)
|
|
snapshot[name] = entry
|
|
}
|
|
f.mu.RUnlock()
|
|
if !ok {
|
|
return nil
|
|
}
|
|
sort.Strings(names)
|
|
|
|
sent := uint32(0)
|
|
for _, name := range names {
|
|
if req.Prefix != "" && !strings.HasPrefix(name, req.Prefix) {
|
|
continue
|
|
}
|
|
if req.StartFromFileName != "" {
|
|
if name < req.StartFromFileName {
|
|
continue
|
|
}
|
|
if name == req.StartFromFileName && !req.InclusiveStartFrom {
|
|
continue
|
|
}
|
|
}
|
|
if err := stream.Send(&filer_pb.ListEntriesResponse{Entry: snapshot[name]}); err != nil {
|
|
return err
|
|
}
|
|
sent++
|
|
if req.Limit > 0 && sent >= req.Limit {
|
|
return nil
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (f *MemFiler) CreateEntry(_ context.Context, req *filer_pb.CreateEntryRequest) (*filer_pb.CreateEntryResponse, error) {
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
if _, ok := f.entries[req.Directory]; !ok {
|
|
f.entries[req.Directory] = make(map[string]*filer_pb.Entry)
|
|
}
|
|
// O_EXCL is the filer's put-if-not-exists. Ignoring it here would let a test
|
|
// that races two writers see both of them win.
|
|
if _, exists := f.entries[req.Directory][req.Entry.Name]; exists && req.OExcl {
|
|
return &filer_pb.CreateEntryResponse{ErrorCode: filer_pb.FilerError_ENTRY_ALREADY_EXISTS}, nil
|
|
}
|
|
f.entries[req.Directory][req.Entry.Name] = req.Entry
|
|
return &filer_pb.CreateEntryResponse{}, nil
|
|
}
|
|
|
|
func (f *MemFiler) UpdateEntry(_ context.Context, req *filer_pb.UpdateEntryRequest) (*filer_pb.UpdateEntryResponse, error) {
|
|
// The hook runs before the lock is taken: its whole purpose is to land a
|
|
// competing write in the read-to-write window, and that write needs the lock.
|
|
if hook := f.BeforeUpdate; hook != nil {
|
|
f.BeforeUpdate = nil
|
|
hook()
|
|
}
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
// The real filer validates ExpectedExtended under the per-path lock; without
|
|
// it here a lost update would look like a success.
|
|
for key, expected := range req.ExpectedExtended {
|
|
var actual []byte
|
|
if d, ok := f.entries[req.Directory]; ok {
|
|
if existing := d[req.Entry.Name]; existing != nil {
|
|
actual = existing.Extended[key]
|
|
}
|
|
}
|
|
if !bytes.Equal(actual, expected) {
|
|
return nil, status.Errorf(codes.FailedPrecondition, "extended attribute %q changed", key)
|
|
}
|
|
}
|
|
if _, ok := f.entries[req.Directory]; !ok {
|
|
f.entries[req.Directory] = make(map[string]*filer_pb.Entry)
|
|
}
|
|
f.entries[req.Directory][req.Entry.Name] = req.Entry
|
|
return &filer_pb.UpdateEntryResponse{}, nil
|
|
}
|
|
|
|
func (f *MemFiler) DeleteEntry(_ context.Context, req *filer_pb.DeleteEntryRequest) (*filer_pb.DeleteEntryResponse, error) {
|
|
if reject := f.RejectDelete; reject != nil {
|
|
if reason := reject(req.Directory, req.Name); reason != "" {
|
|
return &filer_pb.DeleteEntryResponse{Error: reason}, nil
|
|
}
|
|
}
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
if d, ok := f.entries[req.Directory]; ok {
|
|
delete(d, req.Name)
|
|
}
|
|
// Honor recursive data deletion so a regression that wipes the table directory
|
|
// also drops its metadata/ and data/ children (the data-loss this guards against).
|
|
if req.IsRecursive && req.IsDeleteData {
|
|
child := path.Join(req.Directory, req.Name)
|
|
for dir := range f.entries {
|
|
if dir == child || strings.HasPrefix(dir, child+"/") {
|
|
delete(f.entries, dir)
|
|
}
|
|
}
|
|
}
|
|
return &filer_pb.DeleteEntryResponse{}, nil
|
|
}
|
|
|
|
// GetFilerConfiguration answers with the defaults, so operations that resolve
|
|
// the buckets directory before touching an entry work against this filer.
|
|
func (f *MemFiler) GetFilerConfiguration(_ context.Context, _ *filer_pb.GetFilerConfigurationRequest) (*filer_pb.GetFilerConfigurationResponse, error) {
|
|
return &filer_pb.GetFilerConfigurationResponse{DirBuckets: s3_constants.DefaultBucketsPath}, nil
|
|
}
|
|
|
|
func (f *MemFiler) Ping(_ context.Context, _ *filer_pb.PingRequest) (*filer_pb.PingResponse, error) {
|
|
now := time.Now().UnixNano()
|
|
return &filer_pb.PingResponse{StartTimeNs: now, RemoteTimeNs: now, StopTimeNs: now}, nil
|
|
}
|
|
|
|
func Start(t *testing.T) *MemFiler {
|
|
t.Helper()
|
|
fs := newMemFiler()
|
|
|
|
listener, err := net.Listen("tcp", "127.0.0.1:0")
|
|
if err != nil {
|
|
t.Fatalf("start filer: %v", err)
|
|
}
|
|
|
|
server := grpc.NewServer()
|
|
filer_pb.RegisterSeaweedFilerServer(server, fs)
|
|
go func() { _ = server.Serve(listener) }()
|
|
t.Cleanup(server.GracefulStop)
|
|
|
|
conn, err := grpc.NewClient(listener.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
if err != nil {
|
|
t.Fatalf("start filer: %v", err)
|
|
}
|
|
t.Cleanup(func() { _ = conn.Close() })
|
|
|
|
fs.Client = filer_pb.NewSeaweedFilerClient(conn)
|
|
deadline := time.Now().Add(5 * time.Second)
|
|
for {
|
|
pingCtx, cancel := context.WithTimeout(context.Background(), 50*time.Millisecond)
|
|
_, err := fs.Client.Ping(pingCtx, &filer_pb.PingRequest{})
|
|
cancel()
|
|
if err == nil {
|
|
break
|
|
}
|
|
if time.Now().After(deadline) {
|
|
t.Fatalf("filer not ready: %v", err)
|
|
}
|
|
time.Sleep(10 * time.Millisecond)
|
|
}
|
|
return fs
|
|
}
|