mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-26 23:10:44 +01:00
* util: add listenOnLocalhost parameter to NewIpAndLocalListeners Nil keeps the current behavior of also binding localhost when the host is a specific address; all callers pass nil for now. * command: add -ip.bind.localhost flag to opt out of the extra localhost listener Binding a command to a specific -ip.bind address also opened a second listener on localhost for every port, with no way to turn it off. Each command that calls NewIpAndLocalListeners (master, master.follower, filer, s3, iam, volume, sftp, mq.broker, mq.agent) now accepts -ip.bind.localhost=false to bind only the requested address. Embedded services get prefixed flags (s3.ip.bind.localhost, sftp.ip.bind.localhost, iam.ip.bind.localhost), and the command-level flag also disables them so a single switch turns off every extra listener the command opens. * mini: only require all-interface port availability while the loopback listener is on With -ip.bind.localhost=false each service binds just -ip.bind, so a port held on another address no longer collides; the all-interface precheck would reject or relocate usable ports. WebDAV, the Admin UI, and the Admin worker gRPC (which binds -admin.worker.ip, not -ip.bind) never open a loopback companion listener, so their checks now use the address they actually bind. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * mq.broker: bind the gRPC listener to -ip.bind instead of all interfaces The listener used an empty host so -ip was ignored for binding and the localhost companion was never created, leaving -ip.bind.localhost with nothing to control. Give the broker the same -ip/-ip.bind pair the other servers use; embedded mode binds to -ip.bind like its peers. * server: add -sftp.ip.bind.localhost and -iam.ip.bind.localhost switches weed filer already exposes the prefixed opt-outs for its embedded sftp and iam; give weed server the same pair so each extra listener can be disabled individually while -ip.bind.localhost=false still turns them all off. * mq.broker: keep the default all-interface bind unless localhost is off An unset -ip.bind used to mean the standalone broker listened on every interface; defaulting it to -ip silently cut off multi-homed clients. Only fall back to -ip when -ip.bind.localhost=false, where a specific bind is needed for the opt-out to take effect. * mini: validate the Admin HTTP port on the address it will bind The port check always used -ip.bind while startMiniAdminWithWorker falls back to loopback when Admin has no credential, so a loopback-held port passed validation and killed the admin at startup. * mq.broker: keep the all-interface default bind when -ip.bind is unset -ip only becomes the fallback once -ip.bind.localhost=false needs a specific address for the listener. Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * mini: validate the Admin HTTP port on its effective bind IP When the Admin listener falls back to loopback (no credential or mTLS configured), the pre-flight port check now probes that same address instead of -ip.bind. Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * util: keep NewIpAndLocalListeners source-compatible for 3-arg callers * command: drop the -ip.bind.localhost flag; an explicit -ip.bind drops the extra listener Instead of an opt-out flag, the loopback companion listener now simply follows whether the bind address was chosen: it is created only while -ip.bind is unset and the bind address falls back to -ip. Passing -ip.bind=<addr> binds each port to exactly that address. Each service options struct carries a listenOnLocalhost *bool that embedders (weed server, weed mini, embedded s3/sftp/iam in weed filer) set from the parent's -ip.bind state, captured before the bind flag is repointed or filled in by the -ip fallback; standalone commands derive it from their own flag before the fallback runs. iam and mq.agent gain a real -ip.bind flag so they have a way to pin a single address. mq.broker keeps its new -ip.bind flag but drops the -ip.bind.localhost fallback hack: empty still listens on all interfaces. * server: default embedded mq.agent brokers to the broker's bind address With an explicit -ip.bind the embedded broker no longer listens on localhost, so an unset -mq.agent.brokers defaulting to localhost:17777 could not reach it. Default to <serverBindIp>:<mq.broker.port> (the address the embedded broker binds), falling back to localhost when the bind address is a wildcard. An explicit -mq.agent.brokers still wins. Also fix the NewIpAndLocalListeners skip message to say localhost. * server: bind embedded mq.agent to serverBindIp The embedded agent's ipBind was never set, so startQueueAgent fell back to the advertised -ip address and an explicit -ip.bind did not pin the agent listener. --------- Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
174 lines
6.2 KiB
Go
174 lines
6.2 KiB
Go
package command
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/aws/aws-sdk-go/aws"
|
|
"github.com/gorilla/mux"
|
|
"google.golang.org/grpc/reflection"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/master_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/security"
|
|
weed_server "github.com/seaweedfs/seaweedfs/weed/server"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
"github.com/seaweedfs/seaweedfs/weed/util/version"
|
|
)
|
|
|
|
var (
|
|
mf MasterOptions
|
|
)
|
|
|
|
func init() {
|
|
cmdMasterFollower.Run = runMasterFollower // break init cycle
|
|
mf.port = cmdMasterFollower.Flag.Int("port", 9334, "http listen port")
|
|
mf.portGrpc = cmdMasterFollower.Flag.Int("port.grpc", 0, "grpc listen port")
|
|
mf.ipBind = cmdMasterFollower.Flag.String("ip.bind", "", "ip address to bind to. Default to localhost.")
|
|
mf.peers = cmdMasterFollower.Flag.String("master", "localhost:9333", "all master nodes in comma separated ip:port list, example: 127.0.0.1:9093,127.0.0.1:9094,127.0.0.1:9095")
|
|
mf.mastersDeprecated = cmdMasterFollower.Flag.String("masters", "", "all master nodes in comma separated ip:port list (deprecated, use -master instead)")
|
|
// A follower serves /submit like the leader does, so it buffers uploads under
|
|
// the same limit and has to be told the same value. Left fixed at 256, a
|
|
// cluster raised above that would accept an upload through the leader and
|
|
// refuse the identical one through a follower.
|
|
mf.fileSizeLimitMB = cmdMasterFollower.Flag.Int("fileSizeLimitMB", 256, "limit the file size accepted by /submit, should match the leader's -fileSizeLimitMB")
|
|
|
|
mf.ip = aws.String(util.DetectedHostAddress())
|
|
mf.metaFolder = aws.String("")
|
|
mf.volumeSizeLimitMB = nil
|
|
mf.volumePreallocate = nil
|
|
mf.defaultReplication = nil
|
|
mf.garbageThreshold = aws.Float64(0.1)
|
|
mf.whiteList = nil
|
|
mf.disableHttp = aws.Bool(false)
|
|
mf.metricsAddress = aws.String("")
|
|
mf.metricsIntervalSec = aws.Int(0)
|
|
mf.raftResumeState = aws.Bool(false)
|
|
mf.maxParallelVacuumPerServer = aws.Int(1)
|
|
mf.vacuumIntervalSeconds = aws.Int(840)
|
|
mf.vacuumDeleteEmptyAfterSeconds = aws.Int(0)
|
|
mf.telemetryUrl = aws.String("https://telemetry.seaweedfs.com/api/collect")
|
|
mf.telemetryEnabled = aws.Bool(false)
|
|
}
|
|
|
|
var cmdMasterFollower = &Command{
|
|
UsageLine: "master.follower -port=9333 -master=<master1Host>:<master1Port>",
|
|
Short: "start a master follower",
|
|
Long: `start a master follower to provide volume=>location mapping service
|
|
|
|
The master follower does not participate in master election.
|
|
It just follow the existing masters, and listen for any volume location changes.
|
|
|
|
In most cases, the master follower is not needed. In big data centers with thousands of volume
|
|
servers. In theory, the master may have trouble to keep up with the write requests and read requests.
|
|
|
|
The master follower can relieve the master from read requests, which only needs to
|
|
lookup a fileId or volumeId.
|
|
|
|
The master follower currently can handle fileId lookup requests:
|
|
/dir/lookup?volumeId=4
|
|
/dir/lookup?fileId=4,49c50924569199
|
|
And gRPC API
|
|
rpc LookupVolume (LookupVolumeRequest) returns (LookupVolumeResponse) {}
|
|
|
|
This master follower is stateless and can run from any place.
|
|
|
|
`,
|
|
}
|
|
|
|
func runMasterFollower(cmd *Command, args []string) bool {
|
|
|
|
util.LoadSecurityConfiguration()
|
|
util.LoadConfiguration("master", false)
|
|
|
|
// Backward compatibility: if -masters is provided, use it
|
|
if *mf.mastersDeprecated != "" {
|
|
*mf.peers = *mf.mastersDeprecated
|
|
}
|
|
|
|
if *mf.portGrpc == 0 {
|
|
*mf.portGrpc = 10000 + *mf.port
|
|
}
|
|
|
|
startMasterFollower(mf)
|
|
|
|
return true
|
|
}
|
|
|
|
func startMasterFollower(masterOptions MasterOptions) {
|
|
|
|
// collect settings from main masters
|
|
masters := pb.ServerAddresses(*mf.peers).ToAddressMap()
|
|
|
|
var err error
|
|
grpcDialOption := security.LoadClientTLS(util.GetViper(), "grpc.master")
|
|
for i := 0; i < 10; i++ {
|
|
err = pb.WithOneOfGrpcMasterClients(false, masters, grpcDialOption, func(client master_pb.SeaweedClient) error {
|
|
resp, err := client.GetMasterConfiguration(context.Background(), &master_pb.GetMasterConfigurationRequest{})
|
|
if err != nil {
|
|
return fmt.Errorf("get master grpc address %v configuration: %w", masters, err)
|
|
}
|
|
masterOptions.defaultReplication = &resp.DefaultReplication
|
|
masterOptions.volumeSizeLimitMB = aws.Uint(uint(resp.VolumeSizeLimitMB))
|
|
masterOptions.volumePreallocate = &resp.VolumePreallocate
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
glog.V(0).Infof("failed to talk to filer %v: %v", masters, err)
|
|
glog.V(0).Infof("wait for %d seconds ...", i+1)
|
|
time.Sleep(time.Duration(i+1) * time.Second)
|
|
}
|
|
}
|
|
if err != nil {
|
|
glog.Errorf("failed to talk to filer %v: %v", masters, err)
|
|
return
|
|
}
|
|
|
|
option := masterOptions.toMasterOption(nil)
|
|
option.IsFollower = true
|
|
|
|
listenOnLocalhost := *masterOptions.ipBind == ""
|
|
if masterOptions.listenOnLocalhost != nil {
|
|
listenOnLocalhost = *masterOptions.listenOnLocalhost
|
|
}
|
|
if *masterOptions.ipBind == "" {
|
|
*masterOptions.ipBind = *masterOptions.ip
|
|
}
|
|
|
|
r := mux.NewRouter()
|
|
ms := weed_server.NewMasterServer(r, option, masters)
|
|
listeningAddress := util.JoinHostPort(*masterOptions.ipBind, *masterOptions.port)
|
|
glog.V(0).Infof("Start Seaweed Master %s at %s", version.Version(), listeningAddress)
|
|
masterListener, masterLocalListener, e := util.NewIpAndLocalListeners(*masterOptions.ipBind, *masterOptions.port, 0, listenOnLocalhost)
|
|
if e != nil {
|
|
glog.Fatalf("Master startup error: %v", e)
|
|
}
|
|
|
|
// starting grpc server
|
|
grpcPort := *masterOptions.portGrpc
|
|
grpcL, grpcLocalL, err := util.NewIpAndLocalListeners(*masterOptions.ipBind, grpcPort, 0, listenOnLocalhost)
|
|
if err != nil {
|
|
glog.Fatalf("master failed to listen on grpc port %d: %v", grpcPort, err)
|
|
}
|
|
grpcS := pb.NewGrpcServer(security.LoadServerTLS(util.GetViper(), "grpc.master"))
|
|
master_pb.RegisterSeaweedServer(grpcS, ms)
|
|
reflection.Register(grpcS)
|
|
glog.V(0).Infof("Start Seaweed Master %s grpc server at %s:%d", version.Version(), *masterOptions.ip, grpcPort)
|
|
if grpcLocalL != nil {
|
|
go grpcS.Serve(grpcLocalL)
|
|
}
|
|
go grpcS.Serve(grpcL)
|
|
|
|
go ms.MasterClient.KeepConnectedToMaster(context.Background())
|
|
|
|
// start http server
|
|
if masterLocalListener != nil {
|
|
go newHttpServer(r, nil).Serve(masterLocalListener)
|
|
}
|
|
go newHttpServer(r, nil).Serve(masterListener)
|
|
|
|
select {}
|
|
}
|