mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-16 19:40:43 +02:00
* feat(s3/lifecycle): filer-backed cursor Persister FilerPersister persists per-shard cursor maps as JSON to /etc/s3/lifecycle/cursors/shard-NN.json via filer.SaveInsideFiler. One file per shard keeps Save atomic — the filer writes the entry in a single mutation, so a crash mid-write doesn't leak partial state. Pipeline.Run loads on start; the periodic checkpoint and graceful-shutdown save go through this implementation. A small FilerStore interface wraps the SeaweedFilerClient surface the persister needs, so tests inject an in-memory fake instead of mocking the full gRPC client. * refactor(s3/lifecycle): drop BlockerStore — durable cursor IS the block A frozen cursor doesn't advance, so the durable cursor (FilerPersister) encodes the blocked state on its own. On worker restart the reader re-encounters the poison event at MinTsNs, the dispatcher walks the same retry budget to BLOCKED, and the cursor freezes at the same EventTs. Other in-flight events between freeze tsNs and prior cursor positions self-resolve via NOOP_RESOLVED (STALE_IDENTITY) since the underlying objects were already deleted on the prior pass. Removed: - BlockerStore interface + InMemoryBlockerStore + BlockerRecord - Dispatcher.Blockers + Dispatcher.ReplayBlockers - the BlockerStore.Put call in handleBlocked - Pipeline.Blockers field + the ReplayBlockers call on startup Added a TestDispatchRestartReFreezesNaturally that pins the self-recovery property: a fresh Dispatcher with a fresh Cursor, fed the same poison event, reaches the same frozen state at the same EventTs without any durable blocker store. Operator visibility: a cursor whose MinTsNs hasn't advanced is the signal — surfaced via the durable cursor file. * refactor(filer): SaveInsideFiler accepts ctx ReadInsideFiler already takes ctx; SaveInsideFiler used context.Background() internally and silently dropped the caller's ctx. Symmetric API now; cancellation/deadlines propagate through LookupEntry / CreateEntry / UpdateEntry. Mechanical update of all callers — most pass context.Background() since the existing call sites have no ctx in scope. * fix(s3/lifecycle): deterministic order in cursor save Iterating Go maps yields random order, so json.Encode produced a different byte sequence on each save even when the state hadn't changed. Sort entries by (Bucket, ActionKind, RuleHash) before encoding so the on-disk file diffs cleanly. New test pins byte-identical output across two saves of the same map. * fix(s3/lifecycle): log reason when freezing cursor in handleBlocked handleBlocked dropped the reason via _ = reason with a comment claiming the caller logged it; none of the three callers do. A frozen cursor is the only surface where the operator finds out something stuck, so the reason has to land somewhere. glog.Warningf with shard, key, eventTs, and the original reason — same shape the rest of the package uses.
147 lines
3.9 KiB
Go
147 lines
3.9 KiB
Go
package shell
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"flag"
|
|
"fmt"
|
|
"io"
|
|
"math"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/filer"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
)
|
|
|
|
func init() {
|
|
Commands = append(Commands, &commandS3BucketQuotaEnforce{})
|
|
}
|
|
|
|
type commandS3BucketQuotaEnforce struct {
|
|
}
|
|
|
|
func (c *commandS3BucketQuotaEnforce) Name() string {
|
|
return "s3.bucket.quota.enforce"
|
|
}
|
|
|
|
func (c *commandS3BucketQuotaEnforce) Help() string {
|
|
return `check quota for all buckets, make the bucket read only if over the limit
|
|
|
|
Example:
|
|
s3.bucket.quota.enforce -apply
|
|
`
|
|
}
|
|
|
|
func (c *commandS3BucketQuotaEnforce) HasTag(CommandTag) bool {
|
|
return false
|
|
}
|
|
|
|
func (c *commandS3BucketQuotaEnforce) Do(args []string, commandEnv *CommandEnv, writer io.Writer) (err error) {
|
|
|
|
bucketCommand := flag.NewFlagSet(c.Name(), flag.ContinueOnError)
|
|
applyQuotaLimit := bucketCommand.Bool("apply", false, "actually change the buckets readonly attribute")
|
|
if err = bucketCommand.Parse(args); err != nil {
|
|
return nil
|
|
}
|
|
infoAboutSimulationMode(writer, *applyQuotaLimit, "-apply")
|
|
|
|
// collect collection information
|
|
topologyInfo, _, err := collectTopologyInfo(commandEnv, 0)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
collectionInfos := make(map[string]*CollectionInfo)
|
|
collectCollectionInfo(topologyInfo, collectionInfos)
|
|
|
|
// read buckets path
|
|
var filerBucketsPath string
|
|
filerBucketsPath, err = readFilerBucketsPath(commandEnv)
|
|
if err != nil {
|
|
return fmt.Errorf("read buckets: %w", err)
|
|
}
|
|
|
|
// read existing filer configuration
|
|
fc, err := filer.ReadFilerConf(commandEnv.option.FilerAddress, commandEnv.option.GrpcDialOption, commandEnv.MasterClient)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// process each bucket
|
|
hasConfChanges := false
|
|
err = filer_pb.List(context.Background(), commandEnv, filerBucketsPath, "", func(entry *filer_pb.Entry, isLast bool) error {
|
|
if !entry.IsDirectory {
|
|
return nil
|
|
}
|
|
collection := getCollectionName(commandEnv, entry.Name)
|
|
var collectionSize float64
|
|
if collectionInfo, found := collectionInfos[collection]; found {
|
|
collectionSize = collectionInfo.Size
|
|
}
|
|
if c.processEachBucket(fc, filerBucketsPath, entry, writer, collectionSize) {
|
|
hasConfChanges = true
|
|
}
|
|
return nil
|
|
}, "", false, math.MaxUint32)
|
|
if err != nil {
|
|
return fmt.Errorf("list buckets under %v: %w", filerBucketsPath, err)
|
|
}
|
|
|
|
// apply the configuration changes
|
|
if hasConfChanges && *applyQuotaLimit {
|
|
|
|
var buf2 bytes.Buffer
|
|
fc.ToText(&buf2)
|
|
|
|
if err = commandEnv.WithFilerClient(false, func(client filer_pb.SeaweedFilerClient) error {
|
|
return filer.SaveInsideFiler(context.Background(), client, filer.DirectoryEtcSeaweedFS, filer.FilerConfName, buf2.Bytes())
|
|
}); err != nil && err != filer_pb.ErrNotFound {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
func (c *commandS3BucketQuotaEnforce) processEachBucket(fc *filer.FilerConf, filerBucketsPath string, entry *filer_pb.Entry, writer io.Writer, collectionSize float64) (hasConfChanges bool) {
|
|
|
|
locPrefix := filerBucketsPath + "/" + entry.Name + "/"
|
|
existingConf := fc.MatchStorageRule(locPrefix)
|
|
|
|
// Create a mutable copy for modification
|
|
locConf := filer.ClonePathConf(existingConf)
|
|
locConf.LocationPrefix = locPrefix
|
|
|
|
if entry.Quota > 0 {
|
|
if locConf.ReadOnly {
|
|
if collectionSize < float64(entry.Quota) {
|
|
locConf.ReadOnly = false
|
|
hasConfChanges = true
|
|
}
|
|
} else {
|
|
if collectionSize > float64(entry.Quota) {
|
|
locConf.ReadOnly = true
|
|
hasConfChanges = true
|
|
}
|
|
}
|
|
} else {
|
|
if locConf.ReadOnly {
|
|
locConf.ReadOnly = false
|
|
hasConfChanges = true
|
|
}
|
|
}
|
|
|
|
if hasConfChanges {
|
|
fmt.Fprintf(writer, " %s\tsize:%.0f", entry.Name, collectionSize)
|
|
fmt.Fprintf(writer, "\tquota:%d\tusage:%.2f%%", entry.Quota, collectionSize*100/float64(entry.Quota))
|
|
fmt.Fprintln(writer)
|
|
if locConf.ReadOnly {
|
|
fmt.Fprintf(writer, " changing bucket %s to read only!\n", entry.Name)
|
|
} else {
|
|
fmt.Fprintf(writer, " changing bucket %s to writable.\n", entry.Name)
|
|
}
|
|
fc.SetLocationConf(locConf)
|
|
}
|
|
|
|
return
|
|
}
|