mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-11-13 23:39:33 +01:00
bac2196d65
* shell: return flag parse errors from every command 48 commands returned nil when their flags failed to parse, so a mistyped flag printed the flag error but the command still counted as a success: a piped weed shell run exited 0, the master maintenance loop logged no error, and admin script jobs reported the line as done. Return the parse error as s3.bucket.create (#12544) and the other shell commands already do. TestCommandsReturnFlagParseErrors runs every registered command with an unknown flag and fails for the 48 on master. Signed-off-by: anant <170962632+antcybersec@users.noreply.github.com> * shell: don't report -h as a failure With the parse errors returned, -h on those commands now returns flag.ErrHelp, so the shell printed "error: flag: help requested" and a piped run exited 1. The flag package has already printed the usage, so processEachCmd now treats flag.ErrHelp as success for every command. Signed-off-by: anant <170962632+antcybersec@users.noreply.github.com> * shell: keep the -h test beside the flag parse test TestProcessEachCmdTreatsHelpAsSuccess covers the same change as TestCommandsReturnFlagParseErrors, so it lives in the same new file and shell_liner_test.go stays as it was. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Signed-off-by: anant <170962632+antcybersec@users.noreply.github.com> Co-authored-by: anant <170962632+antcybersec@users.noreply.github.com> Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
65 lines
1.5 KiB
Go
65 lines
1.5 KiB
Go
package shell
|
|
|
|
import (
|
|
"context"
|
|
"flag"
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/master_pb"
|
|
)
|
|
|
|
func init() {
|
|
Commands = append(Commands, &commandRaftServerAdd{})
|
|
}
|
|
|
|
type commandRaftServerAdd struct {
|
|
}
|
|
|
|
func (c *commandRaftServerAdd) Name() string {
|
|
return "cluster.raft.add"
|
|
}
|
|
|
|
func (c *commandRaftServerAdd) Help() string {
|
|
return `add a server to the raft cluster
|
|
|
|
Example:
|
|
cluster.raft.add -id <server_name> -address <server_host:port> -voter
|
|
`
|
|
}
|
|
|
|
func (c *commandRaftServerAdd) HasTag(CommandTag) bool {
|
|
return false
|
|
}
|
|
|
|
func (c *commandRaftServerAdd) Do(args []string, commandEnv *CommandEnv, writer io.Writer) (err error) {
|
|
|
|
raftServerAddCommand := flag.NewFlagSet(c.Name(), flag.ContinueOnError)
|
|
serverId := raftServerAddCommand.String("id", "", "server id")
|
|
serverAddress := raftServerAddCommand.String("address", "", "server grpc address")
|
|
serverVoter := raftServerAddCommand.Bool("voter", true, "assign it a vote")
|
|
if err = raftServerAddCommand.Parse(args); err != nil {
|
|
return err
|
|
}
|
|
|
|
if *serverId == "" || *serverAddress == "" {
|
|
return fmt.Errorf("empty server id or address")
|
|
}
|
|
|
|
err = commandEnv.MasterClient.WithClient(context.Background(), false, func(client master_pb.SeaweedClient) error {
|
|
_, err := client.RaftAddServer(context.Background(), &master_pb.RaftAddServerRequest{
|
|
Id: *serverId,
|
|
Address: *serverAddress,
|
|
Voter: *serverVoter,
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("raft add server: %w", err)
|
|
}
|
|
println("added server", *serverId)
|
|
return nil
|
|
})
|
|
|
|
return err
|
|
|
|
}
|