mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-11 09:00:45 +02:00
* lance worker: share the integration tests' scaffolding The recorder that keeps what a handler sent, the config builder and the storage-option fallback all lived inside compaction.rs, so a second test binary would have had to copy them. They move to tests/common. The fallback now reads AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY and AWS_ENDPOINT_URL from the environment, defaulting to what it used before. A harness can then point these tests at a gateway that checks what it is given rather than one that accepts anything. * lance worker: maintain one named table, for a harness to drive Compacts and cleans up whatever WEED_LANCE_TABLE names, through the handlers' own detect-then-execute path: a proposal the worker would not have made is not one worth running. The existing tests seed the tables they check. This one deliberately does not, so a harness that has already written a table and knows what is in it can have the real handlers maintain it and then read it back. * test: take a table through its whole life, for Iceberg and Lance Created in the catalog, filled by a real client, maintained by the worker, read again, dropped. The step nothing was checking is the read after maintenance: compaction once rewrote every dictionary-encoded column onto a single value and shipped, because the maintenance tests were thorough about sequence numbers, manifest entries and metadata versions and none of them opened the parquet file the worker had just written. So the assertion is a tally - row count, the cardinality of each dictionary-encoded column, and an md5 over whole rows - taken before maintenance and again after, required to be equal. The cardinalities name the failure that happened; the digest catches a rewrite that keeps every column's cardinality and hands the values to the wrong rows. A compaction that merged nothing fails rather than passes, or the read afterwards is checking a file the worker never wrote. The Iceberg half runs two clients. DuckDB is the one the corruption was reported against and the only one here that writes the deprecated PLAIN_DICTIONARY encoding, which parquet-go normalizes away on write, so a Go writer cannot produce it. PyIceberg writes the modern spelling. Pinning parquet-go back to v0.30.1 fails the DuckDB half and passes the PyIceberg one, which is why both are here. Lance maintenance lives in the Rust worker, so it runs there where cargo is installed and through the two lance calls those handlers wrap where it is not. WEED_LANCE_MAINTENANCE picks one instead of letting the test guess. * ci: run the table lifecycle tests CI maintains the Lance table through the lance library rather than the worker: a cold build of the lance crate costs more than the glue it would be checking, and the worker's own tests cover its handlers. The suite drives the Iceberg maintenance worker, so a change to it now triggers this workflow too. * test: let the lifecycle harness fail instead of skipping Setup failures all exited zero, so a cluster that would not come up, or a port allocation that lost, reported a green run for code nothing had executed. That is the failure mode this whole directory exists to close, and it was in the harness itself. Only a checkout without a weed binary skips now, and it runs the tests so each one says so rather than the package quietly passing. Everything else fails. The filer existence probe gets a deadline while I am here: it ran without one, so an unresponsive filer would hang the suite past every timeout the clients have. * test: make the lifecycle checks check what they claim to Three of them could pass without having looked. The DuckDB skip matched "syntax error", "not implemented" and "Failed to load" anywhere in the output, in any phase. A parse error in the SQL this test generates, or a refusal from our own catalog, would have taken the only coverage of the PLAIN_DICTIONARY encoding out of CI and left it green. It now matches the extension failing to install, and only in the phase that installs it. Everything past LOAD is ours and fails. The digests covered id, category and value. Compaction rewrites the whole row, so a defect confined to ts, or to a Lance vector, changed nothing either side of maintenance. Every persisted column goes in now, ts as microseconds so no timezone sits between the two runs. The Lance drop check caught every exception as proof the dataset was gone. pylance turns credential and transport failures into the same ValueError, so it only accepts the message that means not found. * docs: say up front which maintenance path the Lance half takes The opening summary said the worker maintains both tables. It maintains the Iceberg one always and the Lance one only where cargo is installed, which is not what CI does.
164 lines
5.4 KiB
Python
164 lines
5.4 KiB
Python
#!/usr/bin/env python3
|
|
"""PyIceberg half of the table lifecycle, run one phase per invocation.
|
|
|
|
The Go test calls this three times - write, verify, drop - and runs the
|
|
maintenance worker between the first two. Splitting it that way is the whole
|
|
point: a tally taken before compaction and the same tally taken after are the
|
|
only thing that catches a merge that rewrote every dictionary-encoded column
|
|
onto a single value and said nothing.
|
|
"""
|
|
|
|
import argparse
|
|
import hashlib
|
|
import json
|
|
import sys
|
|
import time
|
|
|
|
import pyarrow as pa
|
|
from pyiceberg.catalog import load_catalog
|
|
from pyiceberg.exceptions import NamespaceAlreadyExistsError, NoSuchTableError
|
|
from pyiceberg.schema import Schema
|
|
from pyiceberg.types import LongType, NestedField, StringType, TimestamptzType
|
|
|
|
# Few enough distinct values in the two string columns that any writer worth
|
|
# the name dictionary-encodes them, which is the encoding that broke.
|
|
CATEGORIES = 7
|
|
VALUES = 13
|
|
ROWS_PER_BATCH = 4000
|
|
BATCHES = 3
|
|
|
|
SCHEMA = Schema(
|
|
NestedField(1, "id", LongType(), required=True),
|
|
NestedField(2, "category", StringType(), required=True),
|
|
NestedField(3, "value", StringType(), required=True),
|
|
NestedField(4, "ts", TimestamptzType(), required=True),
|
|
)
|
|
|
|
ARROW_SCHEMA = pa.schema(
|
|
[
|
|
pa.field("id", pa.int64(), nullable=False),
|
|
pa.field("category", pa.string(), nullable=False),
|
|
pa.field("value", pa.string(), nullable=False),
|
|
pa.field("ts", pa.timestamp("us", tz="UTC"), nullable=False),
|
|
]
|
|
)
|
|
|
|
|
|
def batch(start, count):
|
|
ids = list(range(start, start + count))
|
|
return pa.Table.from_pydict(
|
|
{
|
|
"id": ids,
|
|
"category": [f"cat-{i % CATEGORIES}" for i in ids],
|
|
"value": [f"v-{i % VALUES}" for i in ids],
|
|
# An hour apart, so the rows spread over months the way a real
|
|
# table's do without needing a partition spec to prove it.
|
|
"ts": [1772323200000000 + i * 3600000000 for i in ids],
|
|
},
|
|
schema=ARROW_SCHEMA,
|
|
)
|
|
|
|
|
|
def tally(table):
|
|
"""Row count, per-column cardinality, and a digest of every row.
|
|
|
|
The cardinalities catch a column collapsed onto one dictionary entry; the
|
|
digest catches everything else, including a merge that keeps the right
|
|
number of distinct values while handing them to the wrong rows. Every
|
|
column goes into it, not just the two the cardinalities watch - compaction
|
|
rewrites the whole row. ts goes in as microseconds so no timezone sits
|
|
between the two runs.
|
|
"""
|
|
scanned = table.scan().to_arrow()
|
|
categories = scanned.column("category").to_pylist()
|
|
values = scanned.column("value").to_pylist()
|
|
rows = [
|
|
f"{i}|{t}|{c}|{v}"
|
|
for i, t, c, v in zip(
|
|
scanned.column("id").to_pylist(),
|
|
scanned.column("ts").cast(pa.int64()).to_pylist(),
|
|
categories,
|
|
values,
|
|
strict=True,
|
|
)
|
|
]
|
|
digest = hashlib.md5(
|
|
"\n".join(sorted(rows)).encode(), usedforsecurity=False
|
|
).hexdigest()
|
|
return {
|
|
"rows": scanned.num_rows,
|
|
"categories": len(set(categories)),
|
|
"values": len(set(values)),
|
|
"digest": digest,
|
|
}
|
|
|
|
|
|
def connect(args):
|
|
properties = {
|
|
"type": "rest",
|
|
"uri": args.catalog_url,
|
|
"warehouse": f"s3://{args.bucket}/",
|
|
"prefix": args.bucket,
|
|
"s3.endpoint": args.s3_endpoint,
|
|
"s3.access-key-id": args.access_key,
|
|
"s3.secret-access-key": args.secret_key,
|
|
"s3.region": "us-east-1",
|
|
"s3.path-style-access": "true",
|
|
}
|
|
last = None
|
|
for attempt in range(10):
|
|
try:
|
|
return load_catalog("rest", **properties)
|
|
except Exception as err: # the gateway may still be coming up
|
|
last = err
|
|
print(f"connect attempt {attempt + 1} failed: {err}", file=sys.stderr)
|
|
time.sleep(2)
|
|
raise last
|
|
|
|
|
|
def main():
|
|
parser = argparse.ArgumentParser()
|
|
parser.add_argument("--phase", required=True, choices=["write", "verify", "drop"])
|
|
parser.add_argument("--catalog-url", required=True)
|
|
parser.add_argument("--s3-endpoint", required=True)
|
|
parser.add_argument("--bucket", required=True)
|
|
parser.add_argument("--namespace", required=True)
|
|
parser.add_argument("--table", required=True)
|
|
parser.add_argument("--access-key", required=True)
|
|
parser.add_argument("--secret-key", required=True)
|
|
args = parser.parse_args()
|
|
|
|
catalog = connect(args)
|
|
identifier = f"{args.namespace}.{args.table}"
|
|
|
|
if args.phase == "write":
|
|
try:
|
|
catalog.create_namespace(args.namespace)
|
|
except NamespaceAlreadyExistsError:
|
|
pass
|
|
table = catalog.create_table(identifier, schema=SCHEMA)
|
|
# One append per batch, so compaction has several files to merge
|
|
# rather than one it would leave alone.
|
|
for i in range(BATCHES):
|
|
table.append(batch(i * ROWS_PER_BATCH + 1, ROWS_PER_BATCH))
|
|
table = catalog.load_table(identifier)
|
|
print(json.dumps(tally(table)))
|
|
return
|
|
|
|
if args.phase == "verify":
|
|
print(json.dumps(tally(catalog.load_table(identifier))))
|
|
return
|
|
|
|
catalog.drop_table(identifier)
|
|
try:
|
|
catalog.load_table(identifier)
|
|
except NoSuchTableError:
|
|
pass
|
|
else:
|
|
raise SystemExit("the table is still in the catalog after a drop")
|
|
catalog.drop_namespace(args.namespace)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|