mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-11 17:10:40 +02:00
Chris Lu
b1fecf3b44
* mount: mark windows files archived and ignore a zero timestamp Windows synthesises NORMAL when a file reports no attributes at all, which is not the same as ARCHIVE and is what create_fileattr_test checks. Utimens also wrote a zero timestamp through. Windows sends zero for a field it is not setting, and storing it put 1970 in the atime overlay, which then overrode the entry's real time — so a file created a moment ago reported an access time of 1970 whenever the caller asked through an open handle. Reading the path instead went down a different route and looked right, which is why a probe of a fresh file showed nothing wrong. * mount: match the file type by its mask, and only treat the epoch as unset S_IFDIR is part of the multi-bit type field rather than a flag, so masking against it alone also matched a symlink, which shares the bit. A regular file is now identified by the type mask. Rejecting every timestamp at or below zero also rejected a date genuinely before 1970. Only the epoch itself is what Windows sends for a field it is not setting, so that is all that is refused. create_fileattr goes back on the known-failures list: the archive fix works and the test simply moves on to ask for READONLY too, which needs Chflags. Taking it off was premature. * mount: drop the time overlays when an inode is released atimeMap and dirMtimeMap are keyed by inode and were only ever trimmed by a random eviction at capacity. Inodes are derived from the path, so a delete and recreate hands the same number to a different file, which then reported the previous file's access time — a file created a moment ago answering with a time from long before it existed. Cleared when Forget actually releases the inode, not on every decrement: a partial forget still has users. Forget now reports that so callers holding state keyed by the inode know when to drop it. * ci: keep getfileinfo listed while its access time is unexplained Two causes have been fixed and neither closed it, so the honest state is listed-with-a-reason rather than removed in hope. * mount: drop timestamp overlays while the inode table is locked Forget released the inode under the table's lock but cleaned up the atime and dir-mtime overlays after returning from it. Inode numbers are derived from the path, so a lookup arriving in that window is handed the same number back and can store a time that the cleanup then deletes. Run the cleanup at the release point instead, as a callback under the lock. The directory-cache purge stays deferred until after the unlock, where it has to be. Claude-Session: https://claude.ai/code/session_01EgY2QA3iiPtiu6ww3P2EBn
79 lines
2.8 KiB
Go
79 lines
2.8 KiB
Go
package mount
|
|
|
|
import (
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
)
|
|
|
|
// Forget is called when the kernel discards entries from its
|
|
// dentry cache. This happens on unmount, and when the kernel
|
|
// is short on memory. Since it is not guaranteed to occur at
|
|
// any moment, and since there is no return value, Forget
|
|
// should not do I/O, as there is no channel to report back
|
|
// I/O errors.
|
|
// from https://github.com/libfuse/libfuse/blob/master/include/fuse_lowlevel.h
|
|
/**
|
|
* Forget about an inode
|
|
*
|
|
* This function is called when the kernel removes an inode
|
|
* from its internal caches.
|
|
*
|
|
* The inode's lookup count increases by one for every call to
|
|
* fuse_reply_entry and fuse_reply_create. The nlookup parameter
|
|
* indicates by how much the lookup count should be decreased.
|
|
*
|
|
* Inodes with a non-zero lookup count may receive request from
|
|
* the kernel even after calls to unlink, rmdir or (when
|
|
* overwriting an existing file) rename. Filesystems must handle
|
|
* such requests properly and it is recommended to defer removal
|
|
* of the inode until the lookup count reaches zero. Calls to
|
|
* unlink, rmdir or rename will be followed closely by forget
|
|
* unless the file or directory is open, in which case the
|
|
* kernel issues forget only after the release or releasedir
|
|
* calls.
|
|
*
|
|
* Note that if a file system will be exported over NFS the
|
|
* inodes lifetime must extend even beyond forget. See the
|
|
* generation field in struct fuse_entry_param above.
|
|
*
|
|
* On unmount the lookup count for all inodes implicitly drops
|
|
* to zero. It is not guaranteed that the file system will
|
|
* receive corresponding forget messages for the affected
|
|
* inodes.
|
|
*
|
|
* Valid replies:
|
|
* fuse_reply_none
|
|
*
|
|
* @param req request handle
|
|
* @param ino the inode number
|
|
* @param nlookup the number of lookups to forget
|
|
*/
|
|
/*
|
|
https://libfuse.github.io/doxygen/include_2fuse__lowlevel_8h.html
|
|
|
|
int fuse_reply_entry ( fuse_req_t req,
|
|
const struct fuse_entry_param * e
|
|
)
|
|
Reply with a directory entry
|
|
|
|
Possible requests: lookup, mknod, mkdir, symlink, link
|
|
|
|
Side effects: increments the lookup count on success
|
|
|
|
*/
|
|
func (wfs *WFS) Forget(nodeid, nlookup uint64) {
|
|
// Forget only decrements the kernel's inode lookup count. File handle
|
|
// lifecycle is driven independently by FUSE Open/Release — touching the
|
|
// fhMap here would couple two unrelated refcounts and could tear down a
|
|
// still-live handle if Forget ever raced ahead of Release.
|
|
wfs.inodeToPath.Forget(nodeid, nlookup,
|
|
// Runs at the release, under the table's lock, so a lookup that
|
|
// rebuilds the same inode number afterwards keeps the times it sets.
|
|
wfs.forgetInMemoryTimes,
|
|
func(dir util.FullPath) {
|
|
// Runs after Forget releases its lock; a concurrent lookup+rebuild can
|
|
// re-cache the directory in that window, so purge through the apply loop
|
|
// rather than wiping the store directly.
|
|
wfs.purgeDirectoryCache(dir)
|
|
})
|
|
}
|