mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-10 16:40:46 +02:00
* Add GitHub Actions workflow for codespell on master * Add rudimentary codespell config * Tune codespell config: skip generated code, ignore camelCase, whitelist domain terms Add camelCase/PascalCase regex to ignore common Go/Rust/JS identifiers like allLocations, publishErr, ReadInside, FlushInterval. Also skip templ-generated *_templ.go files, and whitelist a handful of short/domain-specific words (visibles, fo, te, ser, bject, unparseable, keep-alives, tread, anc, ue) that show up as false positives across the tree. Co-Authored-By: Claude Code 2.1.217 / Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Fix ambiguous typos and protect false positives Fixes typos that codespell reports with multiple candidate suggestions (so `codespell -w` cannot auto-apply them), plus one inline pragma and one config entry to protect legitimate identifiers. Manual fixes (single correct answer chosen from context): - pattens -> patterns (5x) in filer/upload/shell flag help strings - finded -> found (2x) in tarantool storage.lua comment - spacify -> specify (2x) in helm chart values.yaml comment - wether -> whether in skiplist.go docstring - simpe -> simple in mq schema test case name False-positive protection: - Add `//codespell:ignore` next to `source GET's` (possessive of HTTP verb) in s3api_object_handlers_copy_stream.go - Whitelist `auther` in .codespellrc — it's a local variable meaning "authenticator" in weed/security/tls.go, not a typo of "author". Co-Authored-By: Claude Code 2.1.217 / Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Extend codespell ignore list: .git-meta path and thirdparty groupId Also skip `.git-meta` (scratch dir for commit messages that may contain typo words verbatim) and whitelist `thirdparty` — it appears as the literal Maven groupId `org.apache.hadoop.thirdparty` in hdfs3 poms and cannot be renamed. Co-Authored-By: Claude Code 2.1.217 / Claude Opus 4.7 (1M context) <noreply@anthropic.com> * [DATALAD RUNCMD] Fix non-ambiguous typos with codespell -w Auto-applied fixes to the 44 remaining single-suggestion typos across docs, comments, log messages, tests, config, and one Java pom. === Do not change lines below === { "chain": [], "cmd": "uvx codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^ * Revert breaking codespell fixes; whitelist unknwon and atleast Two of the auto-applied `codespell -w` fixes were false positives that would break the build/tests: - go.mod: `github.com/unknwon/goconfig` is a real Go module path — the upstream author's GitHub handle is literally `unknwon`. Renaming to `unknown` would fail dependency resolution. - test/benchmark/fuse_db/bin/{sqlite_verify.py,run_mysql.sh,run_sqlite.sh}: `atleast` is a literal CLI mode value (a string constant compared and passed as a positional argument). Rewriting to `at least` splits it into two arguments and breaks the mode check. Reverted those files and whitelisted both words in .codespellrc so future runs won't re-suggest the same broken fixes. Co-Authored-By: Claude Code 2.1.217 / Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Code 2.1.217 / Claude Opus 4.7 (1M context) <noreply@anthropic.com>
121 lines
2.3 KiB
Go
121 lines
2.3 KiB
Go
package schema
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/schema_pb"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestStructToSchema(t *testing.T) {
|
|
type args struct {
|
|
instance any
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want *schema_pb.RecordType
|
|
}{
|
|
{
|
|
name: "scalar type",
|
|
args: args{
|
|
instance: 1,
|
|
},
|
|
want: nil,
|
|
},
|
|
{
|
|
name: "simple struct type",
|
|
args: args{
|
|
instance: struct {
|
|
Field1 int
|
|
Field2 string
|
|
}{},
|
|
},
|
|
want: RecordTypeBegin().
|
|
WithField("Field1", TypeInt32).
|
|
WithField("Field2", TypeString).
|
|
RecordTypeEnd(),
|
|
},
|
|
{
|
|
name: "simple list",
|
|
args: args{
|
|
instance: struct {
|
|
Field1 []int
|
|
Field2 string
|
|
}{},
|
|
},
|
|
want: RecordTypeBegin().
|
|
WithField("Field1", ListOf(TypeInt32)).
|
|
WithField("Field2", TypeString).
|
|
RecordTypeEnd(),
|
|
},
|
|
{
|
|
name: "simple []byte",
|
|
args: args{
|
|
instance: struct {
|
|
Field2 []byte
|
|
}{},
|
|
},
|
|
want: RecordTypeBegin().
|
|
WithField("Field2", TypeBytes).
|
|
RecordTypeEnd(),
|
|
},
|
|
{
|
|
name: "nested simple structs",
|
|
args: args{
|
|
instance: struct {
|
|
Field1 int
|
|
Field2 struct {
|
|
Field3 string
|
|
Field4 int
|
|
}
|
|
}{},
|
|
},
|
|
want: RecordTypeBegin().
|
|
WithField("Field1", TypeInt32).
|
|
WithRecordField("Field2",
|
|
RecordTypeBegin().
|
|
WithField("Field3", TypeString).
|
|
WithField("Field4", TypeInt32).
|
|
RecordTypeEnd(),
|
|
).
|
|
RecordTypeEnd(),
|
|
},
|
|
{
|
|
name: "nested struct type",
|
|
args: args{
|
|
instance: struct {
|
|
Field1 int
|
|
Field2 struct {
|
|
Field3 string
|
|
Field4 []int
|
|
Field5 struct {
|
|
Field6 string
|
|
Field7 []byte
|
|
}
|
|
}
|
|
}{},
|
|
},
|
|
want: RecordTypeBegin().
|
|
WithField("Field1", TypeInt32).
|
|
WithRecordField("Field2", RecordTypeBegin().
|
|
WithField("Field3", TypeString).
|
|
WithField("Field4", ListOf(TypeInt32)).
|
|
WithRecordField("Field5",
|
|
RecordTypeBegin().
|
|
WithField("Field6", TypeString).
|
|
WithField("Field7", TypeBytes).
|
|
RecordTypeEnd(),
|
|
).RecordTypeEnd(),
|
|
).
|
|
RecordTypeEnd(),
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
assert.Equalf(t, tt.want, StructToSchema(tt.args.instance), "StructToSchema(%v)", tt.args.instance)
|
|
})
|
|
}
|
|
}
|